HenrikJannsen
97648c51f3
Rename to make use case more clear
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:49:57 -05:00
HenrikJannsen
0bf44f061d
Remove addressAsString null check. That was when the donationAddress got added to support not updated nodes. Now there are none of such nodes.
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:48:55 -05:00
HenrikJannsen
710dba9f36
Remove validateDonationAddress method without dispute param
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:47:39 -05:00
HenrikJannsen
5daaa60779
Refactor validateDonationAddress
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:44:58 -05:00
HenrikJannsen
3007652f4a
Remove dispute field from TradeDataValidation.ValidationException
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:41:46 -05:00
HenrikJannsen
cfb3780e6b
Move null check for address to validateDonationAddress method
...
Remove dispute as unused param
Remove redundant methods
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:39:56 -05:00
HenrikJannsen
e8c6b0ae14
Remove daoFacade as unused parameter
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:32:28 -05:00
HenrikJannsen
cfc67dcc9c
Move validateDonationAddress to DisputeValidation
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:29:59 -05:00
HenrikJannsen
d86071db4a
Remove validateDonationAddress call inside validateDelayedPayoutTx.
...
Add call to validateDonationAddress at client calling validateDelayedPayoutTx
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:28:41 -05:00
HenrikJannsen
2484fa4371
Part of a multistep refactoring to separate dispute related validation out of TradeDataValidation
...
Refactor donationAddress validation out to new method
Rename addressAsString to delayedPayoutTxOutputAddressAsString
Recreate delayedPayoutTxOutputAddress at new validateDonationAddress method from relevant data
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:25:11 -05:00
HenrikJannsen
e49e634956
Move testIfAnyDisputeTriedReplay and related methods to DisputeValidation
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:14:55 -05:00
HenrikJannsen
37457ed132
Move validateDonationAddress to DisputeValidation
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:12:55 -05:00
HenrikJannsen
12686deff6
Move validateNodeAddress to DisputeValidation
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:11:23 -05:00
HenrikJannsen
aa22bd366a
Add DisputeValidation class for validation methods and exceptions of the dispute domain.
...
Move AddressException, NodeAddressException and DisputeReplayException to DisputeValidation.
Use DisputeValidation.ValidationException as type for DisputeManager.validationExceptions.
Remove Nullable annotation for dispute field in those exceptions.
Remove null checks when those DisputeValidation.ValidationException are used.
2022-11-02 22:09:30 -05:00
HenrikJannsen
43fb0cc635
Reformat code and reorg imports
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 21:22:35 -05:00
jmacxx
797bfe5cd5
Store the build's commit hash in Jarfile manifest.
2022-10-29 22:12:31 -05:00
Christoph Atteneder
80246e5d66
Update data stores for v1.9.6
2022-10-20 12:19:30 +02:00
Christoph Atteneder
6831f72a03
Update translations for v1.9.6
2022-10-13 09:53:23 +02:00
jmacxx
b35e316cdc
Warn at shutdown if Dispute message is pending.
2022-10-11 17:54:07 -05:00
jmacxx
b5dc6a4e45
Misc burn chart series CSS color settings and tooltip description.
2022-10-05 07:11:40 -05:00
jmacxx
8b92b2cdf5
UI Changes for BSQ Supply screen.
...
Adds ability to track Misc Burnt amounts (incl. voting, asset listing etc)
Corrects the descriptions for Total BSQ and Change in supply.
2022-10-05 07:11:36 -05:00
Christoph Atteneder
75e030f541
Merge pull request #6362 from jmacxx/dispute_min_payout
...
Set the minimum payout at mediation to be 2.5% of trade amount
2022-10-04 09:12:38 +02:00
Stephan Oeste
46139cf6b0
Remove c4talys7 seednodes and readd wiz seednodes
2022-09-28 15:16:25 +02:00
Android-X13
ee2db16451
Fix issue with offers getting disabled for no apparent reason
2022-09-20 20:55:19 +03:00
jmacxx
11e4469b0e
Set the minimum payout at mediation to be 2.5% of trade amount.
...
If 2.5% is less than 0.0005 BTC, then fall back to 0.0005 BTC.
2022-09-18 21:51:24 -05:00
ghubstan
a33a6e936b
Fix BSQ buyer's displayed trade fee for gettrade(s) methods
...
API clients looking at their BSQ swap trades -- BSQ buyers
specifically -- were seeing a 0.00 BSQ trade fee, due to an
incorrect assumption BSQ sellers paid the entire BSQ trade
fee for both sides. BSQ Swap execution via API has been
working just like the GUI (same code-base), but the reported
trade fee for the BSQ buy side was wrong.
This change shows the correct BSQ trade fee.
Partially addresses issue https://github.com/bisq-network/bisq/issues/6355
2022-09-11 16:06:59 -03:00
ghubstan
d32fd4e97b
Improve CLI takeoffer man-page param descriptions
2022-09-11 12:26:00 -03:00
Christoph Atteneder
4a359997ff
Merge pull request #6333 from ripcurlx/update-data-stores-for-v1.9.5
...
Update data stores for v1.9.5
2022-08-22 17:57:04 +02:00
jmacxx
4e8e6eb9ac
Use getCurrencyCode method rather than directly accessing member.
...
The transient currencyCode member is null until the getter method
has been used, so we should no access the variable directly.
This fixes a problem with OfferBook filtering, which was checking
for isFiat(currencyCode); the variable was null and isFiat returned
the wrong answer.
2022-08-22 15:53:47 +02:00
Stephan Oeste
dd66520a24
Remove sn2bisqad7... Seeednode
2022-08-22 15:53:21 +02:00
Christoph Atteneder
827ddb071f
Update bitcoinj checkpoints for v1.9.5
2022-08-22 11:46:26 +02:00
Christoph Atteneder
cc11c28ffe
Update translations for v1.9.5
2022-08-21 21:34:06 +02:00
Christoph Atteneder
d2c7824740
Merge pull request #6315 from wiz/wiz/remove-wiz-seed-nodes
...
Remove 3 wiz seed nodes
2022-08-19 12:42:44 +02:00
Stephan Oeste
e878aec78c
Add new Seednodes from jmacxx and c4talys7
2022-08-19 11:48:23 +02:00
jmacxx
8e21682e92
Add P2P network status indicator.
2022-08-18 10:46:39 -05:00
wiz
f193b4a4c5
Remove 3 wiz seed nodes
2022-08-09 18:07:08 +09:00
Christoph Atteneder
423d57ae24
Merge pull request #6312 from ghubstan/support-choosing-trade-amount-in-range
...
API takeoffer: Let user choose intended trade amount
2022-08-07 21:36:41 +02:00
ghubstan
c57b573d5c
Document TakeOfferRequest's intended trade amt param
2022-08-06 15:09:00 -03:00
ghubstan
7d4e7dd696
Support TakeOfferRequest's intended trade amt in daemon
2022-08-06 15:08:30 -03:00
chimp1984
6aa91a4ee4
Add check for date
2022-08-01 17:07:17 +02:00
chimp1984
aebabcb53e
Add api for account age and signed account age witness
2022-08-01 00:34:06 +02:00
chimp1984
ef81bde7f2
Add export feature for signed account age witness
2022-07-31 14:40:18 +02:00
chimp1984
2b6dd187c6
Add export feature for account age
2022-07-25 20:50:43 +02:00
chimp1984
2628eea9db
Add bsq bonds
2022-07-25 00:12:13 +02:00
Christoph Atteneder
ec00c9962f
Merge pull request #6282 from jmacxx/adjust_blocks_response_size
...
GetBlocksResponse lower chunk size (was 6000 now 4000).
2022-07-13 12:33:00 +02:00
Christoph Atteneder
f0db45255a
Merge pull request #6283 from jmacxx/clear_sensitive_data_2
...
Clear sensitive data from trade ProcessModel
2022-07-12 09:55:22 +02:00
Bisq GitHub Admin
fa635bd304
Merge pull request #6286 from bisq-network/release/v1.9.4
...
Release v1.9.4
2022-07-12 09:20:32 +02:00
jmacxx
aacabb9685
Clear sensitive data from trade ProcessModel.
2022-07-06 13:24:26 -05:00
jmacxx
12d3256f20
GetBlocksResponse lower chunk size (was 6000 now 4000).
...
We lower the number of blocks delivered in a message to avoid
exceeding the max network message size.
2022-07-06 08:17:05 -05:00
Christoph Atteneder
9011ebbd3f
Fix incorrect version number for new feature popup
2022-07-05 10:57:45 +02:00
Christoph Atteneder
bca997a55b
Merge pull request #6219 from ghubstan/wip-prep-bisq-for-bitcoin-v23
...
Prepare Bisq for bitcoin-core v23 compatiblity
2022-07-05 09:05:08 +02:00
chimp1984
b515ec7342
Update text and default series
2022-06-30 20:20:02 +02:00
chimp1984
70e2f7c53b
Add supply change series.
...
Remove BsqSupplyChange. Use existing methods for supply calculation
(existing method was incorrect as far I understand).
2022-06-30 20:19:52 +02:00
chimp1984
e08f7b6c09
Add new series. Regroup series. Add tooltips.
2022-06-30 20:19:38 +02:00
jmacxx
a5ba349574
Clear Tor directory when a new release is downloaded.
2022-06-30 20:19:25 +02:00
Christoph Atteneder
9b2c4807bf
Merge pull request #6274 from chimp1984/improve-dao-chats-legends
...
Improve dao chats legends
2022-06-30 20:17:04 +02:00
jmacxx
e1bc92eee5
Clear Tor directory when a new release is downloaded.
2022-06-30 07:04:17 -05:00
chimp1984
09cf4c8a73
Update text and default series
2022-06-29 19:01:20 +02:00
chimp1984
c91ba4a8e0
Add supply change series.
...
Remove BsqSupplyChange. Use existing methods for supply calculation
(existing method was incorrect as far I understand).
2022-06-29 18:50:43 +02:00
chimp1984
42d3df04f7
Add new series. Regroup series. Add tooltips.
2022-06-29 17:24:25 +02:00
Christoph Atteneder
8850436023
Merge pull request #6267 from ripcurlx/datastore-updates-for-v1.9.3
...
Data store updates for v1.9.3
2022-06-29 09:23:59 +02:00
jmacxx
5e59eae17e
Correct wording of altcoin payto address label.
2022-06-28 11:04:36 +02:00
jmacxx
484c4b5f50
Correct wording of altcoin payto address label.
2022-06-27 22:00:16 -05:00
Christoph Atteneder
15a79f27d3
Update bitcoinj checkpoints for v1.9.3
2022-06-23 10:54:43 +02:00
Christoph Atteneder
59d598da52
Update translations for v1.9.3
2022-06-23 09:44:57 +02:00
Christoph Atteneder
444f2183e5
Merge pull request #6236 from jmacxx/xmr_subaddresses
...
Feat: XMR subaddresses per account
2022-06-20 20:40:20 +02:00
ghubstan
2893ec2564
Block API attempt swap BSQ if !sufficient funds
...
This API bug was relying on the UI purposed TaskRunner to bubble up an
insufficient funds error to the client, but it cannot do that.
This change blocks the takeoffer attempt if sufficient funds are not
found after the swap model calculates the taker's trade amounts.
Related: https://github.com/bisq-network/bisq/pull/6221
Based on https://github.com/bisq-network/bisq/pull/6250 .
Based on branch `add-api-price-service-getaverageprice`.
2022-06-20 12:00:39 -03:00
ghubstan
2c043b4b21
Minor refactoring
2022-06-18 11:24:39 -03:00
ghubstan
a12dd52b81
Add API method 'getavgbsqprice'
...
Returns volume weighted average BSQ price in BTC and USD over N days.
The need for this arose while creating a Java BSQ Swap bot example
(PR pending). API bots can use this to determine whether or not to
take swap offers based on their price distance above or below the 30
(or 90) day trade price average.
2022-06-17 18:26:10 -03:00
ghubstan
ae41e98db9
Add API API method 'getnetwork'
...
Returns name of the BTC network API daemon is connected to.
I am working on some Java bot examples in another repo, and want to stop
worrying about accidentally simulating trade payments on mainnet, despite
all the warnings I add in comments. The 'getnetwork' method allows bots
to know what network the API daemon is connected to, and gives API bot
devs and users a way to avoid one potential source of costly mistakes.
API CLI manpage and apitest case are included in this commit.
2022-06-16 15:31:03 -03:00
jmacxx
97ab98a0cf
Remove rules/penalties popup and other unused text resource.
2022-06-14 13:28:35 -05:00
jmacxx
920e05562c
Feat: XMR subaddresses per account
...
incremente subaddress index at the start of the trade
Add subaccounts
Rename XmrAccountHelper to XmrAccountDelegate
Add map as final non null value
Persist subaccounts in User
Add display of used subaddresses and tradeId in account summary.
Main address and account index are the unique key for sub accounts.
Use the initial subaddress chosen by the user.
chimp1984 code review patch.
News badge/info for Account, disable old ones.
Show XMR subaddress popup info at Account (news badge), not startup.
2022-06-14 09:53:44 -05:00
ghubstan
0fc22c02f4
Make API getoffers (altcoin) offer list order match UI
...
This change reverses the server-side sorting of returned altcoin
offer lists, to match the UI altcoin offer-book views' price ordering.
2022-06-14 11:42:55 -03:00
ghubstan
57509890f2
Throw client-friendly EX for payment sent/rcvd msgs
...
Don't depend on silent, UI purposed task runner errors if confirmpaymentstarted
or confirmpaymentreceived msgs are sent outside the proper context.
Throw a FailedPreconditionException instead, and it will be translated
into the proper gPRC StatusRuntimeException before being sent to client.
For BTC buyers and sellers, block the messaging attempt if the taker
deposit tx has not been confirmed.
For BTC sellers, block an attempt to send a confirmpaymentreceived message
until after receiving a confirmpaymentstarted message has been sent from
the buyer.
2022-06-13 21:16:14 -03:00
Christoph Atteneder
6fdd47917f
Merge pull request #6241 from jmacxx/buyer_start_payment_gui
...
Start payment screen reftext message & sizing fixes.
2022-06-09 10:08:52 +02:00
jmacxx
5bf2a78844
Start payment screen reftext message & sizing fixes.
2022-06-07 22:08:57 -05:00
jmacxx
82550314b4
Prevent account creation for banned Revolut GBP sort code 040075.
2022-06-04 10:47:27 -05:00
Christoph Atteneder
a62655c15d
Merge pull request #6217 from chimp1984/improve-xmr-proof-service
...
Improve xmr proof service
2022-06-01 09:16:48 +02:00
chimp1984
89293f1bbf
Use https://www.getmonero.org instead of https://web.getmonero.org
2022-05-31 12:28:59 +02:00
chimp1984
6c2b3629d4
Change link
2022-05-27 15:35:40 +02:00
chimp1984
259b799ae6
Move Monero related classes to xmr package
2022-05-26 23:42:30 +02:00
chimp1984
69b1a0027b
Compare canonicalTxKey with strict case check
...
Cleanups
2022-05-26 23:40:46 +02:00
chimp1984
7127bd5223
Add methods to ExcludesDelegateMethods
2022-05-26 23:35:13 +02:00
chimp1984
d2557181d0
Add popup and info about using dedicated wallets when changing Bisq data dir
2022-05-26 23:31:30 +02:00
chimp1984
7fe93d9be7
Add littleEndian conversions
2022-05-26 12:36:59 +02:00
chimp1984
ed4eaafcdf
Add toCanonicalTxKey method (not correct still)
2022-05-26 12:17:51 +02:00
chimp1984
5194aff311
Extract test
2022-05-26 11:57:17 +02:00
chimp1984
08a76229c1
Add knaccc package and dependent other packages
2022-05-26 11:46:32 +02:00
ghubstan
c9f3aa9edf
Block API takeoffer attempt if !sufficient btc in wallet
...
This API bug was relying on offer availability checks, but those do
not check the taker's wallet. The take offer model makes the check convenient,
and a core.api NotAvailableException can be thrown from CoreTradesService,
then mapped to the appropriate gPRC UNAVAILABLE exception sent to clients.
A new test case is added for this change: Bob's wallet is emptied, he
fails to take an offer, and Alice returns Bob's BTC.
2022-05-22 17:00:33 -03:00
ghubstan
7feecc9aca
Adjust to CJDNS network support in bitcoin-core v23
...
This change is backward compatible for bitcoin-core v22.
This change has not been tested against bitcoin-core v21, v20, v19.
See https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-23.0.md#p2p-and-network-changes
See https://github.com/bitcoin/bitcoin/blob/23.x/doc/cjdns.md
2022-05-21 17:03:14 -03:00
chimp1984
19643488b1
Add test
2022-05-21 01:43:20 +02:00
chimp1984
f97cc86470
Use equalsIgnoreCase for replay protection checks
...
Add check for duplicate txHash
Rename wrongly names variables at startRequestsIfValid
2022-05-21 00:32:52 +02:00
chimp1984
e97ba5aebb
Add comment to viewkey/txKey mismatch due dual mode explorer API
2022-05-21 00:30:19 +02:00
jmacxx
62719615a9
Prevent shutdown if trade is in process of being taken.
2022-05-18 18:05:05 -05:00
jmacxx
0726bdff7e
Prevent shutdown if trade is in process of being taken.
2022-05-17 12:10:23 -05:00
Bisq GitHub Admin
6fa87aea11
Merge pull request #6204 from chimp1984/add-revenue-chart
...
Add chart series for total trade fees
2022-05-16 16:58:27 +02:00
Christoph Atteneder
52b1e13d46
Merge pull request #6200 from jmacxx/fix_issue_6175
...
Refactor BSQ fee validation to handle multiple txins.
2022-05-16 16:15:25 +02:00
Christoph Atteneder
0925370121
Merge pull request #6202 from ghubstan/fix-editoffer-price-bug
...
Fix API editoffer bug: set fixed-price=0 on margin offers
2022-05-16 16:11:48 +02:00
chimp1984
0ed03fc790
Add series for burned BSQ from btc fees and arbitration
2022-05-15 23:42:18 +02:00
jmacxx
574510d172
Attempt self-ping 3 times before reporting error with connectivity.
2022-05-15 12:48:39 -05:00
chimp1984
492182a97d
Add half-year and quarter periods
2022-05-15 17:35:02 +02:00
chimp1984
5f2a430e4e
Add chart series for total trade fees
...
Fix missing color adoption for BSQ supply series
2022-05-15 15:39:59 +02:00
ghubstan
381985ec3a
Fix API editoffer bug: set fixed-price=0 on margin offers
...
This is causing erroneous PRICE_OUT_OF_TOLERANCE errors when trying
to take offers having (fixed) price!=0, and isUsingMktPriceMargin=true
in the payload.
The API daemon editoffer's treatment of (fixed) price and
isUsingMktPriceMargin flag in the API has been inconsistent with the UI.
With this change: when isUsingMktPriceMargin=true, (fixed) price is
set to 0 on the server. API clients, however, still must show the
calculated price when isUsingMktPriceMargin=true, making this fix hard
to test in the client. The server will now throw an exception if
(fixed) price and isUsingMktPriceMargin flag in the API are not
properly set in the API server.
This fix is intended to prevent issues such as
https://github.com/bisq-network/bisq/issues/6170 from happening for
this reason. The offer maker edited offers with API, creating
inconsistent state described above. It is hoped the user's offers
can be fixed by editing them in the UI.
Based on `master`.
2022-05-14 18:14:49 -03:00
jmacxx
17a949e4d1
Refactor BSQ fee validation to handle multiple txins.
2022-05-12 21:14:26 -05:00
Christoph Atteneder
23347e6203
Add missing copyright notice
2022-05-10 11:20:25 +02:00
xyzmaker123
219b408b6a
Show changes in BSQ Supply over time - dynamic calculation
2022-05-10 10:30:25 +02:00
xyzmaker123
5fb1167a28
Show changes in BSQ Supply over time
2022-05-10 10:30:25 +02:00
Christoph Atteneder
8a13076b37
Merge pull request #6188 from xyzmaker123/mark-own-offers
...
Mark user's own offers in Market -> Offer book
2022-05-09 13:10:50 +02:00
xyzmaker123
2b69e34b3a
Mark user's own offers in Market -> Offer book
2022-05-05 10:59:50 +02:00
Christoph Atteneder
80aff38fe7
Merge pull request #6182 from jmacxx/txvalidator_fee_address_fix
...
Check current fee receiver list whenever a fee tx is validated.
2022-05-02 09:54:06 +02:00
jmacxx
b40e424389
Refresh current fee receiver list whenever a fee tx is validated.
2022-05-02 09:53:50 +02:00
ghubstan
740284ab0a
Adjust to renamed class: AustraliaPayidAccountPayload
2022-05-02 09:52:12 +02:00
ghubstan
03b6924508
Adjust to renamed class: AustraliaPayidAccountPayload
2022-05-02 09:52:12 +02:00
ghubstan
b011bae18f
Remove deleted (renamed) class
2022-05-02 09:52:11 +02:00
ghubstan
4c7e214743
Rename AustraliaPayidPayload -> AustraliaPayidAccountPayload
...
Fit to nameing convention for acct payload classes; API's reflection
based acct creation logic depends on it.
2022-05-02 09:52:11 +02:00
jmacxx
f0c79439bb
Fix uninitialized member variable payoutSuggestion.
2022-05-02 09:51:19 +02:00
Christoph Atteneder
0152f00493
Merge pull request #6183 from ghubstan/fix-getacctform-testbug
...
Rename AustraliaPayidPayload -> AustraliaPayidAccountPayload
2022-05-02 09:46:24 +02:00
Christoph Atteneder
4737a36a7b
Merge pull request #6181 from jmacxx/fix_npe_mediator_ticket
...
[1.9.0] Fix uninitialized variable causing NPE in mediation ticket.
2022-05-02 09:39:05 +02:00
ghubstan
c03dac5a26
Adjust to renamed class: AustraliaPayidAccountPayload
2022-04-30 11:11:01 -03:00
ghubstan
4df152b833
Adjust to renamed class: AustraliaPayidAccountPayload
2022-04-30 11:10:13 -03:00
ghubstan
77a206e0db
Remove deleted (renamed) class
2022-04-30 11:09:12 -03:00
ghubstan
f58d39e720
Rename AustraliaPayidPayload -> AustraliaPayidAccountPayload
...
Fit to nameing convention for acct payload classes; API's reflection
based acct creation logic depends on it.
2022-04-30 11:06:29 -03:00
jmacxx
99a74dd4d7
Refresh current fee receiver list whenever a fee tx is validated.
2022-04-29 11:25:56 -05:00
jmacxx
bf6be8998d
Fix uninitialized member variable payoutSuggestion.
2022-04-29 07:58:17 -05:00
Christoph Atteneder
5b2c58b108
Update translations for v1.9.0
2022-04-28 13:12:59 +02:00
Christoph Atteneder
41c7168bb6
Update bitcoinj checkpoints for v1.9.0
2022-04-28 13:10:30 +02:00
jmacxx
d89c3c8bf4
Add popup reminder to inform users of trading rules.
2022-04-28 11:29:32 +02:00
Christoph Atteneder
b71ffc2a4b
Merge pull request #6164 from jmacxx/popup_trading_rules
...
Add popup reminder to inform users of trading rules
2022-04-28 11:29:19 +02:00
Christoph Atteneder
6d3863dbc6
Merge pull request #6172 from xyzmaker123/refactor-cash-deposit-payload
...
Refactor CashDepositAccountPayload to extends BankAccountPayload
2022-04-28 11:28:03 +02:00
xyzmaker123
ca50662ff2
Refactor CashDepositAccountPayload to extends BankAccountPayload
2022-04-28 11:21:20 +02:00
jmacxx
7f141bc04c
Set maxTradeLimit & maxTradePeriod appropriately when editing an offer.
2022-04-28 11:17:44 +02:00
jmacxx
f31040ba31
Set maxTradeLimit & maxTradePeriod appropriately when editing an offer.
2022-04-27 22:25:28 -05:00
xyzmaker123
b932f0fa64
Refactor CashDepositAccountPayload to extends BankAccountPayload
2022-04-27 13:12:35 +02:00
Christoph Atteneder
b4506ac2de
Merge pull request #6167 from xyzmaker123/fix-npe-same-bank-edit-account-name
...
Fix problems with editing account names
2022-04-27 13:00:59 +02:00
xyzmaker123
3a1e1843c9
Fix NPE when switching to not use a custom account name
2022-04-27 12:50:39 +02:00
xyzmaker123
3619278e51
Fix NPE when switching to not use a custom account name
2022-04-26 12:31:27 +02:00
xyzmaker123
b79f963ee7
Fix issue with deleting newly created account
2022-04-26 10:52:36 +02:00
xyzmaker123
74d33e9600
Fix issue with deleting newly created account
2022-04-26 08:45:13 +02:00
jmacxx
36165f686e
Add popup reminder to inform users of trading rules.
2022-04-25 21:11:13 -05:00
Christoph Atteneder
23c62f1f0a
Improve translation key usage
2022-04-22 12:04:25 +02:00
Christoph Atteneder
529755738b
Not log as warning
2022-04-22 12:04:18 +02:00
Christoph Atteneder
5f41a3fb08
Improve translation key usage
2022-04-22 12:02:47 +02:00
Christoph Atteneder
539664d7e3
Not log as warning
2022-04-22 12:02:09 +02:00
Christoph Atteneder
0466f41934
Merge pull request #6135 from ripcurlx/improve-navigation-structure
...
Improve navigation structure
2022-04-22 11:33:53 +02:00
Christoph Atteneder
4447435e5f
Switch to open offers after creating a new offer
2022-04-22 10:01:35 +02:00
Christoph Atteneder
dde4199a15
Merge pull request #6133 from xyzmaker123/fix-pause-in-fee-service
...
Fix pause between fee requests
2022-04-21 10:54:31 +02:00
Christoph Atteneder
2233f73a7b
Fix Codacy complaints
2022-04-21 10:32:27 +02:00
Christoph Atteneder
9431dd5331
Merge pull request #6140 from jmacxx/change_additional_info_prompt
...
Clarify that CBM / F2F not be used to advertise websites or contact info
2022-04-20 21:33:51 +02:00
Christoph Atteneder
108255bf8e
Move supported currencies into payment accounts
2022-04-20 17:57:07 +02:00
Christoph Atteneder
fce247cbc0
Fix a couple of issues regarding default currencies
2022-04-13 12:35:58 +02:00
Christoph Atteneder
82cae5a87d
Merge pull request #6147 from jmacxx/add_inbound_connectivity_test
...
Add inbound Tor connectivity test
2022-04-13 10:56:31 +02:00
jmacxx
c6209e0142
Use Locale.ENGLISH when accessing directories and JAR resource paths.
2022-04-12 18:25:06 -05:00
jmacxx
c3e6a80f78
Add inbound Tor connectivity test.
2022-04-12 14:43:30 -05:00
Christoph Atteneder
9a3ed33238
Use Offer.isFiat helper method
2022-04-11 12:31:54 +02:00
Christoph Atteneder
63ea054026
Adapt amount and volume description for create offer
2022-04-11 12:12:47 +02:00
Christoph Atteneder
492ff35b09
Adapt amount and volume description for take offer
2022-04-11 11:32:55 +02:00
Christoph Atteneder
5b67766109
Properly rename main navigation
...
Otherwise it would display the old 'Buy BTC' and 'Sell BTC' navigation
2022-04-11 10:46:05 +02:00
jmacxx
54c63fd116
Clarify that CBM / F2F not be used to advertise websites or contact info.
2022-04-10 13:14:16 -05:00
Christoph Atteneder
33725c2b4e
Adapt navigation labels back to currency code
...
and fix lots of minor issues
2022-04-08 17:49:33 +02:00
Christoph Atteneder
497158ad13
Fix rebase errors with master
2022-04-07 21:13:24 +02:00
Christoph Atteneder
a8189d7bb3
Adapt create offer process to new navigation structure
2022-04-07 20:49:18 +02:00
Christoph Atteneder
924e92aa47
Adapt take offer process to new navigation structure
2022-04-07 20:49:18 +02:00
Christoph Atteneder
810a29b54f
Add missing payment account filtering
2022-04-07 20:49:17 +02:00
Christoph Atteneder
5781e3bd13
Add payment account filtering for remaining payment methods
2022-04-07 20:49:17 +02:00
Christoph Atteneder
875e5f4e87
Adapt offer book chart view to new navigational structure
2022-04-07 20:49:16 +02:00
Christoph Atteneder
98f355d3fa
Adapt navigational structure and offerbook handling to buy and sell different assets
...
Still missing correct create and take offer handling
2022-04-07 20:48:48 +02:00
Christoph Atteneder
298806150b
Merge pull request #6134 from jmacxx/fix_tradecount_bsqswap
...
Fix the avatar tradecount tag to include BSQ Swap trades.
2022-04-07 19:58:38 +02:00
Christoph Atteneder
02fac2149b
Merge pull request #6131 from jmacxx/fix_bsq_dashboard_freeze
...
Prevent UI freeze in BSQ dashboard view.
2022-04-07 19:56:15 +02:00
jmacxx
14821536c6
code review: remove duplicated lines.
2022-04-05 21:56:43 -05:00
jmacxx
aeea26725f
Fix the tradecount tag to include Bsq Swap trades.
2022-04-05 18:01:51 -05:00
jmacxx
589404f928
Refactor tradestatistics feed to the price feed service.
...
Price change events were being fired too frequently and for ccys
which had not changed.
This caused UI freezing issues most noticably in the DAO dashboard.
2022-04-05 15:38:53 -05:00
xyzmaker123
2073e68d87
Fix pause between fee requests
2022-04-05 17:27:18 +02:00
Christoph Atteneder
3f02d52789
Merge pull request #6132 from jmacxx/purge_sensitive_data_failed_trades
...
Check failed trades for sensitive data purge.
2022-04-05 11:52:04 +02:00
jmacxx
91a9804572
Check failed trades for sensitive data purge.
2022-04-04 16:34:42 -05:00
Christoph Atteneder
3166ea398c
Merge pull request #6130 from jmacxx/dao_status_wording
...
Clarify DAO status shown when in sync & peers have conflicts.
2022-04-04 21:11:20 +02:00
jmacxx
275e710eb2
Clarify DAO status shown when in sync but peers have conflicts.
2022-04-04 09:33:30 -05:00
jmacxx
581deb7056
Remove unused imports
2022-04-03 17:40:47 -05:00
jmacxx
60db9440c7
Generate addresses field from script when necessary (v22+ RPC)
2022-04-03 17:32:35 -05:00
jmacxx
d0a9e660b3
Get TXO address from scriptPubKey
2022-03-28 15:16:53 -05:00
Christoph Atteneder
a384071cff
Merge pull request #6109 from xyzmaker123/5979-price-validation
...
Update trigger price validation
2022-03-21 12:26:47 +01:00
xyzmaker123
55c55dbf47
Update trigger price validation - refactor
2022-03-21 11:43:09 +01:00
Christoph Atteneder
06dd94f77a
Merge pull request #6107 from xyzmaker123/growth-241-validate-with-iban
...
IBAN validation for SEPA account
2022-03-18 12:38:47 +01:00
xyzmaker123
044bc2d33b
Transactions View - Trade ID column
2022-03-17 15:57:01 +01:00
xyzmaker123
ab5d7dd928
Locked view - Trade ID column
2022-03-17 15:56:51 +01:00
xyzmaker123
d548dcba07
Reserved view - Offer ID column
2022-03-17 15:56:35 +01:00
xyzmaker123
41256367af
Update trigger price validation
2022-03-17 12:42:41 +01:00
xyzmaker123
ab1a8a8a2b
SEPA IBAN - fix country code validation
2022-03-16 15:17:45 +01:00
xyzmaker123
7fc406761a
Validate if IBAN country code belongs to SEPA zone
2022-03-16 10:22:29 +01:00
xyzmaker123
fd776954cc
Validate IBAN to match selected country
2022-03-16 09:29:03 +01:00
ghubstan
a3990783a4
Send pretty payment details to api clients
...
Non-CLI clients need a better way of accessing payment details
than a contract json string.
- Add grpc.proto PaymentAccountPayloadInfo field: payment_details.
- Adjust proto wrapper PaymentAccountPayloadInfo to new field.
- Add test asserts to verify payment details are sent to client.
- Fix a test name: testKeepFunds -> testCloseTrade.
Based on branch `master` @ Sat 12 Mar 2022 01:42 PM -03 ,
commit c6293b5273
2022-03-12 14:33:23 -03:00
Bisq GitHub Admin
c6293b5273
Merge pull request #6096 from bisq-network/release/v1.8.4
...
Release/v1.8.4
2022-03-11 15:57:55 +01:00
Christoph Atteneder
a188266d65
Merge pull request #6099 from jmacxx/mediation_enhancements_202203
...
Dispute subsystem enhancements
2022-03-11 15:55:42 +01:00
jmacxx
7e802e5e28
Dispute subsystem enhancements.
...
Dispute result show payout suggestion and penalty.
Feature allowing trader chat upload to dispute agents.
2022-03-10 20:20:37 -06:00
ghubstan
24e5f193be
Exclude persistedAccountName field from json payment acct forms
...
This recently added field is automatically set inside PaymentAccount.
It should not be included in the payment acct json forms used by API clients.
Based on branch `master`.
2022-03-09 12:07:33 -03:00
Christoph Atteneder
0ea70dc36b
Merge pull request #6014 from xyzmaker123/6009-account-names-editable
...
Editable account names
2022-03-09 14:56:00 +01:00
Christoph Atteneder
b3b488c38c
Merge pull request #6094 from ghubstan/3-fix-is-activated-setting-bug
...
API bug-fix for incorrect BsqSwap's OfferInfo.isActivated value [No. 3]
2022-03-08 11:26:44 +01:00
Christoph Atteneder
20a3ec0592
Merge pull request #6088 from ghubstan/2-improve-grpc-exception-status-code-mapping
...
Send meaningful io.grpc.Status.Code to gRPC clients [No. 2]
2022-03-08 11:25:35 +01:00
Christoph Atteneder
ae17da93ea
Merge pull request #6086 from ghubstan/move-cli-crypto-offer-filter-to-server
...
Move get (cryptocurrency) offer filter to daemon [No. 1]
2022-03-08 11:23:05 +01:00
ghubstan
1ba2b6ca18
Fix API OfferInfo.isActivated setting for bsqswaps
...
I think this bug was introduced when deprecating GrpcOffersService
.getMyOffer(id), in favor of using only getOffer(id) for 'my'
and 'available' offers. This change explicitly sets the proto's
isActivated flag in the OfferInfo factory methods, and adds checks
to api offer test cases.
Based on branch `2-improve-grpc-exception-status-code-mapping`,
PR https://github.com/bisq-network/bisq/pull/6088
2022-03-07 20:46:27 -03:00
jmacxx
e9c021eac6
Fix DAO needs resync popup.
...
The resync popup was being shown when flag isInConflictWithSeedNode
was set, but there is also a different relevant flag
isDaoStateBlockChainNotConnecting which can happen in certain
situations. For that case we also need to show the popup.
2022-03-07 16:35:20 +01:00
ghubstan
784e2ae894
Send meaningful io.grpc.Status.Code to gRPC clients
...
Exceptions thrown by the core.api services for the daemon Grpc*Services
have to be converted into gRPC StatusRuntimeExceptions before being sent to
gRPC clients. Most of these gRPC StatusRuntimeExceptions had a gRPC
Status.Code.UNKNOWN, which not helpful to client error handlers.
This change partially resolves the issue by sending more meaningful
io.grpc.Status.Codes to clients, where possible. But it is not as
comprehensive as it an be for a webapp because HTTP has so many more
possible response status codes than the gRPC library (sixteen). See:
https://github.com/grpc/grpc-java/blob/master/api/src/main/java/io/grpc/Status.java
There are three types of changes:
- Create custom exceptions in bisq.core.api.exception.
- Map any custom bisq.core.api.exception to a meaningful
io.grpc.Status.Code within daemon Grpc*Service classes.
- Adjust apitest cases to new grpc status codes.
Based on branch `move-cli-crypto-offer-filter-to-server`, PR https://github.com/bisq-network/bisq/pull/6086
2022-03-05 20:31:50 -03:00
jmacxx
5b03c1a4c5
Fix DAO needs resync popup.
...
The resync popup was being shown when flag isInConflictWithSeedNode
was set, but there is also a different relevant flag
isDaoStateBlockChainNotConnecting which can happen in certain
situations. For that case we also need to show the popup.
2022-03-04 14:17:53 -06:00
ghubstan
b7fb3df0d4
Move get (cryptocurrency) offer filter to daemon
...
Some API reference & Python bot examples exposed an API bug the Java CLI
has been hiding. Due due this Bisq v1 Offer entity design:
- In fiat offers, the baseCurrencyCode=BTC, counterCurrencyCode=FiatCode
- In altcoin offers, baseCurrencyCode=AltcoinCode, counterCurrencyCode=BTC,
new API examples were not doing what the CLI has been doing for several
months, which is get (cryptocurrency) all BTC offers from the server,
and filter on the altcoin code. The CLI side filtering should have been
done on the server, as it is in this commit.
A lot of dead gRPC client side offer filtering code is removed as well.
Based on `master`.
2022-03-03 16:19:00 -03:00
Christoph Atteneder
ea1222b8c9
Merge pull request #6077 from ripcurlx/update-data-stores-for-v1.8.3
...
Update data stores for v1.8.3
2022-03-02 21:03:58 +01:00
xyzmaker123
e6320cdf06
Optimize imports
2022-02-28 13:53:38 +01:00
ghubstan
82a0f0060c
Adjust to grpc.proto TradeInfo field name changes
...
See commit b9b66b4826
.
2022-02-27 18:13:54 -03:00
ghubstan
a1f059ded4
Merge branch '7-more-grpcproto-comments' into 8-remove-trdstats-service
2022-02-26 17:53:04 -03:00
ghubstan
f14806ea1f
Let minAmount param be optional
2022-02-26 17:48:44 -03:00
ghubstan
b904002991
Avoid number formatting problems if clients pass empty (default) str params
2022-02-26 17:17:42 -03:00
ghubstan
aa6f530555
Revert "Allow editoffer clients to pass empty string for price parameter"
...
This reverts commit fcd2bcd34f
.
2022-02-26 15:26:24 -03:00
ghubstan
fcd2bcd34f
Allow editoffer clients to pass empty string for price parameter
...
The client may have passed an empty string for the price parameter,
if only enabling or disabling the offer. If so, validate with new
price = old price.
2022-02-26 15:13:21 -03:00
ghubstan
ab8a3433c3
Use a zero fixed-price if useMarketBasedPrice=true
...
The CLI and apitest cases always pass "0", but java & python clients
might pass an empty string. This change avoids number formatting
& scaling problems when clients pass an empty string in the price
parameter.
2022-02-26 14:27:52 -03:00
ghubstan
2e9e51eb41
Remove GetTradeStatistics service from grpc.proto
...
This protobuf definition and service stub has been in place since
the start of work on the API, but was never fully implmented, nor
intended to be included in the API beta & v1 releases.
Its presence added a useless section to the gRPC API Reference doc.
https://ghubstan.github.io/slate
Based on branch `7-more-grpcproto-comments`,
PR https://github.com/bisq-network/bisq/pull/6068 .
2022-02-26 11:11:26 -03:00
Stan
1499465c11
Merge branch 'master' into 7-more-grpcproto-comments
2022-02-25 20:46:05 -03:00
Christoph Atteneder
c0ab215388
Merge pull request #6078 from jmacxx/5396_privacy_enhancement
...
[1.8.3] Clear sensitive dispute data based on dispute opening date.
2022-02-25 17:29:02 +01:00
jmacxx
a983e4a45e
Clear sensitive dispute data based on dispute opening date.
...
Change recommended setting for sensitive data clearing to 60 days.
2022-02-25 17:09:29 +01:00
jmacxx
327ea680ac
Clear sensitive dispute data based on dispute opening date.
...
Change recommended setting for sensitive data clearing to 60 days.
2022-02-25 09:49:36 -06:00
jmacxx
3bc096417e
Keep first dispute chat msg when clearing sensitive data.
...
Fixes https://github.com/bisq-network/bisq/pull/6001#issuecomment-1049710029
2022-02-25 16:01:32 +01:00
Christoph Atteneder
5824c9cabb
Merge pull request #6076 from jmacxx/5396_privacy_enhancement
...
[1.8.3] Keep first dispute chat msg when clearing sensitive data.
2022-02-25 16:01:25 +01:00
Christoph Atteneder
382c2a1681
Update bitcoinj checkpoints for v1.8.3
2022-02-24 20:47:32 +01:00
jmacxx
f430243b5e
Keep first dispute chat msg when clearing sensitive data.
...
Fixes https://github.com/bisq-network/bisq/pull/6001#issuecomment-1049710029
2022-02-24 11:44:36 -06:00
Christoph Atteneder
07f0e70731
Merge pull request #6072 from jmacxx/5396_privacy_enhancement
...
[1.8.3 fix] Get payment method ID from offerPayload pt.II
2022-02-23 15:42:54 +01:00
jmacxx
c12fb2e004
Get payment method ID from offerPayload.
...
Another problem with closed trades older than v1.7.0.
The payment method ID can always be obtained from offerPayload.
2022-02-23 15:42:34 +01:00
jmacxx
70752a1ffd
Get payment method ID from offerPayload.
...
Another problem with closed trades older than v1.7.0.
The payment method ID can always be obtained from offerPayload.
2022-02-21 23:22:54 -06:00
jmacxx
2bdfa524cf
Get payment method ID from offerPayload.
...
Was getting an NPE with closed trades older than v1.7.0.
makerPaymentMethodId was new at that point (null for older trades).
makerPaymentAccountPayload can be null for trades where we have
removed account info for privacy reasons (see #6001 ).
The payment method ID can always be obtained from offerPayload.
2022-02-21 20:23:14 +01:00
Christoph Atteneder
d12a13b1a1
Merge pull request #6069 from jmacxx/5396_privacy_enhancement
...
[1.8.3 fix] Get payment method ID from offerPayload
2022-02-21 20:22:59 +01:00
jmacxx
f3dfc14779
Get payment method ID from offerPayload.
...
Was getting an NPE with closed trades older than v1.7.0.
makerPaymentMethodId was new at that point (null for older trades).
makerPaymentAccountPayload can be null for trades where we have
removed account info for privacy reasons (see #6001 ).
The payment method ID can always be obtained from offerPayload.
2022-02-21 10:59:32 -06:00
jmacxx
99be324aba
Improve BSQ swap error messaging.
...
Re-enable popup warning indicating when DAO needs to be resynced.
2022-02-21 14:50:41 +01:00
Christoph Atteneder
b739b4c347
Merge pull request #6063 from jmacxx/bsq_swap_improve_dao_errmsg
...
Improve BSQ swap error messaging & DAO resync popup.
2022-02-21 14:50:31 +01:00
xyzmaker123
5e0ebf163d
Fix bug with text rendering on trade step info
2022-02-21 14:49:53 +01:00
ghubstan
66c04bdf3d
Adjust core.api to new .proto *Pct field names
2022-02-20 15:19:32 -03:00
xyzmaker123
3b966d8740
Fix bug with text rendering on trade step info
2022-02-20 10:13:56 +01:00
jmacxx
a302380e1e
Improve BSQ swap error messaging.
...
Re-enable popup warning indicating when DAO needs to be resynced.
2022-02-19 22:15:13 -06:00
ghubstan
a0b68bc756
Adjust .proto wrappers to price & volume type change
...
Some minor refactoring included.
2022-02-19 15:09:16 -03:00
ghubstan
d42c58073f
Change OfferInfo proto's volume fields' type to string
2022-02-18 16:43:23 -03:00
ghubstan
a5fc4b7d52
Get fee from dao state service if JFX prop filterManager.getFilter is null
2022-02-18 17:07:41 +01:00
Christoph Atteneder
aaac08202e
Merge pull request #6052 from ghubstan/alt-fix-feeservice-npe-in-api
...
Fix API FeeService NPE (Alternate)
2022-02-18 17:07:30 +01:00
ghubstan
fafe416e85
Adjust to string triggerPrice
change in API core classes.
2022-02-18 11:24:02 -03:00
ghubstan
461edff631
Change OfferInfo proto's 'price' field type to string
...
Much less ambiguous field value at cost of breaking backward compat in API.
2022-02-17 17:27:15 -03:00
ghubstan
6f1057a766
Include unmerged API NPE fix to FeeService class (see PR #6052 )
2022-02-17 13:28:14 -03:00
Christoph Atteneder
25441814ae
Update translations for v1.8.3
2022-02-17 10:48:22 +01:00
Christoph Atteneder
12a797d9e4
Merge pull request #6053 from jmacxx/display_signed_account_age
...
Show signed status when applicable in Trade & Dispute info screens
2022-02-17 10:35:41 +01:00
jmacxx
b1e88e8338
Add ability to copy popup text to clipboard.
2022-02-16 19:26:37 -06:00
jmacxx
1227781d43
Show signed status when applicable in Trade & Dispute screens
2022-02-16 16:09:08 -06:00
ghubstan
84eb653366
Get fee from dao state service if JFX prop filterManager.getFilter is null
2022-02-16 14:27:05 -03:00
Christoph Atteneder
d671b6805a
Merge pull request #6032 from jmacxx/sign_verify_msg_dao
...
Sign/Verify message for DAO bonded roles
2022-02-15 21:01:21 +01:00
Christoph Atteneder
3f978252ac
Merge pull request #6040 from jmacxx/fix_bsq_sending_issue
...
Fix issue selecting specific BSQ UTXO for send.
2022-02-15 21:00:20 +01:00
jmacxx
f601e0f42f
Obtain trade fee settings from filter
2022-02-15 13:23:33 -06:00
jmacxx
518ca6e0c3
Fix issue selecting specific BSQ UTX for send.
...
The BisqDefaultCoinSelector is invoked multiple times when a
transaction is being built. Problem was that the coin selection
was being reset within, ultimately leading to coin selection
being completely ignored. Solution is to reset the selection
after the transaction has been built.
The UI for selecting UTXO inputs was being resized to the number
of UTXO available, which caused problems when there is a large
UTXO set. Solution is to size the UI to accomodate 3 to 15 rows,
which provides a reasonable screen display and a scrollbar is
provided for the case of a large UTXO set.
2022-02-11 11:15:27 -06:00
jmacxx
5e7e1c5704
Sign/Verify message for DAO bonded roles
2022-02-10 20:45:43 -06:00