bisq/core
ghubstan 381985ec3a
Fix API editoffer bug: set fixed-price=0 on margin offers
This is causing erroneous PRICE_OUT_OF_TOLERANCE errors when trying
to take offers having (fixed) price!=0, and isUsingMktPriceMargin=true
in the payload.

The API daemon editoffer's treatment of (fixed) price and
isUsingMktPriceMargin flag in the API has been inconsistent with the UI.

With this change:  when isUsingMktPriceMargin=true, (fixed) price is
set to 0 on the server.  API clients, however, still must show the
calculated price when isUsingMktPriceMargin=true, making this fix hard
to test in the client.  The server will now throw an exception if
(fixed) price and isUsingMktPriceMargin flag in the API are not
properly set in the API server.

This fix is intended to prevent issues such as
https://github.com/bisq-network/bisq/issues/6170 from happening for
this reason.  The offer maker edited offers with API, creating
inconsistent state described above.  It is hoped the user's offers
can be fixed by editing them in the UI.

Based on `master`.
2022-05-14 18:14:49 -03:00
..
.tx Update translations for v1.9.0 2022-04-28 13:12:59 +02:00
src Fix API editoffer bug: set fixed-price=0 on margin offers 2022-05-14 18:14:49 -03:00
update_translations.sh Add Polish translation 2021-12-01 15:13:57 +01:00