A decentralized bitcoin exchange network
Go to file
ghubstan 381985ec3a
Fix API editoffer bug: set fixed-price=0 on margin offers
This is causing erroneous PRICE_OUT_OF_TOLERANCE errors when trying
to take offers having (fixed) price!=0, and isUsingMktPriceMargin=true
in the payload.

The API daemon editoffer's treatment of (fixed) price and
isUsingMktPriceMargin flag in the API has been inconsistent with the UI.

With this change:  when isUsingMktPriceMargin=true, (fixed) price is
set to 0 on the server.  API clients, however, still must show the
calculated price when isUsingMktPriceMargin=true, making this fix hard
to test in the client.  The server will now throw an exception if
(fixed) price and isUsingMktPriceMargin flag in the API are not
properly set in the API server.

This fix is intended to prevent issues such as
https://github.com/bisq-network/bisq/issues/6170 from happening for
this reason.  The offer maker edited offers with API, creating
inconsistent state described above.  It is hoped the user's offers
can be fixed by editing them in the UI.

Based on `master`.
2022-05-14 18:14:49 -03:00
.github Bump actions/setup-java from 3.2.0 to 3.3.0 2022-05-09 14:19:07 +00:00
.idea
apitest Move supported currencies into payment accounts 2022-04-20 17:57:07 +02:00
assets/src Optimize imports 2022-02-28 13:53:38 +01:00
cli Accept a VERSION parameter, default to SNAPSHOT 2022-03-28 11:05:13 -03:00
common/src Bump version number for v1.9.1 2022-05-02 09:50:46 +02:00
core Fix API editoffer bug: set fixed-price=0 on margin offers 2022-05-14 18:14:49 -03:00
daemon Accept a VERSION parameter, default to SNAPSHOT 2022-03-28 11:05:13 -03:00
desktop Bugfix: Signed account must show signed age. 2022-05-11 08:57:36 -05:00
docs Remove references to keybase and switch to Matrix 2022-02-02 16:57:06 +01:00
gradle Update gradle wrapper to 7.3.3 2021-12-25 13:03:14 +01:00
inventory/src/main Move Utilities.objectToJson to JsonUtil.objectToJson 2021-11-02 16:18:50 +01:00
monitor Cleanups 2021-10-21 10:12:57 +02:00
p2p/src Update data stores for v1.9.0 2022-04-28 13:11:05 +02:00
pricenode Remove references to keybase and switch to Matrix 2022-02-02 16:57:06 +01:00
proto/src/main/proto Adapt navigational structure and offerbook handling to buy and sell different assets 2022-04-07 20:48:48 +02:00
relay Revert to SNAPSHOT version 2022-05-03 10:06:10 +02:00
scripts make all scripts executable 2021-11-30 12:40:06 +01:00
seednode Bump version number for v1.9.1 2022-05-02 09:50:46 +02:00
statsnode/src/main Enforce inclusion of TradeLimits for headless apps 2021-11-23 21:34:43 +01:00
.editorconfig
.gitattributes Add git lfs support for BsqBlocks in resources 2021-11-09 17:22:35 +01:00
.gitignore
.travis.yml Update travis config to Java 11 2021-02-01 18:03:26 +01:00
build.gradle Revert to SNAPSHOT version 2022-05-03 10:06:10 +02:00
CODEOWNERS
CONTRIBUTING.md Remove references to keybase and switch to Matrix 2022-02-02 16:57:06 +01:00
gradle.properties Build: Change default console to plain 2021-05-25 08:59:10 +02:00
gradlew Update gradle wrapper to 7.3.3 2021-12-25 13:03:14 +01:00
gradlew.bat
LICENSE
Makefile Update link to OpenJDK archive 2021-04-23 10:31:11 +02:00
pull_request_template.md
README.md Replace Travis build icon with the Github Actions svg 2022-04-12 17:57:12 +02:00
settings.gradle

Actions Status

What is Bisq?

Bisq is a safe, private and decentralized way to exchange bitcoin for national currencies and other digital assets. Bisq uses peer-to-peer networking and multi-signature escrow to facilitate trading without a third party. Bisq is non-custodial and incorporates a human arbitration system to resolve disputes.

To learn more, see the doc and video at https://bisq.network/intro.

Get started using Bisq

Follow the step-by-step instructions at https://bisq.network/get-started.

Contribute to Bisq

See CONTRIBUTING.md and the developer docs.