mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2025-02-24 23:18:17 +01:00
Code Issues Projects Releases Packages Wiki Activity

Get payment method ID from offerPayload.

Browse source 
Was getting an NPE with closed trades older than v1.7.0.
makerPaymentMethodId was new at that point (null for older trades).
makerPaymentAccountPayload can be null for trades where we have
removed account info for privacy reasons (see #6001).
The payment method ID can always be obtained from offerPayload.
This commit is contained in:
jmacxx 2022-02-21 10:59:32 -06:00 • committed by Christoph Atteneder
parent 99be324aba
commit 2bdfa524cf
No known key found for this signature in database
GPG key ID: CD5DC1C529CDFD3B
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core/src/main/java/bisq/core/trade/model/bisq_v1/Contract.java
View file

@ -298,8 +298,8 @@ public final class Contract implements NetworkPayload {
}
public String getPaymentMethodId() {
// Either makerPaymentMethodId is set or available in makerPaymentAccountPayload
return makerPaymentMethodId != null ? makerPaymentMethodId : Objects.requireNonNull(makerPaymentAccountPayload).getPaymentMethodId();
// Either makerPaymentMethodId is set or available in offerPayload
return makerPaymentMethodId != null ? makerPaymentMethodId : Objects.requireNonNull(getOfferPayload()).getPaymentMethodId();
}
public Coin getTradeAmount() {