Initially in lnd, we didn't store the extra TLV data that could be
dangling off of gossip messages. This was fixed initially in lnd v0.5
with this PR: https://github.com/lightningnetwork/lnd/pull/1825.
Within the PR, we incorrect set the `ExtraOpaqueData` (extra TLV blob)
of the `ChannelAnnouncement` to the value stored in `edge`, which is
actually our channel update. As 6-ish years ago we didn't yet have
anything that used the TLV gossip fields, this went unnoticed.
Fast forward to 2024, we shipped an experimental version of inbounbd
fees. This starts to store additional data in the `ExtraOpaqueData`
field, the TLV for the inbound fee. Initially, everything is valid when
the first `ChannelAnnouncement` is sent, but as soon as a user attempts
to set an inbound fee policy, we'd incorrectly swap in that new
serialized TLV for the _channel announcement_:
841e24399c (diff-1eda595bbebe495bd74a6a0431c46b66cb4e8b53beb311067c010feac2665dcbR2560)
.
Since we're just trying to generate a new `channel_update`, we don't
also regenerate the signature for the `channel_announcement` message. As
a result, we end up storing a `channel_announcement` with an invalid sig
on disk, continuing to broadcast that to peers.
9.8 KiB
Release Notes
Bug Fixes
-
closedchannels
now successfully reports settled balances even if the delivery address is set to an address that LND does not control. -
SendPaymentV2 now cancels the background payment loop if the user cancels the stream context.
-
Fixed a bug that caused LND to read the config only partially and continued with the startup.
-
Avoids duplicate wallet addresses being created when multiple RPC calls are made concurrently.
-
Fixed a bug that caused LND to use a default fee rate for the batch channel opening flow.
-
Fixed a case where LND would not shut down properly when interrupted via e.g. SIGTERM. Moreover, LND now shutsdown correctly in case one subsystem fails to startup.
-
The fee limit for payments was made compatible with inbound fees.
-
Fixed a case where bumping an anchor channel closing was not possible when no HTLCs were on the commitment when the channel was force closed.
-
Fixed old payments that are stuck inflight. Though the root cause is unknown, it's possible the network result for a given HTLC attempt was not saved, which is now fixed. Check here for the details about the analysis, and here for a summary of the issue.
-
We'll now always send channel updates to our remote peer for open channels.
-
A bug has been fixed that could cause invalid channel announcements to be generated if the inbound fee discount is used.
New Features
Functional Enhancements
RPC Additions
-
The SendPaymentRequest message receives a new flag
cancelable
which indicates if the payment loop is cancelable. The cancellation can either occur manually by cancelling the send payment stream context, or automatically at the end of the timeout period if the user providedtimeout_seconds
. -
The SendCoinsRequest now takes an optional param
Outpoints
, which is a list of*lnrpc.OutPoint
that specifies the coins from the wallet to be spent in this RPC call. To send selected coins to a given address with a given amount,req := &lnrpc.SendCoinsRequest{ Addr: ..., Amount: ..., Outpoints: []*lnrpc.OutPoint{ selected_wallet_utxo_1, selected_wallet_utxo_2, }, } SendCoins(req)
To send selected coins to a given address without change output,
req := &lnrpc.SendCoinsRequest{ Addr: ..., SendAll: true, Outpoints: []*lnrpc.OutPoint{ selected_wallet_utxo_1, selected_wallet_utxo_2, }, } SendCoins(req)
-
The
EstimateFee
call on thewalletrpc
sub-server now also returns the currentmin_relay_fee
.
lncli Additions
-
Added the
cltv_expiry
argument toaddinvoice
andaddholdinvoice
, allowing users to set themin_final_cltv_expiry_delta
. -
The
lncli wallet estimatefeerate
command returns the fee rate estimate for on-chain transactions in sat/kw and sat/vb to achieve a given confirmation target. -
sendcoins
now takes an optional utxo flag. This allows users to specify the coins that they want to use as inputs for the transaction. To send selected coins to a given address with a given amount,sendcoins --addr YOUR_ADDR --amt YOUR_AMT --utxo selected_wallet_utxo1 --utxo selected_wallet_utxo2
To send selected coins to a given address without change output,
sendcoins --addr YOUR_ADDR --utxo selected_wallet_utxo1 --utxo selected_wallet_utxo2 --sweepall
Improvements
Functional Updates
-
A new field,
min_relay_feerate
, is now expected in the response from querying the external fee estimation URL. The new response should have the format,{ "fee_by_block_target": { "2": 5076, "3": 4228, "26": 4200 }, "min_relay_feerate": 1000 }
All units are
sats/kvB
. If the new fieldmin_relay_feerate
is not set, the default floor feerate (1012 sats/kvB) will be used. -
Commitment fees are now taken into account when calculating the fee exposure threshold.
-
Allow multiple etcd hosts to be specified in db.etcd.host.
RPC Updates
-
xImportMissionControl
now accepts0
failure amounts. -
ChanInfoRequest
adds support for channel points. -
BuildRoute now supports inbound fees.
lncli Updates
-
importmc
now accepts0
failure amounts. -
getchaninfo
now accepts a channel outpoint besides a channel id. -
Fixed how we parse the
--amp
flag when sending a payment specifying the payment request.
Code Health
-
Added a new failure reason
FailureReasonCanceled
to the list of payment failure reasons. It indicates that a payment was manually cancelled by the user. -
Update the version of falafel used to generate JSON/wasm stubs. This latest version of falafel also supports proto3 optional fields.
Breaking Changes
Performance Improvements
- Mission Control Store improved performance during DB flushing stage.
Technical and Architectural Updates
BOLT Spec Updates
-
Start assuming that all hops used during path-finding and route construction support the TLV onion format.
-
Allow channel fundee to send a minimum confirmation depth of 0 for a non-zero-conf channel. We will still wait for the channel to have at least one confirmation and so the main change here is that we don't error out for such a case.
-
Groundwork in preparation for implementing route blinding receives.
-
Generate and send to an invoice with blinded paths. With this, the
--blind
flag can be used with thelncli addinvoice
command to instruct LND to include blinded paths in the invoice. -
Add the ability to send to use multiple blinded payment paths in an MP payment.
-
Improve route blinding invoice generation UX by making various params configurable on a per-RPC basis.
Testing
Database
-
Migrate incorrectly stored invoice expiry values. This migration only affects users of native SQL invoice database. Invoices with incorrect expiry values will be updated to 24-hour expiry, which is the default behavior in LND.
-
Fixed pagination issues in SQL invoicedb queries.
-
Check leader status with our health checker to correctly shut down LND if network partitioning occurs towards the etcd cluster.
Code Health
- Move graph building and
maintaining duties from
the
routing.ChannelRouter
to the newgraph.Builder
sub-system and also remove thechanneldb.ChannelGraph
pointer from theChannelRouter
.
Tooling and Documentation
lntest.HarnessTest
no longer exposesMiner
instance. Instead, it's changed into a privateminer
instance and all mining related assertions are now only accessible via the harness.
Contributors (Alphabetical Order)
- Andras Banki-Horvath
- bitromortac
- Bufo
- Elle Mouton
- Eugene Siegel
- Matheus Degiovani
- Olaoluwa Osuntokun
- Oliver Gugger
- Slyghtning
- Yong Yu
- Ziggie