lnd/docs/release-notes
Olaoluwa Osuntokun f7daa307dd
discovery: fix bug that can lead to sending invalid chan_ann msgs
Initially in lnd, we didn't store the extra TLV data that could be
dangling off of gossip messages. This was fixed initially in lnd v0.5
with this PR: https://github.com/lightningnetwork/lnd/pull/1825.

Within the PR, we incorrect set the `ExtraOpaqueData` (extra TLV blob)
of the `ChannelAnnouncement` to the value stored in `edge`, which is
actually our channel update. As 6-ish years ago we didn't yet have
anything that used the TLV gossip fields, this went unnoticed.

Fast forward to 2024, we shipped an experimental version of inbounbd
fees. This starts to store additional data in the `ExtraOpaqueData`
field, the TLV for the inbound fee. Initially, everything is valid when
the first `ChannelAnnouncement` is sent, but as soon as a user attempts
to set an inbound fee policy, we'd incorrectly swap in that new
serialized TLV for the _channel announcement_:
841e24399c (diff-1eda595bbebe495bd74a6a0431c46b66cb4e8b53beb311067c010feac2665dcbR2560).

Since we're just trying to generate a new `channel_update`, we don't
also regenerate the signature for the `channel_announcement` message. As
a result, we end up storing a `channel_announcement` with an invalid sig
on disk, continuing to broadcast that to peers.
2024-08-13 19:39:16 -07:00
..
release-notes-0.13.1.md lntest: avoid global ServeMux 2021-08-27 11:30:01 +02:00
release-notes-0.13.2.md docs/release-notes: add item for easy AMP CLI re-use 2021-08-04 19:17:57 -07:00
release-notes-0.13.3.md docs: update release notes for 0.13.3 2021-09-30 13:44:35 -04:00
release-notes-0.14.0.md multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
release-notes-0.14.1.md docs/release-notes: add entry for funding API downgrade protection 2021-11-24 14:32:55 -06:00
release-notes-0.14.2.md lnwallet: increase legacy fee limit threshold to 1k sats 2022-02-03 11:54:01 -08:00
release-notes-0.14.3.md docs: add release notes 2022-03-24 14:13:06 +01:00
release-notes-0.15.0.md docs: update remote signing update hint to v0.15.3-beta [skip ci] 2022-10-11 09:42:43 +02:00
release-notes-0.15.1.md docs: update remote signing update hint to v0.15.3-beta [skip ci] 2022-10-11 09:42:43 +02:00
release-notes-0.15.2.md docs/release-notes: shift prior 0.15.2 release to 0.15.3 2022-10-09 18:39:40 -07:00
release-notes-0.15.3.md lnwallet/chancloser: properly compute initial fee of cop close txn 2022-10-10 14:50:45 -07:00
release-notes-0.15.4.md docs: add release notes for 0.15.4-beta 2022-11-01 16:39:19 +01:00
release-notes-0.15.5.md docs/release-notes: add entry for 0.15.5 2022-11-22 13:44:55 +01:00
release-notes-0.16.0.md Merge pull request #7442 from 84adam/postgres-docs-schema-84adam 2023-04-10 16:51:19 -07:00
release-notes-0.16.1.md docs: fix typos [skip ci] 2023-11-20 15:35:56 +08:00
release-notes-0.16.2.md build: update to btcwallet version with async mempool scan 2023-04-27 16:27:26 -05:00
release-notes-0.16.3.md docs/release-notes: add release notes for adamant htlc sweeps 2023-05-29 12:49:07 -07:00
release-notes-0.17.0.md contractcourt: modify the incoming contest resolver to use concurrent queue 2023-09-25 18:48:30 -05:00
release-notes-0.17.1.md release-notes: update for 0.17.1 2023-11-08 16:36:04 -05:00
release-notes-0.17.3.md Merge pull request #8232 from yyforyongyu/optimize-mempool 2023-11-30 14:47:14 -08:00
release-notes-0.17.4.md tls_manager: let REST proxy skip tls cert verification 2024-01-29 17:56:50 +02:00
release-notes-0.18.0.md cfg: move experimental options to main protocol cfg 2024-05-16 17:16:50 -05:00
release-notes-0.18.1.md docs: update release notes and add notes for 0.18.2 2024-06-26 01:44:00 +08:00
release-notes-0.18.2.md docs: update release notes 2024-07-15 15:56:33 +02:00
release-notes-0.18.3.md discovery: fix bug that can lead to sending invalid chan_ann msgs 2024-08-13 19:39:16 -07:00
release-notes-0.19.0.md docs: add release notes. 2024-08-09 19:41:27 +02:00