lnd/docs
Olaoluwa Osuntokun f7daa307dd
discovery: fix bug that can lead to sending invalid chan_ann msgs
Initially in lnd, we didn't store the extra TLV data that could be
dangling off of gossip messages. This was fixed initially in lnd v0.5
with this PR: https://github.com/lightningnetwork/lnd/pull/1825.

Within the PR, we incorrect set the `ExtraOpaqueData` (extra TLV blob)
of the `ChannelAnnouncement` to the value stored in `edge`, which is
actually our channel update. As 6-ish years ago we didn't yet have
anything that used the TLV gossip fields, this went unnoticed.

Fast forward to 2024, we shipped an experimental version of inbounbd
fees. This starts to store additional data in the `ExtraOpaqueData`
field, the TLV for the inbound fee. Initially, everything is valid when
the first `ChannelAnnouncement` is sent, but as soon as a user attempts
to set an inbound fee policy, we'd incorrectly swap in that new
serialized TLV for the _channel announcement_:
841e24399c (diff-1eda595bbebe495bd74a6a0431c46b66cb4e8b53beb311067c010feac2665dcbR2560).

Since we're just trying to generate a new `channel_update`, we don't
also regenerate the signature for the `channel_announcement` message. As
a result, we end up storing a `channel_announcement` with an invalid sig
on disk, continuing to broadcast that to peers.
2024-08-13 19:39:16 -07:00
..
alloy-models docs/alloy-model: add linear fee function model 2024-08-01 17:42:31 -07:00
grpc multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
release-notes discovery: fix bug that can lead to sending invalid chan_ann msgs 2024-08-13 19:39:16 -07:00
rest multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
code_contribution_guidelines.md multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
code_formatting_rules.md multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
configuring_tor.md multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
debugging_lnd.md scripted-diff: replace ⛰ emoji with $ [skip ci] 2022-10-28 12:06:49 -04:00
DOCKER.md multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
etcd.md multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
fuzz.md multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
INSTALL.md multi: use Go version 1.22.5 throughout 2024-07-31 16:53:47 +01:00
key_import.md multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
leader_election.md docs: fix leader node readiness probe example [skip ci] 2024-07-29 21:31:24 +02:00
macaroons.md multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
MAKEFILE.md multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
musig2.md multi: move itest out of lntest 2023-02-23 21:56:08 +08:00
nat_traversal.md scripted-diff: replace ⛰ emoji with $ [skip ci] 2022-10-28 12:06:49 -04:00
postgres.md multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
psbt.md multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
recovery.md multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
release.md multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
remote-signing.md multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
ruby-thing.rb docs: update contribution guidelines to add section on commit structure 2018-12-18 20:59:46 -08:00
safety.md Merge pull request #8881 from mwaite-codes/fix-doc-grammar 2024-07-23 00:25:17 -06:00
sqlite.md docs: add sqlite instructions 2023-01-25 14:16:56 +02:00
wallet.md multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
watchtower.md multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
zero_conf_channels.md docs: add documentation for zero-conf channels 2022-08-10 14:25:11 -04:00