Rusty Russell
d8e68893f5
bcli: become less aggressive with onchain fee levels.
...
Users are more upset recently with the cost of unilateral closes
than they are the risk of being cheated. While we complete our
anchor implementation so we can use low fees there, let's
get less aggressive (we already have 34 or 18 blocks to close
in the worst case).
The changes are:
- Commit transactions were "2 CONSERVATIVE" now "6 ECONOMICAL".
- HTLC resolution txs were "3 CONSERVATIVE" now "6 ECONOMICAL".
- Penalty txs were "3 CONSERVATIVE" now "12 ECONOMICAL".
- Normal txs were "4 ECONOMICAL" now "12 ECONOMICAL".
There can be no perfect levels, but we have had understandable
complaints recently about how high our default fee levels are.
Changelog-Changed: Protocol: channel feerates reduced to bitcoind's "6 block ECONOMICAL" rate.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-11 11:25:16 +09:30
Rusty Russell
9a22e7b3a1
plugins/bcli: make feerate calls more changeable.
...
This make it clearer what we're doing, IMHO, so we can easily alter
the levels if we want.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-11 11:25:16 +09:30
Rusty Russell
9825f32874
lightningd: implement --log-timestamps=false.
...
Fixes : #4494
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: config: New option `log-timestamps` allow disabling of timestamp prefix in logs.
2021-05-05 17:19:19 -05:00
Christian Decker
96acafcef3
libhsmd: Prefix check_client_capabilities
...
I wante to hide it inside the library, but it is good to have a single
place to verify that the client was permitted to send a message we are
handling, so make it officially part of the interface by prefixing it.
2021-05-04 11:18:52 +09:30
Christian Decker
fb2b107bef
libhsmd: Cleanup the bip32_key_version
2021-05-04 11:18:52 +09:30
Christian Decker
4d43e84afd
libhsmd: Finalize encapsulation of hsmd data in libhsmd
...
Changelog-Added: libhsmd: Extracted the `hsmd` logic into its own library for other projects to use
2021-05-04 11:18:52 +09:30
Christian Decker
c9e9581b35
libhsmd: Migrate bolt12 initialization into hsmd_init
2021-05-04 11:18:52 +09:30
Christian Decker
d30392c432
libhsmd: Start migrating initialization to hsmd_init
2021-05-04 11:18:52 +09:30
Christian Decker
befa7fb9f0
libhsmd: Clean up includes in hsmd.c
2021-05-04 11:18:52 +09:30
Christian Decker
1efa792edc
libhsmd: Migrate handle_sign_delayer_payment_to_us
2021-05-04 11:18:52 +09:30
Christian Decker
fe82181fe3
libhsmd: Migrate handle_sign_remote_htlc_to_us
2021-05-04 11:18:52 +09:30
Christian Decker
e643594104
libhsmd: handle_sign_commitment_tx
2021-05-04 11:18:52 +09:30
Christian Decker
4764ebd879
libhsmd: Migrate handle_sign_penalty_to_us
2021-05-04 11:18:52 +09:30
Christian Decker
bee7a65170
libhsmd: Migrate handle_sign_remote_commitment_tx
2021-05-04 11:18:52 +09:30
Christian Decker
c2d035d377
libhsmd: Migrate handle_sign_remote_htlc_tx
2021-05-04 11:18:52 +09:30
Christian Decker
7b2c6ec4d3
libhsmd: Migrate handle_sign_local_htlc_tx
2021-05-04 11:18:52 +09:30
Christian Decker
cd8fb641cf
libhsmd: Migrate handle_sign_mutual_tx
2021-05-04 11:18:52 +09:30
Christian Decker
9aa4b5198d
libhsmd: Migrate handle_sign_withdrawal_tx
2021-05-04 11:18:52 +09:30
Christian Decker
e7007a7f36
libhsmd: Migrate handle_get_per_commitment_point
2021-05-04 11:18:52 +09:30
Christian Decker
eab4aeaed3
libhsmd: Migrate handle_channel_update_sig
2021-05-04 11:18:52 +09:30
Christian Decker
166f0ade04
libhsmd: Migrate handle_sign_node_announcement
2021-05-04 11:18:52 +09:30
Christian Decker
4a3f24a737
libhsmd: Migrate handle_cannouncement_sig
2021-05-04 11:18:52 +09:30
Christian Decker
e9cc8644b6
libhsmd: Migrate handle_get_output_scriptpubkey
2021-05-04 11:18:52 +09:30
Christian Decker
ec5d40c0e7
libhsmd: Migrate handle_check_future_secret
2021-05-04 11:18:52 +09:30
Christian Decker
0e61ed32e3
libhsmd: Migrate handle_ecdh
2021-05-04 11:18:52 +09:30
Christian Decker
d1b3a5b1aa
libhsmd: Migrate handle_get_channel_basepoints
2021-05-04 11:18:52 +09:30
Christian Decker
2cb25a16e0
libhsmd: Migrate handle_sign_invoice
2021-05-04 11:18:52 +09:30
Christian Decker
79ec4b4808
libhsmd: Migrate handle_sign_bolt12
2021-05-04 11:18:52 +09:30
Christian Decker
3d959e128d
libhsmd: Add dispatcher function
2021-05-04 11:18:52 +09:30
Christian Decker
ac836bbd1b
libhsmd: Add status functions to report to whoever is listening
...
These are currently just shims that replicate the old behavior, but
when compiling as a library we can relink the status_* functions to
something that makes sense in the context of the user, and not assume
we're running as a subdaemon.
2021-05-04 11:18:52 +09:30
Christian Decker
b5a2ddd384
libhsmd: Migrate check_client_capabilities to libhsmd
2021-05-04 11:18:52 +09:30
Christian Decker
ed4676bea8
libhsmd: Add scaffolding to start separating hsmd from io logic
2021-05-04 11:18:52 +09:30
Nalin Bhardwaj
ae06bb91ed
plugins/bcli: strip trailing whitespace appropriately
...
Changelog-Fixed: Handle windows-style newlines and other trailing whitespaces correctly in bitcoin-cli interface
2021-05-03 19:00:26 +09:30
Rusty Russell
ff6b26b70e
plugins/funder: fix up compilation.
...
I merge Christian's plugin notification API change at the same
time, broke plugins/funder.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-03 11:42:04 +09:30
Christian Decker
c58b15de19
docs: Document the custom plugin notifications
2021-05-03 11:20:15 +09:30
Christian Decker
ef7f9a8022
pay: Add pay_failure notification
2021-05-03 11:20:15 +09:30
Christian Decker
c6fd849aa3
pay: Add notification for pay_success
2021-05-03 11:20:15 +09:30
Christian Decker
98aa3c3da7
plugin: Make unannounced notification topics no longer fatal
...
Since plugins will start sending them soon, and they are likely to get
it wrong sometimes, be a bit more lenient, warn them in the logs
instead and then make sure it doesn't accidentally work anyway.
2021-05-03 11:20:15 +09:30
Christian Decker
c8c0c4dc99
libplugin: Add functions to start and end notifications
2021-05-03 11:20:15 +09:30
Christian Decker
c1f08a42fe
libplugin: Add notification topics to the manifest response
2021-05-03 11:20:15 +09:30
Christian Decker
f963a6a551
libplugin: Add notification topics to plugin_main
2021-05-03 11:20:15 +09:30
Christian Decker
e02e972729
cleanup: Make lnprototest run only with DEVELOPER=1
2021-05-03 11:20:15 +09:30
Christian Decker
f08ae49134
plugin: Restrict plugin notifications only to announced topics
...
We want to have well-behaved notifications that are clearly announced
during the initialization, kill plugins that don't behave.
2021-05-03 11:20:15 +09:30
Christian Decker
62e3358a5b
plugin: Wrap custom notifications in a dict with additional origin
...
This should allow us to differentiate the origin of the notification,
and further prevent plugins from spoofing native notifications.
2021-05-03 11:20:15 +09:30
Christian Decker
cfb1107244
plugin: Remember the shortname for a plugin
...
We use it in a couple of places, so let's remember it for easier
access.
2021-05-03 11:20:15 +09:30
Christian Decker
2e27e4e443
plugin: Move list of notification topics to each plugin
...
We want to ensure that plugins register their topics before sending
any notification, so we need to remember which plugin registered which
topics.
2021-05-03 11:20:15 +09:30
Christian Decker
c8c2c33952
plugin: Prevent plugins from registering native notification topics
...
They may already have subscribers, and they may crash if presented
with a malformed notification.
2021-05-03 11:20:15 +09:30
Christian Decker
f716c55983
plugin: Implement custom notification dispatch for plugins
...
Changelog-Added: plugin: Plugins may now send custom notifications that other plugins can subscribe to.
2021-05-03 11:20:15 +09:30
Christian Decker
9d310366af
plugin: Store the notification topics announced by the plugins
2021-05-03 11:20:15 +09:30
Christian Decker
f77a0bcd8f
plugin: Move the notification subscription check into a second phase
...
A plugin might subscribe to a notification topic that is only
registered by another plugin later, so push the check to that
consistency check phase where we do hook ordering as well.
2021-05-03 11:20:15 +09:30
