mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2024-11-19 09:52:23 +01:00
Code Issues Packages Projects Releases Wiki Activity
18,137 Commits 4 Branches 148 Tags 4.3 GiB
b0357cdedc
Commit Graph

7320 Commits

Author SHA1 Message Date
Alejandro García
fda3c45008
Merge pull request #6501 from HenrikJannsen/always_include_high_prio_payload_in_get_data_response 
Always include high prio payload in get data response
 2023-01-12 16:33:08 +00:00
HenrikJannsen
116118a451
Distribute evenly restart time 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-10 11:55:27 -05:00
HenrikJannsen
7387b3ac2d
Increase timeout at RequestStateHashesHandler from 2 min. to 3 min 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-06 20:19:55 -05:00
HenrikJannsen
bc5045dd28
Force rebuild at CI 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-06 13:24:17 -05:00
HenrikJannsen
fa82990e6e
Handle DPT_MIN_REMAINDER_TO_LEGACY_BM with isHotfixActivated param 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-06 13:19:59 -05:00
HenrikJannsen
b872683b60
Use trade date for check if hotfix is activated at refund managers DPT verification 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-06 13:10:12 -05:00
HenrikJannsen
9dc79fdcd4
Add checks if hot fix is activated for 2 other changes made since 1.9.8 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-06 10:03:39 -05:00
Alejandro García
be1691ba0c
Merge pull request #6505 from HenrikJannsen/use_thread_for_processing_BM_AccountingBlocks 
Run processAccountingBlocks async in forkjoinpool thread
 2023-01-06 14:09:35 +00:00
Alejandro García
dda32c09ff
Merge pull request #6504 from HenrikJannsen/add_check_for_isInConflictWithSeedNode 
Add check for dao state hash conflict with seed node
 2023-01-06 14:09:01 +00:00
HenrikJannsen
7977c8670a
Cleanup 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 22:25:31 -05:00
HenrikJannsen
8b0f8fbead
Cleanup 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 22:18:10 -05:00
HenrikJannsen
41a63cc8a5
Add handling of miner fee in case there is only the legacy BM 
Use spendableAmount instead of inputAmount at maxOutputAmount

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 22:04:23 -05:00
HenrikJannsen
bb06f64049
Add complete call 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 22:04:23 -05:00
HenrikJannsen
bc91914cb0
Change log level 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 14:48:51 -05:00
HenrikJannsen
093e8f99f4
Remove unused methods 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 11:41:11 -05:00
HenrikJannsen
13180ddc30
Improve DaoPresentation and add handler for daoStateHash updates 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 11:21:01 -05:00
HenrikJannsen
1e2f48b9bc
Rename isDaoStateIsInSync to isDaoStateReadyAndInSync 
Add daoStateService.isParseBlockChainComplete() check

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 10:42:59 -05:00
HenrikJannsen
b33c610015
Add CheckIfDaoStateIsInSync task in trade protocol as first task 
Add ifDaoStateIsInSync method to DaoFacade
Add ifDaoStateIsInSync to logs if DPT verification fails
 2023-01-05 10:39:24 -05:00
HenrikJannsen
be33aa5236
Add chain heights to logs 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 10:22:50 -05:00
HenrikJannsen
f4d335b624
Improve logs 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 10:18:42 -05:00
HenrikJannsen
02093b986b
Improve log 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 10:06:49 -05:00
HenrikJannsen
ea285e6ad1
Run processAccountingBlocks async in forkjoinpool thread 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-04 20:52:22 -05:00
HenrikJannsen
819c6fb200
Combine nested if statements 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-04 19:30:02 -05:00
HenrikJannsen
5542ea23ec
Add custom getGetDataResponsePriority methods 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-04 18:25:17 -05:00
HenrikJannsen
5efd13a678
Check if setException returns false and if so, cancel future. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-04 18:09:04 -05:00
Alejandro García
9d820ba83e
Merge pull request #6495 from HenrikJannsen/fix_BM_collection_at_DPT 
Fix bug with calculating the miner fee for the DPT.
 2023-01-03 23:38:30 +00:00
HenrikJannsen
56377d8930
Reduce DPT_MIN_REMAINDER_TO_LEGACY_BM from 50k sat to 25k sat. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-03 17:32:10 -05:00
HenrikJannsen
a296887a73
Use getActiveBurningManCandidates for fee distribution 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-03 12:08:12 -05:00
HenrikJannsen
0c4199fef4
Fix but with calculating the miner fee for the DPT. 
Add activation date for hotfix.

We used all potential BM instead only the ones who have a positive cappedBurnAmountShare.
 2023-01-03 12:07:38 -05:00
HenrikJannsen
8bde140e3d
Add all addresses of all burningman who have burned BSQ to the list of addresses who are permitted to receive trade fees. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-02 17:01:38 -05:00
Alejandro García
1d669240d8
Merge pull request #6425 from jmacxx/fix_bsq_fee_validation 
Validate BSQ fee payment using DAO tx info.
 2022-12-29 20:12:38 +00:00
jmacxx
fa6beffa49
Apply code review changes. 2022-12-29 13:57:13 -06:00
Alejandro García
eef7846394
Merge pull request #6487 from HenrikJannsen/reset_pending_trade_protocol_of_same_offer 
Reset pending trade protocol of same offer
 2022-12-29 15:02:36 +00:00
HenrikJannsen
42dc0b5b79
Merge branch 'add_higher_capacity_for_write_to_json_thread_pool' into seednodes 2022-12-28 12:11:05 -05:00
HenrikJannsen
5ff7be9208
Increase capacity for thread pool queue at ExportJsonFilesService 
One seed node using the ExportJsonFilesService had RejectedExecutionExceptions as before we had only permitted a thread pool queue capacity of 1.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-28 12:09:59 -05:00
HenrikJannsen
5b38e5b83b
Allow to set fullNode if isBmFullNode and rpcDataSet is true even if BurningManService.isActivated() is false. 
This allows us to run the seed nodes already in BM mode before activation

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 18:40:38 -05:00
HenrikJannsen
9a31606fea
Make codacy happy 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:11 -05:00
HenrikJannsen
e1d8d0a6a0
Make codacy happy 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:11 -05:00
HenrikJannsen
7f16e874d2
Improve shutdown at dao nodes 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:10 -05:00
HenrikJannsen
0b33a12c19
Change visibility, make isShutdownInProgress volatile 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:09 -05:00
HenrikJannsen
d5b4ce275b
Add support for listeners when GetDataResponse and GetBlocksResponse are sent. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:08 -05:00
HenrikJannsen
3f4a069202
Add reset method to trade protocol. 
Add map for maintaining pending protocols by offerID.

Fixes a bug when the same taker got an early failure in a take offer attempt before the maker removes the offer and the taker did not persist the failed trade, thus the protection to not be permitted to take the same offer after a failure does not prevent another take offer attempt of the same taker. In such a case the maker has the old pending protocol listening for the trade messages and both the old and new protocol instance process those messages. In case the model data has changes (e.g. diff. inputs) this can cause a failed trade.
We do not remove the message listeners on failures to tolerate minor failures which can be recovered by resend routines.
There could be more solid fixes for that issue but this approach seems to carry less risks.
 2022-12-26 14:07:14 -05:00
HenrikJannsen
72b55f429a
Move log before super handler to maintain correct order of logs 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-26 12:30:07 -05:00
HenrikJannsen
4fb0420712
Remove price node and seed nodes of @miker and @mrosseel 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-20 19:40:59 +01:00
Christoph Atteneder
d99452c978
Not use additional -%d in name format because of refactoring 2022-12-20 11:36:42 +01:00
jmacxx
9f8b3df1ac
Base initial limit from users max past trade size if applicable. 2022-12-19 16:49:39 +01:00
HenrikJannsen
8eb555df8f
Add INVALID_SNAPSHOT_HEIGHT to AvailabilityResult. 
Use AvailabilityResult.INVALID_SNAPSHOT_HEIGHT instead of AckMessage with error.
Show description in error popup instead of enum name.
Return PRICE_CHECK_FAILED instead of UNKNOWN_FAILURE at error at price check also for non api users.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:32:00 +01:00
HenrikJannsen
0b849800f9
Fix test 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:32:00 +01:00
HenrikJannsen
bd85958c9e
Add sanity check for a min. block height for the snapshot height 
We don't allow to get further back than 767950 (the block height from Dec. 18th 2022)

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:32:00 +01:00
HenrikJannsen
f834fbdda6
Add sanity check that max share of a non-legacy BM is 20% over MAX_BURN_SHARE (taking into account potential increase due adjustment) 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:59 +01:00
HenrikJannsen
618e610f3e
Exclude legacy BM from DAO balance 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:59 +01:00
HenrikJannsen
109c200650
Add balance fields for DAO revenue with total burned BSQ and total distributed BTC/BSQ 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:59 +01:00
HenrikJannsen
2be5d2fbd8
Increase GENESIS_OUTPUT_AMOUNT_FACTOR and ISSUANCE_BOOST_FACTOR 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:59 +01:00
HenrikJannsen
c268cc46cb
Add new average bsq price after historical data 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:58 +01:00
HenrikJannsen
a76267b6f3
Use static fields for opReturnData instead of hardcoded mainnet hashes 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:58 +01:00
HenrikJannsen
16bfdd6154
Remove regtest value for DEFAULT_ESTIMATED_BTC_TRADE_FEE_REVENUE_PER_CYCLE 
Adjust reimbursement amounts as we do not reimburse 100% of the DPT

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:57 +01:00
HenrikJannsen
80063d735c
Add custom handling of legacy BM. 
Refactoring: rename variables

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:57 +01:00
HenrikJannsen
1aa5a9b17a
Don't allow the myBurnAmount to be larger than the upperBaseTarget 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:56 +01:00
HenrikJannsen
7eed7a4cda
In case we have capped burn shares we redistribute the share from the over-burned amount to the non capped candidates. 
This helps to avoid that the legacy BM would get the rest in case there are capped shares.
It still can be that a candidate exceeds the cap and by the adjustment becomes capped. We take that into account and the legacy BM would get some share in that case.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:56 +01:00
HenrikJannsen
709f0e1b85
Change burn target calculation. 
Left side is amount to burn to reach the max allowed receiver share based on the burned amount of all BM.
The right side is the amount to burn to reach the max allowed receiver share based the boosted max burn target.

Increase ISSUANCE_BOOST_FACTOR from 3 to 4.

Add help overlay to burn target table header.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:56 +01:00
jmacxx
9ce2964ff4
Fix divide by zero errors in Trade history summary. 2022-12-19 09:28:42 +01:00
sqrrm
1cf51be56c
Update sqrrm provided btc onion addresses 2022-12-19 09:28:21 +01:00
HenrikJannsen
ddf5239800
Increase timeouts from 3 to 4 min. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:27:44 +01:00
HenrikJannsen
6aad3a8dc5
Reduce getDataResponse size from 9 MB to 6 MB 
Reduce number of blocks at GetBlocksResponse from 4000 to 3000

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:27:27 +01:00
Christoph Atteneder
afba2f22b9
Update bitcoinj checkpoints for v1.9.7 2022-12-14 11:12:49 +01:00
Christoph Atteneder
72dea08473
Update translations for v1.9.7 2022-12-14 10:39:28 +01:00
Christoph Atteneder
5dea677644
Merge pull request #6459 from HenrikJannsen/handle_exception_at_send 
Handle exception at send
 2022-12-14 10:20:07 +01:00
Christoph Atteneder
71d6e126dd
Merge pull request #6423 from HenrikJannsen/add-burningman-accounting 
Add burningman accounting
 2022-12-14 10:17:38 +01:00
HenrikJannsen
8c65da9c85
Add thread index format 
Add name param to newCachedThreadPool

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-13 20:35:49 -05:00
HenrikJannsen
d4b6965348
Use networkNode.sendMessage instead of connection.sendMessage as the call on connection is blocking. 
This was likely a major bug for seed nodes that at sending hash responses the main thread got blocked.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-13 16:25:39 -05:00
HenrikJannsen
1b10cc22db
Refactor: Move monitor package from core to seedNode and rename to reporting 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 17:10:02 -05:00
HenrikJannsen
21c6c52ec8
Make fields final. 
Remove setter of key.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 17:02:30 -05:00
Alejandro García
4f34be0a33
Merge pull request #6452 from ripcurlx/update-app-signatures 
Update app signatures for v1.9.7
 2022-12-11 18:36:00 +02:00
Alejandro García
77afb2d62c
Merge pull request #6450 from jmacxx/dispute_min_payout 
Change minimum payout at mediation from 2.5% to 5% of trade amount.
 2022-12-11 18:26:56 +02:00
HenrikJannsen
e57af6e8e8
Update mediation popup text 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:19 -05:00
HenrikJannsen
b7d5af18b0
Add MAX_BURN_TARGET_LOWER_FLOOR to avoid cases where small burn amounts lead to deadlock situations. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:19 -05:00
HenrikJannsen
46b2cf914b
Remove DevEnv.isDevTesting 
Add check for number of confirmations in devMode to show support button after 5 blocks

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:19 -05:00
HenrikJannsen
e3a0ae9425
Use constants for opReturn data. Rename hash to opReturnData. 
Update UI.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:18 -05:00
HenrikJannsen
1bb4b55220
Add BurningManAccountingStore resource file. 
Use resourceDataStoreService and extend StoreService

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:18 -05:00
HenrikJannsen
446762f02c
Add BM account UI 2022-12-11 11:15:17 -05:00
HenrikJannsen
a9bf52d26c
Add BurningMan accounting domain 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:17 -05:00
HenrikJannsen
22c43769bd
Add BurningManAccountingService to CorePersistedDataHost 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:17 -05:00
HenrikJannsen
90550dee3f
Add messages and domain data for accounting domain 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:17 -05:00
HenrikJannsen
d4a0032965
Add new fields and methods 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:17 -05:00
HenrikJannsen
f9db6e0d5c
Add support for multiple clients adding a block handler. 
Add requestRawDtoBlock method.
Rename to make different block types more clear.
Change visibility
 2022-12-11 11:15:17 -05:00
HenrikJannsen
a551a41e5a
Add support for multiple clients calling the setup method. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:17 -05:00
HenrikJannsen
e2f7c4e103
Make AveragePriceUtil.getAveragePriceTuple mor flexible 
Add filter for before date

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:16 -05:00
HenrikJannsen
bc9ccfd0e9
Add String formatCoin(long value) API to CoinFormatter 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:16 -05:00
HenrikJannsen
2615309931
Add Config options 2022-12-11 11:15:16 -05:00
HenrikJannsen
adb02428ee
Remove unused var 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:16 -05:00
HenrikJannsen
d12c8b5fc4
Remove TODO, rename method 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:16 -05:00
HenrikJannsen
97ba1560be
Improve receiver distribution to avoid that legacy BM gets outputs if some outputs fall below the min. amount limit. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:16 -05:00
HenrikJannsen
fa4c952409
Apply code review feedback 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
eeaafc1e04
Use HashSet instead Lists. 
Remove sorting as not needed.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
7cbc5d6263
Increase ISSUANCE_BOOST_FACTOR to 3 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
4ce6ce745a
Add check for isActivated and if not return LEGACY_BURNING_MAN_BTC_FEES_ADDRESS 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
4e08bcd53d
Split up legacy BM into DPT and BTC fee BM 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
d30ec07d94
Cleanup/add comments 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
8ab2582db6
Use check for isRegtest instead of test for isDevTesting to set dev parameters 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
0e79582819
Refactoring: Move isActivated method to BurningManService 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:14 -05:00
HenrikJannsen
dff6d48333
Refactoring: Move BM model classes into model package. Adjust visibility. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:14 -05:00
HenrikJannsen
c1dc317783
Remove unused methods 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:14 -05:00
HenrikJannsen
d31493b1e9
Use TradeWalletService.MIN_DELAYED_PAYOUT_TX_FEE as min value for miner fee in DelayedPayoutTxReceiverService.getSpendableAmount 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:14 -05:00
HenrikJannsen
d4646cc19f
Add LegacyBurningMan to UI 
It is not included in BurningManCandidate candidate map as that would complicate things.
We only want to show it in the UI for informational purposes.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:14 -05:00
HenrikJannsen
883b0542a1
Fix getSnapshotHeight method 
For chainHeights < genesisHeight+3*grid we ended up with future chainHeights

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:14 -05:00
HenrikJannsen
2b4b6fe715
Add logs for delayedPayoutTx receiver data 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
b7a5b569ca
Add legacy burningman to btc fee distribution in case we do not reach 100% from capped burn shares. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
c1b8871fda
Fix burn target calculations 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
3a7af07e86
Improve burn target calculation and display 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
c747a486a7
Fix duration calculations 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
3213c5e770
Avoid negative cycle index 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
683bc409c7
Use cycles for periods instead of blocks in months/years. 
A cycle is the fundamental unit in the DAO, months/years have no relevance, so using
cycles as base helps avoids some potential weird behaviour with data getting updated at cycle events.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
2799ccabad
Add util class for cycle related methods with caching 
Add getCycleAtIndex convenience method to DaoStateService

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:12 -05:00
HenrikJannsen
516004dfaf
Change ISSUANCE_BOOST_FACTOR to 3 
Use lower dev test value for BURN_TARGET_BOOST_AMOUNT

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:12 -05:00
HenrikJannsen
1e8ec6f206
Add details if donationAddressOfDelayedPayoutTx check fails 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:12 -05:00
HenrikJannsen
625939b0f9
Bugfix: set burningManSelectionHeight and tradeTxFee at dispute clone 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:12 -05:00
HenrikJannsen
a6a018883d
Add isDevTesting method for adjusting behaviour for dev testing purposes 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:12 -05:00
HenrikJannsen
4e25d2f253
Add isDevMode check to set dev params 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:12 -05:00
HenrikJannsen
402c4075d0
Add option to add opReturn data at BSQ wallet send screen for non-BSQ balance. 
This can be used for providing proof of ownership of a genesis output when attaching a custom BM receiver address.
See: https://github.com/bisq-network/proposals/issues/390#issuecomment-1306075295

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:11 -05:00
HenrikJannsen
78d3fd8d44
Fix wrong initial value. 
For myGenesisOutputNames we check for null not Optional.empty as empty is a valid case and we do not
want to wrap the optional field into another Optional.
Also myCompensationRequestNames is using a null check and gets reset to null instead of an
empty set as the empty set is a valid case as well.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:11 -05:00
HenrikJannsen
88cf28c526
Add applyBlock method and call at constructor (some classes get not initiated at app startup but created by UI activity). 
Remove accumulatedDecayedBurnAmount at getAllowedBurnAmount. Was incorrect.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:11 -05:00
HenrikJannsen
fb51861c4b
Use months and not cycles for burn target and average. 
Add checks for chainHeight to make code more generic (in the current usage its always last block anyway)

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:11 -05:00
HenrikJannsen
befe166bc7
Refactor out fields from BurningManCandidate which are not affecting data for delayed payout tx receivers. 
This allows to split off the burn target related code to separate classes.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:11 -05:00
HenrikJannsen
52d48eb90a
Rename getDelayedPayoutTxReceivers to getReceivers 
Cleanup

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
f0faa44804
Remove Current from method names 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
7724b5b3ea
Rename getBtcFeeReceiverAddress to getAddress 
Cleanup

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
92b38ed20f
Move BurningManUtil.getLegacyBurningManAddress to BurningManService. 
Remove BurningManUtil

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
508081ad16
Rearrange methods 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
ec25722d08
Split up calculateShare into 4 distinct methods 
Reduce visibility to package scope

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
3fda949526
Add sorting for output index needed for genesis tx outputs. 
Use static factory methods for the 2 diff. use cases of CompensationModel.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
22f7b089f4
Remove reference to delayedPayoutTxReceiverService and btcFeeReceiverService inside BurningManService. 
Use DelayedPayoutTxReceiverService and BtcFeeReceiverService in client code instead of BurningManService.
Make BurningManService package private.
 2022-12-11 11:15:09 -05:00
HenrikJannsen
40a03ebdc5
Move getAverageDistributionPerCycle to BurningManService and use from BurningManInfoService. 
Remove reference to BurningManInfoService inside BurningManService.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:09 -05:00
HenrikJannsen
559ba6e9b9
Refactor BurningManService 
Split up into 4 service classes
- BurningManService: Common stuff
- BurningManInfoService: For displaying BurningMan data
- BtcFeeReceiverService: For getting btcFeeReceivers
- DelayedPayoutTxReceiverService: For getting delayedPayoutTxReceivers. This is the critical part where we need to have a deterministic data and which could break trade consensus.

WIP refactoring. More to come...

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:09 -05:00
HenrikJannsen
19067acbcd
Cleanup 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:09 -05:00
HenrikJannsen
7407ab87f9
Subtract accumulatedDecayedBurnAmount from allowedBurnAmount 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:09 -05:00
HenrikJannsen
58cabfaaf6
Add expectedRevenue to BurningManCandidate. 
Add getAverageDistributionPerCycle method to BurningManService.
Show receiver address when BM is selected.
Refactor code, cleanups, UI improvements.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:09 -05:00
HenrikJannsen
731363d128
Sort getBtcFeeReceiverAddress by amount and address. 
Increase minOutputAmount to 1000 sat.
Cleanups

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:08 -05:00
HenrikJannsen
02a163f2f1
Fix handling of null entries in getBtcFeeReceiverAddress method 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:08 -05:00
HenrikJannsen
e16a9b00b1
Add verifyDelayedPayoutTxReceivers method in RefundManager. 
Add burningManSelectionHeight and tradeTxFee in Dispute.
Call validateDonationAddressMatchesAnyPastParamValues and validateDonationAddress
only if legacy BM was used.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:08 -05:00
HenrikJannsen
060b9c476e
Validate delayedPayoutTx outputs size and amount only if BurningManService.isActivated is false. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:08 -05:00
HenrikJannsen
7b280c4a99
Use Burningmen receivers for delayed payout tx. 
Add verification by re-creating receivers and check txId of both DPTs.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:08 -05:00
HenrikJannsen
eee0b691d0
Remove FeeReceiverSelector and test as not used anymore 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:08 -05:00
HenrikJannsen
e2ce053a01
Add burningManSelectionHeight fields to OfferAvailabilityRequest, InputsForDepositTxRequest and ProcessModel. 
Use BurningManService.getBtcFeeReceiverAddress at createFeeTx tasks.
Verify takers burningManSelectionHeight if BurningManService.isActivated at MakerProcessesInputsForDepositTxRequest and OpenOfferManager.
Stores burningManSelectionHeight in ProcessModel.
Add BurningManService fields to OfferAvailabilityModel, PlaceOfferModel, OpenOfferManager and Provider

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:07 -05:00
HenrikJannsen
39a49adb92
Add Burningman UI 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:07 -05:00
HenrikJannsen
739ff8e447
Add BurningMan domain 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:07 -05:00
HenrikJannsen
ea5662f84d
Add new methods to DaoStateService and DaoFacade. 
Will be used later by BurningMan domain.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:07 -05:00
HenrikJannsen
5c7a3308a7
Add burningManReceiverAddress as extraMap entry to CompensationProposal. 
We cannot add a new field as that would break DAO consensus.

Add optional text field for burningManReceiverAddress to CompensationProposal UI.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:07 -05:00
HenrikJannsen
09a1af8f2c
Add allowEmpty flag to InputValidator and BtcAddressValidator 
We will use that for the optional address field in compensation requests and interpret empty input as Optional.empty.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:06 -05:00
Alejandro García
6c7764fc33
Merge pull request #6451 from HenrikJannsen/avoid_sending_repeated_block_related_report_data 
Avoid sending repeated block related report data
 2022-12-11 17:38:00 +02:00
Stephan Oeste
9e50066567
Remove KanoczTomas Bitcoin node, because it is permanet offline. 2022-12-11 15:28:32 +01:00
HenrikJannsen
491c6a0861
Add onDaoStateBlockCreated method 
Use onDaoStateBlockCreated instead of onDaoStateHashesChanged to avoid multiple calls when we receive hashes from other nodes.
Add daoStateMonitoringService listener after blockchain parsing is completed

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-10 19:19:29 -05:00
jmacxx
e2a23ee196
Change minimum payout at mediation from 2.5% to 5% of trade amount. 
Implements bisq-network/proposals#397
 2022-12-10 10:37:52 -06:00
Alejandro García
2d607cd092
Merge pull request #6433 from jmacxx/user_trade_limits 
User defined trade limit, Part II.
 2022-12-09 19:46:34 +02:00
HenrikJannsen
f98cd04fd8
Use LongValueItem instead of IntegerValueItem 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-09 08:54:28 -05:00
jmacxx
6f8bb00704
Apply code review suggestions. 2022-12-08 08:16:11 -06:00
HenrikJannsen
f4775f89b0
Add SeedNodeReportingService 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-07 13:23:28 -05:00
HenrikJannsen
3a4ed1fc01
Add seedNodeReportingServerUrl option 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-07 11:51:49 -05:00
HenrikJannsen
2c84f07ada
Add value objects and protobuf definitions 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-07 11:51:08 -05:00
HenrikJannsen
3caf2c2b64
Change visibility (will be used from monitor project). 
Remove log, change log level.
Add getters

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-07 11:50:24 -05:00
HenrikJannsen
a925017e4b
Rename readCommitHash to findCommitHash, make it static and return optional. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-07 11:03:08 -05:00
jmacxx
09a7a09ec3
Fix FileTransferSession tests. 2022-12-06 20:33:48 -06:00
jmacxx
bddbe6b7ae
Feature to zip logfiles to home directory. 2022-12-05 09:14:12 -06:00
Christoph Atteneder
5dc006ec9b
Merge pull request #6435 from jmacxx/add_shutdown_guard 
Prompt to confirm before shutting down.
 2022-12-05 10:45:02 +01:00
jmacxx
75f224c67c
Check filterWarningHandler is set before use. 2022-12-04 21:10:06 -06:00
jmacxx
0e3314ce14
Prompt to confirm before shutting down. Has dont show again option. 2022-12-02 15:35:27 -06:00
Christoph Atteneder
4069e60f8c
Update app signatures 2022-12-01 12:21:46 +01:00
Christoph Atteneder
16166c42a7
Merge pull request #6429 from HenrikJannsen/handle-rpc-errors-gracefully 
Handle HttpExceptions at block handler
 2022-12-01 09:50:54 +01:00
jmacxx
7ec86c3dc3
User defined trade limit. 
Some commits were missed from the first implementation in #6431.
The user limit is applied to offer entry via AccountAgeWitnessService.
Offers are filtered according to limits in OfferFilterService.
If limit changed, the cache in OfferFilterServices must be cleared.
 2022-11-29 22:41:34 -06:00
jmacxx
1df3046371
Validate BSQ fee payment using DAO tx info. 
Previously the BSQ fee payment was determined by parsing a raw tx
without relying on the DAO.  Unfortunately this turned out to be
problematic, so with this change the BSQ fee paid is obtained from
the DAO tx, as originally preferred by chimp1984.

Unconfirmed transactions will not be able to have their BSQ fees
checked so early requests for validation will skip the fee check.
This is not a problem since maker fee validation is done by the
taker and in the majority of cases will be already confirmed; taker
fee validation is done after the first confirm at trade step 2.
 2022-11-29 18:16:21 -06:00
jmacxx
c796531658
Increase trading limits as an opt-in setting (GH proposal 398) 
More restrictive limits will still apply based on payment method.

It is intended to avoid that a new users who do not fully understand
the process of a Bisq trade to cause an arbitration case with high
amounts and therefore higher risks and costs for the DAO.
 2022-11-29 09:32:38 -06:00
Alejandro García
8d2f0a5d12
Merge pull request #6383 from Android-X13/option_for_qr_codes 
Include option for non-URI addresses in QR codes
 2022-11-29 14:42:05 +02:00
Alejandro García
e054083c1f
Merge pull request #6376 from jmacxx/fix_issue_6367 
Fix loss of mailbox messages during SPV resync
 2022-11-29 14:41:27 +02:00
HenrikJannsen
0b07c104a7
Use recovery for all RPC HttpExceptions exceptions in generic error handler. 
It seems that a reorgs or if a new block arrives quickly after another, that bitcoind is not ready
for a request and throws an RPC error, also the blockhandler throws that if the new block came too fast.
We try to request again with increasing delays up to 1 min. If after 10 attempts its still failing we
do a reorg and start parting again.
 2022-11-27 17:42:53 -05:00
HenrikJannsen
a0900a0f1b
Handle HttpExceptions at block handler 2022-11-27 17:41:21 -05:00
sqrrm
b10881ff7f
Merge pull request #6418 from HenrikJannsen/improve-dao-node-domain 
Improve dao node domain
 2022-11-26 16:19:52 +01:00
jmacxx
8a94642e1a
Do not erase mailbox messages during SPV resync. 2022-11-25 21:13:09 -06:00
Alejandro García
92e4c62287
Merge pull request #6422 from jmacxx/fix_trade_timer_issue 
Fix:  incorrect wallet tx handling
 2022-11-26 03:02:05 +02:00
Alejandro García
80a927afb9
Merge pull request #6404 from HenrikJannsen/improve-dispute-validation 
Improve dispute validation
 2022-11-25 17:37:44 +02:00
Alejandro García
a6293a64cb
Merge pull request #6396 from jmacxx/show_commit_hash 
Store the build's commit hash in Jarfile manifest
 2022-11-25 17:36:34 +02:00
Android-X13
d77b76034d
Include option for non-URI addresses in QR codes 2022-11-22 23:11:45 +02:00
jmacxx
24ae5f6220
Make sure the actual wallet transaction is returned. 
There was an issue with the transaction having a non-initialized
updateTime and/or blockTime because the wallet transaction was
not returned.
 2022-11-21 09:39:21 -06:00
HenrikJannsen
671ab1f373
Cleanup 
Improve toString methods

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-17 19:55:04 -05:00
HenrikJannsen
0f14ea29c9
Improve handling of case when Bitcoin Core sync is not completed. 
We repeat with a quadratically increasing delay 5 times, then we give up.
In the previous code we repeated forever which could be risky in case that
code branch is called unexpectedly.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-17 19:51:15 -05:00
HenrikJannsen
811ae52f27
Fix bug with using getPreviousBlockHash instead of getHash 
It had no consequences as it was only used for info logging

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-17 19:46:38 -05:00
HenrikJannsen
1e72e265f7
Cleanup comments 
Improve toString methods
Rename var for more clear meaning

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-17 19:44:58 -05:00
HenrikJannsen
de654c15b3
Improve handling of ConnectionState.expectedInitialDataResponses 
Rename to expectedInitialDataResponses as we compare with numInitialDataResponses.
Add comment to make it more clear how its used.
Let the LiteNode increment only if getBlocks get called (e.g. blocks are missing).

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-17 19:41:32 -05:00
Bisq GitHub Admin
60522218a7
Merge pull request #6412 from bisq-network/release/v1.9.6 
Merge release branch
 2022-11-15 21:03:40 +01:00
sqrrm
3dd9b0e575
Merge pull request #6403 from HenrikJannsen/disable-deactivation-of-dao 
Require the DAO is enabled for traders
 2022-11-04 11:44:26 +01:00
HenrikJannsen
81be778df3
Remove deposit tx output size check. 
It is allowed that there are change outputs, for instance if taker
does not take full trade amount, there is a change output for maker.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 14:14:32 -05:00
HenrikJannsen
e653262751
Fix param in test 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 12:26:59 -05:00
HenrikJannsen
cba35b6342
Remove deposit tx output size check. 
It is allowed that there are change outputs, for instance if taker
does not take full trade amount, there is a change output for maker.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 12:21:47 -05:00
HenrikJannsen
8d8cdc14b4
Cleanup 2022-11-03 12:12:02 -05:00
HenrikJannsen
b5df4afd40
Remove DevEnv.isDaoActivated method as not used anymore 
Remove daoActivatedToggleButton from PreferencesView and NewsView

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 11:16:10 -05:00
HenrikJannsen
e8a9132d30
Remove if blocks with !DevEnv.isDaoActivated() and combined && as isDaoActivated is always true the whole statement is always false 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 11:00:23 -05:00
HenrikJannsen
80e7dc7203
Remove tertiary operator DevEnv.isDaoActivated() ? as isDaoActivated is always true 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 11:00:22 -05:00
HenrikJannsen
72d97b8d97
Remove if (DevEnv.isDaoActivated()) checks as isDaoActivated is always true 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 10:51:01 -05:00
HenrikJannsen
008cfaac57
Remove daoActivated options 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 10:46:26 -05:00
HenrikJannsen
14312f08af
Add validateDisputeData, validateTradeAndDispute and validateSenderNodeAddress methods 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 23:59:12 -05:00
HenrikJannsen
04e501d450
We had not updated the contract hash after setting the signature. 
We verify later the contract hash in disputes and that would fail otherwise.
 2022-11-02 23:56:25 -05:00
HenrikJannsen
c49b811da3
Add verification of chain of transactions at DisputeSummaryWindow 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 23:24:05 -05:00
HenrikJannsen
60cd8b1e16
Add requestBlockchainTransactions and verifyTradeTxChain methods to RefundManager 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 23:15:41 -05:00
HenrikJannsen
0553a0f9d4
Add cachedDepositTx field to Dispute 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 23:15:11 -05:00
HenrikJannsen
0388c7c88a
Add block explorer tx as hex request using completeable future api 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 23:03:55 -05:00
HenrikJannsen
7f5675f054
Remove if case for old clients 
Remove null check for dispute

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:51:39 -05:00
HenrikJannsen
97648c51f3
Rename to make use case more clear 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:49:57 -05:00
HenrikJannsen
0bf44f061d
Remove addressAsString null check. That was when the donationAddress got added to support not updated nodes. Now there are none of such nodes. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:48:55 -05:00
HenrikJannsen
710dba9f36
Remove validateDonationAddress method without dispute param 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:47:39 -05:00
HenrikJannsen
5daaa60779
Refactor validateDonationAddress 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:44:58 -05:00
HenrikJannsen
3007652f4a
Remove dispute field from TradeDataValidation.ValidationException 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:41:46 -05:00
HenrikJannsen
cfb3780e6b
Move null check for address to validateDonationAddress method 
Remove dispute as unused param
Remove redundant methods

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:39:56 -05:00
HenrikJannsen
e8c6b0ae14
Remove daoFacade as unused parameter 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:32:28 -05:00
HenrikJannsen
cfc67dcc9c
Move validateDonationAddress to DisputeValidation 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:29:59 -05:00
HenrikJannsen
d86071db4a
Remove validateDonationAddress call inside validateDelayedPayoutTx. 
Add call to validateDonationAddress at client calling validateDelayedPayoutTx

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:28:41 -05:00
HenrikJannsen
2484fa4371
Part of a multistep refactoring to separate dispute related validation out of TradeDataValidation 
Refactor donationAddress validation out to new method
Rename addressAsString to delayedPayoutTxOutputAddressAsString
Recreate delayedPayoutTxOutputAddress at new validateDonationAddress method from relevant data

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:25:11 -05:00
HenrikJannsen
e49e634956
Move testIfAnyDisputeTriedReplay and related methods to DisputeValidation 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:14:55 -05:00
HenrikJannsen
37457ed132
Move validateDonationAddress to DisputeValidation 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:12:55 -05:00
HenrikJannsen
12686deff6
Move validateNodeAddress to DisputeValidation 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:11:23 -05:00
HenrikJannsen
aa22bd366a
Add DisputeValidation class for validation methods and exceptions of the dispute domain. 
Move AddressException, NodeAddressException and DisputeReplayException to DisputeValidation.
Use DisputeValidation.ValidationException as type for DisputeManager.validationExceptions.
Remove Nullable annotation for dispute field in those exceptions.
Remove null checks when those DisputeValidation.ValidationException are used.
 2022-11-02 22:09:30 -05:00
HenrikJannsen
43fb0cc635
Reformat code and reorg imports 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 21:22:35 -05:00
jmacxx
797bfe5cd5
Store the build's commit hash in Jarfile manifest. 2022-10-29 22:12:31 -05:00
Christoph Atteneder
80246e5d66
Update data stores for v1.9.6 2022-10-20 12:19:30 +02:00
Christoph Atteneder
6831f72a03
Update translations for v1.9.6 2022-10-13 09:53:23 +02:00
jmacxx
b35e316cdc
Warn at shutdown if Dispute message is pending. 2022-10-11 17:54:07 -05:00
jmacxx
b5dc6a4e45
Misc burn chart series CSS color settings and tooltip description. 2022-10-05 07:11:40 -05:00
jmacxx
8b92b2cdf5
UI Changes for BSQ Supply screen. 
Adds ability to track Misc Burnt amounts (incl. voting, asset listing etc)
Corrects the descriptions for Total BSQ and Change in supply.
 2022-10-05 07:11:36 -05:00
Christoph Atteneder
75e030f541
Merge pull request #6362 from jmacxx/dispute_min_payout 
Set the minimum payout at mediation to be 2.5% of trade amount
 2022-10-04 09:12:38 +02:00
Stephan Oeste
46139cf6b0
Remove c4talys7 seednodes and readd wiz seednodes 2022-09-28 15:16:25 +02:00
Android-X13
ee2db16451
Fix issue with offers getting disabled for no apparent reason 2022-09-20 20:55:19 +03:00
jmacxx
11e4469b0e
Set the minimum payout at mediation to be 2.5% of trade amount. 
If 2.5% is less than 0.0005 BTC, then fall back to 0.0005 BTC.
 2022-09-18 21:51:24 -05:00
ghubstan
a33a6e936b
Fix BSQ buyer's displayed trade fee for gettrade(s) methods 
API clients looking at their BSQ swap trades -- BSQ buyers
specifically -- were seeing a 0.00 BSQ trade fee, due to an
incorrect assumption BSQ sellers paid the entire BSQ trade
fee for both sides.  BSQ Swap execution via API has been
working just like the GUI (same code-base), but the reported
trade fee for the BSQ buy side was wrong.
This change shows the correct BSQ trade fee.

Partially addresses issue https://github.com/bisq-network/bisq/issues/6355
 2022-09-11 16:06:59 -03:00
ghubstan
d32fd4e97b
Improve CLI takeoffer man-page param descriptions 2022-09-11 12:26:00 -03:00
Christoph Atteneder
4a359997ff
Merge pull request #6333 from ripcurlx/update-data-stores-for-v1.9.5 
Update data stores for v1.9.5
 2022-08-22 17:57:04 +02:00
jmacxx
4e8e6eb9ac
Use getCurrencyCode method rather than directly accessing member. 
The transient currencyCode member is null until the getter method
has been used, so we should no access the variable directly.

This fixes a problem with OfferBook filtering, which was checking
for isFiat(currencyCode); the variable was null and isFiat returned
the wrong answer.
 2022-08-22 15:53:47 +02:00
Stephan Oeste
dd66520a24
Remove sn2bisqad7... Seeednode 2022-08-22 15:53:21 +02:00
Christoph Atteneder
827ddb071f
Update bitcoinj checkpoints for v1.9.5 2022-08-22 11:46:26 +02:00
Christoph Atteneder
cc11c28ffe
Update translations for v1.9.5 2022-08-21 21:34:06 +02:00
Christoph Atteneder
d2c7824740
Merge pull request #6315 from wiz/wiz/remove-wiz-seed-nodes 
Remove 3 wiz seed nodes
 2022-08-19 12:42:44 +02:00
Stephan Oeste
e878aec78c
Add new Seednodes from jmacxx and c4talys7 2022-08-19 11:48:23 +02:00
jmacxx
8e21682e92
Add P2P network status indicator. 2022-08-18 10:46:39 -05:00
wiz
f193b4a4c5
Remove 3 wiz seed nodes 2022-08-09 18:07:08 +09:00
Christoph Atteneder
423d57ae24
Merge pull request #6312 from ghubstan/support-choosing-trade-amount-in-range 
API takeoffer:  Let user choose intended trade amount
 2022-08-07 21:36:41 +02:00
ghubstan
c57b573d5c
Document TakeOfferRequest's intended trade amt param 2022-08-06 15:09:00 -03:00
ghubstan
7d4e7dd696
Support TakeOfferRequest's intended trade amt in daemon 2022-08-06 15:08:30 -03:00
chimp1984
6aa91a4ee4
Add check for date 2022-08-01 17:07:17 +02:00
chimp1984
aebabcb53e
Add api for account age and signed account age witness 2022-08-01 00:34:06 +02:00
chimp1984
ef81bde7f2
Add export feature for signed account age witness 2022-07-31 14:40:18 +02:00
chimp1984
2b6dd187c6
Add export feature for account age 2022-07-25 20:50:43 +02:00
chimp1984
2628eea9db
Add bsq bonds 2022-07-25 00:12:13 +02:00
Christoph Atteneder
ec00c9962f
Merge pull request #6282 from jmacxx/adjust_blocks_response_size 
GetBlocksResponse lower chunk size (was 6000 now 4000).
 2022-07-13 12:33:00 +02:00
Christoph Atteneder
f0db45255a
Merge pull request #6283 from jmacxx/clear_sensitive_data_2 
Clear sensitive data from trade ProcessModel
 2022-07-12 09:55:22 +02:00
Bisq GitHub Admin
fa635bd304
Merge pull request #6286 from bisq-network/release/v1.9.4 
Release v1.9.4
 2022-07-12 09:20:32 +02:00
jmacxx
aacabb9685
Clear sensitive data from trade ProcessModel. 2022-07-06 13:24:26 -05:00
jmacxx
12d3256f20
GetBlocksResponse lower chunk size (was 6000 now 4000). 
We lower the number of blocks delivered in a message to avoid
exceeding the max network message size.
 2022-07-06 08:17:05 -05:00
Christoph Atteneder
9011ebbd3f
Fix incorrect version number for new feature popup 2022-07-05 10:57:45 +02:00
Christoph Atteneder
bca997a55b
Merge pull request #6219 from ghubstan/wip-prep-bisq-for-bitcoin-v23 
Prepare Bisq for bitcoin-core v23 compatiblity
 2022-07-05 09:05:08 +02:00
chimp1984
b515ec7342
Update text and default series 2022-06-30 20:20:02 +02:00
chimp1984
70e2f7c53b
Add supply change series. 
Remove BsqSupplyChange. Use existing methods for supply calculation
(existing method was incorrect as far I understand).
 2022-06-30 20:19:52 +02:00
chimp1984
e08f7b6c09
Add new series. Regroup series. Add tooltips. 2022-06-30 20:19:38 +02:00
jmacxx
a5ba349574
Clear Tor directory when a new release is downloaded. 2022-06-30 20:19:25 +02:00
Christoph Atteneder
9b2c4807bf
Merge pull request #6274 from chimp1984/improve-dao-chats-legends 
Improve dao chats legends
 2022-06-30 20:17:04 +02:00
jmacxx
e1bc92eee5
Clear Tor directory when a new release is downloaded. 2022-06-30 07:04:17 -05:00
chimp1984
09cf4c8a73
Update text and default series 2022-06-29 19:01:20 +02:00
chimp1984
c91ba4a8e0
Add supply change series. 
Remove BsqSupplyChange. Use existing methods for supply calculation
(existing method was incorrect as far I understand).
 2022-06-29 18:50:43 +02:00
chimp1984
42d3df04f7
Add new series. Regroup series. Add tooltips. 2022-06-29 17:24:25 +02:00
Christoph Atteneder
8850436023
Merge pull request #6267 from ripcurlx/datastore-updates-for-v1.9.3 
Data store updates for v1.9.3
 2022-06-29 09:23:59 +02:00
jmacxx
5e59eae17e
Correct wording of altcoin payto address label. 2022-06-28 11:04:36 +02:00
jmacxx
484c4b5f50
Correct wording of altcoin payto address label. 2022-06-27 22:00:16 -05:00
Christoph Atteneder
15a79f27d3
Update bitcoinj checkpoints for v1.9.3 2022-06-23 10:54:43 +02:00
Christoph Atteneder
59d598da52
Update translations for v1.9.3 2022-06-23 09:44:57 +02:00
Christoph Atteneder
444f2183e5
Merge pull request #6236 from jmacxx/xmr_subaddresses 
Feat: XMR subaddresses per account
 2022-06-20 20:40:20 +02:00
ghubstan
2893ec2564
Block API attempt swap BSQ if !sufficient funds 
This API bug was relying on the UI purposed TaskRunner to bubble up an
insufficient funds error to the client, but it cannot do that.
This change blocks the takeoffer attempt if sufficient funds are not
found after the swap model calculates the taker's trade amounts.

Related: https://github.com/bisq-network/bisq/pull/6221
Based on https://github.com/bisq-network/bisq/pull/6250.
Based on branch `add-api-price-service-getaverageprice`.
 2022-06-20 12:00:39 -03:00
ghubstan
2c043b4b21
Minor refactoring 2022-06-18 11:24:39 -03:00
ghubstan
a12dd52b81
Add API method 'getavgbsqprice' 
Returns volume weighted average BSQ price in BTC and USD over N days.

The need for this arose while creating a Java BSQ Swap bot example
(PR pending).  API bots can use this to determine whether or not to
take swap offers based on their price distance above or below the 30
(or 90) day trade price average.
 2022-06-17 18:26:10 -03:00
ghubstan
ae41e98db9
Add API API method 'getnetwork' 
Returns name of the BTC network API daemon is connected to.

I am working on some Java bot examples in another repo, and want to stop
worrying about accidentally simulating trade payments on mainnet, despite
all the warnings I add in comments.  The 'getnetwork' method allows bots
to know what network the API daemon is connected to, and gives API bot
devs and users a way to avoid one potential source of costly mistakes.

API CLI manpage and apitest case are included in this commit.
 2022-06-16 15:31:03 -03:00
jmacxx
97ab98a0cf
Remove rules/penalties popup and other unused text resource. 2022-06-14 13:28:35 -05:00
jmacxx
920e05562c
Feat: XMR subaddresses per account 
incremente subaddress index at the start of the trade

Add subaccounts

Rename XmrAccountHelper to XmrAccountDelegate
Add map as final non null value

Persist subaccounts in User

Add display of used subaddresses and tradeId in account summary.
Main address and account index are the unique key for sub accounts.
Use the initial subaddress chosen by the user.

chimp1984 code review patch.

News badge/info for Account, disable old ones.

Show XMR subaddress popup info at Account (news badge), not startup.
 2022-06-14 09:53:44 -05:00
ghubstan
0fc22c02f4
Make API getoffers (altcoin) offer list order match UI 
This change reverses the server-side sorting of returned altcoin
offer lists, to match the UI altcoin offer-book views' price ordering.
 2022-06-14 11:42:55 -03:00
ghubstan
57509890f2
Throw client-friendly EX for payment sent/rcvd msgs 
Don't depend on silent, UI purposed task runner errors if confirmpaymentstarted
or confirmpaymentreceived msgs are sent outside the proper context.
Throw a FailedPreconditionException instead, and it will be translated
into the proper gPRC StatusRuntimeException before being sent to client.

For BTC buyers and sellers, block the messaging attempt if the taker
deposit tx has not been confirmed.

For BTC sellers, block an attempt to send a confirmpaymentreceived message
until after receiving a confirmpaymentstarted message has been sent from
the buyer.
 2022-06-13 21:16:14 -03:00
Christoph Atteneder
6fdd47917f
Merge pull request #6241 from jmacxx/buyer_start_payment_gui 
Start payment screen reftext message & sizing fixes.
 2022-06-09 10:08:52 +02:00
jmacxx
5bf2a78844
Start payment screen reftext message & sizing fixes. 2022-06-07 22:08:57 -05:00
jmacxx
82550314b4
Prevent account creation for banned Revolut GBP sort code 040075. 2022-06-04 10:47:27 -05:00
Christoph Atteneder
a62655c15d
Merge pull request #6217 from chimp1984/improve-xmr-proof-service 
Improve xmr proof service
 2022-06-01 09:16:48 +02:00
chimp1984
89293f1bbf
Use https://www.getmonero.org instead of https://web.getmonero.org 2022-05-31 12:28:59 +02:00
chimp1984
6c2b3629d4
Change link 2022-05-27 15:35:40 +02:00
chimp1984
259b799ae6
Move Monero related classes to xmr package 2022-05-26 23:42:30 +02:00
chimp1984
69b1a0027b
Compare canonicalTxKey with strict case check 
Cleanups
 2022-05-26 23:40:46 +02:00
chimp1984
7127bd5223
Add methods to ExcludesDelegateMethods 2022-05-26 23:35:13 +02:00
chimp1984
d2557181d0
Add popup and info about using dedicated wallets when changing Bisq data dir 2022-05-26 23:31:30 +02:00
chimp1984
7fe93d9be7
Add littleEndian conversions 2022-05-26 12:36:59 +02:00
chimp1984
ed4eaafcdf
Add toCanonicalTxKey method (not correct still) 2022-05-26 12:17:51 +02:00
chimp1984
5194aff311
Extract test 2022-05-26 11:57:17 +02:00
chimp1984
08a76229c1
Add knaccc package and dependent other packages 2022-05-26 11:46:32 +02:00
ghubstan
c9f3aa9edf
Block API takeoffer attempt if !sufficient btc in wallet 
This API bug was relying on offer availability checks, but those do
not check the taker's wallet.  The take offer model makes the check convenient,
and a core.api NotAvailableException can be thrown from CoreTradesService,
then mapped to the appropriate gPRC UNAVAILABLE exception sent to clients.

A new test case is added for this change:  Bob's wallet is emptied, he
fails to take an offer, and Alice returns Bob's BTC.
 2022-05-22 17:00:33 -03:00
ghubstan
7feecc9aca
Adjust to CJDNS network support in bitcoin-core v23 
This change is backward compatible for bitcoin-core v22.
This change has not been tested against bitcoin-core v21, v20, v19.

See https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-23.0.md#p2p-and-network-changes
See https://github.com/bitcoin/bitcoin/blob/23.x/doc/cjdns.md
 2022-05-21 17:03:14 -03:00
chimp1984
19643488b1
Add test 2022-05-21 01:43:20 +02:00
chimp1984
f97cc86470
Use equalsIgnoreCase for replay protection checks 
Add check for duplicate txHash
Rename wrongly names variables at startRequestsIfValid
 2022-05-21 00:32:52 +02:00
chimp1984
e97ba5aebb
Add comment to viewkey/txKey mismatch due dual mode explorer API 2022-05-21 00:30:19 +02:00
jmacxx
62719615a9
Prevent shutdown if trade is in process of being taken. 2022-05-18 18:05:05 -05:00
jmacxx
0726bdff7e
Prevent shutdown if trade is in process of being taken. 2022-05-17 12:10:23 -05:00
Bisq GitHub Admin
6fa87aea11
Merge pull request #6204 from chimp1984/add-revenue-chart 
Add chart series for total trade fees
 2022-05-16 16:58:27 +02:00
Christoph Atteneder
52b1e13d46
Merge pull request #6200 from jmacxx/fix_issue_6175 
Refactor BSQ fee validation to handle multiple txins.
 2022-05-16 16:15:25 +02:00
Christoph Atteneder
0925370121
Merge pull request #6202 from ghubstan/fix-editoffer-price-bug 
Fix API editoffer bug: set fixed-price=0 on margin offers
 2022-05-16 16:11:48 +02:00
chimp1984
0ed03fc790
Add series for burned BSQ from btc fees and arbitration 2022-05-15 23:42:18 +02:00
jmacxx
574510d172
Attempt self-ping 3 times before reporting error with connectivity. 2022-05-15 12:48:39 -05:00
chimp1984
492182a97d
Add half-year and quarter periods 2022-05-15 17:35:02 +02:00
chimp1984
5f2a430e4e
Add chart series for total trade fees 
Fix missing color adoption for BSQ supply series
 2022-05-15 15:39:59 +02:00
ghubstan
381985ec3a
Fix API editoffer bug: set fixed-price=0 on margin offers 
This is causing erroneous PRICE_OUT_OF_TOLERANCE errors when trying
to take offers having (fixed) price!=0, and isUsingMktPriceMargin=true
in the payload.

The API daemon editoffer's treatment of (fixed) price and
isUsingMktPriceMargin flag in the API has been inconsistent with the UI.

With this change:  when isUsingMktPriceMargin=true, (fixed) price is
set to 0 on the server.  API clients, however, still must show the
calculated price when isUsingMktPriceMargin=true, making this fix hard
to test in the client.  The server will now throw an exception if
(fixed) price and isUsingMktPriceMargin flag in the API are not
properly set in the API server.

This fix is intended to prevent issues such as
https://github.com/bisq-network/bisq/issues/6170 from happening for
this reason.  The offer maker edited offers with API, creating
inconsistent state described above.  It is hoped the user's offers
can be fixed by editing them in the UI.

Based on `master`.
 2022-05-14 18:14:49 -03:00
jmacxx
17a949e4d1
Refactor BSQ fee validation to handle multiple txins. 2022-05-12 21:14:26 -05:00
Christoph Atteneder
23347e6203
Add missing copyright notice 2022-05-10 11:20:25 +02:00
xyzmaker123
219b408b6a
Show changes in BSQ Supply over time - dynamic calculation 2022-05-10 10:30:25 +02:00
xyzmaker123
5fb1167a28
Show changes in BSQ Supply over time 2022-05-10 10:30:25 +02:00
Christoph Atteneder
8a13076b37
Merge pull request #6188 from xyzmaker123/mark-own-offers 
Mark user's own offers in Market -> Offer book
 2022-05-09 13:10:50 +02:00
xyzmaker123
2b69e34b3a
Mark user's own offers in Market -> Offer book 2022-05-05 10:59:50 +02:00
Christoph Atteneder
80aff38fe7
Merge pull request #6182 from jmacxx/txvalidator_fee_address_fix 
Check current fee receiver list whenever a fee tx is validated.
 2022-05-02 09:54:06 +02:00
jmacxx
b40e424389
Refresh current fee receiver list whenever a fee tx is validated. 2022-05-02 09:53:50 +02:00
ghubstan
740284ab0a
Adjust to renamed class: AustraliaPayidAccountPayload 2022-05-02 09:52:12 +02:00
ghubstan
03b6924508
Adjust to renamed class: AustraliaPayidAccountPayload 2022-05-02 09:52:12 +02:00
ghubstan
b011bae18f
Remove deleted (renamed) class 2022-05-02 09:52:11 +02:00
ghubstan
4c7e214743
Rename AustraliaPayidPayload -> AustraliaPayidAccountPayload 
Fit to nameing convention for acct payload classes; API's reflection
based acct creation logic depends on it.
 2022-05-02 09:52:11 +02:00
jmacxx
f0c79439bb
Fix uninitialized member variable payoutSuggestion. 2022-05-02 09:51:19 +02:00
Christoph Atteneder
0152f00493
Merge pull request #6183 from ghubstan/fix-getacctform-testbug 
Rename AustraliaPayidPayload -> AustraliaPayidAccountPayload
 2022-05-02 09:46:24 +02:00
Christoph Atteneder
4737a36a7b
Merge pull request #6181 from jmacxx/fix_npe_mediator_ticket 
[1.9.0] Fix uninitialized variable causing NPE in mediation ticket.
 2022-05-02 09:39:05 +02:00
ghubstan
c03dac5a26
Adjust to renamed class: AustraliaPayidAccountPayload 2022-04-30 11:11:01 -03:00
ghubstan
4df152b833
Adjust to renamed class: AustraliaPayidAccountPayload 2022-04-30 11:10:13 -03:00
ghubstan
77a206e0db
Remove deleted (renamed) class 2022-04-30 11:09:12 -03:00
ghubstan
f58d39e720
Rename AustraliaPayidPayload -> AustraliaPayidAccountPayload 
Fit to nameing convention for acct payload classes; API's reflection
based acct creation logic depends on it.
 2022-04-30 11:06:29 -03:00
jmacxx
99a74dd4d7
Refresh current fee receiver list whenever a fee tx is validated. 2022-04-29 11:25:56 -05:00
jmacxx
bf6be8998d
Fix uninitialized member variable payoutSuggestion. 2022-04-29 07:58:17 -05:00
Christoph Atteneder
5b2c58b108
Update translations for v1.9.0 2022-04-28 13:12:59 +02:00
Christoph Atteneder
41c7168bb6
Update bitcoinj checkpoints for v1.9.0 2022-04-28 13:10:30 +02:00
jmacxx
d89c3c8bf4
Add popup reminder to inform users of trading rules. 2022-04-28 11:29:32 +02:00
Christoph Atteneder
b71ffc2a4b
Merge pull request #6164 from jmacxx/popup_trading_rules 
Add popup reminder to inform users of trading rules
 2022-04-28 11:29:19 +02:00
Christoph Atteneder
6d3863dbc6
Merge pull request #6172 from xyzmaker123/refactor-cash-deposit-payload 
Refactor CashDepositAccountPayload to extends BankAccountPayload
 2022-04-28 11:28:03 +02:00
xyzmaker123
ca50662ff2
Refactor CashDepositAccountPayload to extends BankAccountPayload 2022-04-28 11:21:20 +02:00
jmacxx
7f141bc04c
Set maxTradeLimit & maxTradePeriod appropriately when editing an offer. 2022-04-28 11:17:44 +02:00
jmacxx
f31040ba31
Set maxTradeLimit & maxTradePeriod appropriately when editing an offer. 2022-04-27 22:25:28 -05:00
xyzmaker123
b932f0fa64
Refactor CashDepositAccountPayload to extends BankAccountPayload 2022-04-27 13:12:35 +02:00
Christoph Atteneder
b4506ac2de
Merge pull request #6167 from xyzmaker123/fix-npe-same-bank-edit-account-name 
Fix problems with editing account names
 2022-04-27 13:00:59 +02:00
xyzmaker123
3a1e1843c9
Fix NPE when switching to not use a custom account name 2022-04-27 12:50:39 +02:00
xyzmaker123
3619278e51
Fix NPE when switching to not use a custom account name 2022-04-26 12:31:27 +02:00
xyzmaker123
b79f963ee7
Fix issue with deleting newly created account 2022-04-26 10:52:36 +02:00
xyzmaker123
74d33e9600
Fix issue with deleting newly created account 2022-04-26 08:45:13 +02:00
jmacxx
36165f686e
Add popup reminder to inform users of trading rules. 2022-04-25 21:11:13 -05:00
Christoph Atteneder
23c62f1f0a
Improve translation key usage 2022-04-22 12:04:25 +02:00
Christoph Atteneder
529755738b
Not log as warning 2022-04-22 12:04:18 +02:00
Christoph Atteneder
5f41a3fb08
Improve translation key usage 2022-04-22 12:02:47 +02:00
Christoph Atteneder
539664d7e3
Not log as warning 2022-04-22 12:02:09 +02:00
Christoph Atteneder
0466f41934
Merge pull request #6135 from ripcurlx/improve-navigation-structure 
Improve navigation structure
 2022-04-22 11:33:53 +02:00
Christoph Atteneder
4447435e5f
Switch to open offers after creating a new offer 2022-04-22 10:01:35 +02:00
Christoph Atteneder
dde4199a15
Merge pull request #6133 from xyzmaker123/fix-pause-in-fee-service 
Fix pause between fee requests
 2022-04-21 10:54:31 +02:00
Christoph Atteneder
2233f73a7b
Fix Codacy complaints 2022-04-21 10:32:27 +02:00
Christoph Atteneder
9431dd5331
Merge pull request #6140 from jmacxx/change_additional_info_prompt 
Clarify that CBM / F2F not be used to advertise websites or contact info
 2022-04-20 21:33:51 +02:00
Christoph Atteneder
108255bf8e
Move supported currencies into payment accounts 2022-04-20 17:57:07 +02:00
Christoph Atteneder
fce247cbc0
Fix a couple of issues regarding default currencies 2022-04-13 12:35:58 +02:00
Christoph Atteneder
82cae5a87d
Merge pull request #6147 from jmacxx/add_inbound_connectivity_test 
Add inbound Tor connectivity test
 2022-04-13 10:56:31 +02:00
jmacxx
c6209e0142
Use Locale.ENGLISH when accessing directories and JAR resource paths. 2022-04-12 18:25:06 -05:00
jmacxx
c3e6a80f78
Add inbound Tor connectivity test. 2022-04-12 14:43:30 -05:00
Christoph Atteneder
9a3ed33238
Use Offer.isFiat helper method 2022-04-11 12:31:54 +02:00
Christoph Atteneder
63ea054026
Adapt amount and volume description for create offer 2022-04-11 12:12:47 +02:00
Christoph Atteneder
492ff35b09
Adapt amount and volume description for take offer 2022-04-11 11:32:55 +02:00
Christoph Atteneder
5b67766109
Properly rename main navigation 
Otherwise it would display the old 'Buy BTC' and 'Sell BTC' navigation
 2022-04-11 10:46:05 +02:00
jmacxx
54c63fd116
Clarify that CBM / F2F not be used to advertise websites or contact info. 2022-04-10 13:14:16 -05:00
Christoph Atteneder
33725c2b4e
Adapt navigation labels back to currency code 
and fix lots of minor issues
 2022-04-08 17:49:33 +02:00
Christoph Atteneder
497158ad13
Fix rebase errors with master 2022-04-07 21:13:24 +02:00
Christoph Atteneder
a8189d7bb3
Adapt create offer process to new navigation structure 2022-04-07 20:49:18 +02:00
Christoph Atteneder
924e92aa47
Adapt take offer process to new navigation structure 2022-04-07 20:49:18 +02:00
Christoph Atteneder
810a29b54f
Add missing payment account filtering 2022-04-07 20:49:17 +02:00
Christoph Atteneder
5781e3bd13
Add payment account filtering for remaining payment methods 2022-04-07 20:49:17 +02:00
Christoph Atteneder
875e5f4e87
Adapt offer book chart view to new navigational structure 2022-04-07 20:49:16 +02:00
Christoph Atteneder
98f355d3fa
Adapt navigational structure and offerbook handling to buy and sell different assets 
Still missing correct create and take offer handling
 2022-04-07 20:48:48 +02:00
Christoph Atteneder
298806150b
Merge pull request #6134 from jmacxx/fix_tradecount_bsqswap 
Fix the avatar tradecount tag to include BSQ Swap trades.
 2022-04-07 19:58:38 +02:00
Christoph Atteneder
02fac2149b
Merge pull request #6131 from jmacxx/fix_bsq_dashboard_freeze 
Prevent UI freeze in BSQ dashboard view.
 2022-04-07 19:56:15 +02:00
jmacxx
14821536c6
code review: remove duplicated lines. 2022-04-05 21:56:43 -05:00
jmacxx
aeea26725f
Fix the tradecount tag to include Bsq Swap trades. 2022-04-05 18:01:51 -05:00
jmacxx
589404f928
Refactor tradestatistics feed to the price feed service. 
Price change events were being fired too frequently and for ccys
which had not changed.
This caused UI freezing issues most noticably in the DAO dashboard.
 2022-04-05 15:38:53 -05:00
xyzmaker123
2073e68d87
Fix pause between fee requests 2022-04-05 17:27:18 +02:00
Christoph Atteneder
3f02d52789
Merge pull request #6132 from jmacxx/purge_sensitive_data_failed_trades 
Check failed trades for sensitive data purge.
 2022-04-05 11:52:04 +02:00
jmacxx
91a9804572
Check failed trades for sensitive data purge. 2022-04-04 16:34:42 -05:00
Christoph Atteneder
3166ea398c
Merge pull request #6130 from jmacxx/dao_status_wording 
Clarify DAO status shown when in sync & peers have conflicts.
 2022-04-04 21:11:20 +02:00
jmacxx
275e710eb2
Clarify DAO status shown when in sync but peers have conflicts. 2022-04-04 09:33:30 -05:00
jmacxx
581deb7056
Remove unused imports 2022-04-03 17:40:47 -05:00
jmacxx
60db9440c7
Generate addresses field from script when necessary (v22+ RPC) 2022-04-03 17:32:35 -05:00
jmacxx
d0a9e660b3
Get TXO address from scriptPubKey 2022-03-28 15:16:53 -05:00
Christoph Atteneder
a384071cff
Merge pull request #6109 from xyzmaker123/5979-price-validation 
Update trigger price validation
 2022-03-21 12:26:47 +01:00
xyzmaker123
55c55dbf47
Update trigger price validation - refactor 2022-03-21 11:43:09 +01:00
Christoph Atteneder
06dd94f77a
Merge pull request #6107 from xyzmaker123/growth-241-validate-with-iban 
IBAN validation for SEPA account
 2022-03-18 12:38:47 +01:00
xyzmaker123
044bc2d33b
Transactions View - Trade ID column 2022-03-17 15:57:01 +01:00
xyzmaker123
ab5d7dd928
Locked view - Trade ID column 2022-03-17 15:56:51 +01:00
xyzmaker123
d548dcba07
Reserved view - Offer ID column 2022-03-17 15:56:35 +01:00
xyzmaker123
41256367af
Update trigger price validation 2022-03-17 12:42:41 +01:00
xyzmaker123
ab1a8a8a2b
SEPA IBAN - fix country code validation 2022-03-16 15:17:45 +01:00
xyzmaker123
7fc406761a
Validate if IBAN country code belongs to SEPA zone 2022-03-16 10:22:29 +01:00
xyzmaker123
fd776954cc
Validate IBAN to match selected country 2022-03-16 09:29:03 +01:00
ghubstan
a3990783a4
Send pretty payment details to api clients 
Non-CLI clients need a better way of accessing payment details
than a contract json string.

- Add grpc.proto PaymentAccountPayloadInfo field: payment_details.
- Adjust proto wrapper PaymentAccountPayloadInfo to new field.
- Add test asserts to verify payment details are sent to client.
- Fix a test name: testKeepFunds -> testCloseTrade.

Based on branch `master` @ Sat 12 Mar 2022 01:42 PM -03 ,
         commit c6293b5273
 2022-03-12 14:33:23 -03:00
Bisq GitHub Admin
c6293b5273
Merge pull request #6096 from bisq-network/release/v1.8.4 
Release/v1.8.4
 2022-03-11 15:57:55 +01:00
Christoph Atteneder
a188266d65
Merge pull request #6099 from jmacxx/mediation_enhancements_202203 
Dispute subsystem enhancements
 2022-03-11 15:55:42 +01:00
jmacxx
7e802e5e28
Dispute subsystem enhancements. 
Dispute result show payout suggestion and penalty.
Feature allowing trader chat upload to dispute agents.
 2022-03-10 20:20:37 -06:00
ghubstan
24e5f193be
Exclude persistedAccountName field from json payment acct forms 
This recently added field is automatically set inside PaymentAccount.
It should not be included in the payment acct json forms used by API clients.

Based on branch `master`.
 2022-03-09 12:07:33 -03:00
Christoph Atteneder
0ea70dc36b
Merge pull request #6014 from xyzmaker123/6009-account-names-editable 
Editable account names
 2022-03-09 14:56:00 +01:00
Christoph Atteneder
b3b488c38c
Merge pull request #6094 from ghubstan/3-fix-is-activated-setting-bug 
API bug-fix for incorrect BsqSwap's OfferInfo.isActivated value [No. 3]
 2022-03-08 11:26:44 +01:00