mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2024-11-19 09:52:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

Apply code review changes.

Browse Source
This commit is contained in:
jmacxx 2022-12-29 13:57:13 -06:00
parent 1df3046371
commit fa6beffa49
No known key found for this signature in database
GPG Key ID: 155297BABFE94A1B
2 changed files with 4 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
core/src/main/java/bisq/core/provider/mempool/TxValidator.java
View File

@ -61,7 +61,8 @@ public class TxValidator {
private final List<String> errorList;
private final String txId;
private Coin amount;
private Boolean isFeeCurrencyBtc = true;
@Nullable
private Boolean isFeeCurrencyBtc;
@Nullable
private Long chainHeight;
@Setter
@ -70,21 +71,7 @@ public class TxValidator {
public TxValidator(DaoStateService daoStateService,
String txId,
Coin amount,
@Nullable Boolean isFeeCurrencyBtc,
FilterManager filterManager) {
this.daoStateService = daoStateService;
this.txId = txId;
this.amount = amount;
this.isFeeCurrencyBtc = isFeeCurrencyBtc;
this.filterManager = filterManager;
this.errorList = new ArrayList<>();
this.jsonTxt = "";
}
public TxValidator(DaoStateService daoStateService,
String txId,
Coin amount,
@Nullable Boolean isFeeCurrencyBtc,
boolean isFeeCurrencyBtc,
long feePaymentBlockHeight,
FilterManager filterManager) {
this.daoStateService = daoStateService;

2
core/src/test/java/bisq/core/provider/mempool/TxValidatorTest.java
View File

@ -209,7 +209,7 @@ public class TxValidatorTest {
knownValuesList.forEach(offerData -> {
TxValidator txValidator = createTxValidator(offerData);
log.warn("TESTING {}", txValidator.getTxId());
if (txValidator.getIsFeeCurrencyBtc()) {
if (txValidator.getIsFeeCurrencyBtc() != null && txValidator.getIsFeeCurrencyBtc()) {
String jsonTxt = mempoolData.get(txValidator.getTxId());
if (jsonTxt == null || jsonTxt.isEmpty()) {
log.warn("{} was not found in the mempool", txValidator.getTxId());