Oliver Gugger
0aa0831619
Merge pull request #6270 from guggero/enable-whitespace-linter
...
ci: enable whitespace linter
2022-02-15 18:21:04 +01:00
Oliver Gugger
eb366a64e6
docs: add release notes
2022-02-15 18:13:03 +01:00
Oliver Gugger
13f187046b
multi: fix issues reported by whitespace linter
2022-02-15 16:26:08 +01:00
Oliver Gugger
8d83778314
tools+golangci-lint: enable fixed version of whitespace linter
2022-02-15 11:16:19 +01:00
Oliver Gugger
2891dc7399
Merge pull request #6248 from guggero/lint-dockerize
...
make+tools: dockerize linting [skip ci]
2022-02-11 10:10:56 +01:00
Oliver Gugger
09406f613a
make+tools: dockerize linting
2022-02-10 16:03:00 +01:00
Oliver Gugger
28ea2736a0
Merge pull request #6244 from guggero/linter-upgrade
...
Move tools dependencies into submodule, upgrade `golangci-lint`
2022-02-10 15:11:20 +01:00
Oliver Gugger
67eae60bcc
docs: add release notes
2022-02-10 11:04:54 +01:00
Oliver Gugger
895a2e497b
multi: formatting and comment fixes
2022-02-10 11:02:02 +01:00
Oliver Gugger
ffee7d1bcf
multi: fix newly detected linter issues
2022-02-10 11:02:02 +01:00
Oliver Gugger
369627901f
lint+tools: bump version of golangci-lint
2022-02-10 11:02:01 +01:00
naveen
192cee494f
mod+tools+Makefile:separate tools different module
...
Separated the tools to different go module to avoid having tools
dependencies on the main module.
2022-02-10 11:02:01 +01:00
Oliver Gugger
dfdc2bff8b
multi: run gosimports
2022-02-10 11:02:01 +01:00
Oliver Gugger
d1b512ff92
mod+make: replace goimports with gosimports
2022-02-10 11:02:00 +01:00
Oliver Gugger
3107c807a9
Merge pull request #6239 from BTCparadigm/UpdateLicenses
...
multi: Update licenses to 2022 [skip ci]
2022-02-09 14:31:45 +01:00
Rafe
62dc1b5323
multi: Update Licenses to 2022 [skip ci]
2022-02-09 00:25:20 +02:00
Oliver Gugger
0bef42e93c
Merge pull request #6233 from guggero/sign-psbt-utxo-error-message
...
rpcwallet: disallow empty UTXO pk script [skip ci]
2022-02-08 09:39:09 +01:00
Olaoluwa Osuntokun
5084d2a4e5
Merge pull request #6236 from carlaKC/6225-hophintlimit
...
invoicesrpc: limit first pass of hop hint selection
2022-02-07 10:46:45 -08:00
carla
46e048af31
docs: add pr to release notes
2022-02-07 09:07:10 +02:00
carla
0092c731e5
lnrpc: limit hop hint selection in both passes by amount + count
...
Previously, we'd always add up to the maximum number of hop hints
(and beyond!) when selecting hop hints in our first pass. This
change updates hop hint selection to always stick to our hop hint
limit, and to the "hop hint factor" that we scale our invoices by.
This change will result in selecting fewer channels in our first
pass if their total inbound capacity reaches our hop hint factor.
This prevents us from revealing as many private channels as
before, but has the downside of providing fewer options for
payers.
2022-02-07 09:04:30 +02:00
carla
5836d58a99
lnrpc: add unit test covering too many hop hints
2022-02-07 09:03:10 +02:00
carla
4ac6f82b5e
itest: fix lack of hop hint coverage in hold invoice test
...
Update our test to assert that we have hop hints present when we
expect them, and fix the "alice is a private node" issue that was
previously preventing us from adding hop hints. Asserting that we
have hop hints present in this itest ensures that we'll fail our
itests if a change to SelectHopHints results in our no longer
having hints in this secnario.
2022-02-07 09:03:09 +02:00
Olaoluwa Osuntokun
f6ba5be351
Merge pull request #6234 from Roasbeef/increase-legacy-api-fee-limit
...
lnwallet: increase legacy fee limit threshold to 1k sats
2022-02-03 12:17:20 -08:00
Olaoluwa Osuntokun
80e304573c
lnwallet: increase legacy fee limit threshold to 1k sats
...
In this commit, we increase the legacy fee limit threshold (the amount
below which we'll allow 100% of funds to go to fees for the non-v2 RPC
calls) from 50 sats to 1k sats.
2022-02-03 11:54:01 -08:00
Oliver Gugger
75016a176c
rpcwallet: disallow empty UTXO pk script [skip ci]
...
If we're signing for an UTXO that isn't known to the wallet, then the
UTXO's pk script _must_ be set in the sign descriptor. Otherwise we run
into a generic PSBT serialization error when running in a remote signing
setup.
2022-02-03 17:34:14 +01:00
Oliver Gugger
04bbbea9a7
Merge pull request #6228 from guggero/contribution-guidelines
...
docs: rewrite and regroup formatting rules [skip ci]
2022-02-03 10:02:02 +01:00
Olaoluwa Osuntokun
5891643269
Merge pull request #6226 from guggero/fee-limit-fix
...
Fix default value for fee limit
2022-02-02 12:53:11 -08:00
Oliver Gugger
84c8c18a9e
docs: update release notes
2022-02-02 17:29:55 +01:00
Oliver Gugger
d252653624
lncli: use amount based default routing fee
2022-02-02 17:29:52 +01:00
Oliver Gugger
30367d50c7
Merge pull request #6229 from Neil-LL/patch-1
...
Tiny Formatting Change
2022-02-02 15:48:04 +01:00
Neil-LL
b398d64393
Tiny Formatting Change
2022-02-02 16:14:42 +02:00
Oliver Gugger
b667f7a89c
docs: rewrite and regroup formatting rules [skip ci]
2022-02-02 15:11:43 +01:00
Oliver Gugger
3c324ad058
docs: remove protobuf compilation section from guidelines
...
Since we're now enforcing the formatting of the protobuf files through a
CI step, this explicit mention in the docs is no longer needed.
2022-02-02 15:10:24 +01:00
Oliver Gugger
d22f543906
lnrpc: use amount based default routing fee
2022-02-02 14:24:53 +01:00
Oliver Gugger
bfa1cf17b9
lnwallet: introduce default routing fee calculation
2022-02-02 14:24:52 +01:00
Olaoluwa Osuntokun
5a827dd19b
Merge pull request #6177 from bottlepay/interceptor-failures
...
htlcswitch: add htlc interceptor failure control
2022-02-01 17:00:07 -08:00
Oliver Gugger
4a6e4d283e
Merge pull request #6222 from positiveblue/code-guidelines
...
docs: add guidelines for func declarations [skip ci]
2022-02-01 17:43:16 +01:00
positiveblue
d2143bd40f
docs: add guidelines for func declarations [skip ci]
2022-02-01 08:31:19 -08:00
Joost Jager
e2b56f212f
htlcswitch: accept failure reason for intercepted htlcs
2022-02-01 17:18:59 +01:00
Oliver Gugger
60625b6c1a
Merge pull request #6213 from blakejakopovic/master
...
docs: fixed typos in mobile readme
2022-01-31 15:16:59 +01:00
Oliver Gugger
91f93f161d
Merge pull request #6218 from guggero/dev-rpc-fix
...
devrpc: remove lncli API docs tag [skip ci]
2022-01-31 13:35:05 +01:00
Oliver Gugger
a5849bb189
devrpc: remove lncli API docs tag [skip ci]
...
The API doc generator failed after merging #6149 because of the `lncli
importgraph` tag in the proto file.
We could also fix the API doc generator by adding the "dev" build tag,
but not including any dev only features in the API docs is probably the
preferred path.
2022-01-31 13:05:27 +01:00
Oliver Gugger
8d40c8904e
Merge pull request #6207 from lightningnetwork/ci-rpc-check
...
makefile: fail rpc-check after finding any changes
2022-01-31 11:15:35 +01:00
positiveblue
3c3bce3415
makefile: fail rpc-check after finding any changes
...
`rpc-check` is used in our CI pipeline to detect any difference
between the committed and the automatically generated rpc files.
Unfortunately, the current method only detects changes in the
already existing files and won't fail if `make rpc` generates
a totally new file.
`git status --porcelain` makes the trick, it returns a line for
each file that has been modified, created or deleted.
2022-01-29 11:23:24 -08:00
Blake Jakopovic
e534ae373f
docs: fixed typos in mobile readme [skip ci]
...
Added missing single quote
Removed extra backticks
2022-01-29 09:23:08 +11:00
Oliver Gugger
9e0f7e73db
Merge pull request #6211 from carlaKC/github-prtemplate
...
github: simplify PR template and add more sections
2022-01-28 10:46:22 +01:00
Oliver Gugger
b77c1fb200
Merge pull request #6149 from bhandras/graph_import_rpc
...
lnd: add `devrpc` sub server and `devrpc.ImportGraph` to import graph dumps
2022-01-28 10:24:59 +01:00
Oliver Gugger
065412b948
Merge pull request #6182 from carlaKC/454-loop-hophintsrefactor
...
invoicerpc: refactor SelectHopHints to allow external use
2022-01-28 09:44:29 +01:00
carla
0f8d314ee7
github: simplify PR template and add more sections [skip ci]
2022-01-28 09:50:02 +02:00
carla
c15d010ba2
docs: add release notes
2022-01-27 15:10:04 +02:00
