mirrors/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-01-18 21:35:24 +01:00
Code Issues Projects Releases Wiki Activity

makefile: fail rpc-check after finding any changes

Browse Source 
`rpc-check` is used in our CI pipeline to detect any difference
between the committed and the automatically generated rpc files.
Unfortunately, the current method only detects changes in the
already existing files and won't fail if `make rpc` generates
a totally new file.

`git status --porcelain` makes the trick, it returns a line for
each file that has been modified, created or deleted.
This commit is contained in:
positiveblue 2022-01-26 22:52:03 -08:00
parent 9e0f7e73db
commit 3c3bce3415
No known key found for this signature in database
GPG Key ID: 4FFF2510928804DC
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -280,7 +280,7 @@ rpc-format:
rpc-check: rpc
@$(call print, "Verifying protos.")
cd ./lnrpc; ../scripts/check-rest-annotations.sh
if test -n "$$(git describe --dirty | grep dirty)"; then echo "Protos not properly formatted or not compiled with v3.4.0"; git status; git diff; exit 1; fi
if test -n "$$(git status --porcelain)"; then echo "Protos not properly formatted or not compiled with v3.4.0"; git status; git diff; exit 1; fi
rpc-js-compile:
@$(call print, "Compiling JSON/WASM stubs.")

4
docs/release-notes/release-notes-0.15.0.md
View File

@ -83,6 +83,9 @@
allows code external to lnd to call the function, where previously it would
require access to lnd's internals.
* [rpc-check fails if it finds any changes](https://github.com/lightningnetwork/lnd/pull/6207/)
including new and deleted files.
# Contributors (Alphabetical Order)
* 3nprob
@ -96,6 +99,7 @@
* ErikEk
* henta
* Joost Jager
* Jordi Montes
* LightningHelper
* Liviu
* mateuszmp