bitcoin/test/functional
josibake f47ff71761
test: only run test for descriptor wallets
since this test uses bech32m, we skip unless sqlite is used, which is the
same as checking if we are using descriptor wallets or not
2022-08-10 15:19:32 +02:00
..
data Add rawtr() descriptor for P2TR with unknown tweak 2022-07-19 17:36:08 -04:00
mocks Check descriptors returned by external signers 2021-12-09 11:17:04 +01:00
test_framework Merge bitcoin/bitcoin#22751: rpc/wallet: add simulaterawtransaction RPC 2022-08-05 15:19:03 -04:00
.gitignore
combine_logs.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
combined_log_template.html
create_cache.py
example_test.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_abortnode.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_addrman.py streams: Add AutoFile without ser-type and ser-version 2022-06-29 10:31:53 +02:00
feature_anchors.py Merge bitcoin/bitcoin#23392: test: move check_node_connections to util 2021-11-29 13:51:27 +01:00
feature_asmap.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 2021-11-16 11:22:06 +08:00
feature_assumevalid.py test: refactor: take use of create_block txlist parameter 2021-11-17 15:45:30 +01:00
feature_backwards_compatibility.py test: previous releases: add v23.0 2022-05-06 10:00:47 +02:00
feature_bind_extra.py test: Fix out-of-range port collisions 2022-06-10 15:56:07 +02:00
feature_bind_port_discover.py net: only assume all local addresses if listening on any 2022-03-02 15:42:40 +01:00
feature_bind_port_externalip.py net: fix GetListenPort() to derive the proper port 2022-03-02 15:42:37 +01:00
feature_bip68_sequence.py test: refactor: take use of create_block txlist parameter 2021-11-17 15:45:30 +01:00
feature_block.py test: refactor: add constant for sequence number SEQUENCE_FINAL 2022-01-11 15:28:28 +01:00
feature_blocksdir.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_cltv.py Merge bitcoin/bitcoin#23508: Add getdeploymentinfo RPC 2022-01-28 08:46:03 +01:00
feature_coinstatsindex.py test: stop node before calling assert_start_raises_init_error 2022-04-29 22:50:26 +02:00
feature_config_args.py Merge bitcoin/bitcoin#24830: init: Allow -proxy="" setting values 2022-05-20 08:28:08 +01:00
feature_csv_activation.py test: MiniWallet: always rehash after signing (P2PK mode) 2022-04-22 15:06:44 +02:00
feature_dbcrash.py test: pass dustrelayfee=0 option for tests using dust (instead of acceptnonstdtxn=1) 2022-07-03 16:30:11 +02:00
feature_dersig.py Merge bitcoin/bitcoin#23508: Add getdeploymentinfo RPC 2022-01-28 08:46:03 +01:00
feature_dirsymlinks.py test: Run symlink regression tests on Windows 2022-02-18 15:27:08 +01:00
feature_fee_estimation.py test: Return new_utxos from create_self_transfer_multi in MiniWallet 2022-06-27 11:07:34 +02:00
feature_filelock.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_help.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_includeconf.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_index_prune.py Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block 2022-06-03 07:20:07 +00:00
feature_init.py test: Fix wait_for_debug_log UnicodeDecodeError 2022-06-07 20:54:37 +02:00
feature_loadblock.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_logging.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_maxtipage.py test: add functional test for -maxtipage parameter 2022-01-25 16:20:00 +01:00
feature_maxuploadtarget.py test: pass datacarriersize option for tests using large outputs (instead of acceptnonstdtxn) 2022-06-29 18:05:59 +02:00
feature_minchainwork.py test: remove unnecessary parens 2022-07-12 13:38:14 -04:00
feature_notifications.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_nulldummy.py test: remove wallet dependency from feature_nulldummy.py 2022-06-24 17:56:53 +05:30
feature_presegwit_node_upgrade.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_proxy.py test: Fix out-of-range port collisions 2022-06-10 15:56:07 +02:00
feature_pruning.py Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block 2022-06-03 07:20:07 +00:00
feature_rbf.py scripted-diff: [test] Rename BIP125_SEQUENCE_NUMBER to MAX_BIP125_RBF_SEQUENCE 2022-07-12 18:49:08 +02:00
feature_reindex.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_segwit.py test: Fix generate calls and comments in feature_segwit 2022-03-18 16:23:43 +01:00
feature_settings.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_shutdown.py
feature_signet.py test: Fail if connect_nodes fails 2022-06-22 09:15:33 +02:00
feature_startupnotify.py test: wait rather than assert presence of file in startupnotify test 2022-01-05 09:25:43 +08:00
feature_syscall_sandbox.py test: Properly skip feature_syscall_sandbox in valgrind 2022-02-04 16:33:05 +01:00
feature_taproot.py Merge bitcoin/bitcoin#24799: Add test case mimicking issue 24765 2022-08-01 11:58:57 +02:00
feature_txindex_compatibility.py Replace "can not" with "cannot" in docs, user messages, and tests 2022-02-21 19:07:29 +01:00
feature_uacomment.py
feature_unsupported_utxo_db.py Remove utxo db upgrade code 2022-03-10 13:05:29 +01:00
feature_utxo_set_hash.py Remove buggy and confusing IncrementExtraNonce 2022-04-01 11:00:42 +02:00
feature_versionbits_warning.py test, contrib, refactor: use with when opening a file 2022-04-27 20:04:33 -03:00
interface_bitcoin_cli.py test: fix test feature_coinstatsindex.py for descriptor wallets 2021-12-09 16:40:35 +01:00
interface_http.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
interface_rest.py test: compare /mempool/info response with getmempoolinfo RPC 2022-05-12 17:49:50 -03:00
interface_rpc.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
interface_usdt_coinselection.py test: Add test for coinselection tracepoints 2022-04-21 11:17:00 -04:00
interface_usdt_net.py test: hook into PID in tracing tests 2022-07-02 14:37:29 +02:00
interface_usdt_utxocache.py test: adopt USDT utxocache interface tests 2022-07-02 14:37:32 +02:00
interface_usdt_validation.py test: hook into PID in tracing tests 2022-07-02 14:37:29 +02:00
interface_zmq.py [move only] remove is_wallet_compiled checks 2022-03-24 11:00:22 +01:00
mempool_accept_wtxid.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mempool_accept.py scripted-diff: [test] Rename BIP125_SEQUENCE_NUMBER to MAX_BIP125_RBF_SEQUENCE 2022-07-12 18:49:08 +02:00
mempool_compatibility.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 2021-11-16 11:22:06 +08:00
mempool_expiry.py scripted-diff: Rename DEFAULT_MEMPOOL_EXPIRY to indicate time unit 2022-06-28 15:42:40 -04:00
mempool_limit.py test: pass datacarriersize option for tests using large outputs (instead of acceptnonstdtxn) 2022-06-29 18:05:59 +02:00
mempool_package_limits.py test: Target exact weight in MiniWallet _bulk_tx 2022-08-03 12:02:20 +02:00
mempool_package_onemore.py test: use MiniWallet for mempool_package_onemore.py 2022-03-22 18:44:27 +01:00
mempool_packages.py Add RPC to get mempool txs spending outputs 2022-05-05 14:56:48 +02:00
mempool_persist.py test/mempool_persist: Test manual savemempool when -persistmempool=0 2022-07-12 22:37:17 -04:00
mempool_reorg.py test: Return new_utxo from create_self_transfer in MiniWallet 2022-06-27 11:07:29 +02:00
mempool_resurrect.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
mempool_spend_coinbase.py test: Remove MiniWallet mempool_valid option 2022-06-13 18:09:16 +02:00
mempool_unbroadcast.py test: Remove from_node from create_self_transfer* MiniWallet helpers 2022-06-21 12:02:01 +02:00
mempool_updatefromblock.py test: remove wallet dependency from mempool_updatefromblock.py 2022-07-01 19:27:34 +05:30
mining_basic.py test: use MiniWallet for mining_basic.py 2022-01-04 19:39:23 +01:00
mining_getblocktemplate_longpoll.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
mining_prioritisetransaction.py univalue: Return more detailed type check error messages 2022-07-18 11:31:36 +02:00
p2p_add_connections.py scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
p2p_addr_relay.py Add tests for addr destination rotation 2022-03-13 16:54:43 +01:00
p2p_addrfetch.py test: use test_framework.p2p P2P_SERVICES in functional tests 2021-09-19 14:20:48 +02:00
p2p_addrv2_relay.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_block_sync.py Add functional test for block sync from inbound peers 2022-05-17 09:36:49 -04:00
p2p_blockfilters.py test: add coverage for unknown -blockfilterindex 2022-05-23 18:06:13 -03:00
p2p_blocksonly.py refactor: Introduce PeerManagerImpl::RejectIncomingTxs 2022-06-14 08:39:55 +02:00
p2p_compactblocks_blocksonly.py [net processing] Only advertise support for version 2 compact blocks 2022-05-15 15:37:56 -04:00
p2p_compactblocks_hb.py scripted-diff: Remove redundant sync_all and sync_blocks 2021-11-10 11:10:15 +01:00
p2p_compactblocks.py test: check for getblocktxn request with out-of-bounds tx index 2022-06-14 18:11:22 +02:00
p2p_disconnect_ban.py test: set ban after mocking time 2022-01-06 15:33:43 -03:00
p2p_dns_seeds.py
p2p_dos_header_tree.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_eviction.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_feefilter.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_filter.py test: introduce getnewdestination helper for generating various address types 2021-12-26 12:10:52 +01:00
p2p_fingerprint.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_getaddr_caching.py test: Fix out-of-range port collisions 2022-06-10 15:56:07 +02:00
p2p_getdata.py
p2p_i2p_ports.py
p2p_ibd_txrelay.py Merge bitcoin/bitcoin#21327: net_processing: ignore transactions while in IBD 2021-11-30 19:09:15 +01:00
p2p_invalid_block.py Remove GetAdjustedTime from init.cpp 2021-11-30 17:19:49 +01:00
p2p_invalid_locator.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_invalid_messages.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_invalid_tx.py Merge bitcoin/bitcoin#19393: test: Add more tests for orphan tx handling 2022-07-05 18:55:56 +02:00
p2p_leak_tx.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_leak.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_message_capture.py test: Check msg type in msg capture is followed by zeros 2022-05-12 17:07:35 +02:00
p2p_nobloomfilter_messages.py
p2p_node_network_limited.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_permissions.py rpc: Default rbf enabled 2022-07-15 11:46:34 -04:00
p2p_ping.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_segwit.py Remove ::fRequireStandard global 2022-08-02 15:23:24 +02:00
p2p_sendheaders.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_timeouts.py test: passing a non-positive integer value to -peertimeout should throw an error 2022-06-30 10:18:36 -03:00
p2p_tx_download.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_unrequested_blocks.py test: Fix intermittent race in p2p_unrequested_blocks.py 2022-05-13 09:15:12 +02:00
README.md doc: Fix a link to test/lint/lint-python.py 2022-04-19 12:19:32 +02:00
rpc_bind.py
rpc_blockchain.py univalue: Return more detailed type check error messages 2022-07-18 11:31:36 +02:00
rpc_createmultisig.py test: implement 'bech32m' mode for getnewdestination() helper 2022-06-14 13:37:18 +02:00
rpc_decodescript.py Replace "can not" with "cannot" in docs, user messages, and tests 2022-02-21 19:07:29 +01:00
rpc_deprecated.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_deriveaddresses.py
rpc_dumptxoutset.py rpc: check fopen return code in dumptxoutset 2022-05-11 16:03:40 +02:00
rpc_estimatefee.py
rpc_fundrawtransaction.py univalue: Return more detailed type check error messages 2022-07-18 11:31:36 +02:00
rpc_generate.py test: move-only: Move all generate* tests to a single file 2022-03-25 11:55:49 +01:00
rpc_getblockfilter.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_getblockfrompeer.py Merge bitcoin/bitcoin#24944: rpc: add getblockfrompeer RPCTypeCheck and invalid input test coverage 2022-07-12 17:28:26 +02:00
rpc_getblockstats.py rpc: Quote user supplied strings in error messages 2021-12-13 15:18:35 +01:00
rpc_getchaintips.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_getdescriptorinfo.py rpc: Quote user supplied descriptor in error msg 2022-01-01 00:26:08 +13:00
rpc_help.py univalue: Return more detailed type check error messages 2022-07-18 11:31:36 +02:00
rpc_invalid_address_message.py Report encoding type in bech32 error message 2021-11-23 15:48:59 +13:00
rpc_invalidateblock.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_mempool_info.py test: Remove unused call to generate in rpc_mempool_info 2022-06-27 11:09:01 +02:00
rpc_misc.py util/check: Add CHECK_NONFATAL identity function, NONFATAL_UNREACHABLE AND UNREACHABLE macros 2022-04-16 15:07:41 +02:00
rpc_named_arguments.py
rpc_net.py Sanitize port in addpeeraddress() 2022-05-14 10:22:16 +02:00
rpc_packages.py scripted-diff: [test] Rename BIP125_SEQUENCE_NUMBER to MAX_BIP125_RBF_SEQUENCE 2022-07-12 18:49:08 +02:00
rpc_preciousblock.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_psbt.py Merge bitcoin/bitcoin#25610: wallet, rpc: Opt in to RBF by default 2022-08-01 10:53:11 +02:00
rpc_rawtransaction.py univalue: Return more detailed type check error messages 2022-07-18 11:31:36 +02:00
rpc_scantxoutset.py test: use MiniWallet for rpc_scantxoutset.py 2021-12-26 15:52:45 +01:00
rpc_setban.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_signer.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_signmessagewithprivkey.py test: check that verifymessage RPC fails for non-P2PKH addresses 2022-08-05 11:59:56 +02:00
rpc_signrawtransactionwithkey.py test: refactor rpc_signrawtransaction.py 2022-06-30 19:12:01 +05:30
rpc_txoutproof.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 2021-11-16 11:22:06 +08:00
rpc_uptime.py Replace "can not" with "cannot" in docs, user messages, and tests 2022-02-21 19:07:29 +01:00
rpc_users.py Reject invalid rpcauth formats 2022-04-30 12:53:35 +02:00
rpc_whitelist.py
test_runner.py rpc/wallet: add simulaterawtransaction RPC 2022-08-05 09:48:09 +09:00
test-shell.md scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
tool_signet_miner.py test: add test for signet miner script 2022-04-14 00:28:37 +02:00
tool_wallet.py wallettool: Check that the dumpfile checksum is the correct size 2021-12-26 12:33:23 -05:00
wallet_abandonconflict.py test: add more wallet conflicts assertions 2022-01-20 10:13:03 +01:00
wallet_address_types.py test: remove unused if statements 2022-07-25 09:59:05 +02:00
wallet_avoid_mixing_output_types.py test: only run test for descriptor wallets 2022-08-10 15:19:32 +02:00
wallet_avoidreuse.py test: Test for disabling wallet flags 2022-04-14 14:42:34 -04:00
wallet_backup.py refactor: remove the wallet folder if the restore fails 2021-12-15 18:41:40 -03:00
wallet_balance.py rpc, wallet: Document and test mempool scan after importprivkey 2022-07-03 21:06:49 +02:00
wallet_basic.py univalue: Return more detailed type check error messages 2022-07-18 11:31:36 +02:00
wallet_bumpfee.py scripted-diff: [test] Rename BIP125_SEQUENCE_NUMBER to MAX_BIP125_RBF_SEQUENCE 2022-07-12 18:49:08 +02:00
wallet_coinbase_category.py test: speedup wallet_coinbase_category.py 2022-07-11 15:13:32 -03:00
wallet_create_tx.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_createwallet.py tests: Do not always create a descriptor wallet in wallet_createwallet 2022-04-27 14:50:04 -04:00
wallet_crosschain.py tests: add tests for cross-chain wallet use prevention 2022-02-16 15:02:26 +02:00
wallet_descriptor.py doc: Update importaddress mention incompatibility with descriptor wallet 2022-06-14 20:54:45 +02:00
wallet_disable.py test: move-only: Move all generate* tests to a single file 2022-03-25 11:55:49 +01:00
wallet_dump.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_encryption.py Replace "can not" with "cannot" in docs, user messages, and tests 2022-02-21 19:07:29 +01:00
wallet_fallbackfee.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_groups.py wallet: Strictly match tx change type to improve privacy 2021-12-17 07:59:39 +01:00
wallet_hd.py univalue: Return more detailed type check error messages 2022-07-18 11:31:36 +02:00
wallet_implicitsegwit.py
wallet_import_rescan.py test, wallet: Add mempool rescan test for import RPCs 2022-07-03 21:06:49 +02:00
wallet_import_with_label.py
wallet_importdescriptors.py Merge bitcoin/bitcoin#25351: rpc, wallet: Scan mempool after import* - Second attempt 2022-07-18 14:26:21 -04:00
wallet_importmulti.py rpc: Add missing BlockUntilSyncedToCurrentChain to wallet RPCs 2021-12-03 11:13:00 +01:00
wallet_importprunedfunds.py test: check for importprunedfunds RPC errors 2022-03-09 16:16:07 +01:00
wallet_inactive_hdchains.py tests: Tests for inactive HD chains 2022-02-22 14:41:52 -05:00
wallet_keypool_topup.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_keypool.py Create a tr() descriptor bech32m DescriptorScriptPubKeyMan by default 2021-11-16 12:20:13 -05:00
wallet_labels.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_listdescriptors.py Create a tr() descriptor bech32m DescriptorScriptPubKeyMan by default 2021-11-16 12:20:13 -05:00
wallet_listreceivedby.py test: add coverage for 'listreceivedbyaddress' no change addrs return 2022-06-22 12:51:30 -03:00
wallet_listsinceblock.py scripted-diff: [test] Rename BIP125_SEQUENCE_NUMBER to MAX_BIP125_RBF_SEQUENCE 2022-07-12 18:49:08 +02:00
wallet_listtransactions.py rpc: Default rbf enabled 2022-07-15 11:46:34 -04:00
wallet_miniscript.py qa: functional test Miniscript watchonly support 2022-07-14 12:11:44 +02:00
wallet_multisig_descriptor_psbt.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 2021-11-16 11:22:06 +08:00
wallet_multiwallet.py univalue: Return more detailed type check error messages 2022-07-18 11:31:36 +02:00
wallet_orphanedreward.py scripted-diff: Remove redundant sync_all and sync_blocks 2021-11-10 11:10:15 +01:00
wallet_reorgsrestore.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_resendwallettransactions.py scripted-diff: rename TxRelay members 2022-03-18 11:35:58 +00:00
wallet_send.py tests: Use descriptor that requires both legacy and segwit 2022-04-21 21:00:36 -04:00
wallet_sendall.py add tests for no recipient and using send_max while inputs are specified 2022-03-29 16:37:49 -04:00
wallet_signer.py Add sendall RPC née sweep 2022-03-29 16:37:47 -04:00
wallet_signmessagewithaddress.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_signrawtransactionwithwallet.py test: refactor rpc_signrawtransaction.py 2022-06-30 19:12:01 +05:30
wallet_simulaterawtx.py rpc/wallet: add simulaterawtransaction RPC 2022-08-05 09:48:09 +09:00
wallet_startup.py
wallet_taproot.py Add wallet tests for spending rawtr() 2022-07-19 18:17:20 -04:00
wallet_timelock.py Replace "can not" with "cannot" in docs, user messages, and tests 2022-02-21 19:07:29 +01:00
wallet_transactiontime_rescan.py test: fix test wallet_transactiontime_rescan.py for descriptor wallets 2021-11-25 17:31:22 +01:00
wallet_txn_clone.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_txn_doublespend.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_upgradewallet.py tests: Test upgrading wallet with privkeys disabled 2022-02-22 13:52:40 -05:00
wallet_watchonly.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x50=1250 BTC) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: