mirrors/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-19 05:45:05 +01:00
Code Issues Projects Releases Wiki Activity

test: check that verifymessage RPC fails for non-P2PKH addresses

Browse Source
This commit is contained in:
Sebastian Falbesoner 2022-08-04 18:31:54 +02:00
parent f765d4e232
commit 68006c10ab
1 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
test/functional/rpc_signmessagewithprivkey.py
View File

@ -4,27 +4,44 @@
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
"""Test RPC commands for signing messages with private key."""
from test_framework.descriptors import (
descsum_create,
)
from test_framework.test_framework import BitcoinTestFramework
from test_framework.util import (
assert_equal,
assert_raises_rpc_error,
)
class SignMessagesWithPrivTest(BitcoinTestFramework):
def set_test_params(self):
self.setup_clean_chain = True
self.num_nodes = 1
def addresses_from_privkey(self, priv_key):
'''Return addresses for a given WIF private key in legacy (P2PKH),
nested segwit (P2SH-P2WPKH) and native segwit (P2WPKH) formats.'''
descriptors = f'pkh({priv_key})', f'sh(wpkh({priv_key}))', f'wpkh({priv_key})'
return [self.nodes[0].deriveaddresses(descsum_create(desc))[0] for desc in descriptors]
def run_test(self):
message = 'This is just a test message'
self.log.info('test signing with priv_key')
priv_key = 'cUeKHd5orzT3mz8P9pxyREHfsWtVfgsfDjiZZBcjUBAaGk1BTj7N'
address = 'mpLQjfK79b7CCV4VMJWEWAj5Mpx8Up5zxB'
expected_signature = 'INbVnW4e6PeRmsv2Qgu8NuopvrVjkcxob+sX8OcZG0SALhWybUjzMLPdAsXI46YZGb0KQTRii+wWIQzRpG/U+S0='
signature = self.nodes[0].signmessagewithprivkey(priv_key, message)
assert_equal(expected_signature, signature)
assert self.nodes[0].verifymessage(address, signature, message)
self.log.info('test that verifying with P2PKH address succeeds')
addresses = self.addresses_from_privkey(priv_key)
assert_equal(addresses[0], 'mpLQjfK79b7CCV4VMJWEWAj5Mpx8Up5zxB')
assert self.nodes[0].verifymessage(addresses[0], signature, message)
self.log.info('test that verifying with non-P2PKH addresses throws error')
for non_p2pkh_address in addresses[1:]:
assert_raises_rpc_error(-3, "Address does not refer to key", self.nodes[0].verifymessage, non_p2pkh_address, signature, message)
self.log.info('test parameter validity and error codes')
# signmessagewithprivkey has two required parameters
@ -41,5 +58,6 @@ class SignMessagesWithPrivTest(BitcoinTestFramework):
# malformed signature provided
assert_raises_rpc_error(-3, "Malformed base64 encoding", self.nodes[0].verifymessage, 'mpLQjfK79b7CCV4VMJWEWAj5Mpx8Up5zxB', "invalid_sig", message)
if __name__ == '__main__':
SignMessagesWithPrivTest().main()