Bitcoin Core integration/staging tree
  • C++ 62.9%
  • Python 18.8%
  • C 14.7%
  • CMake 1.1%
  • Shell 0.9%
  • Other 1.4%
Find a file
Hennadii Stepanov 49c3c7fe09
Merge bitcoin/bitcoin#36252: ci, iwyu: skip subtrees in compilation database
01e3eca2d8 ci, iwyu: skip subtrees in compilation database (Ryan Ofsky)

Pull request description:

  **Problem:** The IWYU CI job analyzes `src/ipc/libmultiprocess/` even though its results are thrown away. Every run prints IWYU suggestions for 14 libmultiprocess files in the non-enforced pass, applies them, and then reverts them with the `git restore` from #36112. The suggestions also disagree with what libmultiprocess's own IWYU CI reports (it runs with `-Xiwyu --error` and passes), because the two jobs use different IWYU versions and mapping files. libmultiprocess is the only subtree in this situation; leveldb, crc32c, minisketch and secp256k1 are already excluded from `compile_commands.json` with `EXPORT_COMPILE_COMMANDS OFF`. #35361 reported this output and said IWYU shouldn't be running on subtrees.

  **Solution:** Filter `SHARED_EXCLUDED_SUBTREES` (from `test/lint/lint_ignore_dirs.py`) out of `compile_commands.json` at the start of the IWYU section of `ci/test/03_test_script.sh`, so subtree sources are neither analyzed nor edited. This is done in the CI script rather than in cmake so that only IWYU is affected: clang-tidy keeps running on libmultiprocess, and no list of subtree targets has to be maintained in `cmake/libmultiprocess.cmake` (that approach broke `-DBUILD_TESTS=OFF` in #35418 and was reverted in #35523). The change is three lines in `ci/test/03_test_script.sh`; the rest of the diff is comments.

  **Testing note:** You can confirm this works by checking the IWYU CI logs and confirming that output like `/home/runner/work/_temp/src/ipc/libmultiprocess/src/mp/gen.cpp should add these lines:` no longer appears.

ACKs for top commit:
  David-Uka:
    Code-review ACK 01e3eca2d8
  hebasto:
    ACK 01e3eca2d8.

Tree-SHA512: dcec5bce3e26aad0bbc52d6f91aa1cadb3fc92e241cc6f31e938b9facd66c1f8d1c9f3cc1b6360fc1fa1e4beba180c1244a229e997bee764630e80d49b97fd50
2026-11-07 14:01:12 +00:00
.github build: Bump clang minimum supported version to 19 2026-11-05 16:49:38 +01:00
.tx translation: Switch to Qt TS source file 2026-03-16 12:20:58 +00:00
ci Merge bitcoin/bitcoin#36252: ci, iwyu: skip subtrees in compilation database 2026-11-07 14:01:12 +00:00
cmake build: Bump clang minimum supported version to 19 2026-11-05 16:49:38 +01:00
contrib Merge bitcoin/bitcoin#36592: build: Bump macOS SDK version to 15.0 2026-11-05 14:33:44 +00:00
depends refactor: Drop unused libc++-16 workarounds 2026-11-05 16:50:18 +01:00
doc Merge bitcoin/bitcoin#36036: build: Bump clang minimum supported version to 19 2026-11-06 09:13:07 +00:00
share Merge bitcoin/bitcoin#34808: cmake, translation: Use native Qt TS file as source for translations on Transifex 2026-07-23 14:55:30 +02:00
src Merge bitcoin/bitcoin#36744: refactor: fix mismatched and undefined declarations 2026-11-07 12:56:11 +00:00
test Merge bitcoin/bitcoin#36613: test: add getblockfilter test coverage for header-only blocks 2026-11-06 14:26:58 +01:00
.editorconfig doc: remove reference to cirrus 2026-05-29 08:59:43 +01:00
.gitattributes cmake: Skip using git when building from source tarball or as subproject 2026-05-14 13:32:27 +01:00
.gitignore iwyu: Add patch to prefer angled brackets over quotes for includes 2025-12-17 20:28:42 +00:00
.python-version Don't pin Python patch version 2026-04-29 21:50:13 +01:00
.style.yapf Update .style.yapf 2023-06-01 23:35:10 +05:30
CMakeLists.txt build: swap -Wunreachable-code for aggressive variant 2026-11-06 11:01:34 +00:00
CMakePresets.json cmake: Drop support for the MSVC compiler (cl.exe) 2026-11-02 16:54:50 +00:00
CONTRIBUTING.md doc: clarify test placement guidance 2026-07-22 08:36:39 -07:00
COPYING doc: update copyright year 2025-12-29 17:50:43 +00:00
CTestConfig.cmake cmake: Set CTEST_NIGHTLY_START_TIME for CDash Nightly pipelines 2026-05-08 11:09:06 +02:00
INSTALL.md lint: Check for missing trailing newline 2025-05-13 15:50:02 +02:00
libbitcoinkernel.pc.in kernel: create monolithic kernel static library 2025-07-28 10:37:42 +01:00
README.md doc: fix transifex 404s 2025-06-19 11:22:14 +01:00
ruff.toml lint: set ruff target-version to py310 2026-11-05 11:59:50 +00:00
SECURITY.md Remove my key from SECURITY.md 2026-09-25 12:26:52 +01:00
vcpkg.json build, msvc: Disable default features of the sqlite3 package 2026-08-10 23:26:01 +01:00

Bitcoin Core integration/staging tree

https://bitcoincore.org

For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.

What is Bitcoin Core?

Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.

Further information about Bitcoin Core is available in the doc folder.

License

Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/license/MIT.

Development Process

The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be completely stable. Tags are created regularly from release branches to indicate new official, stable release versions of Bitcoin Core.

The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.

The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled during the generation of the build system) with: ctest. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python. These tests can be run (if the test dependencies are installed) with: build/test/functional/test_runner.py (assuming build is your build directory).

The CI (Continuous Integration) systems make sure that every pull request is tested on Windows, Linux, and macOS. The CI must pass on all commits before merge to avoid unrelated CI failures on new pull requests.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.