bitcoin/test/functional
Andrew Chow f0c4807a6a
Merge bitcoin/bitcoin#26560: wallet: bugfix, invalid CoinsResult cached total amount
7362f8e5e2 refactor: make CoinsResult total amounts members private (furszy)
3282fad599 wallet: add assert to SelectionResult::Merge for safety (S3RK)
c4e3b7d6a1 wallet: SelectCoins, return early if wallet's UTXOs cannot cover the target (furszy)
cac2725fd0 test: bugfix, coinselector_test, use 'CoinsResult::Erase/Add' instead of direct member access (furszy)
cf79384697 test: Coin Selection, duplicated preset inputs selection (furszy)
341ba7ffd8 test: wallet, coverage for CoinsResult::Erase function (furszy)
f930aefff9 wallet: bugfix, 'CoinsResult::Erase' is erasing only one output of the set (furszy)

Pull request description:

  This comes with #26559.

  Solving few bugs inside the wallet's transaction creation
  process and adding test coverage for them.
  Plus, making use of the `CoinsResult::total_amount` cached value
  inside the Coin Selection process to return early if we don't have
  enough funds to cover the target amount.

  ### Bugs

  1) The `CoinsResult::Erase` method removes only one
  output from the available coins vector (there is a [loop break](c1061be14a/src/wallet/spend.cpp (L112))
  that should have never been there) and not all the preset inputs.

     Which on master is not a problem, because since [#25685](https://github.com/bitcoin/bitcoin/pull/25685)
     we are no longer using the method. But, it's a bug on v24
     (check [#26559](https://github.com/bitcoin/bitcoin/pull/26559)).

     This method it's being fixed and not removed because I'm later using it to solve
     another bug inside this PR.

  2) As we update the total cached amount of the `CoinsResult` object inside
     `AvailableCoins` and we don't use such function inside the coin selection
     tests (we manually load up the `CoinsResult` object), there is a discrepancy
     between the outputs that we add/erase and the total amount cached value.

  ### Improvements

  * This makes use of the `CoinsResult` total amount field to early return
    with an "Insufficient funds" error inside Coin Selection if the tx target
    amount is greater than the sum of all the wallet available coins plus the
    preset inputs amounts (we don't need to perform the entire coin selection
    process if we already know that there aren't enough funds inside our wallet).

  ### Test Coverage

  1) Adds test coverage for the duplicated preset input selection bug that we have in v24.
    Where the wallet invalidly selects the preset inputs twice during the Coin Selection
    process. Which ends up with a "good" Coin Selection result that does not cover the
    total tx target amount. Which, alone, crashes the wallet due an insane fee.
    But.. to make it worst, adding the subtract fee from output functionality
    to this mix ends up with the wallet by-passing the "insane" fee assertion,
    decreasing the output amount to fulfill the insane fee, and.. sadly,
    broadcasting the tx to the network.

  2) Adds test coverage for the `CoinsResult::Erase` method.

  ------------------------------------

  TO DO:
  * [ ] Update [#26559 ](https://github.com/bitcoin/bitcoin/pull/26559) description.

ACKs for top commit:
  achow101:
    ACK 7362f8e5e2
  glozow:
    ACK 7362f8e5e2, I assume there will be a followup PR to add coin selection sanity checks and we can discuss the best way to do that there.
  josibake:
    ACK [7362f8e](7362f8e5e2)

Tree-SHA512: 37a6828ea10d8d36c8d5873ceede7c8bef72ae4c34bef21721fa9dad83ad6dba93711c3170a26ab6e05bdbc267bb17433da08ccb83b82956d05fb16090328cba
2022-12-05 12:00:45 -05:00
..
data tests: Test that PSBT_OUT_TAP_TREE is included correctly 2022-10-06 15:32:51 -04:00
mocks Merge bitcoin/bitcoin#23578: Add external signer taproot support 2022-10-26 11:10:23 +08:00
test_framework Merge bitcoin/bitcoin#26414: test: Move tx creation to create_self_transfer_multi 2022-12-05 16:22:42 +01:00
.gitignore
combine_logs.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
combined_log_template.html
create_cache.py
example_test.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
feature_abortnode.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_addrman.py streams: Add AutoFile without ser-type and ser-version 2022-06-29 10:31:53 +02:00
feature_anchors.py Merge bitcoin/bitcoin#23392: test: move check_node_connections to util 2021-11-29 13:51:27 +01:00
feature_asmap.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 2021-11-16 11:22:06 +08:00
feature_assumevalid.py test: refactor: take use of create_block txlist parameter 2021-11-17 15:45:30 +01:00
feature_backwards_compatibility.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
feature_bind_extra.py test: Fix out-of-range port collisions 2022-06-10 15:56:07 +02:00
feature_bind_port_discover.py net: only assume all local addresses if listening on any 2022-03-02 15:42:40 +01:00
feature_bind_port_externalip.py net: fix GetListenPort() to derive the proper port 2022-03-02 15:42:37 +01:00
feature_bip68_sequence.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
feature_block.py Require callers of AcceptBlockHeader() to perform anti-dos checks 2022-08-29 08:10:35 -04:00
feature_blocksdir.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_cltv.py test: refactor: eliminate genesis block timestamp magic numbers 2022-12-01 12:59:59 +01:00
feature_coinstatsindex.py test: stop node before calling assert_start_raises_init_error 2022-04-29 22:50:26 +02:00
feature_config_args.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
feature_csv_activation.py test: MiniWallet: always rehash after signing (P2PK mode) 2022-04-22 15:06:44 +02:00
feature_dbcrash.py test: pass dustrelayfee=0 option for tests using dust (instead of acceptnonstdtxn=1) 2022-07-03 16:30:11 +02:00
feature_dersig.py Merge bitcoin/bitcoin#23508: Add getdeploymentinfo RPC 2022-01-28 08:46:03 +01:00
feature_dirsymlinks.py test: Run symlink regression tests on Windows 2022-02-18 15:27:08 +01:00
feature_discover.py test: add functional test for -discover 2022-09-30 08:26:45 -03:00
feature_fee_estimation.py test: Return new_utxos from create_self_transfer_multi in MiniWallet 2022-06-27 11:07:34 +02:00
feature_filelock.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
feature_help.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_includeconf.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_index_prune.py test: fix intermittent failure in feature_index_prune.py 2022-10-28 15:25:12 -04:00
feature_init.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
feature_loadblock.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_logging.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_maxtipage.py Move ::nMaxTipAge into ChainstateManager 2022-10-18 14:07:59 +02:00
feature_maxuploadtarget.py test: pass datacarriersize option for tests using large outputs (instead of acceptnonstdtxn) 2022-06-29 18:05:59 +02:00
feature_minchainwork.py test: remove unnecessary parens 2022-07-12 13:38:14 -04:00
feature_notifications.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
feature_nulldummy.py test: remove wallet dependency from feature_nulldummy.py 2022-06-24 17:56:53 +05:30
feature_presegwit_node_upgrade.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_proxy.py Validate port options 2022-10-05 19:30:15 +02:00
feature_pruning.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
feature_rbf.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
feature_reindex.py Faster -reindex by initially deserializing only headers 2022-10-24 13:02:37 -06:00
feature_segwit.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
feature_settings.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_shutdown.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_signet.py test: Fail if connect_nodes fails 2022-06-22 09:15:33 +02:00
feature_startupnotify.py test: wait rather than assert presence of file in startupnotify test 2022-01-05 09:25:43 +08:00
feature_syscall_sandbox.py test: Properly skip feature_syscall_sandbox in valgrind 2022-02-04 16:33:05 +01:00
feature_taproot.py Merge bitcoin/bitcoin#26480: test: Remove wallet option from non-wallet tests 2022-11-28 11:16:49 -05:00
feature_txindex_compatibility.py Replace "can not" with "cannot" in docs, user messages, and tests 2022-02-21 19:07:29 +01:00
feature_uacomment.py
feature_unsupported_utxo_db.py Remove utxo db upgrade code 2022-03-10 13:05:29 +01:00
feature_utxo_set_hash.py Remove buggy and confusing IncrementExtraNonce 2022-04-01 11:00:42 +02:00
feature_versionbits_warning.py test, contrib, refactor: use with when opening a file 2022-04-27 20:04:33 -03:00
interface_bitcoin_cli.py Merge bitcoin/bitcoin#19762: rpc: Allow named and positional arguments to be used together 2022-11-29 18:37:55 -05:00
interface_http.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
interface_rest.py Merge bitcoin/bitcoin#25412: rest: add /deploymentinfo endpoint 2022-10-13 13:30:55 -04:00
interface_rpc.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
interface_usdt_coinselection.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
interface_usdt_net.py test: hook into PID in tracing tests 2022-07-02 14:37:29 +02:00
interface_usdt_utxocache.py test: adopt USDT utxocache interface tests 2022-07-02 14:37:32 +02:00
interface_usdt_validation.py test: don't rely on usdt block_conn event order 2022-08-06 13:59:38 +02:00
interface_zmq.py [move only] remove is_wallet_compiled checks 2022-03-24 11:00:22 +01:00
mempool_accept_wtxid.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mempool_accept.py RPC: unify arg type error message 2022-09-12 10:04:15 -03:00
mempool_compatibility.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
mempool_datacarrier.py test: add tests for datacarrier and datacarriersize options 2022-08-11 12:05:09 -03:00
mempool_expiry.py test: Test that an unconfirmed not-in-mempool chain is rebroadcast 2022-08-29 12:41:50 -04:00
mempool_limit.py test: pass datacarriersize option for tests using large outputs (instead of acceptnonstdtxn) 2022-06-29 18:05:59 +02:00
mempool_package_limits.py test: Target exact weight in MiniWallet _bulk_tx 2022-08-03 12:02:20 +02:00
mempool_package_onemore.py test: refactor: deduplicate DEFAULT_{ANCESTOR,DESCENDANT}_LIMIT constants 2022-08-09 15:22:38 +02:00
mempool_packages.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
mempool_persist.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
mempool_reorg.py test: Return new_utxo from create_self_transfer in MiniWallet 2022-06-27 11:07:29 +02:00
mempool_resurrect.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
mempool_spend_coinbase.py test: Remove MiniWallet mempool_valid option 2022-06-13 18:09:16 +02:00
mempool_unbroadcast.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
mempool_updatefromblock.py test: remove wallet dependency from mempool_updatefromblock.py 2022-07-01 19:27:34 +05:30
mining_basic.py test: Test year 2106 block timestamps 2022-10-20 14:45:50 +02:00
mining_getblocktemplate_longpoll.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
mining_prioritisetransaction.py rpc: treat univalue type check error as RPC_TYPE_ERROR, not RPC_MISC_ERROR 2022-09-15 10:24:53 -03:00
p2p_add_connections.py scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
p2p_addr_relay.py Add tests for addr destination rotation 2022-03-13 16:54:43 +01:00
p2p_addrfetch.py test: use test_framework.p2p P2P_SERVICES in functional tests 2021-09-19 14:20:48 +02:00
p2p_addrv2_relay.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_block_sync.py Add functional test for block sync from inbound peers 2022-05-17 09:36:49 -04:00
p2p_blockfilters.py test: add coverage for unknown -blockfilterindex 2022-05-23 18:06:13 -03:00
p2p_blocksonly.py net: Set relay in version msg to peers with relay permission 2022-10-04 16:07:00 +02:00
p2p_compactblocks_blocksonly.py [net processing] Only advertise support for version 2 compact blocks 2022-05-15 15:37:56 -04:00
p2p_compactblocks_hb.py scripted-diff: Remove redundant sync_all and sync_blocks 2021-11-10 11:10:15 +01:00
p2p_compactblocks.py Require callers of AcceptBlockHeader() to perform anti-dos checks 2022-08-29 08:10:35 -04:00
p2p_disconnect_ban.py test: set ban after mocking time 2022-01-06 15:33:43 -03:00
p2p_dns_seeds.py [test] Test the delay before querying DNS seeds 2021-07-30 11:15:49 -07:00
p2p_dos_header_tree.py Add warning on first startup if free disk space is less than necessary 2022-10-10 16:58:14 -04:00
p2p_eviction.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_feefilter.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_filter.py test: introduce getnewdestination helper for generating various address types 2021-12-26 12:10:52 +01:00
p2p_fingerprint.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_getaddr_caching.py test: Fix out-of-range port collisions 2022-06-10 15:56:07 +02:00
p2p_getdata.py
p2p_headers_sync_with_minchainwork.py test: fix non-determinism in p2p_headers_sync_with_minchainwork.py 2022-09-01 15:45:20 -04:00
p2p_i2p_ports.py test: ensure I2P ports are handled as expected 2021-07-09 11:19:37 +02:00
p2p_i2p_sessions.py test: add a test that -i2pacceptincoming=0 creates a transient session 2022-08-16 13:02:19 +02:00
p2p_ibd_txrelay.py Merge bitcoin/bitcoin#21327: net_processing: ignore transactions while in IBD 2021-11-30 19:09:15 +01:00
p2p_initial_headers_sync.py Add functional test for block announcements during initial headers sync 2022-08-12 17:13:00 -04:00
p2p_invalid_block.py Remove GetAdjustedTime from init.cpp 2021-11-30 17:19:49 +01:00
p2p_invalid_locator.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_invalid_messages.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_invalid_tx.py Merge bitcoin/bitcoin#19393: test: Add more tests for orphan tx handling 2022-07-05 18:55:56 +02:00
p2p_leak_tx.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_leak.py test: Fix intermittent issue in p2p_leak.py 2022-08-24 12:51:11 +02:00
p2p_message_capture.py test: Check msg type in msg capture is followed by zeros 2022-05-12 17:07:35 +02:00
p2p_nobloomfilter_messages.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_node_network_limited.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_permissions.py rpc: Default rbf enabled 2022-07-15 11:46:34 -04:00
p2p_ping.py test: remove unused class NodePongAdd1 2022-11-21 13:03:35 +01:00
p2p_segwit.py Remove ::fRequireStandard global 2022-08-02 15:23:24 +02:00
p2p_sendheaders.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_sendtxrcncl.py test, refactor: Reorder sendtxrcncl tests for better readability 2022-11-14 12:04:08 +02:00
p2p_timeouts.py test: passing a non-positive integer value to -peertimeout should throw an error 2022-06-30 10:18:36 -03:00
p2p_tx_download.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_tx_privacy.py [test] Add p2p_tx_privacy.py 2022-11-30 16:36:16 +00:00
p2p_unrequested_blocks.py Require callers of AcceptBlockHeader() to perform anti-dos checks 2022-08-29 08:10:35 -04:00
README.md doc: test: suggest multi-line imports in functional test style guide 2022-08-09 18:04:20 +02:00
rpc_bind.py
rpc_blockchain.py test: Test year 2106 block timestamps 2022-10-20 14:45:50 +02:00
rpc_createmultisig.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
rpc_decodescript.py Replace "can not" with "cannot" in docs, user messages, and tests 2022-02-21 19:07:29 +01:00
rpc_deprecated.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_deriveaddresses.py rpc: add non-regression test about deriveaddresses crash when index is 2147483647 2022-10-06 12:03:36 +02:00
rpc_dumptxoutset.py rpc: check fopen return code in dumptxoutset 2022-05-11 16:03:40 +02:00
rpc_estimatefee.py RPC: unify arg type error message 2022-09-12 10:04:15 -03:00
rpc_fundrawtransaction.py Merge bitcoin/bitcoin#26560: wallet: bugfix, invalid CoinsResult cached total amount 2022-12-05 12:00:45 -05:00
rpc_generate.py test: move-only: Move all generate* tests to a single file 2022-03-25 11:55:49 +01:00
rpc_getblockfilter.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_getblockfrompeer.py test: fix intermittent failure in rpc_getblockfrompeer.py 2022-10-28 10:17:50 -04:00
rpc_getblockstats.py rpc: Quote user supplied strings in error messages 2021-12-13 15:18:35 +01:00
rpc_getchaintips.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_getdescriptorinfo.py RPC: unify arg type error message 2022-09-12 10:04:15 -03:00
rpc_help.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
rpc_invalid_address_message.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
rpc_invalidateblock.py test: verify best blockhash after invalidating an unknown block 2022-09-09 13:49:54 -03:00
rpc_mempool_info.py Adjust RPCTypeCheckObj error string 2022-10-10 18:08:00 -03:00
rpc_misc.py util/check: Add CHECK_NONFATAL identity function, NONFATAL_UNREACHABLE AND UNREACHABLE macros 2022-04-16 15:07:41 +02:00
rpc_named_arguments.py rpc: Allow named and positional arguments to be used together 2022-11-05 05:32:39 -04:00
rpc_net.py test: Fix intermittent issue in rpc_net.py 2022-12-03 17:42:05 +01:00
rpc_packages.py test: refactor RPCPackagesTest to use MiniWallet 2022-10-03 22:37:40 -03:00
rpc_preciousblock.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_psbt.py Merge bitcoin/bitcoin#26480: test: Remove wallet option from non-wallet tests 2022-11-28 11:16:49 -05:00
rpc_rawtransaction.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
rpc_scanblocks.py RPC/Blockchain: Clarify invalid-action error in scanblocks & scantxoutset 2022-11-16 00:43:07 +00:00
rpc_scantxoutset.py rpc: Return coinbase flag in scantxoutset 2022-10-07 15:04:28 +02:00
rpc_setban.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_signer.py GetExternalSigner(): fail if multiple signers are found 2022-06-09 20:34:46 +02:00
rpc_signmessagewithprivkey.py test: check that verifymessage RPC fails for non-P2PKH addresses 2022-08-05 11:59:56 +02:00
rpc_signrawtransactionwithkey.py test: refactor rpc_signrawtransaction.py 2022-06-30 19:12:01 +05:30
rpc_txoutproof.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 2021-11-16 11:22:06 +08:00
rpc_uptime.py Replace "can not" with "cannot" in docs, user messages, and tests 2022-02-21 19:07:29 +01:00
rpc_users.py Reject invalid rpcauth formats 2022-04-30 12:53:35 +02:00
rpc_whitelist.py
test_runner.py Merge bitcoin/bitcoin#26569: p2p: Ensure transaction announcements are only queued for fully connected peers 2022-12-02 15:13:31 +00:00
test-shell.md doc: test: update/fix TestShell example instructions 2022-11-17 12:04:13 +01:00
tool_signet_miner.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
tool_wallet.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_abandonconflict.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_address_types.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_avoid_mixing_output_types.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_avoidreuse.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_backup.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_balance.py Merge bitcoin/bitcoin#26480: test: Remove wallet option from non-wallet tests 2022-11-28 11:16:49 -05:00
wallet_basic.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_bumpfee.py test: Remove unused blocktools imports from wallet_bumpfee 2022-11-30 16:59:21 +01:00
wallet_coinbase_category.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_create_tx.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_createwallet.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_crosschain.py Merge bitcoin/bitcoin#26480: test: Remove wallet option from non-wallet tests 2022-11-28 11:16:49 -05:00
wallet_descriptor.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_disable.py test: move-only: Move all generate* tests to a single file 2022-03-25 11:55:49 +01:00
wallet_dump.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_encryption.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_fallbackfee.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_fast_rescan.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_groups.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_hd.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_implicitsegwit.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_import_rescan.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_import_with_label.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_importdescriptors.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_importmulti.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_importprunedfunds.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_inactive_hdchains.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_keypool_topup.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_keypool.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_labels.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_listdescriptors.py test: refactor: eliminate genesis block timestamp magic numbers 2022-12-01 12:59:59 +01:00
wallet_listreceivedby.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_listsinceblock.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_listtransactions.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_migration.py Merge bitcoin/bitcoin#26594: wallet: Avoid a segfault in migratewallet failure cleanup 2022-12-01 10:17:09 +00:00
wallet_miniscript.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_multisig_descriptor_psbt.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_multiwallet.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_orphanedreward.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_reorgsrestore.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_resendwallettransactions.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_send.py Merge bitcoin/bitcoin#26480: test: Remove wallet option from non-wallet tests 2022-11-28 11:16:49 -05:00
wallet_sendall.py test: Add sendall test for min-fee setting 2022-12-02 13:30:40 +01:00
wallet_signer.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_signmessagewithaddress.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_signrawtransactionwithwallet.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_simulaterawtx.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_startup.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_taproot.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_timelock.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_transactiontime_rescan.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_txn_clone.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_txn_doublespend.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_upgradewallet.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_watchonly.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports.
  • If more than one name from a module is needed, use lexicographically sorted multi-line imports in order to reduce the possibility of potential merge conflicts.
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x50=1250 BTC) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: