bitcoin/test/functional
glozow 35dddbccf1
Merge bitcoin/bitcoin#30394: net: fix race condition in self-connect detection
16bd283b3a Reapply "test: p2p: check that connecting to ourself leads to disconnect" (Sebastian Falbesoner)
0dbcd4c148 net: prevent sending messages in `NetEventsInterface::InitializeNode` (Sebastian Falbesoner)
66673f1c13 net: fix race condition in self-connect detection (Sebastian Falbesoner)

Pull request description:

  This PR fixes a recently discovered race condition in the self-connect detection (see #30362 and #30368).

  Initiating an outbound network connection currently involves the following steps after the socket connection is established (see [`CConnman::OpenNetworkConnection`](bd5d1688b4/src/net.cpp (L2923-L2930)) method):
  1. set up node state
  2. queue VERSION message (both steps 1 and 2 happen in [`InitializeNode`](bd5d1688b4/src/net_processing.cpp (L1662-L1683)))
  3. add new node to vector `m_nodes`

  If we connect to ourself, it can happen that the sent VERSION message (step 2) is received and processed locally *before* the node object is added to the connection manager's `m_nodes` vector (step 3). In this case, the self-connect remains undiscovered, as the detection doesn't find the outbound peer in `m_nodes` yet (see `CConnman::CheckIncomingNonce`).

  Fix this by swapping the order of 2. and 3., by taking the `PushNodeVersion` call out of `InitializeNode` and doing that in the `SendMessages` method instead, which is only called for `CNode` instances in `m_nodes`.

  The temporarily reverted test introduced in #30362 is readded. Fixes #30368.

  Thanks go to vasild, mzumsande and dergoegge for suggestions on how to fix this (see https://github.com/bitcoin/bitcoin/issues/30368#issuecomment-2200625017 ff. and https://github.com/bitcoin/bitcoin/pull/30394#discussion_r1668290789).

ACKs for top commit:
  naiyoma:
    tested ACK [16bd283b3a),  built and tested locally,  test passes successfully.
  mzumsande:
    ACK 16bd283b3a
  tdb3:
    ACK 16bd283b3a
  glozow:
    ACK 16bd283b3a
  dergoegge:
    ACK 16bd283b3a

Tree-SHA512: 5b8aced6cda8deb38d4cd3fe4980b8af505d37ffa0925afaa734c5d81efe9d490dc48a42e1d0d45dd2961c0e1172a3d5b6582ae9a2d642f2592a17fbdc184445
2024-07-16 09:40:53 +01:00
..
data psbt: Check non witness utxo outpoint early 2024-04-11 10:58:03 -04:00
mocks wallet: return and display signer error 2024-04-16 17:47:43 +02:00
test_framework Merge bitcoin/bitcoin#29431: test/BIP324: disconnection scenarios during v2 handshake 2024-07-09 16:37:27 -04:00
.gitignore
combine_logs.py
combined_log_template.html
create_cache.py
example_test.py
feature_abortnode.py node: Make translations of fatal errors consistent 2024-03-21 16:40:22 +01:00
feature_addrman.py test: Remove struct.pack from almost all places 2024-05-07 15:41:17 +02:00
feature_anchors.py [test] make v2transport arg in addconnection mandatory and few cleanups 2024-01-31 22:37:54 +05:30
feature_asmap.py test: add coverage for mapped_as from getrawaddrman 2024-05-22 07:58:08 -03:00
feature_assumeutxo.py Merge bitcoin/bitcoin#29996: Assumeutxo: bugfix on loadtxoutset with a divergent chain + test 2024-07-10 15:18:33 -04:00
feature_assumevalid.py test: makes timeout a forced named argument in tests methods that use it 2024-03-27 15:33:07 +01:00
feature_bind_extra.py test: use skip_if_platform_not_linux helper where possible 2023-12-08 18:15:34 +01:00
feature_bind_port_discover.py
feature_bind_port_externalip.py
feature_bip68_sequence.py refactor: Rename CTransaction::nVersion to version 2024-06-07 13:55:23 -04:00
feature_block.py test: Remove struct.pack from almost all places 2024-05-07 15:41:17 +02:00
feature_blocksdir.py test: Use pathlib over os.path #28362 2023-10-10 09:26:56 -04:00
feature_cltv.py test: add option to speed up tx relay/mempool sync 2024-02-28 10:05:56 -03:00
feature_coinstatsindex.py test: Added coverage to Block not found error using gettxoutsetinfo 2024-06-30 10:46:33 -04:00
feature_config_args.py test: detect OS consistently using platform.system() 2023-12-08 18:16:24 +01:00
feature_csv_activation.py refactor: Rename CTransaction::nVersion to version 2024-06-07 13:55:23 -04:00
feature_dbcrash.py scripted-diff: Rename hash_serialized_2 to hash_serialized_3 2023-10-20 22:53:06 +02:00
feature_dersig.py test: add option to speed up tx relay/mempool sync 2024-02-28 10:05:56 -03:00
feature_dirsymlinks.py scripted-diff: Use blocks_path where possible 2023-07-25 15:51:36 +02:00
feature_discover.py
feature_fastprune.py
feature_fee_estimation.py test: add option to speed up tx relay/mempool sync 2024-02-28 10:05:56 -03:00
feature_filelock.py init: don't delete PID file if it was not generated 2023-12-04 12:54:20 +00:00
feature_framework_miniwallet.py test: add framework functional test for MiniWallet's tx padding 2024-05-31 00:12:00 +02:00
feature_framework_unit_tests.py test: add unit test for keys_to_multisig_script 2024-06-05 16:18:31 +02:00
feature_help.py
feature_includeconf.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
feature_index_prune.py test: Bump timeouts in feature_index_prune and wallet_importdescriptors 2024-04-02 17:49:48 +02:00
feature_init.py test: use sleepy wait-for-log in reindex readonly 2024-04-30 14:14:50 -04:00
feature_loadblock.py test: Use pathlib over os.path #28362 2023-10-10 09:26:56 -04:00
feature_logging.py scripted-diff: Use wallets_path and chain_path where possible 2023-06-21 08:48:34 +02:00
feature_maxtipage.py Add TimeOffsets helper class 2024-04-10 17:01:27 +02:00
feature_maxuploadtarget.py Merge bitcoin/bitcoin#29358: test: use v2 everywhere for P2PConnection if --v2transport is enabled 2024-02-27 09:51:41 +00:00
feature_minchainwork.py
feature_notifications.py test: detect OS consistently using platform.system() 2023-12-08 18:16:24 +01:00
feature_nulldummy.py Make post-p2sh consensus rules mandatory for tx relay 2023-08-18 00:59:27 +10:00
feature_posix_fs_permissions.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
feature_presegwit_node_upgrade.py
feature_proxy.py test: cover UNIX sockets in feature_proxy.py 2024-03-01 14:47:29 -05:00
feature_pruning.py rpc: Make pruneheight also reflect undo data presence 2024-06-23 00:15:24 +02:00
feature_rbf.py test: remove unneeded -maxorphantx=1000 settings 2024-05-17 22:38:59 +02:00
feature_reindex_readonly.py test: use sleepy wait-for-log in reindex readonly 2024-04-30 14:14:50 -04:00
feature_reindex.py test: Add functional test for continuing a reindex 2024-06-07 19:17:21 +02:00
feature_remove_pruned_files_on_startup.py test: detect OS consistently using platform.system() 2023-12-08 18:16:24 +01:00
feature_segwit.py Remove deprecated -rpcserialversion 2023-12-11 18:22:13 +01:00
feature_settings.py QA: Expect PACKAGE_NAME rather than constant "Bitcoin Core" 2024-06-19 14:59:31 +00:00
feature_shutdown.py
feature_signet.py
feature_startupnotify.py Merge bitcoin/bitcoin#27884: test: Use TestNode datadir_path or chain_path where possible 2023-06-29 09:51:53 +01:00
feature_taproot.py refactor: Rename CTransaction::nVersion to version 2024-06-07 13:55:23 -04:00
feature_uacomment.py
feature_unsupported_utxo_db.py scripted-diff: Use blocks_path where possible 2023-07-25 15:51:36 +02:00
feature_utxo_set_hash.py test: Fix utxo set hash serialisation signedness 2024-02-07 11:47:17 +01:00
feature_versionbits_warning.py rpc: return warnings as an array instead of just a single one 2024-05-01 14:44:57 +01:00
interface_bitcoin_cli.py cli: Sanitize ports in rpcconnect and rpcport 2024-05-13 12:14:04 -04:00
interface_http.py
interface_rest.py Merge bitcoin/bitcoin#27114: p2p: Allow whitelisting manual connections 2024-03-12 12:59:02 -04:00
interface_rpc.py test: remove unused variable in interface_rpc.py 2024-06-07 09:26:55 -04:00
interface_usdt_coinselection.py wallet: fix coin selection tracing to return -1 when no change pos 2024-01-20 14:56:41 +01:00
interface_usdt_mempool.py test: fix usdt undeclared function errors on mantis 2023-10-09 21:01:38 +01:00
interface_usdt_net.py test: fix usdt undeclared function errors on mantis 2023-10-09 21:01:38 +01:00
interface_usdt_utxocache.py test: fix usdt undeclared function errors on mantis 2023-10-09 21:01:38 +01:00
interface_usdt_validation.py test: fix usdt undeclared function errors on mantis 2023-10-09 21:01:38 +01:00
interface_zmq.py test: cover unix sockets in zmq interface 2024-04-16 14:14:42 -04:00
mempool_accept_wtxid.py
mempool_accept.py Replace hard-coded constant in test 2024-06-18 19:43:33 +02:00
mempool_compatibility.py mempool: persist with XOR 2023-11-09 19:44:50 +01:00
mempool_datacarrier.py test: replace random_bytes with randbytes #28720 2023-10-25 08:56:41 -04:00
mempool_dust.py tests: ensure functional tests set permitbaremultisig=1 when needed 2023-12-15 18:37:29 +10:00
mempool_expiry.py rpc: exposing modified_fee in getprioritisedtransactions 2024-01-11 08:16:22 -06:00
mempool_limit.py test: MiniWallet: respect fee_rate for target_weight, use in mempool_limit.py 2024-05-31 00:12:00 +02:00
mempool_package_limits.py [rpc] return full string for package_msg and package-error 2024-01-26 15:58:35 +00:00
mempool_package_onemore.py Merge bitcoin/bitcoin#29998: functional test: ensure confirmed utxo being sourced for 2nd chain 2024-06-04 21:47:16 -04:00
mempool_package_rbf.py package rbf: cpfp structure requires package > parent feerate 2024-07-09 13:18:04 -04:00
mempool_packages.py test: remove unneeded -maxorphantx=1000 settings 2024-05-17 22:38:59 +02:00
mempool_persist.py Add importmempool RPC 2023-08-07 11:33:34 +02:00
mempool_reorg.py test: Fix intermittent issue in mempool_reorg 2023-08-22 11:08:46 +02:00
mempool_resurrect.py
mempool_sigoplimit.py [refactor] use MAX_PUBKEYS_PER_MULTISIG instead of magic numbers in test 2024-02-12 14:47:12 +00:00
mempool_spend_coinbase.py
mempool_truc.py use version=3 instead of v3 in debug strings 2024-07-02 12:20:12 +01:00
mempool_unbroadcast.py
mempool_updatefromblock.py
mining_basic.py test: Extends wait_for_getheaders so a specific block hash can be checked 2024-04-04 13:36:45 +02:00
mining_getblocktemplate_longpoll.py test: Fix intermittent issue in mining_getblocktemplate_longpoll.py 2023-06-23 15:21:29 +02:00
mining_prioritisetransaction.py test: Assert that a new tx with a delta of 0 is never added 2024-01-11 08:16:42 -06:00
p2p_1p1c_network.py test: use tagged ephemeral MiniWallet instance in fill_mempool 2024-05-05 12:36:51 +02:00
p2p_add_connections.py test: p2p: adhere to typical VERSION message protocol flow 2024-02-01 13:33:23 +01:00
p2p_addr_relay.py net_processing: make all Misbehaving increments = 100 2024-05-30 08:35:18 -04:00
p2p_addrfetch.py test: Combine sync_send_with_ping and sync_with_ping 2023-09-05 12:11:10 +02:00
p2p_addrv2_relay.py net_processing: make all Misbehaving increments = 100 2024-05-30 08:35:18 -04:00
p2p_block_sync.py doc: fix some typos 2024-03-26 16:51:46 +00:00
p2p_blockfilters.py test: add bip157 coverage for (start height > stop height) disconnect 2023-08-07 12:20:22 +02:00
p2p_blocksonly.py test: Combine sync_send_with_ping and sync_with_ping 2023-09-05 12:11:10 +02:00
p2p_compactblocks_blocksonly.py test: Combine sync_send_with_ping and sync_with_ping 2023-09-05 12:11:10 +02:00
p2p_compactblocks_hb.py test: fix intermittent failure in p2p_compactblocks_hb.py 2024-04-16 12:20:47 -04:00
p2p_compactblocks.py test: Extends wait_for_getheaders so a specific block hash can be checked 2024-04-04 13:36:45 +02:00
p2p_disconnect_ban.py test: Set mocktime in p2p_disconnect_ban.py to avoid intermittent test failure 2024-06-04 21:49:50 +02:00
p2p_dns_seeds.py
p2p_dos_header_tree.py
p2p_eviction.py
p2p_feefilter.py test: add option to speed up tx relay/mempool sync 2024-02-28 10:05:56 -03:00
p2p_filter.py test: add option to speed up tx relay/mempool sync 2024-02-28 10:05:56 -03:00
p2p_fingerprint.py
p2p_getaddr_caching.py test: drop duplicate getaddrs from p2p_getaddr_caching 2023-07-25 10:34:29 -04:00
p2p_getdata.py
p2p_handshake.py Reapply "test: p2p: check that connecting to ourself leads to disconnect" 2024-07-09 21:36:35 +02:00
p2p_headers_sync_with_minchainwork.py
p2p_i2p_ports.py i2p: log connection was refused due to arbitrary port 2024-02-08 18:33:16 -03:00
p2p_i2p_sessions.py
p2p_ibd_stalling.py test: enable v2 for python p2p depending on global --v2transport flag 2024-02-12 10:46:42 -05:00
p2p_ibd_txrelay.py test: Combine sync_send_with_ping and sync_with_ping 2023-09-05 12:11:10 +02:00
p2p_initial_headers_sync.py test: Extends wait_for_getheaders so a specific block hash can be checked 2024-04-04 13:36:45 +02:00
p2p_invalid_block.py test: add option to speed up tx relay/mempool sync 2024-02-28 10:05:56 -03:00
p2p_invalid_locator.py test: python E721 updates 2023-07-31 12:13:46 -06:00
p2p_invalid_messages.py Merge bitcoin/bitcoin#29575: net_processing: make any misbehavior trigger immediate discouragement 2024-06-20 13:28:38 -04:00
p2p_invalid_tx.py [log] updates in TxOrphanage 2024-05-14 10:38:57 +01:00
p2p_leak_tx.py
p2p_leak.py
p2p_message_capture.py script, test: add missing python type annotations 2023-06-29 16:13:51 -06:00
p2p_mutated_blocks.py Merge bitcoin/bitcoin#29575: net_processing: make any misbehavior trigger immediate discouragement 2024-06-20 13:28:38 -04:00
p2p_net_deadlock.py test: replace random_bytes with randbytes #28720 2023-10-25 08:56:41 -04:00
p2p_nobloomfilter_messages.py
p2p_node_network_limited.py Merge bitcoin/bitcoin#29750: test: makes timeout a forced named argument in tests methods that use it 2024-04-02 11:06:35 +01:00
p2p_opportunistic_1p1c.py test: use tagged ephemeral MiniWallet instance in fill_mempool 2024-05-05 12:36:51 +02:00
p2p_orphan_handling.py [functional test] attackers sending mutated orphans 2024-05-14 10:38:57 +01:00
p2p_outbound_eviction.py test: adds outbound eviction tests for non outbound-full-relay peers 2024-04-26 11:15:22 -04:00
p2p_permissions.py test: add coverage for whitelisting manual connections 2024-02-28 10:05:56 -03:00
p2p_ping.py
p2p_segwit.py refactor: Rename CTransaction::nVersion to version 2024-06-07 13:55:23 -04:00
p2p_sendheaders.py net_processing: drop Misbehavior for unconnecting headers 2024-05-30 08:34:59 -04:00
p2p_sendtxrcncl.py test: p2p: adhere to typical VERSION message protocol flow 2024-02-01 13:33:23 +01:00
p2p_timeouts.py test: enable v2 for python p2p depending on global --v2transport flag 2024-02-12 10:46:42 -05:00
p2p_tx_download.py test: use tagged ephemeral MiniWallet instance in fill_mempool 2024-05-05 12:36:51 +02:00
p2p_tx_privacy.py
p2p_unrequested_blocks.py net_processing: make all Misbehaving increments = 100 2024-05-30 08:35:18 -04:00
p2p_v2_encrypted.py [test] Check whether v2 TestNode performs downgrading 2024-01-25 11:10:50 +05:30
p2p_v2_misbehaving.py test: Fix intermittent failure in p2p_v2_misbehaving.py 2024-07-15 20:51:05 +05:30
p2p_v2_transport.py test: assert rpc error for addnode v2transport not enabled 2024-02-20 22:04:53 -06:00
README.md doc: test: mention OS detection preferences in style guideline 2023-12-08 18:16:27 +01:00
rpc_bind.py test: use skip_if_platform_not_linux helper where possible 2023-12-08 18:15:34 +01:00
rpc_blockchain.py Throw error if invalid parameters passed to getnetworkhashps RPC endpoint 2023-11-07 12:58:42 -05:00
rpc_createmultisig.py test: add createmultisig P2MS encoding test for all n (1..20) 2024-06-05 16:18:34 +02:00
rpc_decodescript.py descriptor: InferScript, do not return top-level only func as sub descriptor 2023-07-20 11:04:52 -03:00
rpc_deprecated.py
rpc_deriveaddresses.py Add PubKeyDestination for P2PK scripts 2023-09-12 12:14:31 -04:00
rpc_dumptxoutset.py rpc: Enhance metadata of the dumptxoutset output 2024-05-21 13:57:09 +02:00
rpc_estimatefee.py test: added coverage to estimatefee 2023-06-22 08:27:38 -05:00
rpc_generate.py rpc: call TestBlockValidity via miner interface 2024-06-18 18:47:51 +02:00
rpc_getblockfilter.py
rpc_getblockfrompeer.py
rpc_getblockstats.py
rpc_getchaintips.py
rpc_getdescriptorinfo.py
rpc_help.py
rpc_invalid_address_message.py
rpc_invalidateblock.py
rpc_mempool_info.py
rpc_misc.py removed StrFormatInternalBug quote delimitation 2023-08-18 04:04:06 +00:00
rpc_named_arguments.py
rpc_net.py test: change comments to self.log.info for test_addnode_getaddednodeinfo 2024-06-26 06:22:05 -03:00
rpc_packages.py refactor: Rename CTransaction::nVersion to version 2024-06-07 13:55:23 -04:00
rpc_preciousblock.py
rpc_psbt.py Merge bitcoin/bitcoin#29855: psbt: Check non witness utxo outpoint early 2024-07-08 13:56:52 -04:00
rpc_rawtransaction.py Merge bitcoin/bitcoin#29325: consensus: Store transaction nVersion as uint32_t 2024-06-12 10:32:31 +01:00
rpc_scanblocks.py
rpc_scantxoutset.py
rpc_setban.py test: remove duplicated ban test 2024-03-26 10:57:40 -03:00
rpc_signer.py scripted-diff: Specify Python major version explicitly on Windows 2023-08-03 14:57:45 +01:00
rpc_signmessagewithprivkey.py
rpc_signrawtransactionwithkey.py test: cover more errors for signrawtransactionwithkey RPC 2024-06-12 17:07:16 -03:00
rpc_txoutproof.py
rpc_uptime.py [rpc, bugfix] Enforce maximum value for setmocktime 2024-04-15 09:51:06 +01:00
rpc_users.py test: add rpccookieperms test 2024-06-27 15:08:23 +01:00
rpc_validateaddress.py
rpc_whitelist.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
test_runner.py Merge bitcoin/bitcoin#29431: test/BIP324: disconnection scenarios during v2 handshake 2024-07-09 16:37:27 -04:00
test-shell.md doc: fix broken relative md links 2024-05-03 16:07:12 +01:00
tool_signet_miner.py
tool_wallet.py wallet, test: Be able to always swap BDB endianness 2024-05-16 15:03:13 -04:00
wallet_abandonconflict.py Merge bitcoin/bitcoin#27307: wallet: track mempool conflicts with wallet transactions 2024-03-27 12:45:08 -04:00
wallet_address_types.py test: add option to speed up tx relay/mempool sync 2024-02-28 10:05:56 -03:00
wallet_assumeutxo.py test: Remove unnecessary sync_blocks in assumeutxo tests 2024-02-26 17:04:46 +01:00
wallet_avoid_mixing_output_types.py test: add option to speed up tx relay/mempool sync 2024-02-28 10:05:56 -03:00
wallet_avoidreuse.py test: add option to speed up tx relay/mempool sync 2024-02-28 10:05:56 -03:00
wallet_backup.py test: add option to speed up tx relay/mempool sync 2024-02-28 10:05:56 -03:00
wallet_backwards_compatibility.py wallet: Test upgrade of pre-taproot wallet to have tr() descriptors 2024-03-20 16:15:43 -04:00
wallet_balance.py test: Use int.to_bytes over struct packing 2024-05-07 15:40:41 +02:00
wallet_basic.py Merge bitcoin/bitcoin#28336: rpc: parse legacy pubkeys consistently with specific error messages 2024-05-08 17:52:58 -04:00
wallet_blank.py test: Use pathlib over os.path #28362 2023-10-10 09:26:56 -04:00
wallet_bumpfee.py Merge bitcoin/bitcoin#27969: bumpfee: ignore WALLET_INCREMENTAL_RELAY_FEE when user specifies fee_rate 2024-06-14 14:46:04 -04:00
wallet_change_address.py
wallet_coinbase_category.py
wallet_conflicts.py wallet: update mempool conflicts tests + docs 2024-07-01 12:27:43 -04:00
wallet_create_tx.py [doc] replace mentions of v3 with TRUC 2024-07-02 12:06:07 +01:00
wallet_createwallet.py test: Add Wallet Unlock Context Manager 2023-10-10 18:12:31 +03:00
wallet_createwalletdescriptor.py test: Add test for createwalletdescriptor 2024-03-20 16:15:43 -04:00
wallet_crosschain.py test: Use pathlib over os.path #28362 2023-10-10 09:26:56 -04:00
wallet_descriptor.py tests: Test for concurrent writes with db tx 2024-02-06 12:24:36 -05:00
wallet_disable.py
wallet_dump.py Merge bitcoin/bitcoin#28617: test: Add Wallet Unlock Context Manager 2023-10-19 10:23:44 +01:00
wallet_encryption.py test: Add Wallet Unlock Context Manager 2023-10-10 18:12:31 +03:00
wallet_fallbackfee.py
wallet_fast_rescan.py test: use built-in collection types for type hints (Python 3.9 / PEP 585) 2023-10-25 01:10:21 +02:00
wallet_fundrawtransaction.py test: fix inconsistency in fundrawtransaction weight limits test 2024-07-10 20:04:21 -03:00
wallet_gethdkeys.py tests: Test for gethdkeys 2024-03-20 16:15:43 -04:00
wallet_groups.py test: remove immediate tx relay workaround in wallet_groups.py 2024-04-06 18:30:09 +02:00
wallet_hd.py test: add option to speed up tx relay/mempool sync 2024-02-28 10:05:56 -03:00
wallet_implicitsegwit.py
wallet_import_rescan.py test: add option to speed up tx relay/mempool sync 2024-02-28 10:05:56 -03:00
wallet_import_with_label.py
wallet_importdescriptors.py test: Bump timeouts in feature_index_prune and wallet_importdescriptors 2024-04-02 17:49:48 +02:00
wallet_importmulti.py
wallet_importprunedfunds.py wallet: batch and simplify ZapSelectTx process 2024-02-09 14:54:50 -03:00
wallet_inactive_hdchains.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
wallet_keypool_topup.py test: add coverage for bech32m in wallet_keypool_topup 2024-03-20 11:09:36 -03:00
wallet_keypool.py test: make sure keypool sizes do not change on getrawchangeaddress/getnewaddress failures 2024-02-28 13:04:48 +03:00
wallet_labels.py
wallet_listdescriptors.py
wallet_listreceivedby.py test: add option to speed up tx relay/mempool sync 2024-02-28 10:05:56 -03:00
wallet_listsinceblock.py test: Added test coverage to listsinceblock rpc 2024-06-16 13:30:56 -04:00
wallet_listtransactions.py test: add option to speed up tx relay/mempool sync 2024-02-28 10:05:56 -03:00
wallet_migration.py test: verify wallet is still active post-migration failure 2024-07-01 14:25:55 -04:00
wallet_miniscript.py tests: Increase wallet_miniscript.py rpc timeout to 90 seconds 2023-11-07 18:32:28 -05:00
wallet_multisig_descriptor_psbt.py tests: improve wallet multisig descriptor test and docs 2024-05-19 19:59:38 -05:00
wallet_multiwallet.py test: detect OS consistently using platform.system() 2023-12-08 18:16:24 +01:00
wallet_orphanedreward.py
wallet_pruning.py test: Use pathlib over os.path #28362 2023-10-10 09:26:56 -04:00
wallet_reindex.py rpc: getwalletinfo, return wallet 'birthtime' 2023-12-05 18:55:35 -03:00
wallet_reorgsrestore.py test: fix intermittent failure in wallet_reorgrestore.py 2024-02-12 15:27:18 -05:00
wallet_rescan_unconfirmed.py [test] import descriptor wallet with reorged parent + IsFromMe child in mempool 2024-01-12 14:51:16 +00:00
wallet_resendwallettransactions.py tests: Use manual bumps instead of bumpfee for resendwallettransactions 2023-09-27 11:39:07 -04:00
wallet_send.py wallet: notify when preset + automatic inputs exceed max weight 2024-06-21 18:13:22 -03:00
wallet_sendall.py test: test sendall does ancestor aware funding 2024-05-09 12:49:41 -04:00
wallet_sendmany.py test: add tests for fundrawtx and sendmany rpcs 2024-01-19 15:04:56 +01:00
wallet_signer.py wallet: return and display signer error 2024-04-16 17:47:43 +02:00
wallet_signmessagewithaddress.py
wallet_signrawtransactionwithwallet.py rpc: Reword SighashFromStr error message 2024-04-15 10:01:15 +02:00
wallet_simulaterawtx.py
wallet_spend_unconfirmed.py Amend bumpfee for inputs with overlapping ancestry 2023-09-13 15:46:59 -04:00
wallet_startup.py
wallet_taproot.py
wallet_timelock.py
wallet_transactiontime_rescan.py
wallet_txn_clone.py test: refactor: support sending funds with outpoint result 2023-10-24 11:13:51 +02:00
wallet_txn_doublespend.py test: refactor: support sending funds with outpoint result 2023-10-24 11:13:51 +02:00
wallet_upgradewallet.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
wallet_watchonly.py

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports.
  • If more than one name from a module is needed, use lexicographically sorted multi-line imports in order to reduce the possibility of potential merge conflicts.
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.
  • Use platform.system() for detecting the running operating system and os.name to check whether it's a POSIX system (see also the skip_if_platform_not_{linux,posix} methods in the BitcoinTestFramework class, which can be used to skip a whole test depending on the platform).

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x50=1250 BTC) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: