bitcoin/test/functional
W. J. van der Laan 5ccab7187b
Merge bitcoin/bitcoin#23394: Taproot wallet test vectors (generation+tests)
f1c33ee4ac tests: implement BIP341 test vectors (Pieter Wuille)
ac3037df11 tests: BIP341 test vector generation (Pieter Wuille)
ca83ffc2ea tests: add deterministic signing mode to ECDSA (Pieter Wuille)
c98c53f20c tests: abstract out precomputed BIP341 signature hash elements (Pieter Wuille)
a5bde018b4 tests: give feature_taproot access to sighash preimages (Pieter Wuille)
5140825096 tests: add more fields to TaprootInfo (Pieter Wuille)
2478c6730a Make signing follow BIP340 exactly w.r.t. aux randomness (Pieter Wuille)

Pull request description:

  This PR adds code to `test/functional/feature_taproot.py` which runs through a (deterministic) scenario covering several aspects of the wallet side of BIP341 (scriptPubKey computation from keys/scripts, control block computation, key path spending), with the ability to output test vectors in mediawiki format based on this scenario. The generated tests are then also included directly in `src/test/script_tests.cpp` and `src/test/script_standard_tests.cpp`.

  I intend to add these test vectors to BIP341 itself: https://github.com/bitcoin/bips/pull/1225

ACKs for top commit:
  laanwj:
    Code review ACK f1c33ee4ac

Tree-SHA512: fcf7109539cb214d3190516b205cd32d2b1b452f14aa66f4107acfaa8bfc7d368f626857f1935665a4342eabc0b9ee8aba608a7c0a2494bec0b498e723439c9d
2021-11-15 20:32:42 +01:00
..
data lint: enable mypy checking for missing imports 2021-10-16 09:14:37 +08:00
mocks rpc: send: support external signer 2021-02-23 14:34:32 +01:00
test_framework Merge bitcoin/bitcoin#23394: Taproot wallet test vectors (generation+tests) 2021-11-15 20:32:42 +01:00
.gitignore
combine_logs.py lint: enable mypy checking for missing imports 2021-10-16 09:14:37 +08:00
combined_log_template.html
create_cache.py
example_test.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
feature_abortnode.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
feature_addrman.py Introduce new V4 format addrman 2021-10-25 13:48:21 -04:00
feature_anchors.py test: Remove useless overwrite 2021-09-03 16:14:57 +02:00
feature_asmap.py p2p: improve checkaddrman logging with duration in milliseconds 2021-10-05 18:34:22 +02:00
feature_assumevalid.py test: remove unnecessary block rehashing prior to solving 2021-11-12 18:29:43 +01:00
feature_backwards_compatibility.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
feature_bind_extra.py net: don't bind on 0.0.0.0 if binds are restricted to Tor 2021-07-07 15:46:38 +02:00
feature_bip68_sequence.py test: remove unnecessary block rehashing prior to solving 2021-11-12 18:29:43 +01:00
feature_block.py test: remove unnecessary block rehashing prior to solving 2021-11-12 18:29:43 +01:00
feature_blockfilterindex_prune.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
feature_blocksdir.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
feature_cltv.py test: Activate all regtest softforks at height 1, unless overridden 2021-09-16 18:53:04 +02:00
feature_coinstatsindex.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
feature_config_args.py test: Fix tests on Windows 2021-09-08 18:58:31 +02:00
feature_csv_activation.py test: remove unnecessary block rehashing prior to solving 2021-11-12 18:29:43 +01:00
feature_dbcrash.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
feature_dersig.py test: remove unnecessary block rehashing prior to solving 2021-11-12 18:29:43 +01:00
feature_fee_estimation.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
feature_filelock.py wallet: Use PACKAGE_NAME to mention our software 2021-10-20 21:09:14 +03:00
feature_help.py test: use f-strings in feature_help.py 2021-08-18 12:39:18 +08:00
feature_includeconf.py Cleanup -includeconf error message 2021-05-21 10:54:12 +02:00
feature_loadblock.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
feature_logging.py test: use f-strings in feature_logging.py 2021-08-18 12:39:18 +08:00
feature_maxuploadtarget.py test: Set peertimeout in write_config 2021-09-13 09:41:58 +02:00
feature_minchainwork.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
feature_notifications.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
feature_nulldummy.py test: remove unnecessary block rehashing prior to solving 2021-11-12 18:29:43 +01:00
feature_presegwit_node_upgrade.py Introduce -testactivationheight=name@height setting 2021-09-16 18:52:59 +02:00
feature_proxy.py test: extend feature_proxy.py to test CJDNS 2021-11-03 14:58:51 +01:00
feature_pruning.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
feature_rbf.py test: MiniWallet: add P2TR support and use it per default 2021-11-09 12:25:48 +01:00
feature_reindex.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
feature_segwit.py test: add script_util helper for creating bare multisig scripts 2021-10-26 14:51:18 +02:00
feature_settings.py test: use f-strings in feature_settings.py 2021-08-18 12:39:19 +08:00
feature_shutdown.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_signet.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
feature_syscall_sandbox.py Add syscall sandboxing (seccomp-bpf) 2021-10-01 13:51:10 +00:00
feature_taproot.py Merge bitcoin/bitcoin#23394: Taproot wallet test vectors (generation+tests) 2021-11-15 20:32:42 +01:00
feature_txindex_compatibility.py test: Add txindex migration test 2021-11-09 12:05:45 +01:00
feature_uacomment.py
feature_utxo_set_hash.py test: MiniWallet: add P2TR support and use it per default 2021-11-09 12:25:48 +01:00
feature_versionbits_warning.py Add syscall sandboxing (seccomp-bpf) 2021-10-01 13:51:10 +00:00
interface_bitcoin_cli.py net: don't skip CJDNS from GetNetworksInfo() 2021-11-03 14:58:49 +01:00
interface_http.py test: use f-strings in interface_*.py tests 2021-08-18 12:39:20 +08:00
interface_rest.py Merge bitcoin/bitcoin#22918: rpc: Add level 3 verbosity to getblock RPC call (#21245 modified) 2021-10-19 15:47:53 +02:00
interface_rpc.py test: use f-strings in interface_*.py tests 2021-08-18 12:39:20 +08:00
interface_zmq.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
mempool_accept_wtxid.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mempool_accept.py test: add script_util helper for creating bare multisig scripts 2021-10-26 14:51:18 +02:00
mempool_compatibility.py test: MiniWallet: add P2TR support and use it per default 2021-11-09 12:25:48 +01:00
mempool_expiry.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mempool_limit.py test: fix misleading fee unit in mempool_limit.py 2021-09-14 15:51:21 +02:00
mempool_package_limits.py test: Use generate* from TestFramework, not TestNode 2021-10-06 13:39:39 +02:00
mempool_package_onemore.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mempool_packages.py test: get and decode tx with a single gettransaction RPC call 2021-10-17 18:10:36 +02:00
mempool_persist.py Merge bitcoin/bitcoin#23398: rpc: add return message to savemempool RPC 2021-11-10 14:20:28 +01:00
mempool_reorg.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
mempool_resurrect.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mempool_spend_coinbase.py test: Replace MiniWallet scan_blocks with rescan_utxos 2021-09-20 08:31:04 +02:00
mempool_unbroadcast.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
mempool_updatefromblock.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mining_basic.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
mining_getblocktemplate_longpoll.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mining_prioritisetransaction.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
p2p_add_connections.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
p2p_addr_relay.py [addrman] Add Add_() inner function, fix Add() return semantics 2021-10-28 14:00:21 +01:00
p2p_addrfetch.py test: use test_framework.p2p P2P_SERVICES in functional tests 2021-09-19 14:20:48 +02:00
p2p_addrv2_relay.py [addrman] Add Add_() inner function, fix Add() return semantics 2021-10-28 14:00:21 +01:00
p2p_blockfilters.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
p2p_blocksonly.py p2p: Rename fBlocksOnly, Add test 2021-09-12 12:53:50 +02:00
p2p_compactblocks_blocksonly.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
p2p_compactblocks_hb.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_compactblocks.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_disconnect_ban.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_dns_seeds.py [test] Test the delay before querying DNS seeds 2021-07-30 11:15:49 -07:00
p2p_dos_header_tree.py scripted-diff: test: rename FromHex to from_hex 2021-06-21 14:33:59 +02:00
p2p_eviction.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_feefilter.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_filter.py test: use MiniWallet for p2p_filter.py 2021-09-27 13:55:25 +02:00
p2p_fingerprint.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_getaddr_caching.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
p2p_getdata.py
p2p_i2p_ports.py test: ensure I2P ports are handled as expected 2021-07-09 11:19:37 +02:00
p2p_ibd_txrelay.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_invalid_block.py test: remove unnecessary block rehashing prior to solving 2021-11-12 18:29:43 +01:00
p2p_invalid_locator.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_invalid_messages.py log: improve addrman logging 2021-10-19 00:20:28 +02:00
p2p_invalid_tx.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_leak_tx.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_leak.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_message_capture.py test: remove type: comments in favour of actual annotations 2021-02-08 13:24:44 +08:00
p2p_nobloomfilter_messages.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_node_network_limited.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
p2p_permissions.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_ping.py p2p: Use mocktime for ping timeout 2021-10-07 13:22:02 +02:00
p2p_segwit.py test: remove unnecessary block rehashing prior to solving 2021-11-12 18:29:43 +01:00
p2p_sendheaders.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
p2p_timeouts.py net: use peer=N instead of from=N in debug log 2021-01-28 16:04:04 +10:00
p2p_tx_download.py test: introduce tx_from_hex helper for tx deserialization 2021-06-21 14:28:05 +02:00
p2p_unrequested_blocks.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
README.md Enable TLS in links in documentation 2021-09-16 22:00:20 +00:00
rpc_bind.py
rpc_blockchain.py test: generate blocks to MiniWallet address in rpc_blockchain.py 2021-11-09 12:24:48 +01:00
rpc_createmultisig.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_decodescript.py test: refactor: remove hex_str_to_bytes helper 2021-08-01 19:26:51 +02:00
rpc_deprecated.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_deriveaddresses.py
rpc_dumptxoutset.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_estimatefee.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
rpc_fundrawtransaction.py Merge bitcoin/bitcoin#23300: test: Implicitly sync after generate*, unless opted out 2021-11-09 09:58:51 +01:00
rpc_generate.py
rpc_generateblock.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_getblockfilter.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
rpc_getblockstats.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_getchaintips.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
rpc_getdescriptorinfo.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_help.py rpc: add external signer RPC files 2021-02-23 14:34:30 +01:00
rpc_invalid_address_message.py Make explicit the node param in init_wallet() 2021-10-20 00:30:28 -03:00
rpc_invalidateblock.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
rpc_misc.py blockstorage: use debug log category 2021-10-11 21:45:49 +10:00
rpc_named_arguments.py
rpc_net.py Merge bitcoin/bitcoin#22872: log: improve checkaddrman logging with duration in milliseconds 2021-11-10 17:38:45 +01:00
rpc_packages.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_preciousblock.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
rpc_psbt.py Fix intermittent test failures due to missing sync_all 2021-10-06 12:19:04 +13:00
rpc_rawtransaction.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_scantxoutset.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_setban.py style: remove () from assert in rpc_setban.py 2021-06-21 15:29:28 +02:00
rpc_signer.py Add syscall sandboxing (seccomp-bpf) 2021-10-01 13:51:10 +00:00
rpc_signmessagewithprivkey.py test: added test for disabled wallet 2021-08-12 18:14:56 +05:30
rpc_signrawtransaction.py test: introduce script_util helper for creating P2PK scripts 2021-09-29 14:09:14 +02:00
rpc_txoutproof.py test: Return the largest utxo in MiniWallet.get_utxo 2021-11-15 13:10:37 +01:00
rpc_uptime.py util: Disallow negative mocktime 2021-02-02 08:43:19 +00:00
rpc_users.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_whitelist.py
test_runner.py Merge bitcoin/bitcoin#23046: test: Add txindex migration test 2021-11-15 09:36:42 +01:00
test-shell.md scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
tool_wallet.py Merge bitcoin/bitcoin#23311: wallet: Use PACKAGE_NAME to mention our software 2021-10-25 15:24:00 +02:00
wallet_abandonconflict.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
wallet_address_types.py test: get and decode tx with a single gettransaction RPC call 2021-10-17 18:10:36 +02:00
wallet_avoidreuse.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_backup.py Make explicit the node param in init_wallet() 2021-10-20 00:30:28 -03:00
wallet_balance.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
wallet_basic.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
wallet_bumpfee.py test: remove unnecessary block rehashing prior to solving 2021-11-12 18:29:43 +01:00
wallet_coinbase_category.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_create_tx.py test: get and decode tx with a single gettransaction RPC call 2021-10-17 18:10:36 +02:00
wallet_createwallet.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_descriptor.py test: Use generate* node RPC, not wallet RPC 2021-10-06 13:39:44 +02:00
wallet_disable.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_dump.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_encryption.py doc: fix various typos 2021-01-04 12:31:31 +08:00
wallet_fallbackfee.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_groups.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_hd.py test: get and decode tx with a single gettransaction RPC call 2021-10-17 18:10:36 +02:00
wallet_implicitsegwit.py
wallet_import_rescan.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
wallet_import_with_label.py
wallet_importdescriptors.py Merge bitcoin/bitcoin#23287: test: get and decode tx with a single gettransaction RPC call 2021-10-21 10:07:06 +02:00
wallet_importmulti.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
wallet_importprunedfunds.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_keypool_topup.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_keypool.py Merge bitcoin/bitcoin#22949: fee: Round up fee calculation to avoid a lower than expected feerate 2021-11-05 00:08:00 +13:00
wallet_labels.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_listdescriptors.py Make explicit the node param in init_wallet() 2021-10-20 00:30:28 -03:00
wallet_listreceivedby.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_listsinceblock.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
wallet_listtransactions.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
wallet_multisig_descriptor_psbt.py depends, wallet: fix typos 2021-11-13 20:05:56 +02:00
wallet_multiwallet.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
wallet_orphanedreward.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
wallet_reorgsrestore.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
wallet_resendwallettransactions.py test: remove unnecessary block rehashing prior to solving 2021-11-12 18:29:43 +01:00
wallet_send.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
wallet_signer.py Add syscall sandboxing (seccomp-bpf) 2021-10-01 13:51:10 +00:00
wallet_signmessagewithaddress.py test: added test for disabled wallet 2021-08-12 18:14:56 +05:30
wallet_startup.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_taproot.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
wallet_transactiontime_rescan.py test: Use generate* from TestFramework, not TestNode 2021-10-06 13:39:39 +02:00
wallet_txn_clone.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
wallet_txn_doublespend.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
wallet_upgradewallet.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
wallet_watchonly.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x50=1250 BTC) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: