mirrors/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2024-11-19 18:09:47 +01:00
Code Issues Projects Releases Wiki Activity

test: Drop 22.x node from TxindexCompatibilityTest

Browse Source 
* The node was only used to migrate the legacy txindex. But now that it
  is known to be working and that 22.x is EOL, it can be dropped.
* Also, fix a typo to properly check the txindex of node [1], not [2].
This commit is contained in:
MarcoFalke 2023-07-12 14:52:52 +02:00
parent fa7f65b0f8
commit faba4fc325
No known key found for this signature in database
1 changed files with 5 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
test/functional/feature_txindex_compatibility.py
View File

@ -11,16 +11,16 @@ import os
import shutil import shutil
from test_framework.test_framework import BitcoinTestFramework from test_framework.test_framework import BitcoinTestFramework
from test_framework.util import assert_raises_rpc_error
from test_framework.wallet import MiniWallet from test_framework.wallet import MiniWallet
class TxindexCompatibilityTest(BitcoinTestFramework): class TxindexCompatibilityTest(BitcoinTestFramework):
def set_test_params(self): def set_test_params(self):
self.num_nodes = 3 self.num_nodes = 2
self.extra_args = [ self.extra_args = [
["-reindex", "-txindex"], ["-reindex", "-txindex"],
[], [],
[],
] ]
def skip_test_if_missing_module(self): def skip_test_if_missing_module(self):
@ -33,12 +33,10 @@ class TxindexCompatibilityTest(BitcoinTestFramework):
versions=[ versions=[
160300, # Last release with legacy txindex 160300, # Last release with legacy txindex
None, # For MiniWallet, without migration code None, # For MiniWallet, without migration code
220000, # Last release with migration code (0.17.x - 22.x)
], ],
) )
self.start_nodes() self.start_nodes()
self.connect_nodes(0, 1) self.connect_nodes(0, 1)
self.connect_nodes(1, 2)
def run_test(self): def run_test(self):
mini_wallet = MiniWallet(self.nodes[1]) mini_wallet = MiniWallet(self.nodes[1])
@ -47,22 +45,12 @@ class TxindexCompatibilityTest(BitcoinTestFramework):
self.generate(self.nodes[1], 1) self.generate(self.nodes[1], 1)
self.log.info("Check legacy txindex") self.log.info("Check legacy txindex")
assert_raises_rpc_error(-5, "Use -txindex", lambda: self.nodes[1].getrawtransaction(txid=spend_utxo["txid"]))
self.nodes[0].getrawtransaction(txid=spend_utxo["txid"]) # Requires -txindex self.nodes[0].getrawtransaction(txid=spend_utxo["txid"]) # Requires -txindex
self.stop_nodes() self.stop_nodes()
legacy_chain_dir = self.nodes[0].chain_path legacy_chain_dir = self.nodes[0].chain_path
self.log.info("Migrate legacy txindex")
migrate_chain_dir = self.nodes[2].chain_path
shutil.rmtree(migrate_chain_dir)
shutil.copytree(legacy_chain_dir, migrate_chain_dir)
with self.nodes[2].assert_debug_log([
"Upgrading txindex database...",
"txindex is enabled at height 200",
]):
self.start_node(2, extra_args=["-txindex"])
self.nodes[2].getrawtransaction(txid=spend_utxo["txid"]) # Requires -txindex
self.log.info("Drop legacy txindex") self.log.info("Drop legacy txindex")
drop_index_chain_dir = self.nodes[1].chain_path drop_index_chain_dir = self.nodes[1].chain_path
shutil.rmtree(drop_index_chain_dir) shutil.rmtree(drop_index_chain_dir)
@ -73,16 +61,14 @@ class TxindexCompatibilityTest(BitcoinTestFramework):
) )
# Build txindex from scratch and check there is no error this time # Build txindex from scratch and check there is no error this time
self.start_node(1, extra_args=["-txindex"]) self.start_node(1, extra_args=["-txindex"])
self.nodes[2].getrawtransaction(txid=spend_utxo["txid"]) # Requires -txindex self.wait_until(lambda: self.nodes[1].getindexinfo()["txindex"]["synced"] == True)
self.nodes[1].getrawtransaction(txid=spend_utxo["txid"]) # Requires -txindex
self.stop_nodes() self.stop_nodes()
self.log.info("Check migrated txindex cannot be read by legacy node") self.log.info("Check migrated txindex cannot be read by legacy node")
err_msg = f": You need to rebuild the database using -reindex to change -txindex.{os.linesep}Please restart with -reindex or -reindex-chainstate to recover." err_msg = f": You need to rebuild the database using -reindex to change -txindex.{os.linesep}Please restart with -reindex or -reindex-chainstate to recover."
shutil.rmtree(legacy_chain_dir) shutil.rmtree(legacy_chain_dir)
shutil.copytree(migrate_chain_dir, legacy_chain_dir)
self.nodes[0].assert_start_raises_init_error(extra_args=["-txindex"], expected_msg=err_msg)
shutil.rmtree(legacy_chain_dir)
shutil.copytree(drop_index_chain_dir, legacy_chain_dir) shutil.copytree(drop_index_chain_dir, legacy_chain_dir)
self.nodes[0].assert_start_raises_init_error(extra_args=["-txindex"], expected_msg=err_msg) self.nodes[0].assert_start_raises_init_error(extra_args=["-txindex"], expected_msg=err_msg)