From faba4fc3257c0e7d7bcb5146dab07ffe3193744b Mon Sep 17 00:00:00 2001
From: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
Date: Wed, 12 Jul 2023 14:52:52 +0200
Subject: [PATCH] test: Drop 22.x node from TxindexCompatibilityTest

* The node was only used to migrate the legacy txindex. But now that it
  is known to be working and that 22.x is EOL, it can be dropped.
* Also, fix a typo to properly check the txindex of node [1], not [2].
---
 .../feature_txindex_compatibility.py          | 24 ++++---------------
 1 file changed, 5 insertions(+), 19 deletions(-)

diff --git a/test/functional/feature_txindex_compatibility.py b/test/functional/feature_txindex_compatibility.py
index a5b25cbd717..572e12df138 100755
--- a/test/functional/feature_txindex_compatibility.py
+++ b/test/functional/feature_txindex_compatibility.py
@@ -11,16 +11,16 @@ import os
 import shutil
 
 from test_framework.test_framework import BitcoinTestFramework
+from test_framework.util import assert_raises_rpc_error
 from test_framework.wallet import MiniWallet
 
 
 class TxindexCompatibilityTest(BitcoinTestFramework):
     def set_test_params(self):
-        self.num_nodes = 3
+        self.num_nodes = 2
         self.extra_args = [
             ["-reindex", "-txindex"],
             [],
-            [],
         ]
 
     def skip_test_if_missing_module(self):
@@ -33,12 +33,10 @@ class TxindexCompatibilityTest(BitcoinTestFramework):
             versions=[
                 160300,  # Last release with legacy txindex
                 None,  # For MiniWallet, without migration code
-                220000,  # Last release with migration code (0.17.x - 22.x)
             ],
         )
         self.start_nodes()
         self.connect_nodes(0, 1)
-        self.connect_nodes(1, 2)
 
     def run_test(self):
         mini_wallet = MiniWallet(self.nodes[1])
@@ -47,22 +45,12 @@ class TxindexCompatibilityTest(BitcoinTestFramework):
         self.generate(self.nodes[1], 1)
 
         self.log.info("Check legacy txindex")
+        assert_raises_rpc_error(-5, "Use -txindex", lambda: self.nodes[1].getrawtransaction(txid=spend_utxo["txid"]))
         self.nodes[0].getrawtransaction(txid=spend_utxo["txid"])  # Requires -txindex
 
         self.stop_nodes()
         legacy_chain_dir = self.nodes[0].chain_path
 
-        self.log.info("Migrate legacy txindex")
-        migrate_chain_dir = self.nodes[2].chain_path
-        shutil.rmtree(migrate_chain_dir)
-        shutil.copytree(legacy_chain_dir, migrate_chain_dir)
-        with self.nodes[2].assert_debug_log([
-                "Upgrading txindex database...",
-                "txindex is enabled at height 200",
-        ]):
-            self.start_node(2, extra_args=["-txindex"])
-        self.nodes[2].getrawtransaction(txid=spend_utxo["txid"])  # Requires -txindex
-
         self.log.info("Drop legacy txindex")
         drop_index_chain_dir = self.nodes[1].chain_path
         shutil.rmtree(drop_index_chain_dir)
@@ -73,16 +61,14 @@ class TxindexCompatibilityTest(BitcoinTestFramework):
         )
         # Build txindex from scratch and check there is no error this time
         self.start_node(1, extra_args=["-txindex"])
-        self.nodes[2].getrawtransaction(txid=spend_utxo["txid"])  # Requires -txindex
+        self.wait_until(lambda: self.nodes[1].getindexinfo()["txindex"]["synced"] == True)
+        self.nodes[1].getrawtransaction(txid=spend_utxo["txid"])  # Requires -txindex
 
         self.stop_nodes()
 
         self.log.info("Check migrated txindex cannot be read by legacy node")
         err_msg = f": You need to rebuild the database using -reindex to change -txindex.{os.linesep}Please restart with -reindex or -reindex-chainstate to recover."
         shutil.rmtree(legacy_chain_dir)
-        shutil.copytree(migrate_chain_dir, legacy_chain_dir)
-        self.nodes[0].assert_start_raises_init_error(extra_args=["-txindex"], expected_msg=err_msg)
-        shutil.rmtree(legacy_chain_dir)
         shutil.copytree(drop_index_chain_dir, legacy_chain_dir)
         self.nodes[0].assert_start_raises_init_error(extra_args=["-txindex"], expected_msg=err_msg)