Commit Graph

17400 Commits

Author SHA1 Message Date
HenrikJannsen
dbd1098ebb
Add isCloneOfferViewActivated flag to avoid repeated code execution in doActivate.
Do not create a new observableArrayList in filterPaymentAccounts.

The reason why the wrong account gets selected is not completely clear to me. The selection handler gets called when the combobox gets filled and that overwrites the selected account from the data. It seems that the new observableArrayList in filterPaymentAccounts triggered that un-expected behaviour.
2023-05-20 08:31:52 +02:00
HenrikJannsen
8c37ddd57b
Use trigger price from model instead from sourceOpenOffer
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-20 06:36:38 +02:00
HenrikJannsen
13f7b39fbd
Do not show BSQ accounts in CloneOfferView
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-13 22:55:03 +07:00
HenrikJannsen
4262e91f1f
Reapply original code from @jmacxx in AddressEntryList
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-13 22:45:39 +07:00
HenrikJannsen
b11511e037
Do not use sourceOfferPayload for extraDataMap
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-13 22:15:38 +07:00
HenrikJannsen
e6dc26a26a
Further restrict cloning
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-12 21:02:19 +07:00
HenrikJannsen
63ca40db5c
Remove code for adjusting the security deposit.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-12 19:30:27 +07:00
HenrikJannsen
f843345dcc
Use sourceOfferPayload when cloning the OfferPayload for the fields which must not get changed (like security deposit could get adjusted by the UI).
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-12 19:26:32 +07:00
HenrikJannsen
60fad3ab6c
Fix incorrect filtering of offers with shared maker fee
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-10 11:42:00 +07:00
HenrikJannsen
2651a88d5e
Do not reset addressEntries if its from cloned offers at cleanUpAddressEntries
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-05 19:42:08 +07:00
HenrikJannsen
13bcfb3121
Use new offerId and fresh data at clone offer
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-05 19:41:24 +07:00
HenrikJannsen
d42895637f
Publish cloned offer if activated
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-05 14:19:31 +07:00
HenrikJannsen
21672a1bd0
Add clone offer tab
Change flow of cloning an offer:
We open the clone offer tab similar like the duplicate/edit offer tab. When clicking the clone button we create and publish the cloned offer. if the clone would not have changed the payment method/currency we show a popup and deactivate the offer.
At editOffer we check if the offer is using a shared maker fee and if so we check if the edit triggered same payment method/currency. If so we show a popup and deactivate the offer.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-05 13:34:03 +07:00
HenrikJannsen
4ae89e748c
Use link icon for cloned offers
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-05 11:11:58 +07:00
HenrikJannsen
384173c894
Rename translation string
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-05 10:01:57 +07:00
HenrikJannsen
a621973eed
Add translation string
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-05 09:41:05 +07:00
HenrikJannsen
8b91ed7a00
Only reset if there are no other shared maker fee offers
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-05 09:33:35 +07:00
HenrikJannsen
6036da352b
Add cloneItemColumn
Hide trigger price column if none is in list

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-04 20:25:11 +07:00
HenrikJannsen
3403b1662c
User maker fee as column name (instead of group)
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-04 20:10:38 +07:00
HenrikJannsen
992854c9b9
Various refactorings and changes
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-04 18:31:20 +07:00
HenrikJannsen
cadf2073cf
Fix updateReservedBalance.
btcWalletService.getAddressEntriesForOpenOffer() contains also OFFER_FUNDING entries.
This version minimizes the change by mapping to address and use distinct to avoid duplicate entries to be summed up.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-04 18:31:19 +07:00
HenrikJannsen
f6c31aa479
Remove added code with entryWithSameContextStillExists as it is not needed.
Multiple calls will call add on the hashset but as the entry is the same it will not trigger any change of the hashset.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-04 18:31:18 +07:00
HenrikJannsen
966b9d8448
Add getAllRecentTransactions method.
The numTransactions param in getRecentTransactions delivers all transactions if it is 0 but that is not intuitive. Passing Integer.MAX_VALUE makes more sense.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-04 18:31:18 +07:00
jmacxx
acbff2b11a
Use domain data as requested by reviewer. 2023-05-04 18:31:17 +07:00
jmacxx
e66517fb8a
Code review changes.
Pick a more user friendly name instead of OCO.
Clean up code.
2023-05-04 18:31:16 +07:00
jmacxx
27dcec00e9
Code review changes. 2023-05-04 18:31:16 +07:00
jmacxx
1cc42aef77
Bug fix. 2023-05-04 18:31:15 +07:00
jmacxx
4f08f9f383
Feat: OCO Offers 2023-05-04 18:31:15 +07:00
Alejandro García
d17749110a
Merge pull request #6670 from jmacxx/trade_fee_leniency
Allow leniency of 50% when validating trade fees.
2023-05-04 05:59:13 +00:00
Alejandro García
0e22b1c6d7
Merge pull request #6674 from HenrikJannsen/fix-accounting-filter-for-large-fees
Increase fee limit for accounting data filter.
2023-05-03 14:24:56 +00:00
HenrikJannsen
35f69232fd
Increase fee limit for accounting data filter.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-05-02 09:59:23 +07:00
jmacxx
8c05af1f0a
Allow leniency of 50% when validating trade fees. Issue #6669. 2023-04-30 14:04:03 -05:00
Christoph Atteneder
c8c256f958
Merge pull request #6666 from stejbac/fix-npe-from-burningmanview-comparators
Fix NPE from BurningManView column comparators
2023-04-24 11:01:56 +02:00
Steven Barclay
01de88b163
Slight code cleanup: BurningManView & BalanceEntryItem
1) Replace statement lambda with expression lambda;
2) Use '.iterator().next()' instead of 'new ArrayList<>(_).get(0)'.
2023-04-22 00:41:12 +01:00
Steven Barclay
c353a95cd9
Use primitive 'comparing*' comparators to avoid boxing
Replace uses of 'Comparator.comparing' with 'comparing[Double|Int|Long]'
in BurningManView, as appropriate, since it is slightly more efficient.
2023-04-22 00:29:13 +01:00
Steven Barclay
8e8d727231
Fix NPE from BurningManView column comparators
Make sure that none of the key extractor functions passed to
'Comparator.comparing(fn)' can return null, as this results in an NPE
when the corresponding column is sorted in the UI, but has blank entries
(such as the BTC received for a BSQ burn in the balance entries table).

(Make blanks appear smallest in magnitude using 'Comparator.nullsFirst'
or by defaulting to 0 instead of null, since the entries are initially
sorted biggest to smallest, pushing them to the bottom of the table.)

Also change the default sort type of the burned BSQ column, which should
be ASCENDING since the entries are negative.
2023-04-21 23:59:37 +01:00
Alejandro García
23dae954e7
Merge pull request #6662 from wiz/wiz/20230419-update-wiz-bitcoin-nodes
Update clearnet IPs for wiz's Bitcoin nodes
2023-04-21 10:24:58 +00:00
Alejandro García
1fe05c0fb9
Merge pull request #6656 from bisq-network/dependabot/github_actions/actions/checkout-3.5.2
Bump actions/checkout from 3.5.0 to 3.5.2
2023-04-21 10:22:40 +00:00
Alejandro García
6e65b2ba63
Merge pull request #6655 from bisq-network/dependabot/github_actions/gradle/gradle-build-action-2.4.2
Bump gradle/gradle-build-action from 2.4.0 to 2.4.2
2023-04-21 10:14:11 +00:00
wiz
4df4c4bc3a
Update clearnet IPs for wiz's Bitcoin nodes 2023-04-19 17:21:13 +09:00
dependabot[bot]
129944f59a
Bump actions/checkout from 3.5.0 to 3.5.2
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.0 to 3.5.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3.5.0...v3.5.2)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-17 14:58:53 +00:00
dependabot[bot]
7d5d345367
Bump gradle/gradle-build-action from 2.4.0 to 2.4.2
Bumps [gradle/gradle-build-action](https://github.com/gradle/gradle-build-action) from 2.4.0 to 2.4.2.
- [Release notes](https://github.com/gradle/gradle-build-action/releases)
- [Commits](https://github.com/gradle/gradle-build-action/compare/v2.4.0...v2.4.2)

---
updated-dependencies:
- dependency-name: gradle/gradle-build-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-17 14:58:50 +00:00
Gabriel Bernard
caab3dbe55
Merge pull request #6649 from bisq-network/release/v1.9.10
Release/v1.9.10
2023-04-17 08:15:12 +00:00
Alejandro García
3f584e32fe
Merge pull request #6652 from alvasw/remove_broken_offer_util_test_test_get_random_offer_id
OfferUtilTest: Remove broken testGetRandomOfferId test
2023-04-17 07:30:18 +00:00
Alva Swanson
d969d497bb
OfferUtilTest: Remove broken testGetRandomOfferId test 2023-04-17 17:00:29 +10:00
Alejandro García
bfad06caae
Merge pull request #6647 from HenrikJannsen/show_total_distributed_btc_fees
Show total fees and total DPT
2023-04-15 02:32:21 +00:00
Alejandro García
e8a3d92d34
Merge pull request #6646 from helixx87/api-get-all
Support "all" attribute in getoffers API method
2023-04-15 02:31:02 +00:00
Alejandro García
28bb0a60fc
Merge pull request #6641 from helixx87/6629-fix-close-button-after-offer-creation
Fix close button behaviour on successful offer creation popup
2023-04-15 02:28:41 +00:00
Alejandro García
0391be64a5
Revert to SNAPSHOT version 2023-04-15 11:59:46 +10:00
HenrikJannsen
1416b946a8
Add fields for total BTC fees and total DPT amounts
Add more data to CSV export

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-04-12 16:17:44 +07:00