Commit graph

10059 commits

Author SHA1 Message Date
Florian Reimair
d12843a74c
Merge pull request #3682 from ripcurlx/improve-account-signing
Improve account signing security
2019-11-26 12:50:12 +01:00
Florian Reimair
4c9d915031
Merge pull request #3674 from bodymindarts/fix-bsq-monetary-format
Use correct monetary format in BsqFormatter
2019-11-25 12:37:54 +01:00
Justin Carter
fe00f4aac9
Use correct monetary format in BsqFormatter
Also remove logic regarding base currency. Only BTC is currently
supported so there is no need to keep the logic around.
2019-11-24 07:59:02 +01:00
Christoph Atteneder
d12a4049ad
Merge pull request #3659 from rex4539/typos
Fix some even more typos
2019-11-22 14:12:29 +01:00
Christoph Atteneder
c0108b83af
Merge pull request #3655 from lusarz/refactor-offer-view
Refactor OfferView constructor
2019-11-22 14:11:49 +01:00
Christoph Atteneder
cb2093a54c
Merge pull request #3654 from lusarz/refactor-use-inject
Use dependency injection in FilterWindow and SendAlertMessageWindow
2019-11-22 14:10:35 +01:00
Christoph Atteneder
8ffc4b0a24
Merge pull request #3653 from lusarz/refactor-send-private-notification
Remove redundant interfaces from SendPrivateNotificationWindow
2019-11-22 14:08:39 +01:00
Dimitris Apostolou
a718c885fc
Fix typos 2019-11-22 14:05:50 +02:00
Christoph Atteneder
0ac6bf1307
Only allow seller side to sign accounts
This prevents a scammer to use publicly known account details
(without being in control of the account) as a seller to get
signed by a buyer. The money received in the seller account might
not be detected by the legitimate owner and/or the money not sent back.
30 days later the scammer could use this signed account as seed to peer sign other stolen accounts.
2019-11-22 11:32:43 +01:00
Christoph Atteneder
46ce873b01
Add additional trade amount limit for trades that qualify for account signing
Should make it easier to detect by a stolen bank account owner as buyer that an outgoing transactions is taking place.
2019-11-22 11:26:46 +01:00
Christoph Atteneder
90bf1388da
Merge pull request #3658 from bodymindarts/missing-annotations
Add missing @Named annotations for CoinFormatter injection
2019-11-22 11:11:12 +01:00
Justin Carter
88d031fdd3
Add missing @Named annotations for CoinFormatter injection 2019-11-22 11:02:40 +01:00
Christoph Atteneder
f48f9244e0
Merge pull request #3647 from rex4539/more-typos
Fix some more typos and cleanup
2019-11-21 15:16:57 +01:00
lukasz
8917df94ee
Refactor OfferView constructor 2019-11-21 15:16:38 +01:00
lukasz
f3622c280b
Use dependency injection in FilterWindow and SendAlertMessageWindow 2019-11-21 11:48:29 +01:00
lukasz
e23ad9eb71
Remove redundant interfaces from SendPrivateNotificationWindow 2019-11-21 11:28:22 +01:00
Dimitris Apostolou
594fc08035
Fix typos and cleanup 2019-11-21 11:17:48 +02:00
Christoph Atteneder
02d521aeb1
Merge pull request #3651 from stejbac/ungenerify-popup-class
Un-generify Popup class
2019-11-21 10:04:38 +01:00
Christoph Atteneder
871051f8fb
Merge pull request #3643 from rex4539/fix-typos
Fix typos and cleanup
2019-11-21 09:53:26 +01:00
Christoph Atteneder
42dfc6a158
Get monitor up to speed again (#3633)
* Updated price node list for monitor

* Price monitor is more resilient against timeouts

Recenty, a price node got removed. Unfortunately, this node
has been the first in the list of configured price nodes in
the monitor configuration.

A misplaced catch block caused the loop to stop instead of
trying the next configured price node in the list.

* Monitor selects a price node randomly

Up until now, the monitor always chose the price nodes
in their configured order. This resulted in querying
always the same node and thus, create a bigger system
load for this very node. Only in case of a failure,
the monitor moved on to another node.

Shuffling the list of nodes prior to querying provides
at least some load balancing for the price nodes.

* Fixed monitor market API query

The format of the market API response changed. Formerly,
there has been one line, now it is pretty print json.

* Add RefundAgent messages to monitor

Add the relatively new RefundAgent message to the monitor.

* Adjust monitor timeout

Observed, that a timeout of one minute works better than
the original 90 seconds.
2019-11-21 09:42:40 +01:00
Christoph Atteneder
a77c09bcc1
Remove redundant interfaces from FilterWindow and SendAlertMessageWindow (#3617)
* Refactor FilterWindow - remove redundant interfaces

* Refactor SendAlertMessageWindow - remove redundant interfaces
2019-11-21 09:32:57 +01:00
Steven Barclay
a26366ee0d
Un-generify Popup class
Remove the type parameter from Popup<T>, as it appears to have never
been used or set anywhere in the code. (This mainly involves replacing a
lot of "new Popup<>" occurrences.)
2019-11-20 21:27:11 +00:00
Dimitris Apostolou
587b55d37b
Fix typos and cleanup 2019-11-20 22:56:19 +02:00
Florian Reimair
ab214d3fe7
Merge pull request #3637 from rex4539/fix-typos
Fix typos and cleanup in documentation
2019-11-20 10:44:44 +01:00
Christoph Atteneder
928b35c7d3
Merge pull request #3635 from cbeams/upgrade-shadow-plugin
Upgrade Gradle Shadow plugin from 4.0.2 => 5.2.0
2019-11-20 10:43:45 +01:00
Florian Reimair
f6740d06a0
Merge pull request #3585 from blabno/sort-gradle-witness
Sort existing gradle-witness.gradle
2019-11-20 10:37:50 +01:00
Florian Reimair
8025cc10a1
Merge pull request #3634 from bodymindarts/coin-formatter-interface
Coin formatter interface
2019-11-20 10:28:35 +01:00
Christoph Atteneder
778e9b2b79
Implement installation path check on Windows (#3642)
* Implement installation path check on Windows

Prior to starting the installation, check if the install location
contains special characters and if so use a different default install
location as well as display a prompt to the user providing additional
details.

This is in response to #3605, for which a proper solution has yet to be
found.

* Ensure the destination location dialog is always shown

This resolves #552

* Show the Welcome dialog

Rather then potentially being greeted with the newly implemented
prompt on the destination location dialog if they have special
characters in their install path, greet the user with the Welcome
dialog when they initially launch the installer.

* Reorder/group setup items logically
2019-11-20 10:22:23 +01:00
Devin Bileck
446c80291c
Reorder/group setup items logically 2019-11-20 00:58:55 -08:00
Devin Bileck
33c611c8cc
Show the Welcome dialog
Rather then potentially being greeted with the newly implemented
prompt on the destination location dialog if they have special
characters in their install path, greet the user with the Welcome
dialog when they initially launch the installer.
2019-11-20 00:56:54 -08:00
Devin Bileck
eba7fddc0f
Ensure the destination location dialog is always shown
This resolves #552
2019-11-20 00:45:45 -08:00
Devin Bileck
0ea11ebc46
Implement installation path check on Windows
Prior to starting the installation, check if the install location
contains special characters and if so use a different default install
location as well as display a prompt to the user providing additional
details.

This is in response to #3605, for which a proper solution has yet to be
found.
2019-11-20 00:39:52 -08:00
Dimitris Apostolou
ce8804b418
Fix typos and cleanup 2019-11-20 01:24:48 +02:00
lusarz
2f6589b5e5
Refactor SendAlertMessageWindow - remove redundant interfaces 2019-11-19 18:50:21 +01:00
lusarz
ba0437e6b0
Refactor FilterWindow - remove redundant interfaces 2019-11-19 18:50:17 +01:00
Chris Beams
1a2461fcdf
Upgrade Gradle Shadow plugin from 4.0.2 => 5.2.0
After the upgrade from Gradle 4.10.2 to 5.6.4 in commit 5fe71fa0a,
all of Bisq's shadowJar tasks started failing Gradle's incremental build
checks. This meant that repeated invocations of `gradle build` went from
a handful of seconds to more than a minute, because shadowJar tasks had
to be re-executed on every build.

For example, with --info enabled, one would see entries like this in the
build output:

    > Task :seednode:shadowJar
    Custom actions are attached to task ':seednode:shadowJar'.
    Caching disabled for task ':seednode:shadowJar' because:
      Caching has not been enabled for the task
    Task ':seednode:shadowJar' is not up-to-date because:
      Output property 'archiveFile' file [...]libs/seednode.jar has changed.

This problem was solved by in johnrengelman/shadow#524 and made
available in the project's recent 5.0.2 release. This patch simply bumps
the shadow plugin version to that value, and gets us back to snappy
incremental builds, e.g.:

    $ gradle build

    BUILD SUCCESSFUL in 7s
2019-11-19 18:05:14 +01:00
Bernard Labno
37918f5df7
Sort existing gradle-witness.gradle
This should make comparison in future much easier.
2019-11-19 17:28:59 +01:00
Justin Carter
80fda1ec2c
Inject CoinFormatter via BTC_FORMATTER_KEY 2019-11-19 15:54:18 +01:00
Justin Carter
68a988b3a8
Remove dead code 2019-11-19 14:24:30 +01:00
Justin Carter
cb8873fa6d
Move BsqFormatter and ImmutableCoinFormatter under .coin package 2019-11-19 14:23:18 +01:00
Justin Carter
d23ae558e7
Rename BSFormatter to ImmutableCoinFormatter 2019-11-19 14:11:01 +01:00
Justin Carter
ed97f7a9e5
Use interface instead of class name for CoinFormatter 2019-11-19 14:00:22 +01:00
Justin Carter
d10683e192
Extract CoinFormatter interface 2019-11-19 12:30:31 +01:00
Justin Carter
2f7a924792
Remove dead code from BSFormatter 2019-11-19 12:18:10 +01:00
Florian Reimair
b0c68e0b5a
Adjust monitor timeout
Observed, that a timeout of one minute works better than
the original 90 seconds.
2019-11-19 12:12:09 +01:00
Florian Reimair
debb94f0a6
Add RefundAgent messages to monitor
Add the relatively new RefundAgent message to the monitor.
2019-11-19 12:10:55 +01:00
Florian Reimair
97586ff8dd
Fixed monitor market API query
The format of the market API response changed. Formerly,
there has been one line, now it is pretty print json.
2019-11-19 12:01:09 +01:00
Florian Reimair
edefcdb368
Monitor selects a price node randomly
Up until now, the monitor always chose the price nodes
in their configured order. This resulted in querying
always the same node and thus, create a bigger system
load for this very node. Only in case of a failure,
the monitor moved on to another node.

Shuffling the list of nodes prior to querying provides
at least some load balancing for the price nodes.
2019-11-19 11:48:58 +01:00
Florian Reimair
74b84159ca
Price monitor is more resilient against timeouts
Recenty, a price node got removed. Unfortunately, this node
has been the first in the list of configured price nodes in
the monitor configuration.

A misplaced catch block caused the loop to stop instead of
trying the next configured price node in the list.
2019-11-19 11:45:01 +01:00
Florian Reimair
cf575966dc
Updated price node list for monitor 2019-11-19 11:44:21 +01:00