mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2025-01-19 05:44:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix typos and cleanup

Browse Source
This commit is contained in:
Dimitris Apostolou 2019-11-20 22:45:45 +02:00
parent 871051f8fb
commit 594fc08035
No known key found for this signature in database
GPG Key ID: 4B5D20E938204A8A
10 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CONTRIBUTING.md
View File

@ -37,7 +37,7 @@ Anyone may participate in peer review which is expressed by comments in the pull
- `Concept ACK` means "I agree in the general principle of this pull request";
- `Nit` refers to trivial, often non-blocking issues.
Please note that Pull Requests marked `NACK` and/or Github's `Change requested` are closed after 30 days if not addressed.
Please note that Pull Requests marked `NACK` and/or GitHub's `Change requested` are closed after 30 days if not addressed.
## Compensation

2
desktop/src/main/java/bisq/desktop/components/SeparatedPhaseBars.java
View File

@ -92,7 +92,7 @@ public class SeparatedPhaseBars extends VBox {
if (totalDuration > 0) {
// We want to have a min. width for the breaks and for the phases which are important to the user but
// quite short (blind vote, vote reveal, result). If we display it correctly most of the space is
// consumed by the proposal phase. We we apply a min and max width and adjust the available width so
// consumed by the proposal phase. We apply a min and max width and adjust the available width so
// we have all phases displayed so that the text is fully readable. The proposal phase is shorter as
// it would be with correct display but we take that into account to have a better overall overview.
final double finalAvailableWidth = availableWidth;

2
desktop/src/main/java/bisq/desktop/components/TooltipUtil.java
View File

@ -37,7 +37,7 @@ public class TooltipUtil {
final Tooltip tooltip = new Tooltip(untruncatedText);
// Force tooltip to use color, as it takes in some cases the color of the parent label
// and can't be overriden by class or id
// and can't be overridden by class or id
tooltip.setStyle("-fx-text-fill: -bs-rd-tooltip-truncated;");
labeled.setTooltip(tooltip);
}

2
desktop/src/main/java/bisq/desktop/components/TxIdTextField.java
View File

@ -161,7 +161,7 @@ public class TxIdTextField extends AnchorPane {
} else {
//TODO we should show some placeholder in case of a tx which we are not aware of but which can be
// confirmed already. This is for instance the case of the other peers trade fee tx, as it is not related
// to our wallet we don't have a confidence object but we should show that it is in a unknown state instead
// to our wallet we don't have a confidence object but we should show that it is in an unknown state instead
// of not showing anything which causes confusion that the tx was not broadcasted. Best would be to request
// it from a block explorer service but that is a bit too heavy for that use case...
// Maybe a question mark with a tooltip explaining why we don't know about the confidence might be ok...

2
desktop/src/main/java/bisq/desktop/components/controlsfx/control/PopOver.java
View File

@ -561,7 +561,7 @@ public class PopOver extends PopupControl {
* Sets the value of the detached property.
*
* @param detached
* if true the pop over will change its apperance to "detached"
* if true the pop over will change its appearance to "detached"
* mode
*
* @see #detachedProperty()

6
desktop/src/main/java/bisq/desktop/components/paymentmethods/FasterPaymentsForm.java
View File

@ -44,7 +44,7 @@ public class FasterPaymentsForm extends PaymentMethodForm {
public static int addFormForBuyer(GridPane gridPane, int gridRow,
PaymentAccountPayload paymentAccountPayload) {
// do not translate as it is used in english only
// do not translate as it is used in English only
addCompactTopLabelTextField(gridPane, ++gridRow, UK_SORT_CODE,
((FasterPaymentsAccountPayload) paymentAccountPayload).getSortCode());
addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("payment.accountNr"),
@ -66,7 +66,7 @@ public class FasterPaymentsForm extends PaymentMethodForm {
@Override
public void addFormForAddAccount() {
gridRowFrom = gridRow + 1;
// do not translate as it is used in english only
// do not translate as it is used in English only
sortCodeInputTextField = FormBuilder.addInputTextField(gridPane, ++gridRow, UK_SORT_CODE);
sortCodeInputTextField.setValidator(inputValidator);
sortCodeInputTextField.setValidator(new BranchIdValidator("GB"));
@ -102,7 +102,7 @@ public class FasterPaymentsForm extends PaymentMethodForm {
fasterPaymentsAccount.getAccountName(), Layout.FIRST_ROW_AND_GROUP_DISTANCE);
addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("shared.paymentMethod"),
Res.get(fasterPaymentsAccount.getPaymentMethod().getId()));
// do not translate as it is used in english only
// do not translate as it is used in English only
addCompactTopLabelTextField(gridPane, ++gridRow, UK_SORT_CODE, fasterPaymentsAccount.getSortCode());
TextField field = addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("payment.accountNr"),
fasterPaymentsAccount.getAccountNr()).second;

2
desktop/src/main/java/bisq/desktop/components/paymentmethods/JapanBankTransferForm.java
View File

@ -219,7 +219,7 @@ public class JapanBankTransferForm extends PaymentMethodForm
String bankNameFull = StringUtils.substringAfter(bank, JapanBankData.SPACE);
if (bankNameFull != null)
{
// parse beginning as japanese bank name
// parse beginning as Japanese bank name
String bankNameJa = StringUtils.substringBefore(bankNameFull, JapanBankData.SPACE);
if (bankNameJa != null)
{

8
desktop/src/main/java/bisq/desktop/components/paymentmethods/data/JapanBankData.java
View File

@ -52,7 +52,7 @@ public class JapanBankData
Returns the main list of ~500 banks in Japan with bank codes,
but since 90%+ of people will be using one of ~30 major banks,
we hard-code those at the top for easier pull-down selection,
and add their English names in paranthesis for foreigners.
and add their English names in parenthesis for foreigners.
*/
public static List<String> prettyPrintBankList() // {{{
{
@ -863,11 +863,11 @@ public class JapanBankData
if (ja) return "入力は漢字、ひらがな、またはカタカナでなければなりません";
return "Input must be Kanji, Hiragana, or Katakana";
case "japanese.validation.regex":
// epic regex to only match japanese input
return "[" + // match any of the these characters:
// epic regex to only match Japanese input
return "[" + // match any of these characters:
// "Ａ-ｚ" + // full-width alphabet
// "０-９" + // full-width numerals
"一-龯" + // all japanese kanji (0x4e00 ~ 0x9fcf)
"一-龯" + // all Japanese kanji (0x4e00 ~ 0x9fcf)
"ぁ-ゔ" + // full-width hiragana (0x3041 ~ 0x3094)
"ァ-・" + // full-width katakana (0x30a1 ~ 0x30fb)
"ぁ-ゞ" + // half-width hiragana

2
desktop/src/main/java/bisq/desktop/util/GUIUtil.java
View File

@ -957,7 +957,7 @@ public class GUIUtil {
tableView.setVisible(false);
// We need to delay the setter to the next render frame as otherwise views don' get updated in some cases
// Not 100% clear what causes that issue, but seems the requestLayout method is not called otherwise.
// We still need to set the height immediately, otherwise some views render a incorrect layout.
// We still need to set the height immediately, otherwise some views render an incorrect layout.
tableView.setPrefHeight(height);
UserThread.execute(() -> {

2
relay/src/main/java/bisq/relay/RelayMain.java
View File

@ -40,7 +40,7 @@ public class RelayMain {
private static RelayService relayService;
static {
// Need to set default locale initially otherwise we get problems at non-english OS
// Need to set default locale initially otherwise we get problems at non-English OS
Locale.setDefault(new Locale("en", Locale.getDefault().getCountry()));
}