mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2024-11-19 18:03:12 +01:00
Code Issues Packages Projects Releases Wiki Activity
17,060 Commits 4 Branches 148 Tags 4.3 GiB
b7d1a9da22
Commit Graph

17060 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
HenrikJannsen
b7d1a9da22
Increase thread pool size at Broadcaster 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-03 19:58:29 -05:00
Alejandro García
9d820ba83e
Merge pull request #6495 from HenrikJannsen/fix_BM_collection_at_DPT 
Fix bug with calculating the miner fee for the DPT.
 2023-01-03 23:38:30 +00:00
Alejandro García
e0985c397e
Merge pull request #6494 from HenrikJannsen/fix_trade_fee_validation_for_new_BM 
Fix trade fee validation with new BM
 2023-01-03 23:37:46 +00:00
HenrikJannsen
56377d8930
Reduce DPT_MIN_REMAINDER_TO_LEGACY_BM from 50k sat to 25k sat. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-03 17:32:10 -05:00
HenrikJannsen
a296887a73
Use getActiveBurningManCandidates for fee distribution 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-03 12:08:12 -05:00
HenrikJannsen
0c4199fef4
Fix but with calculating the miner fee for the DPT. 
Add activation date for hotfix.

We used all potential BM instead only the ones who have a positive cappedBurnAmountShare.
 2023-01-03 12:07:38 -05:00
HenrikJannsen
8bde140e3d
Add all addresses of all burningman who have burned BSQ to the list of addresses who are permitted to receive trade fees. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-02 17:01:38 -05:00
Alejandro García
1d669240d8
Merge pull request #6425 from jmacxx/fix_bsq_fee_validation 
Validate BSQ fee payment using DAO tx info.
 2022-12-29 20:12:38 +00:00
jmacxx
fa6beffa49
Apply code review changes. 2022-12-29 13:57:13 -06:00
Alejandro García
681d8f972b
Merge pull request #6483 from jmacxx/fix_issue_6276 
Fix problem causing multiple offers with same ID.
 2022-12-29 15:05:20 +00:00
Alejandro García
eef7846394
Merge pull request #6487 from HenrikJannsen/reset_pending_trade_protocol_of_same_offer 
Reset pending trade protocol of same offer
 2022-12-29 15:02:36 +00:00
Alejandro García
2298d126d9
Merge pull request #6478 from HenrikJannsen/seednodes 
Seednode improvements for monitoring
 2022-12-29 14:57:35 +00:00
HenrikJannsen
42dc0b5b79
Merge branch 'add_higher_capacity_for_write_to_json_thread_pool' into seednodes 2022-12-28 12:11:05 -05:00
HenrikJannsen
5ff7be9208
Increase capacity for thread pool queue at ExportJsonFilesService 
One seed node using the ExportJsonFilesService had RejectedExecutionExceptions as before we had only permitted a thread pool queue capacity of 1.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-28 12:09:59 -05:00
HenrikJannsen
5b38e5b83b
Allow to set fullNode if isBmFullNode and rpcDataSet is true even if BurningManService.isActivated() is false. 
This allows us to run the seed nodes already in BM mode before activation

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 18:40:38 -05:00
HenrikJannsen
9a31606fea
Make codacy happy 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:11 -05:00
HenrikJannsen
e1d8d0a6a0
Make codacy happy 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:11 -05:00
HenrikJannsen
abbee20284
Remove CompletableFutureUtil 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:10 -05:00
HenrikJannsen
7f16e874d2
Improve shutdown at dao nodes 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:10 -05:00
HenrikJannsen
0b33a12c19
Change visibility, make isShutdownInProgress volatile 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:09 -05:00
HenrikJannsen
12e8b46859
Report size or faults of GetDataResponse and GetBlocksResponse. 
Remove Unspecified and use optional instead.
Add reporting for data requests and hash requests.
Report commit hash only if present.
Report messages only if an enum entry is present.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:09 -05:00
HenrikJannsen
d5b4ce275b
Add support for listeners when GetDataResponse and GetBlocksResponse are sent. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:08 -05:00
HenrikJannsen
1030f891b9
Improve/cleanup logs. 
Only log lostAllConnections after numOnConnections > 2 to avoid logs at startup

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:08 -05:00
HenrikJannsen
c3acd5fb4a
Handle OutOfMemoryError to cause a shutdown at seed node 2022-12-27 17:54:01 -05:00
HenrikJannsen
a8a0c0e725
Add custom thread pool to broadcaster 
The broadcasting consumes most of the threads but has lower priority than other messages being sent.
By separating that thread pool from the common sendMessage executor we can reduce the risk that a burst of
broadcasts exhausts the thread pool and might drop send message tasks.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:33:39 -05:00
HenrikJannsen
d5b65fe239
Reduce keepAliveTime to 30 sec. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:31:07 -05:00
HenrikJannsen
7953e35395
Add executor parameter to sendMessage 
Add try/catch to handle RejectedExecutionException

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:13:13 -05:00
HenrikJannsen
e0f4aa281a
Catch RejectedExecutionException at UncaughtExceptionHandler and log error instead calling the uncaughtExceptionHandler 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:11:38 -05:00
HenrikJannsen
3f4a069202
Add reset method to trade protocol. 
Add map for maintaining pending protocols by offerID.

Fixes a bug when the same taker got an early failure in a take offer attempt before the maker removes the offer and the taker did not persist the failed trade, thus the protection to not be permitted to take the same offer after a failure does not prevent another take offer attempt of the same taker. In such a case the maker has the old pending protocol listening for the trade messages and both the old and new protocol instance process those messages. In case the model data has changes (e.g. diff. inputs) this can cause a failed trade.
We do not remove the message listeners on failures to tolerate minor failures which can be recovered by resend routines.
There could be more solid fixes for that issue but this approach seems to carry less risks.
 2022-12-26 14:07:14 -05:00
HenrikJannsen
72b55f429a
Move log before super handler to maintain correct order of logs 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-26 12:30:07 -05:00
Christoph Atteneder
4c237dcf0d
Merge pull request #6472 from bisq-network/dependabot/github_actions/actions/checkout-3.2.0 
Bump actions/checkout from 3.1.0 to 3.2.0
 2022-12-26 15:43:25 +01:00
Christoph Atteneder
e419221336
Merge pull request #6482 from bisq-network/release/v1.9.8 
Release/v1.9.8
 2022-12-26 15:42:40 +01:00
Christoph Atteneder
a3f9cb3084
Merge pull request #6471 from bisq-network/dependabot/github_actions/actions/setup-java-3.9.0 
Bump actions/setup-java from 3.8.0 to 3.9.0
 2022-12-26 15:40:39 +01:00
jmacxx
bb17429588
Fix problem causing multiple offers with same ID. 2022-12-23 14:49:14 -06:00
Christoph Atteneder
2e244c8e26
Remove unused signing key 2022-12-23 19:05:18 +01:00
Christoph Atteneder
fae711e765
Revert to SNAPSHOT version 2022-12-23 19:04:16 +01:00
Bisq GitHub Admin
3435121028
Merge pull request #6477 from ripcurlx/fix-cli-and-daemon-distribution 
Add back distribution tar generation for daemon and cli
 2022-12-22 10:38:28 +01:00
Bisq GitHub Admin
5340ce1de8
Merge pull request #6476 from ripcurlx/fix-key-derivation-for-wallet-password 
[v1.9.7] Wallet password broken: Not use additional `-%d` in name format because of refactoring
 2022-12-22 10:38:03 +01:00
Christoph Atteneder
d27e958fa1
Merge pull request #6481 from HenrikJannsen/increase_queue_capacity_at_thread_pools 
Increase queue capacity from 10 to 30.
 2022-12-22 08:46:25 +01:00
HenrikJannsen
4a72c27fa0
Increase queue capacity from 10 to 30. 
https://github.com/bisq-network/bisq/issues/6480 reported reaching the limit with the current settings.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-22 08:46:02 +01:00
Christoph Atteneder
cdb9fe44c1
Bump version number for v1.9.8 2022-12-22 08:44:13 +01:00
HenrikJannsen
59073274fc
Increase queue capacity from 10 to 30. 
https://github.com/bisq-network/bisq/issues/6480 reported reaching the limit with the current settings.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-21 19:53:51 -05:00
Christoph Atteneder
d1a2811589
Add back distribution tar generation for daemon and cli 
This is required in finalize.sh script for creating the release bundle
 2022-12-20 19:43:29 +01:00
HenrikJannsen
4fb0420712
Remove price node and seed nodes of @miker and @mrosseel 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-20 19:40:59 +01:00
Christoph Atteneder
d47d84dede
Merge pull request #6479 from HenrikJannsen/remove_seed_nodes_and_price_node 
Remove price node and seed nodes of @miker and @mrosseel
 2022-12-20 19:40:42 +01:00
HenrikJannsen
e1b332c32d
Remove price node and seed nodes of @miker and @mrosseel 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-20 12:55:57 -05:00
Christoph Atteneder
9e3b28bf0f
Add back distribution tar generation for daemon and cli 
This is required in finalize.sh script for creating the release bundle
 2022-12-20 13:32:27 +01:00
Christoph Atteneder
d99452c978
Not use additional -%d in name format because of refactoring 2022-12-20 11:36:42 +01:00
Christoph Atteneder
a726d826c8
Not use additional -%d in name format because of refactoring 2022-12-20 11:29:14 +01:00
HenrikJannsen
30afccb2d6
Use ThreadPoolExecutor with custom set queueCapacity instead of CachedThreadPool 
The previously used newCachedThreadPool carries higher risk for execution exceptions if exceeded.

Originally we had only one executor with a corePoolSize of 15 and a maximumPoolSize of 30 and queueCapacity was set to maximumPoolSize.
This was risky when the 15 corePool threads have been busy and new messages or connection creation threads are
queued up with potentially significant delay until getting served leading to timeouts.
Now we use (if maxConnections is 12) corePoolSize of 24, maximumPoolSize 36 and queueCapacity 10. This gives
considerable headroom. We also have split up the executors in 2 distinct ones.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 16:50:55 +01:00