Commit Graph

12625 Commits

Author SHA1 Message Date
Christoph Atteneder
9946496646
Merge pull request #4647 from chimp1984/persist-seen-mediator-warnings
Persist seen mediator warnings
2020-10-15 09:10:19 +02:00
chimp1984
fc875240ab
Add dont show again check box to validation exception popups 2020-10-14 09:59:10 -05:00
chimp1984
feb4e5230f
Use toString for NullPointerException 2020-10-14 09:52:53 -05:00
Mike Rosseel
58f5066e0a
Resolve conflict in 'core/src/main/resources/btc_mainnet.seednodes'. 2020-10-14 15:15:30 +02:00
wiz
866b227fcc
Replace emzy's v2 seednodes with new v3 seednodes 2020-10-14 12:54:25 +02:00
sqrrm
c41bfd7164
Merge pull request #4643 from chimp1984/add-get-inventory-msg
Add GetInventory messages
2020-10-14 12:22:00 +02:00
sqrrm
8ed83cab00
Merge pull request #4642 from chimp1984/change-handling-of-trade-stats-in-data-response
Change data response behaviour
2020-10-14 11:28:11 +02:00
chimp1984
32b953b61a
Improve GetInventoryRequester and GetInventoryRequestManager 2020-10-14 02:37:00 -05:00
chimp1984
5f9d3d1f0d
Add GetInventory messages
This will be used for monitoring seed nodes.
Instead of requesting all data (we cannot request all in fact as it is too large)
we request the number of items the node has.

This code will not have any impact atm. It will be triggered once a new monitor module gets added which
will send the GetInventoryRequest to the seeds.
2020-10-13 23:30:39 -05:00
chimp1984
b0bc3d0c87
Remove lombok getter for date and rename getDate to getDateAsLong and getTradeDate to getDate. 2020-10-13 20:46:05 -05:00
chimp1984
cc5bdfaf9c
Change data response behaviour
Add DateSortedTruncatablePayload interface for TradeStatistics2

We check first if we need to truncate dateSortedTruncatablePayloads, if so we have sorted by date and truncate in the way that we receive the most recent data. We define the maxItems in the class implementing the interface (3000 for trade stats).
Later we apply the maxEntries check the combined list and if we need to truncate here as well (10 000) we have added the dateSortedTruncatablePayloads at the end so those will get truncated with higher prio.

There is also a bit wrong handling in the previous code that we check for max limits before the shouldTransmitPayloadToPeer filter. Should be fixed in another PR for master...
2020-10-13 20:31:09 -05:00
Christoph Atteneder
e30a7e041c
Merge pull request #4632 from oscarguindzberg/fixSendNonBsq
Fix send non bsq funds
2020-10-13 21:57:35 +02:00
Oscar Guindzberg
864700775b
Accept segwit addresses when sending non-BSQ funds 2020-10-13 15:14:40 -03:00
sqrrm
be08c86c18
Merge pull request #4640 from chimp1984/update-trade-stat-resource-file
Update trade stat resource file
2020-10-13 18:51:14 +02:00
chimp1984
30c77aa419
Update resource file.
Number of objects is 24 more then with 1.3.9. Seems there are still either a few duplicate
with some diverging data which should not be different or that our old code to filter
duplicates had some issues. But a difference of 24 out of 75 000 object can be ignored IMO.
2020-10-13 11:31:54 -05:00
chimp1984
b71930252f
Exclude depositTxId as it seems that leads to
duplicates (we got about 1000 objects more without excluding it,
so seems some traders had set it to null, prob. due bugs)
2020-10-13 11:29:54 -05:00
sqrrm
129eaa76c4
Merge pull request #4638 from chimp1984/fix-mediation-bug
Fix bug at mediation with old client
2020-10-13 18:20:17 +02:00
chimp1984
3b4d109652
Fix bug at mediation with old client
If dispute opener is old client the delayed payout tx is not sent in mediation case (only in refund agent cases).
At 1.4.0 we send it as well in mediation case and the mediator get a warning shown in case its missing.
To avoid that warning we check if dispute is of refund agent type and only check in that case.
This can be removed once we have enforced update to 1.4.0 (segwit will require that).
Also added checks to not add null entries in the duplicates checks.
2020-10-13 10:26:20 -05:00
Christoph Atteneder
e5dd316a0a
Merge pull request #4631 from oscarguindzberg/fixPeerGroupStop
Stop PeerGroup only if running
2020-10-13 09:26:41 +02:00
Christoph Atteneder
88f9eee75b
Merge pull request #4635 from chimp1984/fix-performance-issues-at-dump-dao-data
Change write DAO json files to disk strategy
2020-10-13 09:20:51 +02:00
chimp1984
0d469066ce
Change write json files to disk strategy
We have written all files each time at each new block which accumulated to about
1 GB of data, this led to stability issues and very high disk IO for the explorer nodes.

Now we write only the data of the new block. We also remove the deletion of all
files at startup.
The dao state is still written in a monolithic file so that cannot be optimized
but we added a new directly where we add each block named by block height.
Looking up the latest written file tells us our last persisted block.
So all that data is equivalent to the monolithic daoState data which should
be removed once the webapp devs have implemented the change to use the blocks directory.
2020-10-12 23:51:15 -05:00
Oscar Guindzberg
1c0655e2c7
Stop PeerGroup only if running 2020-10-12 17:10:39 -03:00
Christoph Atteneder
41b2e6a56d
Merge pull request #4619 from chimp1984/fix-memo-bug-issue-4616
Set memo to tx after tx creation and not on broadcast success
2020-10-12 09:12:11 +02:00
Christoph Atteneder
ee1488489e
Merge pull request #4625 from chimp1984/only-showXmrAutoConf-for-sell-offers
Only show xmr auto conf label for sell offers
2020-10-12 09:10:53 +02:00
Christoph Atteneder
1eb730a431
Merge pull request #4626 from chimp1984/avoid-duplicate-trade-stats
Use hash at conversion also for local data to avoid duplicates.
2020-10-12 09:10:11 +02:00
Christoph Atteneder
2dc7662590
Merge pull request #4627 from oscarguindzberg/fixWalletToString
Fix Wallet.toString()
2020-10-12 09:08:48 +02:00
Oscar Guindzberg
8e93e4be0b Use aesKey in Wallet.toString() 2020-10-11 20:42:53 -03:00
chimp1984
1f0590dc95
Use hash at conversion also for local data to avoid duplicates. 2020-10-11 17:16:17 -05:00
chimp1984
db10aa31aa
Only show xmr auto conf label for sell offers 2020-10-11 16:40:07 -05:00
chimp1984
4d2f1b5d43
Set memo to tx after tx creation and not on broadcast success, as broadcast success might not get called (even it is broadcast -> pending btcj bug) 2020-10-10 19:01:51 -05:00
Christoph Atteneder
3687a03695
Merge pull request #4611 from chimp1984/new-trade-statistics
New trade statistics
2020-10-09 06:43:56 +02:00
Christoph Atteneder
352d954489
Merge pull request #4610 from chimp1984/remove-address-prefix
Remove address prefix
2020-10-09 06:43:33 +02:00
chimp1984
39c8ade5ef
Cleanups: Remove outdated TODOs, fix typos 2020-10-08 22:00:57 -05:00
chimp1984
66740b7dc1
Remove unused variable 2020-10-08 19:02:51 -05:00
chimp1984
68a10cf5a1
Remove comment line 2020-10-08 18:51:24 -05:00
chimp1984
18a27e9067
Republish trade statistics from seller side if peer capability is know. This is not the case without getting PR #4609 merges as well.
We only do it for 2 weeks after planned release time as then it can be assumed that enough nodes have updated that the normal publishing will distribute the object sufficiently.
2020-10-08 18:49:15 -05:00
chimp1984
197d8c1e0d
Remove copy&past mistake 2020-10-08 18:49:15 -05:00
chimp1984
58d2f1bda9
Apply codacy suggestions
@ripcurl: The complaint about private constructors (using guice this is legit) should be removed IMO.
2020-10-08 18:49:15 -05:00
chimp1984
e95ab2a0b4
Add resource file for 1.4.0 (should be updated at release time) 2020-10-08 18:49:15 -05:00
chimp1984
17f4ae2b54
Add check that size is > LOOK_BACK_RANGE 2020-10-08 18:49:14 -05:00
chimp1984
213050c3d1
Add filter for excluding null objects 2020-10-08 18:49:14 -05:00
chimp1984
fa374b99fb
Do conversion in a thread to not block UI thread. takes about 4 seconds on my machine.
Add shutdown method to TradeStatisticsConverter and call it via TradeStatisticsManager. Now as we have a reference to TradeStatisticsConverter in we don't need the hack anymore in applyInjector.
Set log level for com.neemre.btcdcli4j.core.client.ClientConfigurator to error as there is an expected warn log because of the outdated version.
2020-10-08 18:49:14 -05:00
chimp1984
f56fe42ae1
Add injector.getInstance(TradeStatisticsConverter.class) to BisqExecutable to enforce inclusion.
Cleanups, renamings
2020-10-08 18:49:14 -05:00
chimp1984
9016cb6c32
Prune mediator and refund agent entries for all entries beside the last 100 we use for the selection algorithm. 2020-10-08 18:49:14 -05:00
chimp1984
b14266d815
Remove resource file 2020-10-08 18:49:14 -05:00
chimp1984
6766835af6
Use TradeStatistics3 in protobuf file 2020-10-08 18:49:14 -05:00
chimp1984
0e70a99c42
Adjust tests, remove tests which do not make sense anymore 2020-10-08 18:49:13 -05:00
chimp1984
52be126667
Apply TradeStatistics3 to client classes 2020-10-08 18:49:13 -05:00
chimp1984
c4a4c878b8
Apply TradeStatistics3 to TradeStatisticsManager and some related classes 2020-10-08 18:48:52 -05:00
chimp1984
98207518d6
We "hack" TradeStatistics2StorageService to fulfill our needs:
1. We do not want that initial data request/response use old trades statistics for excluded key hashes.
Thats why we return an empty map in getMap.
2. We do not read resource file as we have removed that.
3. We do not persist as we convert the existing data and re-publish as new data, or at startup we convert the old data to the new one and then delete the file.
2020-10-08 18:48:52 -05:00