mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2024-11-19 09:52:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

Apply codacy suggestions

Browse Source 
@ripcurl: The complaint about private constructors (using guice this is legit) should be removed IMO.
This commit is contained in:
chimp1984 2020-10-08 10:56:23 -05:00
parent e95ab2a0b4
commit 58d2f1bda9
No known key found for this signature in database
GPG Key ID: 9801B4EC591F90E3
3 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
desktop/src/main/java/bisq/desktop/main/dao/economy/dashboard/BsqDashboardView.java
View File

@ -121,7 +121,7 @@ public class BsqDashboardView extends ActivatableView<GridPane, Void> implements
///////////////////////////////////////////////////////////////////////////////////////////
@Inject
private BsqDashboardView(DaoFacade daoFacade,
public BsqDashboardView(DaoFacade daoFacade,
TradeStatisticsManager tradeStatisticsManager,
PriceFeedService priceFeedService,
Preferences preferences,
@ -173,7 +173,7 @@ public class BsqDashboardView extends ActivatableView<GridPane, Void> implements
marketCapTextField = addTopLabelReadOnlyTextField(root, ++gridRow,
Res.get("dao.factsAndFigures.dashboard.marketCap")).second;
availableAmountTextField = FormBuilder.addTopLabelReadOnlyTextField(root, gridRow, 1,
availableAmountTextField = addTopLabelReadOnlyTextField(root, gridRow, 1,
Res.get("dao.factsAndFigures.dashboard.availableAmount")).second;
}

3
desktop/src/test/java/bisq/desktop/main/market/trades/TradesChartsViewModelTest.java
View File

@ -64,9 +64,7 @@ public class TradesChartsViewModelTest {
TradesChartsViewModel model;
TradeStatisticsManager tradeStatisticsManager;
private static final Logger log = LoggerFactory.getLogger(TradesChartsViewModelTest.class);
DateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss");
private KeyRing keyRing;
private File dir;
OfferPayload offer = new OfferPayload(null,
0,
@ -217,7 +215,6 @@ public class TradesChartsViewModelTest {
ArrayList<Trade> trades = new ArrayList<>();
// Set predetermined time to use as "now" during test
Date test_time = dateFormat.parse("2018-01-01T00:00:05"); // Monday
/* new MockUp<System>() {
@Mock
long currentTimeMillis() {

6
monitor/src/main/java/bisq/monitor/metric/P2PSeedNodeSnapshot.java
View File

@ -233,9 +233,9 @@ public class P2PSeedNodeSnapshot extends P2PSeedNodeSnapshotBase {
int oldest = (int) nodeAddressTupleMap.values().stream().min(Comparator.comparingLong(Tuple::getHeight)).get().height;
// - update queried height
if(type.contains("DaoState"))
if (type.contains("DaoState"))
daostateheight = oldest - 20;
else if(type.contains("Proposal"))
else if (type.contains("Proposal"))
proposalheight = oldest - 20;
else
blindvoteheight = oldest - 20;
@ -255,7 +255,7 @@ public class P2PSeedNodeSnapshot extends P2PSeedNodeSnapshotBase {
List<ByteBuffer> states = hitcount.entrySet().stream().sorted((o1, o2) -> o2.getValue().compareTo(o1.getValue())).map(byteBufferIntegerEntry -> byteBufferIntegerEntry.getKey()).collect(Collectors.toList());
hitcount.clear();
TradesChartsViewModelTest.java
nodeAddressTupleMap.forEach((nodeAddress, tuple) -> daoreport.put(type + "." + OnionParser.prettyPrint(nodeAddress) + ".hash", Integer.toString(Arrays.asList(states.toArray()).indexOf(ByteBuffer.wrap(tuple.hash)))));
// - report reference head