Commit Graph

6591 Commits

Author SHA1 Message Date
Christoph Atteneder
d12a13b1a1
Merge pull request #6069 from jmacxx/5396_privacy_enhancement
[1.8.3 fix] Get payment method ID from offerPayload
2022-02-21 20:22:59 +01:00
jmacxx
f3dfc14779
Get payment method ID from offerPayload.
Was getting an NPE with closed trades older than v1.7.0.
makerPaymentMethodId was new at that point (null for older trades).
makerPaymentAccountPayload can be null for trades where we have
removed account info for privacy reasons (see #6001).
The payment method ID can always be obtained from offerPayload.
2022-02-21 10:59:32 -06:00
jmacxx
99be324aba
Improve BSQ swap error messaging.
Re-enable popup warning indicating when DAO needs to be resynced.
2022-02-21 14:50:41 +01:00
Christoph Atteneder
b739b4c347
Merge pull request #6063 from jmacxx/bsq_swap_improve_dao_errmsg
Improve BSQ swap error messaging & DAO resync popup.
2022-02-21 14:50:31 +01:00
xyzmaker123
5e0ebf163d
Fix bug with text rendering on trade step info 2022-02-21 14:49:53 +01:00
ghubstan
66c04bdf3d
Adjust core.api to new .proto *Pct field names 2022-02-20 15:19:32 -03:00
xyzmaker123
3b966d8740
Fix bug with text rendering on trade step info 2022-02-20 10:13:56 +01:00
jmacxx
a302380e1e
Improve BSQ swap error messaging.
Re-enable popup warning indicating when DAO needs to be resynced.
2022-02-19 22:15:13 -06:00
ghubstan
a0b68bc756
Adjust .proto wrappers to price & volume type change
Some minor refactoring included.
2022-02-19 15:09:16 -03:00
ghubstan
d42c58073f
Change OfferInfo proto's volume fields' type to string 2022-02-18 16:43:23 -03:00
ghubstan
a5fc4b7d52
Get fee from dao state service if JFX prop filterManager.getFilter is null 2022-02-18 17:07:41 +01:00
Christoph Atteneder
aaac08202e
Merge pull request #6052 from ghubstan/alt-fix-feeservice-npe-in-api
Fix API FeeService NPE (Alternate)
2022-02-18 17:07:30 +01:00
ghubstan
fafe416e85
Adjust to string triggerPrice change in API core classes. 2022-02-18 11:24:02 -03:00
ghubstan
461edff631
Change OfferInfo proto's 'price' field type to string
Much less ambiguous field value at cost of breaking backward compat in API.
2022-02-17 17:27:15 -03:00
ghubstan
6f1057a766
Include unmerged API NPE fix to FeeService class (see PR #6052) 2022-02-17 13:28:14 -03:00
Christoph Atteneder
25441814ae
Update translations for v1.8.3 2022-02-17 10:48:22 +01:00
Christoph Atteneder
12a797d9e4
Merge pull request #6053 from jmacxx/display_signed_account_age
Show signed status when applicable in Trade & Dispute info screens
2022-02-17 10:35:41 +01:00
jmacxx
b1e88e8338
Add ability to copy popup text to clipboard. 2022-02-16 19:26:37 -06:00
jmacxx
1227781d43
Show signed status when applicable in Trade & Dispute screens 2022-02-16 16:09:08 -06:00
ghubstan
84eb653366
Get fee from dao state service if JFX prop filterManager.getFilter is null 2022-02-16 14:27:05 -03:00
Christoph Atteneder
d671b6805a
Merge pull request #6032 from jmacxx/sign_verify_msg_dao
Sign/Verify message for DAO bonded roles
2022-02-15 21:01:21 +01:00
Christoph Atteneder
3f978252ac
Merge pull request #6040 from jmacxx/fix_bsq_sending_issue
Fix issue selecting specific BSQ UTXO for send.
2022-02-15 21:00:20 +01:00
jmacxx
f601e0f42f
Obtain trade fee settings from filter 2022-02-15 13:23:33 -06:00
jmacxx
518ca6e0c3
Fix issue selecting specific BSQ UTX for send.
The BisqDefaultCoinSelector is invoked multiple times when a
transaction is being built.  Problem was that the coin selection
was being reset within, ultimately leading to coin selection
being completely ignored.  Solution is to reset the selection
after the transaction has been built.

The UI for selecting UTXO inputs was being resized to the number
of UTXO available, which caused problems when there is a large
UTXO set.  Solution is to size the UI to accomodate 3 to 15 rows,
which provides a reasonable screen display and a scrollbar is
provided for the case of a large UTXO set.
2022-02-11 11:15:27 -06:00
jmacxx
5e7e1c5704
Sign/Verify message for DAO bonded roles 2022-02-10 20:45:43 -06:00
Christoph Atteneder
4e225738c8
Not keep empty translation key 2022-02-09 10:56:53 +01:00
xyzmaker123
9831d19849
Update "get help" message
Co-authored-by: m52go <735155+m52go@users.noreply.github.com>
2022-02-08 09:44:26 +01:00
xyzmaker123
469f589582
Update "still not resolved" message
Co-authored-by: m52go <735155+m52go@users.noreply.github.com>
2022-02-08 09:44:25 +01:00
xyzmaker123
19d6b2607c
Add support/help links on the UI - trade details 2022-02-08 09:44:23 +01:00
xyzmaker123
90c2bfa651
Introduce SimpleMarkdownLabel 2022-02-08 09:44:17 +01:00
Christoph Atteneder
9c70a8a62a
Merge pull request #6029 from jmacxx/fix_issue_5877
Fix unhandled exception when locale specifies unknown country/region code.
2022-02-07 21:56:14 +01:00
Christoph Atteneder
ee33feeff7
Merge pull request #6018 from jmacxx/fix_OutOfSyncBsqBlocks
Fix exception: heightOfLastBlock must match chainHeight
2022-02-07 10:28:45 +01:00
Christoph Atteneder
5e7ac77d69
Merge pull request #6005 from w0000000t/keybase_>_matrix
Remove references to keybase and switch to Matrix
2022-02-07 10:26:24 +01:00
jmacxx
78e9ed2382
Fix NPE when locale specifies unknown country code. 2022-02-05 11:21:59 -06:00
jmacxx
5c48a289a6
Warn and prompt for password before showing wallet keys. 2022-02-02 18:38:35 -06:00
WAT
7b191a4049
Remove references to keybase and switch to Matrix
Except `dao.bond.bondedRoleType.ROCKET_CHAT_ADMIN` which refers to an
unused role, every other instance of `keybase` has been contextually
updated to Matrix (bisq.chat); functions to display moderator name
and profile address on keybase have been updated to work with Matrix
usernames and urls.
Kept translated resources in original state as per jmacxx suggestion.
2022-02-02 16:57:06 +01:00
jmacxx
33644b0983
Fix exception: heightOfLastBlock must match chainHeight 2022-02-01 22:10:22 -06:00
Christoph Atteneder
fcb13ed772
Merge pull request #5976 from ghubstan/1-gettrades
Add API 'gettrades' method
2022-02-01 11:10:45 +01:00
jmacxx
57821b7474
Clear account payload info & chats from closed trades & disputes. 2022-01-31 14:58:22 -06:00
ghubstan
820642516a
Remove unnecessary casts 2022-01-27 17:27:20 -03:00
ghubstan
ad638e33cd
Revert "Sort API gettrades's response list by trade date"
This reverts commit f231aacb31.

Sorting cumulative trade history lists should be done once, in GrpcTradesService.
2022-01-27 16:36:14 -03:00
ghubstan
f231aacb31
Sort API gettrades's response list by trade date 2022-01-26 11:43:31 -03:00
Christoph Atteneder
ffd2a92ae9
Merge pull request #5963 from xyzmaker123/transactions-filtering
Add missing filtering on lists
2022-01-26 09:59:53 +01:00
ghubstan
4c8cec54f3
Push Trade->TradeModel mapping down from CoreApi into CoreTradesService 2022-01-25 19:11:24 -03:00
ghubstan
4ab4c3d213
Log exception and return "Not Available" when trade role cannot be found 2022-01-25 12:21:22 -03:00
ghubstan
d902e77710
Add Bisq license banners 2022-01-25 11:44:42 -03:00
Christoph Atteneder
9be361aa08
Merge pull request #5987 from xyzmaker123/refactor-remove-unused-classes
Cleanup: remove unused classes
2022-01-25 11:36:27 +01:00
xyzmaker123
669bc88900
Remove unused classes 2022-01-25 11:18:14 +01:00
xyzmaker123
752606d788
Add missing filtering on lists - adapt PendingTradesView to use FilterBox 2022-01-24 17:20:02 +01:00
sqrrm
f315bd299e
Merge pull request #5993 from bisq-network/release/v1.8.2
Release/v1.8.2
2022-01-24 16:26:35 +01:00
Christoph Atteneder
ded4c072cb
Merge pull request #5965 from MwithM/patch-2
Include penalty for exceeding transfer limits
2022-01-24 10:30:18 +01:00
ghubstan
3e14bd3fbe
Change var name 2022-01-23 17:05:55 -03:00
ghubstan
0e020e8987
Add payout fields to trade proto msgs, show optional trade/tx fees in swaps 2022-01-23 17:03:43 -03:00
ghubstan
fadaaf9151
Display tx-fee from BsqSwapProtocolModel 2022-01-22 16:22:41 -03:00
ghubstan
6e0299642e
Fill out gettrades-help.txt 2022-01-22 16:03:34 -03:00
ghubstan
69e6c9ce70
Remove duplicated buyer/seller proto fields (already exist no OfferInfo) 2022-01-20 16:50:08 -03:00
ghubstan
2e7346a695
Fix comments 2022-01-20 15:54:19 -03:00
Christoph Atteneder
fd42c4507d
Merge pull request #5966 from jmacxx/tor_bridges_fix
Tor bridges preferences fix
2022-01-20 18:15:17 +01:00
Christoph Atteneder
300b4aa613
Merge pull request #5975 from ripcurlx/update-data-stores-for-v1.8.1
Update data stores for v1.8.1
2022-01-20 18:12:18 +01:00
Christoph Atteneder
58dca6fd1b
Merge pull request #5981 from Emzy/master
update hostname of BSQ explorer mempool.emzy.de
2022-01-20 09:49:50 +01:00
Christoph Atteneder
638d638d25
Use isFiat method for checking if it is a fiat method 2022-01-20 09:48:13 +01:00
Christoph Atteneder
cad973efd1
Not create and publish account age witnesses for BSQ swap accounts 2022-01-20 09:48:02 +01:00
Stephan Oeste
6637806019
update hostname ob BSQ explorer
The new version 2.3.0 of mempool.space supports BSQ exporer only on a separate domain.
update URL to http://bisq.mempool.emzy.de/....

There is a redirect from the old location to the new one. 
So nothing is broken and the PR is low prio.
2022-01-19 17:32:49 +01:00
Christoph Atteneder
5e158e8300
Use isFiat method for checking if it is a fiat method 2022-01-19 16:55:09 +01:00
ghubstan
3cd1e05a9f
Try to display accurate status of closed trades, or "Pending" if still open 2022-01-18 13:01:42 -03:00
Christoph Atteneder
b7af53d22f
Update bitcoinj checkpoints for v1.8.1 2022-01-18 11:33:16 +01:00
Christoph Atteneder
1f22f89bb4
Not create and publish account age witnesses for BSQ swap accounts 2022-01-18 11:29:41 +01:00
ghubstan
d98d795c77
Add server impl for gettrades (open|closed), refactor getrole methods 2022-01-16 16:46:45 -03:00
ghubstan
fdd94fe1f2
Remove commented code 2022-01-16 16:44:18 -03:00
ghubstan
a9e7484aee
Add buyer/seller dep & status-desc fields to TradeInfo 2022-01-16 16:43:34 -03:00
ghubstan
5c217793c8
Add buyer/seller dep & status-desc fields to TradeInfoV1Builder 2022-01-16 16:42:34 -03:00
ghubstan
a53fee345f
Add List<OpenOffer> getCanceledOpenOffers() ClosedTradableManager 2022-01-16 16:41:53 -03:00
ghubstan
50bbbfe6c4
Add List<Trade> getTrades() to TradeManager (w/out transitive jfx dep) 2022-01-16 16:41:09 -03:00
ghubstan
b4fa52f4e4
Add List<Trade> getTrades() to FailedTradesManager (w/out transitive jfx dep) 2022-01-16 16:39:07 -03:00
jmacxx
684fd39c75
Force persistence write when editing Tor Bridge settings.
This is necessary because Tor settings are edited before the app has
completed startup and normally persistence is prohibited.
2022-01-16 11:52:44 -06:00
MwithM
7d1e8a1649
Include penalty for exceeding transfer limits
Nequi payment method did not include that there might be a penalty for exceeding the transfer limits. I have used the same wording for every payment method.
2022-01-13 20:01:21 +01:00
Christoph Atteneder
efac836fa2
Update translations for v1.8.1 2022-01-12 10:54:00 +01:00
Christoph Atteneder
63a241a64e
Remove unused translation keys 2022-01-12 10:47:11 +01:00
Bisq GitHub Admin
808c3ad9d9
Merge pull request #5930 from xyzmaker123/modify-accepted-countries
SEPA Account - editable account name and accepted countries
2022-01-12 10:32:20 +01:00
Bisq GitHub Admin
8401b3885b
Merge pull request #5870 from jmacxx/mediation_payout_ux
Improve user experience once mediation has been accepted by both parties
2022-01-12 10:23:02 +01:00
Bisq GitHub Admin
ddead5ef54
Merge pull request #5953 from jmacxx/logs_upload
Feature enabling log file upload to mediators
2022-01-12 09:41:32 +01:00
jmacxx
d9ad531b3c
Fix issue of space in file path 2022-01-11 09:23:49 -06:00
Christoph Atteneder
a1d0e570d1
Apply minor improvements and clean-ups 2022-01-11 12:36:44 +01:00
Christoph Atteneder
310b9a97f2
Merge pull request #5949 from jmacxx/fix_trade_fee_validation
Fix trade fee validation bug
2022-01-11 11:09:09 +01:00
Christoph Atteneder
4a3e29daf5
Improve wording of trade completed notification popups 2022-01-11 11:02:55 +01:00
Christoph Atteneder
9759cebc4d
Remove unused translations 2022-01-11 10:48:06 +01:00
Christoph Atteneder
5c26c635e5
Merge pull request #5961 from ghubstan/2-api-fail-unfail-trade
Add API methods 'failtrade', 'unfailtrade' + test case (#2)
2022-01-10 12:29:54 +01:00
Christoph Atteneder
96878e5789
Merge pull request #5957 from jmacxx/fix_issue_5956
Wording for Bsq swap cancellation popups & withdrawal prompt
2022-01-10 12:01:33 +01:00
xyzmaker123
1da71f6c66
SEPA Account - possibility to modify account name 2022-01-10 10:52:39 +01:00
xyzmaker123
b3bf1903be
SEPA Account - possibility to modify accepted countries 2022-01-10 10:52:25 +01:00
jmacxx
3ea1543882
fixes for Windows compatability, test added 2022-01-07 19:42:24 -06:00
ghubstan
7690ffd953
Add API methods 'failtrade', 'unfailtrade'
Prerequisite for next PR: Add API method 'gettrades'

The `gettrades` method will show 'open', 'closed', and 'failed' trades.
Users already needed to be able to fail and unfail trades for the
same reasons they do in the UI.  API test cases will need to be able to
fail and unfail trades to check correct behavior of 'gettrades' method.

Based on branch `rename-keepfunds2closetrade`.
2022-01-07 19:11:34 -03:00
jmacxx
99b4071bdf
Wording for Bsq swap cancellation popups & withdrawal prompt 2022-01-07 10:03:14 -06:00
jmacxx
9334cffc89
Feature enabling log file upload to mediators 2022-01-06 13:22:44 -06:00
ghubstan
a9aaba87fa
Rename API method keepfunds -> closetrade
Trade proceeds and deposits have already been transfered to Bisq wallets
before the `keepfunds` command is (was) executed;  `keepfunds` merely moves
open trades to closed trades lists and persistence files.  Renaming `keepfunds`
as `closetrade` makes its purpose clear to API users.

The commit modifies only method names and comments in api server+cli classes,
apitest cases, and api trade simulation scripts.

Based on `master`
2022-01-05 12:10:46 -03:00
jmacxx
298aca40bc
Fix trade fee validation bug when two BSQ UTXOs used to pay the fee.
A test has been added to validate the UTXO issue above.
Other tests have been updated as a result of the changes in PR 5826
where fee parameter is now supplied from a filter; this results
in more accurate (less lenient) fee checking.
2022-01-04 09:25:05 -06:00
Christoph Atteneder
dde48f7d9e
Merge pull request #5935 from jmacxx/dao_state_store_and_statistics
Improve DAO state store persistence and statistics logging [chimp1984]
2022-01-03 12:24:18 +01:00
Stan
53d693d710
Merge branch 'master' into 7-deprecate-api-getmyoffer 2021-12-27 12:09:22 -03:00
ghubstan
5f571cccca
Deprecate API 'getmyoffer'
The method 'getoffer' should support looking up a user's open-offers, and other users' available offers.

- Adjust api-beta-test-guide.md to use only 'getoffer'.
- Adjust trade simulation scripts to use only 'getoffer'.
- Adjust api testcases to use 'getoffer' in place of 'getmyoffer'.
- Mark appropriate methods and protobuf msgs as deprecated.
2021-12-27 12:05:17 -03:00
jmacxx
1162060e28
Simplify the trade complete summary dialog 2021-12-24 14:22:59 -06:00