ghubstan
a1f059ded4
Merge branch '7-more-grpcproto-comments' into 8-remove-trdstats-service
2022-02-26 17:53:04 -03:00
ghubstan
f14806ea1f
Let minAmount param be optional
2022-02-26 17:48:44 -03:00
ghubstan
b904002991
Avoid number formatting problems if clients pass empty (default) str params
2022-02-26 17:17:42 -03:00
ghubstan
aa6f530555
Revert "Allow editoffer clients to pass empty string for price parameter"
...
This reverts commit fcd2bcd34f
.
2022-02-26 15:26:24 -03:00
ghubstan
fcd2bcd34f
Allow editoffer clients to pass empty string for price parameter
...
The client may have passed an empty string for the price parameter,
if only enabling or disabling the offer. If so, validate with new
price = old price.
2022-02-26 15:13:21 -03:00
ghubstan
ab8a3433c3
Use a zero fixed-price if useMarketBasedPrice=true
...
The CLI and apitest cases always pass "0", but java & python clients
might pass an empty string. This change avoids number formatting
& scaling problems when clients pass an empty string in the price
parameter.
2022-02-26 14:27:52 -03:00
ghubstan
2e9e51eb41
Remove GetTradeStatistics service from grpc.proto
...
This protobuf definition and service stub has been in place since
the start of work on the API, but was never fully implmented, nor
intended to be included in the API beta & v1 releases.
Its presence added a useless section to the gRPC API Reference doc.
https://ghubstan.github.io/slate
Based on branch `7-more-grpcproto-comments`,
PR https://github.com/bisq-network/bisq/pull/6068 .
2022-02-26 11:11:26 -03:00
Stan
1499465c11
Merge branch 'master' into 7-more-grpcproto-comments
2022-02-25 20:46:05 -03:00
Christoph Atteneder
c0ab215388
Merge pull request #6078 from jmacxx/5396_privacy_enhancement
...
[1.8.3] Clear sensitive dispute data based on dispute opening date.
2022-02-25 17:29:02 +01:00
jmacxx
a983e4a45e
Clear sensitive dispute data based on dispute opening date.
...
Change recommended setting for sensitive data clearing to 60 days.
2022-02-25 17:09:29 +01:00
jmacxx
327ea680ac
Clear sensitive dispute data based on dispute opening date.
...
Change recommended setting for sensitive data clearing to 60 days.
2022-02-25 09:49:36 -06:00
jmacxx
3bc096417e
Keep first dispute chat msg when clearing sensitive data.
...
Fixes https://github.com/bisq-network/bisq/pull/6001#issuecomment-1049710029
2022-02-25 16:01:32 +01:00
Christoph Atteneder
5824c9cabb
Merge pull request #6076 from jmacxx/5396_privacy_enhancement
...
[1.8.3] Keep first dispute chat msg when clearing sensitive data.
2022-02-25 16:01:25 +01:00
Christoph Atteneder
382c2a1681
Update bitcoinj checkpoints for v1.8.3
2022-02-24 20:47:32 +01:00
jmacxx
f430243b5e
Keep first dispute chat msg when clearing sensitive data.
...
Fixes https://github.com/bisq-network/bisq/pull/6001#issuecomment-1049710029
2022-02-24 11:44:36 -06:00
Christoph Atteneder
07f0e70731
Merge pull request #6072 from jmacxx/5396_privacy_enhancement
...
[1.8.3 fix] Get payment method ID from offerPayload pt.II
2022-02-23 15:42:54 +01:00
jmacxx
c12fb2e004
Get payment method ID from offerPayload.
...
Another problem with closed trades older than v1.7.0.
The payment method ID can always be obtained from offerPayload.
2022-02-23 15:42:34 +01:00
jmacxx
70752a1ffd
Get payment method ID from offerPayload.
...
Another problem with closed trades older than v1.7.0.
The payment method ID can always be obtained from offerPayload.
2022-02-21 23:22:54 -06:00
jmacxx
2bdfa524cf
Get payment method ID from offerPayload.
...
Was getting an NPE with closed trades older than v1.7.0.
makerPaymentMethodId was new at that point (null for older trades).
makerPaymentAccountPayload can be null for trades where we have
removed account info for privacy reasons (see #6001 ).
The payment method ID can always be obtained from offerPayload.
2022-02-21 20:23:14 +01:00
Christoph Atteneder
d12a13b1a1
Merge pull request #6069 from jmacxx/5396_privacy_enhancement
...
[1.8.3 fix] Get payment method ID from offerPayload
2022-02-21 20:22:59 +01:00
jmacxx
f3dfc14779
Get payment method ID from offerPayload.
...
Was getting an NPE with closed trades older than v1.7.0.
makerPaymentMethodId was new at that point (null for older trades).
makerPaymentAccountPayload can be null for trades where we have
removed account info for privacy reasons (see #6001 ).
The payment method ID can always be obtained from offerPayload.
2022-02-21 10:59:32 -06:00
jmacxx
99be324aba
Improve BSQ swap error messaging.
...
Re-enable popup warning indicating when DAO needs to be resynced.
2022-02-21 14:50:41 +01:00
Christoph Atteneder
b739b4c347
Merge pull request #6063 from jmacxx/bsq_swap_improve_dao_errmsg
...
Improve BSQ swap error messaging & DAO resync popup.
2022-02-21 14:50:31 +01:00
xyzmaker123
5e0ebf163d
Fix bug with text rendering on trade step info
2022-02-21 14:49:53 +01:00
ghubstan
66c04bdf3d
Adjust core.api to new .proto *Pct field names
2022-02-20 15:19:32 -03:00
xyzmaker123
3b966d8740
Fix bug with text rendering on trade step info
2022-02-20 10:13:56 +01:00
jmacxx
a302380e1e
Improve BSQ swap error messaging.
...
Re-enable popup warning indicating when DAO needs to be resynced.
2022-02-19 22:15:13 -06:00
ghubstan
a0b68bc756
Adjust .proto wrappers to price & volume type change
...
Some minor refactoring included.
2022-02-19 15:09:16 -03:00
ghubstan
d42c58073f
Change OfferInfo proto's volume fields' type to string
2022-02-18 16:43:23 -03:00
ghubstan
a5fc4b7d52
Get fee from dao state service if JFX prop filterManager.getFilter is null
2022-02-18 17:07:41 +01:00
Christoph Atteneder
aaac08202e
Merge pull request #6052 from ghubstan/alt-fix-feeservice-npe-in-api
...
Fix API FeeService NPE (Alternate)
2022-02-18 17:07:30 +01:00
ghubstan
fafe416e85
Adjust to string triggerPrice
change in API core classes.
2022-02-18 11:24:02 -03:00
ghubstan
461edff631
Change OfferInfo proto's 'price' field type to string
...
Much less ambiguous field value at cost of breaking backward compat in API.
2022-02-17 17:27:15 -03:00
ghubstan
6f1057a766
Include unmerged API NPE fix to FeeService class (see PR #6052 )
2022-02-17 13:28:14 -03:00
Christoph Atteneder
25441814ae
Update translations for v1.8.3
2022-02-17 10:48:22 +01:00
Christoph Atteneder
12a797d9e4
Merge pull request #6053 from jmacxx/display_signed_account_age
...
Show signed status when applicable in Trade & Dispute info screens
2022-02-17 10:35:41 +01:00
jmacxx
b1e88e8338
Add ability to copy popup text to clipboard.
2022-02-16 19:26:37 -06:00
jmacxx
1227781d43
Show signed status when applicable in Trade & Dispute screens
2022-02-16 16:09:08 -06:00
ghubstan
84eb653366
Get fee from dao state service if JFX prop filterManager.getFilter is null
2022-02-16 14:27:05 -03:00
Christoph Atteneder
d671b6805a
Merge pull request #6032 from jmacxx/sign_verify_msg_dao
...
Sign/Verify message for DAO bonded roles
2022-02-15 21:01:21 +01:00
Christoph Atteneder
3f978252ac
Merge pull request #6040 from jmacxx/fix_bsq_sending_issue
...
Fix issue selecting specific BSQ UTXO for send.
2022-02-15 21:00:20 +01:00
jmacxx
f601e0f42f
Obtain trade fee settings from filter
2022-02-15 13:23:33 -06:00
jmacxx
518ca6e0c3
Fix issue selecting specific BSQ UTX for send.
...
The BisqDefaultCoinSelector is invoked multiple times when a
transaction is being built. Problem was that the coin selection
was being reset within, ultimately leading to coin selection
being completely ignored. Solution is to reset the selection
after the transaction has been built.
The UI for selecting UTXO inputs was being resized to the number
of UTXO available, which caused problems when there is a large
UTXO set. Solution is to size the UI to accomodate 3 to 15 rows,
which provides a reasonable screen display and a scrollbar is
provided for the case of a large UTXO set.
2022-02-11 11:15:27 -06:00
jmacxx
5e7e1c5704
Sign/Verify message for DAO bonded roles
2022-02-10 20:45:43 -06:00
Christoph Atteneder
4e225738c8
Not keep empty translation key
2022-02-09 10:56:53 +01:00
xyzmaker123
9831d19849
Update "get help" message
...
Co-authored-by: m52go <735155+m52go@users.noreply.github.com>
2022-02-08 09:44:26 +01:00
xyzmaker123
469f589582
Update "still not resolved" message
...
Co-authored-by: m52go <735155+m52go@users.noreply.github.com>
2022-02-08 09:44:25 +01:00
xyzmaker123
19d6b2607c
Add support/help links on the UI - trade details
2022-02-08 09:44:23 +01:00
xyzmaker123
90c2bfa651
Introduce SimpleMarkdownLabel
2022-02-08 09:44:17 +01:00
Christoph Atteneder
9c70a8a62a
Merge pull request #6029 from jmacxx/fix_issue_5877
...
Fix unhandled exception when locale specifies unknown country/region code.
2022-02-07 21:56:14 +01:00