Alejandro García
07def78e4d
Merge pull request #7013 from alvasw/test_maker_tx_vouts
...
Test Maker Transaction Vouts
2024-01-31 11:32:25 +00:00
Alejandro García
e9e62b9e48
Merge pull request #7003 from alvasw/fix_crash_on_missing_vin_0_prevout
...
TxValidator: Fix crash on missing vin[0].prevout
2024-01-25 11:26:35 +00:00
Alejandro García
23b5424d53
Merge pull request #6974 from kiocosta/release/v1.9.14
...
Update 'reason for payment' warning instructions
2024-01-25 11:24:48 +00:00
Alva Swanson
873757e865
MakerTxSanityCheckTests: Add checkFeeAmountMissingVoutValue test
2024-01-24 15:12:55 +01:00
Alva Swanson
49725689ca
MakerTxSanityCheckTests: Add checkFeeAmountMissingVinPreVoutValue test
2024-01-24 15:12:55 +01:00
Alva Swanson
3a7a67d7ca
MakerTxSanityCheckTests: Handle test asset IOException locally
2024-01-24 15:12:55 +01:00
Alva Swanson
516d3c8d7d
TxValidator: Fix crash on missing vin[0].prevout
...
The `checkFeeAmountBTC` method looks up the `value` field of the
`vin[0].prevout` field without checking whether `vin[0].prevout` exists.
When the field is missing `JsonElement jsonVIn0Value =
jsonVin0.getAsJsonObject("prevout").get("value");` (line 193) throws a
NullPointerException.
2024-01-15 10:29:49 +01:00
Alva Swanson
ba09db4356
Test too few outputs in fee payment
2024-01-15 10:29:49 +01:00
Alva Swanson
05dfbca07d
Test too few inputs in fee payment
2024-01-15 10:29:48 +01:00
Caio Costa
77479fffdf
Update 'reason for payment' warning instructions
2024-01-14 23:50:34 +00:00
Alejandro García
4d4c9e3186
Merge pull request #7000 from alvasw/txvalidator_fix_crash_on_invalid_vin_vout_json_array
...
TxValidator: Fix crash on invalid vin or vout JSON Array
2024-01-14 11:50:17 +00:00
Alejandro García
5872e9e1d6
Merge pull request #6998 from jmacxx/allow_mediation_failed_closed_trades
...
Allow mediation of failed and closed trades
2024-01-14 11:48:59 +00:00
Alejandro García
501b554d78
Merge pull request #6997 from alvasw/fix_fee_check_invalid_json_crash
...
Fix fee check crash on invalid JSON response
2024-01-14 11:48:31 +00:00
Alejandro García
f755efa765
Merge pull request #6994 from jmacxx/resync_popup_change
...
Change unconfirmed popup to 24h after trade start.
2024-01-14 11:48:08 +00:00
Alva Swanson
d7cd1e2c92
TxValidator: Fix crash on invalid vin or vout JSON Array
...
The `TxValidator`s `getVinAndVout(...)` method assumes that
`json.get("field").getAsJsonArray()` returns null when the field is not
a JSON array. The `getAsJsonArray()` throws an `IllegalStateException`
exception, however. The `IllegalStateException` doesn't get caught by
any caller.
2024-01-13 11:06:17 +01:00
Alva Swanson
9f4a4d6913
TxValidator: Add missing vin and vout tests
2024-01-13 11:06:10 +01:00
Alva Swanson
d86583c6b7
Run TxValidatorSanityCheckTests for maker and taker
2024-01-13 11:05:48 +01:00
yonson2023
6a146cd4ac
Show prompt if holderName is blank.
2024-01-12 16:08:19 -06:00
Alva Swanson
62496b8bd5
Fix mempool test resource path on Windows
2024-01-10 15:57:25 +01:00
yonson2023
9e5fa8f1b1
Add holdername to MoneyBeam account.
2024-01-09 17:50:07 -06:00
jmacxx
ff52c43d4f
Allow mediation of failed and closed trades.
2024-01-09 12:56:30 -06:00
Alva Swanson
9f760edd25
TxValidator: Fix fee check crash on invalid JSON response
...
The initialSanityChecks method only checks whether the JSON response is
null (HTTP request failed) or the response is empty (HTTP 200) before
parsing the JSON response. A invalid JSON response would throw a
JsonSyntaxException exception which the callers are not catching.
2024-01-09 10:44:10 +01:00
Alva Swanson
be857cb40c
Add TxValidatorSanityCheckTests
2024-01-09 10:44:10 +01:00
Alva Swanson
d7b8587708
Add FeeValidationStatus.NOT_CHECKED_YET tests
2024-01-09 10:44:10 +01:00
Alva Swanson
ecb667c85d
Remove redundant OpenOffer intial state constructor
...
The inital state is always OpenOffer.State.AVAILABLE.
2024-01-09 10:44:10 +01:00
Alva Swanson
a127cde9ac
Test OpenOffer inital state
2024-01-09 10:44:10 +01:00
Alva Swanson
ab8f890a44
Test OpenOffer FeeValidation NOT_CHECKED_YET status
2024-01-09 10:43:47 +01:00
Alejandro García
566ab53c8f
Merge pull request #6995 from alvasw/on_get_blocks_request_handling_create_raw_block_list_once
...
Create GetBlocksRequestHandler's reply list once
2024-01-08 09:17:42 +00:00
Alejandro García
172628f782
Merge pull request #6989 from jmacxx/postpone_bm_activation_date
...
Give more time before activating BM capping algo change
2024-01-08 09:16:41 +00:00
Alejandro García
36734e9c90
Merge pull request #6987 from wiz/patch-1
...
Remove 2 of wiz's Bitcoin nodes
2024-01-08 09:16:13 +00:00
Alejandro García
01f13cb4c5
Merge pull request #6972 from yonson2023/fix_avoid_standby
...
Bugfix: avoid standby mode should adhere to the user preference setting.
2024-01-08 09:15:26 +00:00
Alva Swanson
1e78902bbf
Create GetBlocksRequestHandler's reply list once
...
Previously, the onGetBlocksRequest method created an ArrayList and two
LinkedList before creating the GetBlocksResponse. The first two lists
were never used. PR #6947 introduced the second LinkedList creation.
With this change, the GetBlocksRequestHandler only creates a single
LinkedList.
2024-01-06 08:16:44 +01:00
jmacxx
e082a49760
Change unconfirmed popup to 24h after trade start.
2024-01-05 22:13:48 -06:00
jmacxx
a4dc1ac04a
Activate proposal 412 a month later: Feb 1 2024.
2024-01-02 07:14:45 -06:00
wiz
9771e0c4ce
Remove 2 of wiz's Bitcoin nodes
2024-01-01 06:48:23 +09:00
Alejandro García
5a3a7071f9
Merge pull request #6980 from alvasw/core_do_not_add_old_fitler_to_invalid_filters_if_new_signer_banned
...
core: Don't add old filter to invalid filters if new signer banned
2023-12-31 13:46:06 +00:00
Alejandro García
f12069aeeb
Merge pull request #6979 from alvasw/FilterManagerMockedPrivilegeKeysTests
...
Add FilterManagerMockedPrivilegeKeysTests
2023-12-31 13:45:13 +00:00
Alejandro García
1f072bf774
Merge pull request #6977 from alvasw/FilterManagerAddFilterToNetworkTests
...
Add FilterManagerAddFilterToNetworkTests
2023-12-31 13:44:07 +00:00
Alejandro García
143628b5a0
Merge pull request #6976 from alvasw/FilterManagerInitializationTests
...
Add FilterManagerInitializationTests
2023-12-31 13:42:53 +00:00
Alejandro García
e5ed806235
Merge pull request #6952 from jmacxx/fee_validation_reason_codes
...
Display the reason for auto-disabling an open offer.
2023-12-31 13:35:44 +00:00
Alva Swanson
d6aa5b16f6
core: Don't add old filter to invalid filters if new signer banned
...
Before this change, the currentFilter will be added to the
invalidFilters list after comparing both filters creation date and
before checking whether the new filter was created by a banned signer.
Note: The invalid filters list is only used on the security manager Bisq
instances. This list is never read by regular user clients.
2023-12-28 15:00:21 +01:00
Alva Swanson
78ac425414
Write FilterManagerMockedPrivilegeKeysTests
2023-12-28 15:00:21 +01:00
Alva Swanson
b255dad5c3
Write FilterManagerAddFilterToNetworkTests
2023-12-28 08:50:13 +01:00
Alva Swanson
8a978a2c14
DevEnv: Add static getDevPrivilegePubKeys() method
2023-12-28 08:50:13 +01:00
Alva Swanson
bf98531c46
Config: Make configFile field private and add getter
2023-12-28 08:50:13 +01:00
Alva Swanson
e7cb152e11
DevEnv: Make DEV_PRIVILEGE_PRIV_KEY private and add getter
2023-12-28 08:50:13 +01:00
Alva Swanson
c96b7d2ade
DevEnv: Make DEV_PRIVILEGE_PUB_KEY private and add getter
2023-12-28 08:50:13 +01:00
Alva Swanson
ff15d5a066
Write FilterManagerInitializationTests
2023-12-28 08:50:10 +01:00
yonson2023
65daec0659
Bugfix: avoid standby mode should adhere to the user preference setting.
2023-12-20 12:27:22 -06:00
Alejandro García
70a15ceb06
Merge pull request #6965 from yonson2023/pix_add_holder_name
...
Update Pix payment account, add HolderName
2023-12-20 05:05:18 +00:00