mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2024-11-19 01:41:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant OpenOffer intial state constructor

Browse Source 
The inital state is always OpenOffer.State.AVAILABLE.
This commit is contained in:
Alva Swanson 2024-01-04 15:25:07 +01:00
parent a127cde9ac
commit ecb667c85d
No known key found for this signature in database
GPG Key ID: 004760E77F753090
3 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
core/src/main/java/bisq/core/offer/OpenOffer.java
View File

@ -91,13 +91,6 @@ public final class OpenOffer implements Tradable {
this(offer, 0);
}
public OpenOffer(Offer offer, State state) {
this.offer = offer;
this.triggerPrice = 0;
this.state = state;
arbitratorNodeAddress = null;
}
public OpenOffer(Offer offer, long triggerPrice) {
this.offer = offer;
this.triggerPrice = triggerPrice;

2
core/src/main/java/bisq/core/offer/bsq_swap/OpenBsqSwapOfferService.java
View File

@ -367,7 +367,7 @@ public class OpenBsqSwapOfferService {
checkArgument(!openOffer.isDeactivated(),
"We must not get called at redoProofOrWorkAndRepublish if offer was deactivated");
OpenOffer newOpenOffer = new OpenOffer(newOffer, OpenOffer.State.AVAILABLE);
OpenOffer newOpenOffer = new OpenOffer(newOffer);
if (!newOpenOffer.isDeactivated()) {
openOfferManager.maybeRepublishOffer(newOpenOffer);
}

6
core/src/test/java/bisq/core/fee/FeeValidationTests.java
View File

@ -35,12 +35,6 @@ public class FeeValidationTests {
assertThat(openOffer.getFeeValidationStatus(), is(equalTo(FeeValidationStatus.NOT_CHECKED_YET)));
}
@Test
void createOpenBsqOfferWithSecondConstructor() {
var openOffer = new OpenOffer(mock(Offer.class), OpenOffer.State.AVAILABLE);
assertThat(openOffer.getFeeValidationStatus(), is(equalTo(FeeValidationStatus.NOT_CHECKED_YET)));
}
@Test
void createOpenOfferWithTriggerPrice() {
var openOffer = new OpenOffer(mock(Offer.class), 42_000);