mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2024-11-19 01:41:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

MakerTxSanityCheckTests: Handle test asset IOException locally

Browse Source
This commit is contained in:
Alva Swanson 2024-01-24 15:12:55 +01:00
parent 516d3c8d7d
commit 3a7a67d7ca
No known key found for this signature in database
GPG Key ID: 004760E77F753090
1 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
core/src/test/java/bisq/core/fee/MakerTxValidatorSanityCheckTests.java
View File

@ -83,7 +83,7 @@ public class MakerTxValidatorSanityCheckTests {
@ParameterizedTest
@ValueSource(strings = {"status", "txid", "vin", "vout"})
void mempoolResponseWithMissingField(String missingField) throws IOException {
void mempoolResponseWithMissingField(String missingField) {
JsonObject json = getValidBtcMakerFeeMempoolJsonResponse();
json.remove(missingField);
assertThat(json.has(missingField), is(false));
@ -96,7 +96,7 @@ public class MakerTxValidatorSanityCheckTests {
}
@Test
void mempoolResponseWithoutConfirmedField() throws IOException {
void mempoolResponseWithoutConfirmedField() {
JsonObject json = getValidBtcMakerFeeMempoolJsonResponse();
json.get("status").getAsJsonObject().remove("confirmed");
assertThat(json.get("status").getAsJsonObject().has("confirmed"), is(false));
@ -110,7 +110,7 @@ public class MakerTxValidatorSanityCheckTests {
@ParameterizedTest
@ValueSource(strings = {"vin", "vout"})
void checkFeeAddressBtcTestVinOrVoutNotJsonArray(String vinOrVout) throws IOException {
void checkFeeAddressBtcTestVinOrVoutNotJsonArray(String vinOrVout) {
JsonObject json = MakerTxValidatorSanityCheckTests.getValidBtcMakerFeeMempoolJsonResponse();
json.add(vinOrVout, new JsonPrimitive(1234));
assertThrows(IllegalStateException.class, () -> json.get(vinOrVout).getAsJsonArray());
@ -123,7 +123,7 @@ public class MakerTxValidatorSanityCheckTests {
}
@Test
void checkFeeAddressBtcNoTooFewVin() throws IOException {
void checkFeeAddressBtcNoTooFewVin() {
JsonObject json = MakerTxValidatorSanityCheckTests.getValidBtcMakerFeeMempoolJsonResponse();
json.add("vin", new JsonArray(0));
assertThat(json.get("vin").getAsJsonArray().size(), is(0));
@ -137,7 +137,7 @@ public class MakerTxValidatorSanityCheckTests {
@ParameterizedTest
@ValueSource(ints = {0, 1})
void checkFeeAddressBtcNoTooFewVout(int numberOfVouts) throws IOException {
void checkFeeAddressBtcNoTooFewVout(int numberOfVouts) {
JsonObject json = MakerTxValidatorSanityCheckTests.getValidBtcMakerFeeMempoolJsonResponse();
var jsonArray = new JsonArray(numberOfVouts);
@ -155,7 +155,7 @@ public class MakerTxValidatorSanityCheckTests {
}
@Test
void checkFeeAmountMissingVinPreVout() throws IOException {
void checkFeeAmountMissingVinPreVout() {
JsonObject json = MakerTxValidatorSanityCheckTests.getValidBtcMakerFeeMempoolJsonResponse();
JsonObject firstInput = json.get("vin").getAsJsonArray().get(0).getAsJsonObject();
firstInput.remove("prevout");
@ -173,7 +173,7 @@ public class MakerTxValidatorSanityCheckTests {
}
@Test
void responseHasDifferentTxId() throws IOException {
void responseHasDifferentTxId() {
String differentTxId = "abcde971ead7d03619e3a9eeaa771ed5adba14c448839e0299f857f7bb4ec07";
JsonObject json = getValidBtcMakerFeeMempoolJsonResponse();
@ -187,7 +187,7 @@ public class MakerTxValidatorSanityCheckTests {
assertThat(status, is(equalTo(FeeValidationStatus.NACK_JSON_ERROR)));
}
public static JsonObject getValidBtcMakerFeeMempoolJsonResponse() throws IOException {
public static JsonObject getValidBtcMakerFeeMempoolJsonResponse() {
URL resource = MakerTxValidatorSanityCheckTests.class.getClassLoader()
.getResource("mempool_test_data/valid_btc_maker_fee.json");
String path = Objects.requireNonNull(resource).getPath();
@ -198,7 +198,11 @@ public class MakerTxValidatorSanityCheckTests {
path = path.substring(1);
}
String jsonContent = Files.readString(Path.of(path));
return new Gson().fromJson(jsonContent, JsonObject.class);
try {
String jsonContent = Files.readString(Path.of(path));
return new Gson().fromJson(jsonContent, JsonObject.class);
} catch (IOException e) {
throw new IllegalStateException("Couldn't read valid_btc_maker_fee.json", e);
}
}
}