mirror of https://github.com/lightningnetwork/lnd.git synced 2024-11-20 02:27:21 +01:00

Olaoluwa Osuntokun 8b18c6c69d

config: clamp channel-commit-interval to reasonable time

2022-03-02 17:07:35 -08:00

Release Notes

Security

Pipelining an UpdateFulfillHTLC message now only happens when the related UpdateAddHTLC is locked-in.
Fixed an inactive invoice subscription not removed from invoice registry. When an invoice subscription is created and canceled immediately, it could be left uncleaned due to the cancel signal is processed before the creation. It is now properly handled by moving creation before deletion.
When the block height+delta specified by a network message is greater than the gossiper's best height, it will be considered as premature and ignored. These premature messages are now saved into a cache and processed once the height has reached.
Fixed failure to limit our number of hop hints in private invoices. When a private invoice is created, and the node had > 20 (our hop hint limit) private channels with inbound > invoice amount, hop hint selection would add too many hop hints. When a node had many channels meeting this criteria, it could result in an "invoice too large" error when creating invoices. Hints are now properly limited to our maximum of 20.
Fixed an edge case where the lnd might be stuck at starting due to channel arbitrator relying on htlcswitch to be started first.

Add value to the field remote_balance in pending_force_closing_channels under pendingchannels whereas before was empty(zero).
Add dev only RPC subserver and the devrpc.ImportGraph call
Extend the HTLC interceptor API to provide more control over failure messages. With this change, it allows encrypted failure messages to be returned to the sender. Additionally it is possible to signal a malformed htlc.

Refactored itest to better manage contexts inside integration tests.
Fix itest not picking up local config file or creating directories in home dir of the user.
A refactor of SelectHopHints allows code external to lnd to call the function, where previously it would require access to lnd's internals.
rpc-check fails if it finds any changes including new and deleted files.
The golangci-lint package was updated and new linters were enabled.
The linting process now runs inside a docker container to fix versioning issues between projects.
The whitespace linter was enabled to make sure multi-line if conditions and function/method declarations are followed by an empty line to improve readability. Note to developers: please make sure you delete the old version of golangci-lint in your $GOPATH/bin directory. make lint does not automatically replace it with the new version if the binary already exists!
ChannelLink in the htlcswitch now performs a 2-way handoff instead of a 1-way handoff with its ChannelArbitrator.
The channel-commit-interval is now clamped to a reasonable timeframe of 1h.