Oliver Gugger
ab2dc09eb7
Merge pull request #9582 from yyforyongyu/flake-doc
...
itest: properly document the known flakes
2025-03-07 10:37:14 -06:00
Oliver Gugger
a5f54d1d6b
Merge pull request #9573 from ellemouton/checkUpdateStalenessBeforeRateLimit
...
discovery: obtain channelMtx before doing any DB calls in `handleChannelUpdate`
2025-03-07 04:17:00 -06:00
Oliver Gugger
76808a81a0
Merge pull request #9587 from guggero/mining-block-limit-configurable
...
lntest: make mining block limit configurable
2025-03-07 02:57:29 -06:00
Oliver Gugger
25c83104b7
lntest: make mining block limit configurable
...
Nudging test authors towards not mining too many blocks makes sense,
especially in lnd where we have a lot of integration tests.
But the lntest package is also used in other projects where this
restriction might lead to large refactors.
To be able to stage those refactors we also want to allow this limit to
be configurable if lntest is used as a library.
2025-03-07 09:22:51 +01:00
Oliver Gugger
72b570320a
Merge pull request #9586 from ellemouton/logConfig
...
config: only create a sub-log manager if one doesnt already exist
2025-03-07 01:30:02 -06:00
Elle Mouton
090e687144
config: only create a sub-log manager if one doesnt already exist
...
The ValidateConfig method needs to account for the caller already having
an initialised build.SubLoggerManager and then should not override it.
2025-03-06 18:02:25 +02:00
Oliver Gugger
7d7e1872c8
Merge pull request #9574 from ellemouton/fixWatcherPanic
...
lntest: wait for ChanUpdate req to be fully processed before sending another
2025-03-06 09:21:35 -06:00
yyforyongyu
95569df92e
itest: document a flake found on macOS
2025-03-06 22:46:31 +08:00
yyforyongyu
0f8f092ddd
itest: document a flake from TxNotifier
2025-03-06 09:11:30 +08:00
yyforyongyu
2f545717c9
itest: remove old TODOs
...
As they are fixed now.
2025-03-06 09:11:30 +08:00
yyforyongyu
f349323923
itest: move test testDisconnectingTargetPeer
...
Hence finish an old TODO.
2025-03-06 09:11:30 +08:00
yyforyongyu
4755eff0a8
itest: remove time.Sleep before closing channels
...
Remove an old TODO, which has been fixed with the `NoWait` flag for coop
close.
2025-03-06 09:11:13 +08:00
Elle Mouton
95277bbc35
docs: update release notes
2025-03-05 14:12:56 +02:00
Elle Mouton
2e85e08556
discovery: grab channel mutex before any DB calls
...
In `handleChanUpdate`, make sure to grab the `channelMtx` lock before
making any DB calls so that the logic remains consistent.
2025-03-05 14:12:55 +02:00
Elle Mouton
5e35bd8328
discovery: demonstrate channel update rate limiting bug
...
This commit adds a test to demonstrate that if we receive two identical
updates (which can happen if we get the same update from two peers in
quick succession), then our rate limiting logic will be hit early as
both updates might be counted towards the rate limit. This will be fixed
in an upcoming commit.
2025-03-05 14:12:23 +02:00
yyforyongyu
ec7c36fd6a
itest: document missing wallet UTXO
2025-03-05 18:54:13 +08:00
yyforyongyu
061b7abf76
itest: document the flake found in preimage extraction
...
We now use dedicated methods to properly document the flakes in *one*
place.
2025-03-05 18:54:13 +08:00
Oliver Gugger
9feb761b4e
Merge pull request #9576 from ellemouton/logConfYamlTags
...
build: add yaml tags to some LogConfig fields
2025-03-04 13:27:11 -06:00
Elle Mouton
1dec8ab985
build: add yaml tags to embedded LogConfig structs
...
For any embedded struct, the `yaml:",inline"` tag is required.
2025-03-04 13:32:22 +02:00
Elle Mouton
57c6c236d8
lntest: wait for ChanUpdate req to be fully processed before sending another
...
Before this commit, it was possible for a request to be sent on the
`chanWatchRequests` channel in `WaitForChannelPolicyUpdate` and then for
the `ticker.C` case to select _before_ the `eventChan` select gets
triggered when the `topologyWatcher` closes the `eventChan` in its call
to `handlePolicyUpdateWatchRequest`. This could lead to a "close of a
closed channel" panic.
To fix this, this commit ensures that we only move on to the next
iteration of the select statement in `WaitForChannelPolicyUpdate` once
the request sent on `chanWatchRequests` has been fully handled.
2025-03-03 17:53:15 +02:00
Olaoluwa Osuntokun
f744a5477f
Merge pull request #9565 from guggero/bot-typo-fix-spam
...
GitHub+docs: no longer accept typo fixes to fight PR spam
2025-02-28 16:18:17 -08:00
Oliver Gugger
f1182e4338
Merge pull request #9521 from guggero/coverage-fixes
...
unit: remove GOACC, use Go 1.20 native coverage functionality
2025-02-28 09:54:12 -06:00
Oliver Gugger
7761e37522
GitHub: remove generated files from coverage
2025-02-28 14:55:34 +01:00
Oliver Gugger
124137e31a
GitHub+make: debug failing test, use official coveralls action
2025-02-28 14:55:34 +01:00
Oliver Gugger
576da75a07
multi: remove unneeded env variables
...
With Go 1.23 we don't need to set any of these variables anymore, as
they're the default values now.
2025-02-28 14:55:34 +01:00
Oliver Gugger
70ac201cb8
make+tools: remove goacc, use Go 1.20 builtin functionality
...
Starting with Go 1.20 the -coverprofile flag does the same that GOACC
did before.
2025-02-28 14:55:33 +01:00
Oliver Gugger
dc0ba72271
Merge pull request #9566 from yyforyongyu/improve-itest
...
lntest+itest: change the method signature of `AssertPaymentStatus`
2025-02-28 07:52:49 -06:00
Oliver Gugger
a78f9f6c0a
GitHub+docs: no longer accept typo fixes to fight PR spam
2025-02-28 13:02:49 +01:00
yyforyongyu
2d5a2ce78a
lntest+itest: change the method signature of AssertPaymentStatus
...
So this can be used in other tests when we only care about the payment
hash.
2025-02-28 19:07:38 +08:00
Oliver Gugger
dfd43c972c
Merge pull request #9519 from fuyangpengqi/master
...
refactor: use a more straightforward return value
2025-02-28 04:41:18 -06:00
fuyangpengqi
150f72414a
refactor: use a more straightforward return value
...
Signed-off-by: fuyangpengqi <995764973@qq.com>
2025-02-28 17:09:56 +08:00
Oliver Gugger
8532955b35
Merge pull request #9540 from ellemouton/backwardsCompat
...
scripts+make+GH: Add simple backwards compatibility test to the CI
2025-02-27 05:05:03 -06:00
Elle Mouton
b3133b99d4
docs: add release note entry
2025-02-27 11:33:15 +02:00
Elle Mouton
343bdff26b
make+gh: add make helper and GH action
...
Add a makefile helper to run the neww backwards compatability test and
then add a new GH actions job to call it.
2025-02-27 11:33:15 +02:00
Elle Mouton
f0d4ea10a2
scripts/bw-compatibility-test: add backwards compat test
...
In this commit, a new backwards compatibility test is added. See the
added README.md file in this commit for all the info.
2025-02-27 11:33:15 +02:00
Oliver Gugger
e3d9fcb5ac
Merge pull request #9549 from yyforyongyu/fix-bitcond-test
...
Fix unit test flake `TestHistoricalConfDetailsTxIndex`
2025-02-26 07:23:30 -06:00
yyforyongyu
cfa4341740
routing: fix flake in TestFilteredChainView/bitcoind_polling
2025-02-26 19:51:53 +08:00
yyforyongyu
56fa3aae34
routing/chainview: refactor TestFilteredChainView
...
So each test has its own miner and chainView.
2025-02-26 19:51:53 +08:00
yyforyongyu
4bfcfea2ee
lntest+chainntnfs: make sure bitcoind node is synced
...
This commit makes sure the bitcoind node is synced to the miner when
initialized and returned from `NewBitcoindBackend`.
2025-02-26 19:51:52 +08:00
yyforyongyu
99d49dec6a
multi: change NewBitcoindBackend to take a miner as its param
...
Prepares for the following commit where we assert the chain backend is
synced to the miner.
2025-02-26 19:51:52 +08:00
yyforyongyu
c725ba9f25
docs: update release notes re flake fix
2025-02-26 19:51:52 +08:00
yyforyongyu
1618d2c789
chainntnfs+lntest: fix sync to miner block flake
...
In this commit we document an unexpected behavior found when connecting
a bitcoind node to a btcd node. We mitigate this in our test by
reconnecting the nodes when the connection is broken. We also limit the
connection made from `bitcoind` to be v1 only.
2025-02-26 19:51:52 +08:00
yyforyongyu
175301628f
lntest/unittest: make sure miner is connected to bitcoind
...
We change how the `bitcoind` node connects to the miner by creating a
temp RPC client and use it to connect to the miner. In addition we also
assert the connection is made.
2025-02-25 21:11:26 +08:00
yyforyongyu
245ea85894
lntest/unittest: assert bitcoind is shut down
...
Make sure the shutdown of `bitcoind` is finished without any errors.
2025-02-25 21:11:25 +08:00
yyforyongyu
7666d62a43
lntest/unittest: update config for miner and bitcoind
...
The config used for the miner is updated to skip banning and debug. For
bitcoind, the config is updated to use a unique port for P2P conn.
2025-02-25 21:10:40 +08:00
yyforyongyu
fa8527af09
Makefile+scripts: add unit test flake hunter
...
This commit adds a script to hunt flakes for a specific unit test with
trace logs. Also rename the make commands to make them more clear on
whether it's a unit test, itest, or paralleled itest.
2025-02-25 21:10:40 +08:00
Oliver Gugger
5d3680a6f6
Merge pull request #9484 from Abdulkbk/refactor-makedir
...
lnutils: add CreateDir util function
2025-02-25 01:00:45 -06:00
Oliver Gugger
b8c5e85821
Merge pull request #8900 from guggero/go-cc
...
Makefile: add GOCC variable
2025-02-25 00:59:14 -06:00
Yong
fca9fae2d8
Merge pull request #9433 from hieblmi/estimate-route-fee-fix
...
routerrpc: fix estimateroutefee for public route hints
2025-02-25 13:58:43 +08:00
Slyghtning
f867954a68
docs: update release notes
2025-02-24 09:56:24 +01:00
