Commit Graph

16656 Commits

Author SHA1 Message Date
Keagan McClelland
30e10322b2 contractcourt: consider delivery addresses when evaluating toSelfAmount
This commit fixes #8535 by changing how we assess toSelfAmount inside
the chainWatcher.

In certain cases users may wish to close out channel funds to external
delivery addresses set either during open or close.

Prior to this change we only consider addresses that our wallet is
aware of.

This change now identifies outputs as to_self outputs if the delivery
script matches OR if our wallet is aware of the address. In certain
edge cases it can be possible for there to be more than one output
that matches these criteria and in that case we will return the sum
of those values.
2024-06-10 11:38:17 -07:00
Keagan McClelland
56048133f2 itest+lntest: add itest to reproduce bug #8535 2024-06-05 12:56:04 -07:00
Oliver Gugger
0fadf97e72
Merge pull request #8808 from ProofOfKeags/fn/predicate-combinators
fn: add predicate combinators for && and ||
2024-06-05 14:03:19 +02:00
Oliver Gugger
a832371d61
Merge pull request #8491 from davidgumberg/invoice_cltv_expiry
Expose `cltv_expiry` flag of `addinvoice` to cli
2024-06-04 13:59:50 +02:00
Oliver Gugger
14bed1d1e7
Merge pull request #8795 from guggero/itest-parallel
GitHub: increase itest parallelization to more tranches
2024-06-04 13:16:20 +02:00
David Gumberg
3c1b7ad59c Release note for cltv_expiry flag to addinvoice 2024-06-04 06:19:12 -04:00
David Gumberg
4646afb366 lnrpc: Fix bug in 'cltv below minimum' error msg
Previously the error message produced when `CltvExpiry` is less
than the minimum final cltv (18 at present) set by
`routing.MinCLTVDelta` inserted the values into the wrong spots of the
formatted string.
2024-06-04 06:19:12 -04:00
David Gumberg
80b60d34aa lncli: Expose cltv_expiry flag of addinvoice
Allows users of the RPC CLI to set the `min_final_cltv_expiry_delta`
described in BOLT's 11, 7, and 2 by setting the `cltv_expiry` flag when
calling either of the `addinvoice` or `addholdinvoice` RPC's from
`lncli`.
2024-06-04 06:19:12 -04:00
yyforyongyu
d9498a9d13
lntest: increase DefaultTimeout for postgres 2024-06-04 09:07:44 +02:00
yyforyongyu
c9cad6ab81
itest+sweep: refactor testSignPsbt to use Subtest and add logs 2024-06-04 09:07:44 +02:00
yyforyongyu
55452f64e8
lntest: wait for mempool update after mining txns 2024-06-04 09:07:43 +02:00
Oliver Gugger
a5c04bbd14
GitHub: increase itest parallelization to 16 tranches 2024-06-04 09:07:34 +02:00
Keagan McClelland
cd3c17e1c0 fn: add predicate combinators for && and || 2024-06-03 12:24:02 -07:00
Oliver Gugger
a2266c6c73
Merge pull request #8802 from saubyk/suheb-pgp
scripts: add pgp key for suheb [skip ci]
2024-06-03 17:53:53 +02:00
Oliver Gugger
d7714efc88
Merge pull request #8779 from bufo24/chore/allow-zero-fail-amt-import-mc
Allow 0 failure amt on importmc
2024-06-03 13:02:37 +02:00
Bufo
4a3af519b8
chore: allow 0 failure amount on import mission control 2024-06-03 11:28:26 +02:00
saubyk
ab00c8ad18
scripts: add gpg key for suheb [skip ci] 2024-06-01 11:25:46 -07:00
Oliver Gugger
613bfc07fb
Merge pull request #8798 from zoupingshi/master
chore: fix some comments
2024-05-31 18:03:54 +02:00
Oliver Gugger
a02c6b6194
Merge pull request #8799 from ellemouton/release-notes-0.18.1
docs: add release notes template for 0.18.1
2024-05-31 17:19:05 +02:00
Elle Mouton
401e74c568
docs: add release notes template for 0.18.1 2024-05-31 09:44:48 -04:00
zoupingshi
30047feb35 chore: fix some comments
Signed-off-by: zoupingshi <hellocatty@tom.com>
2024-05-31 15:16:33 +08:00
Olaoluwa Osuntokun
fed760913f
Merge pull request #8794 from Roasbeef/v0-18-0-branch
build: bump version to v0.18.0 beta
2024-05-30 22:52:10 +09:00
Olaoluwa Osuntokun
1a8d196607
build: bump version to v0.18.0 beta 2024-05-30 17:49:17 +09:00
Oliver Gugger
b137892ceb
Merge pull request #8788 from ProofOfKeags/proofofkeags-pgp
scripts: add gpg key for proofofkeags [skip ci]
2024-05-29 20:55:17 +02:00
Olaoluwa Osuntokun
cd23265537
Merge pull request #8784 from lightningnetwork/0-18-rc4
build: bump version to v0.18.0-beta.rc4
2024-05-29 17:00:12 +09:00
Oliver Gugger
a8b679cd60
Merge pull request #8789 from guggero/fn-result
fn: add Result type
2024-05-29 09:55:52 +02:00
Oliver Gugger
c95505db1e
fn: add Result type
In this commit, we add a new result type, which is just Either[A, error]. This is useful as we can always pass around/accept a single value. We add an Unpack() method which is the most idiomatic way of handling errors in Go, as we revert back to (A, error) when necessary.
2024-05-29 09:39:39 +02:00
Keagan McClelland
fce2ef15a5 scripts: add gpg key for proofofkeags [skip ci] 2024-05-28 17:29:36 -07:00
Olaoluwa Osuntokun
1b6f42a107
build: bump version to v0.18.0-beta.rc4 2024-05-28 10:46:15 +09:00
Olaoluwa Osuntokun
ff85328050
Merge pull request #8774 from yyforyongyu/fix-size-calc
lnwallet+sweep: fix wrong unit used in fee calculation
2024-05-27 18:44:29 -07:00
yyforyongyu
2e40a23146
lnrpc: fix linter 2024-05-25 13:37:16 +08:00
yyforyongyu
5e8452cc5d
sweep: make sure the full input is accounted
Fix the case where previously only the witness data is taken into
account when calculating the fees.
2024-05-25 13:37:16 +08:00
yyforyongyu
17a089c899
input+lnwallet: apply the new type lntypes.VByte 2024-05-25 13:37:16 +08:00
yyforyongyu
8da68bb7db
multi: apply the new type lntypes.WeightUnit 2024-05-25 13:37:13 +08:00
yyforyongyu
dc9a0b31c0
lntypes: add new units WeightUnit and VByte 2024-05-24 23:56:28 +08:00
yyforyongyu
634967c5c8
chainfee: add FeeForVByte on SatPerKWeight 2024-05-24 22:49:20 +08:00
Olaoluwa Osuntokun
bc6292f8bd
Merge pull request #8758 from feelancer21/preserve-inbound-fees
multi: Inbound fees are retained when not provided
2024-05-23 13:58:52 -07:00
Olaoluwa Osuntokun
4417229bc8
Merge pull request #8773 from lightningnetwork/0-18-rc3
build: bump verison to v0.18.0-beta.rc3
2024-05-22 13:19:13 -07:00
feelancer21
dc4ec45423
itest: add more tests related to inbound fees
Add tests for setting inbound fees in channel policies, including tests
where no inbound fees are set in the PolicyUpdateRequest.
2024-05-22 20:48:52 +02:00
feelancer21
f62c00fe34
multi: Inbound fees are retained when not provided
Fixes the problem that inbound base fee and fee rate are overwritten
with 0 if they are not specified in PolicyUpdateRequest. This ensures
backward compatibility with older rpc clients that do not yet support
the inbound feature.
2024-05-22 20:48:42 +02:00
Olaoluwa Osuntokun
74237f2c24
build: bump verison to v0.18.0-beta.rc3 2024-05-22 11:44:24 -07:00
Olaoluwa Osuntokun
64639fb771
Merge pull request #8762 from ProofOfKeags/bugfix/ping-stability
Adjust ping parameters to improve tor stability
2024-05-21 19:34:57 -07:00
Keagan McClelland
1148e572bf peer: triple timeout parameters to give tor more grace 2024-05-21 13:36:46 -07:00
Keagan McClelland
61191a576d peer: make PingManager.Stop infallible 2024-05-21 13:29:31 -07:00
Keagan McClelland
94a9baefeb peer: reduce upper bound of pong bytes to ease bandwidth load 2024-05-21 13:27:56 -07:00
Oliver Gugger
68ea8d5312
Merge pull request #8750 from Chinwendu20/fnd
fn: Added `HasDuplicates` function to slice
2024-05-21 17:08:05 +02:00
Oliver Gugger
01e3ac61d8
Merge pull request #8631 from Chinwendu20/brontidetest
[code-health]: reduce duplication in brontide test.
2024-05-21 12:46:16 +02:00
Olaoluwa Osuntokun
e1c5fe2f9e
Merge pull request #8751 from yyforyongyu/fix-sweeper-18
contractcourt+sweep: fix fee function and deadline issue
2024-05-20 18:11:26 -07:00
yyforyongyu
347537791e
sweep: improve loggings based on feedback
This commit changes the logging levels and add a few more loggings based
on the testing results from the testnet/mainnet.
2024-05-21 00:53:24 +08:00
yyforyongyu
e45db07a10
contractcourt+itest: make sure ChannelArbitrator has the latest htlcs 2024-05-21 00:53:23 +08:00