mirrors/lightning-bolts
1
0
Fork 0
mirror of https://github.com/lightning/bolts.git synced 2025-03-10 09:10:07 +01:00
Code Issues Projects Releases Wiki Activity
810 commits 17 branches 1 tag 7.9 MiB
Commit graph

810 commits

This branch
This branch
All branches
Author SHA1 Message Date
Matt Corallo
fa52e74eac Clarify temporary_channel_id's acceptable usages 2018-12-10 02:46:07 +00:00
Hiroki Gondo
e64c9863b5 BOLT 3: add description of remote_htlcpubkey in Key Derivation. 2018-12-06 21:30:01 +09:00
Hiroki Gondo
88b0000a91 BOLT 4: fix the index of ek. 2018-12-04 18:05:49 +09:00
Rusty Russell
20524d4109
BOLT 2: advise ping-before-commitment_signed on quiescent connections. (#508) 
This seems to be a cause of stuck HTLCs on the network: c-lightning has
done this for a while now (since 0.6.1).

[ Minor wording clarification merged --RR ]
Decided-at: Adelaide Summit 2018
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-11-29 04:32:11 +00:00
Rusty Russell
4c12ae8a27 BOLT #7: don't accidentially wumbo the channel_update. 
Reported-by: @roasbeef
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-11-29 04:25:04 +00:00
Hiroki Gondo
ae8c78c8a8 BOLT 2: Hashed Time Locked Contracts not Hash TimeLocked Contracts. 
Be consistent.
ref. 00-introduction.md#glossary-and-terminology-guide
 2018-11-29 04:24:47 +00:00
Hiroki Gondo
56ada3d85c BOLT 3: commitment number not commitment transaction number. 
Be consistent.
 2018-11-29 04:24:28 +00:00
Conner Fromknecht
7163c52d93 04-onion-routing: document non-strict forwarding 
This commit documents the allowance of non-strict
forwarding, permitting forwarding nodes to select
between any available outgoing channel with the peer
that would otherwise be specified by the
short_channel_id in the onion packet.

It also includes recommendations for fee schedules
when using non-strict forwarding, either by using
a uniform fee schedule with a peer or only
considering like-policied channels, to ensure the
channel is truly equivalent in terms of fee revenue
for the forwarder.
 2018-11-29 04:21:46 +00:00
Orfeas Litos
24d5d33d67 Specify valid signature hash flags (SIGHASH_ALL) 
Clarify that this flag is only used for signing and not transmitted
 2018-11-29 04:18:04 +00:00
Mykola Sakhno
8e62fd3a08 BOLT 3: fix private key in internal part 2018-11-29 04:17:43 +00:00
Rusty Russell
3b4165d12a fixup! BOLT 7: Push the sending of announcements_signatures back a little 2018-11-29 04:15:54 +00:00
Matt Corallo
d093c5e50c BOLT 7: Push the sending of announcements_signatures back a little 
Technically this change may result in channels_announcements only
coming from one end. However, because c-lightning already implements
announcement_signatures in this way, in practice this will improve
reliability of channel_announcements.

[ After much bikeshedding, wording rewritten but same effect -- RR ]

Closes #468
Closes: #474
 2018-11-29 04:15:54 +00:00
araspitzu
2b2e5632ca BOLT 4 Add clarifications about the longest route 2018-11-29 04:12:36 +00:00
araspitzu
90ba6ddbc5 Explicit the number of intermediate nodes in the longest route supported by the spec 2018-11-29 04:12:36 +00:00
araspitzu
a01efdd65e BOLT 4: clarify the maximum length of the route 2018-11-29 04:12:36 +00:00
lisa neigut
a307f3b282 peer-protocol: periods make meaning clearer. sometimes. 2018-11-29 04:12:06 +00:00
lisa neigut
d923df5e43 peer-protocol: fixup punctuation to clarify meaning 
The punctuation in this case made it hard to understand.
 2018-11-29 04:12:06 +00:00
lisa neigut
9b5c3df9ce peer-protocol: explain what a commitment number is, in situ 
Although commitment numbers are explained in the
[glossary](00-introduction.md#glossary-and-terminology-guide),
it's helpful to re-iterate at the place that it's first used.
 2018-11-29 04:12:06 +00:00
lisa neigut
1bbcd5552b peer-protocol: fix tense use -> used 2018-11-29 04:12:06 +00:00
lisa neigut
c572c1c42a peer-protocol: add missing word 
Missing `to`
 2018-11-29 04:12:06 +00:00
lisa neigut
0087a64244 peer-protocol: Add link to channel failure in 05 
To 'fail a channel' is mentioned multiple places in this
BOLT without any mention or definition of what that means.

This adds a link to the relevant text in BOLT 05 in the
first place that we mention 'fail the channel'.
 2018-11-29 04:12:06 +00:00
lisa neigut
2f72c225ea peer-protocol: Add short note about channel_id 
Clarify association between temp_id and channel_id, and make
explicit why we have to wait for the funding transaction.
 2018-11-29 04:12:06 +00:00
lisa neigut
f98689b598 intro glossary: add 'outpoint' 
Add a short definition of an outpoint.
 2018-11-29 04:12:06 +00:00
lisa neigut
05a4d18c1e peer-protocol: Add links to referenced BOLTs 
Add links to make it clearer that these two actions:
'authentication' and 'initialization' are specified elsewhere.
 2018-11-29 04:12:06 +00:00
lisa neigut
5727c3dff0 peer-protocol: Add chan_reestablish message name to TOC 
Make it easier to tell at a glance what messages this BOLT
concerns.
 2018-11-29 04:12:06 +00:00
ZmnSCPxj
67b96de4ec 07-routing-gossip.md: Describe standard human-readable format for short channel ID. 2018-11-27 00:05:16 +08:00
ZmnSCPxj, ZmnSCPxj jxPCSmnZ
65753ff6fb 02-peer-protocol.md: Minor typo. (#505) 2018-11-12 16:47:57 +01:00
Hiroki Gondo
635a6a7df9 BOLT 8: fix a typo 2018-11-06 14:26:27 +11:00
Hiroki Gondo
1222fd1eca BOLT 8: fix s description 
In this document `s` is not a public key but keypair.
Because there are expressions such as `s.priv`
 2018-11-06 14:26:27 +11:00
Hiroki Gondo
6fea210458 BOLT 8: change the order of arguments of ECDH function 
ref. http://noiseprotocol.org/noise.html#dh-functions
The order of arguments of DH function is the order of private key, public key.
Made the same order.
This order is reflected in the expressions of `ee`, `se`, `es`, `ss`.
 2018-11-06 14:26:27 +11:00
Hiroki Gondo
46b616c142 BOLT 8: fix names of returned values of ECDH function 
ref. http://noiseprotocol.org/noise.html#overview-of-handshake-state-machine
Change `ss` to `es`, `ee`, `se` according to each case.
 2018-11-06 14:26:27 +11:00
lisa neigut
57dad8161b routing gossip: remove fixup statement 
per rusty, this is left over from a previous editing
pass and can be removed.
 2018-10-29 00:17:36 +00:00
lisa neigut
5a1dafb67f routing gossip: fixup final/endpoint nomenclature weirdness 
'final' and 'endpoint' node don't make much sense out of
context of a payment (in the former case) or when referring to
a non-channel party node. this fixes this
 2018-10-29 00:17:36 +00:00
lisa neigut
b4be990550 routing gossip: attempt to make timestamping mechanism for 
channel_announcement clearer
 2018-10-29 00:17:36 +00:00
lisa neigut
bae8f9c2c6 routing gossip: remove errant tick 2018-10-29 00:17:36 +00:00
lisa neigut
35cee93cee routing gossip: make channel_update singular 2018-10-29 00:17:36 +00:00
lisa neigut
74167366bb routing gossip, query message: attempt to clarify description of 
`query_short_channel_ids`
 2018-10-29 00:17:36 +00:00
lisa neigut
d88e58db90 routing gossip: add missing 'a' 2018-10-29 00:17:36 +00:00
lisa neigut
772e8b854a routing gossip: specify where gossip_queries is flagged on 2018-10-29 00:17:36 +00:00
lisa neigut
7d2c4d5542 routing gossip: re-order initial sync & rebroadcast so it matches table of contents 2018-10-29 00:17:36 +00:00
lisa neigut
b73c77ffe9 routing gosisp: use semi-colon, not colon 2018-10-29 00:17:36 +00:00
lisa neigut
1c6a00778e routing gossip: have Initial Sync be in present tense 2018-10-29 00:17:36 +00:00
lisa neigut
2427bdca7b routing-gossip: add clarifying statement to Initial Sync section 
The Initial Sync section is hard to parse, as is, because it's presented
without context. This adds a small clarifying statement, in particular
highlighting where the mode is triggered from (init message features)
and what in particular is being synced (gossip messages)
 2018-10-29 00:17:36 +00:00
lisa neigut
620b033dd6 routing gossip: clarify what 'redundant' means 2018-10-29 00:17:36 +00:00
ueno
1ddc1a54d7 BOLT2: both nodes send update_add_htlc 
issue #472
 2018-10-29 00:07:56 +00:00
Rusty Russell
bca814e270 BOLT 4: final_incorrect_htlc_amount should be 64-bits. 
Fixes: #469
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-10-18 05:17:48 +00:00
lisa neigut
80eed319ab gossip: add additional clarification for 'discard' 
It's unclear what it means to `discard` a channel.
This add a clarification that it's related to route-finding.
 2018-10-18 05:17:26 +00:00
Chris Stewart
25a9debcf3 Make unit explicit encoded in BOLT11 invoice 
Rewording
 2018-10-18 05:15:48 +00:00
Pierre-Marie Padiou
1fd1e76f9e clarify that error should target the unkown channel 2018-10-18 05:15:22 +00:00
Pierre-Marie Padiou
1de095a0b3 reply to unknown channels with an error 2018-10-18 05:15:22 +00:00