mirror of https://github.com/ACINQ/eclair.git synced 2025-02-28 16:57:49 +01:00

Bastien Teinturier 5b19e58601

Improve payinvoice API response (#2525 )

When sending an outgoing multi-part payment, we forward the preimage back
to the sender as soon as we receive the first `update_fulfill_htlc`.
This is particularly useful when relaying trampoline payments, to be able
to propagate the fulfill upstream as early as possible.

However this meant that callers of the HTTP API would receive this
preimage event instead of the final payment result, which was quite bad.
We now disable this first event when used with the `--blocking` argument,
which ensures that the API always returns the payment result.

Fixes #2389

2022-12-21 09:16:34 +01:00

1.8 KiB

Raw Blame History

Eclair vnext

Major changes

API changes

audit now accepts --count and --skip parameters to limit the number of retrieved items (#2474, #2487)
sendtoroute removes the --trampolineNodes argument and implicitly uses a single trampoline hop (#2480)
payinvoice always returns the payment result when used with --blocking, even when using MPP (#2525)

Miscellaneous improvements and bug fixes

Verifying signatures

You will need gpg and our release signing key 7A73FE77DE2C4027. Note that you can get it:

from our website: https://acinq.co/pgp/drouinf.asc
from github user @sstone, a committer on eclair: https://api.github.com/users/sstone/gpg_keys

To import our signing key:

$ gpg --import drouinf.asc

To verify the release file checksums and signatures:

$ gpg -d SHA256SUMS.asc > SHA256SUMS.stripped
$ sha256sum -c SHA256SUMS.stripped

Building

Eclair builds are deterministic. To reproduce our builds, please use the following environment (*):

Ubuntu 20.04
AdoptOpenJDK 11.0.6
Maven 3.8.1

Use the following command to generate the eclair-node package:

mvn clean install -DskipTests

That should generate eclair-node/target/eclair-node-<version>-XXXXXXX-bin.zip with sha256 checksums that match the one we provide and sign in SHA256SUMS.asc

(*) You may be able to build the exact same artefacts with other operating systems or versions of JDK 11, we have not tried everything.

Upgrading

This release is fully compatible with previous eclair versions. You don't need to close your channels, just stop eclair, upgrade and restart.

Changelog

1.8 KiB Raw Blame History