core-lightning/tests
niftynei 3190c26bc9 dualfund: error on out of order sigs
We weren't blocking if the tx-sigs arrived before the commitment sigs.

This was causing problems in the openchannel (spender plugin)

spenderp: FATAL SIGNAL 11 (version v23.08.1-404-g62ff475-modded)
0x559836dc98ba send_backtrace
	common/daemon.c:33
0x559836dc9951 crashdump
	common/daemon.c:75
0x7f37f42c351f ???
	./signal/../sysdeps/unix/sysv/linux/x86_64/libc_sigaction.c:0
0x7f37f441ac92 ???
	../sysdeps/x86_64/multiarch/memcmp-avx2-movbe.S:83
0x559836db7760 bitcoin_txid_eq
	./bitcoin/tx.h:29
0x559836db7760 collect_sigs
	plugins/spender/openchannel.c:509
0x559836db81de check_sigs_ready
	plugins/spender/openchannel.c:531
0x559836db84dd json_peer_sigs
	plugins/spender/openchannel.c:611
0x559836dbcad7 ld_command_handle
	plugins/libplugin.c:1611
0x559836dbcd9d ld_read_json_one
	plugins/libplugin.c:1721
0x559836dbce29 ld_read_json
	plugins/libplugin.c:1741
0x559836ef3bff next_plan
	ccan/ccan/io/io.c:59
0x559836ef40da do_plan
	ccan/ccan/io/io.c:407
0x559836ef4177 io_ready
	ccan/ccan/io/io.c:417
0x559836ef5b14 io_loop
	ccan/ccan/io/poll.c:453
0x559836dbd48d plugin_main
	plugins/libplugin.c:1948
0x559836db22bf main
	plugins/spender/main.c:35
0x7f37f42aad8f __libc_start_call_main
	../sysdeps/nptl/libc_start_call_main.h:58
0x7f37f42aae3f __libc_start_main_impl
	../csu/libc-start.c:392
0x559836da3774 ???
	???:0
0xffffffffffffffff ???
	???:0
2023-10-31T15:15:57.458Z INFO    plugin-spenderp: Killing plugin: exited during normal operation
2023-10-31T15:15:57.458Z **BROKEN** plugin-spenderp: Plugin marked as important, shutting down lightningd!
2023-10-31T15:15:57.458Z DEBUG   lightningd: io_break: lightningd_exit
2023-10-31T15:15:57.458Z DEBUG   lightningd: io_loop_with_timers: main
2023-10-31T15:15:57.458Z DEBUG   connectd: REPLY WIRE_CONNECTD_START_SHUTDOWN_REPLY with 0 fds
2023-10-31T15:15:57.458Z DEBUG   lightningd: io_break: connectd_start_shutdown_reply
2023-10-31T15:15:57.458Z DEBUG   021ccce7bc396996c8f3b7bfeb1e30c6600269517026a74adfe2217b7187879797-dualopend-chan#1: Status closed, but not exited. Killing
2023-10-31T15:15:57.458Z DEBUG   lightningd: Command returned result after jcon close
2023-10-31T15:15:57.458Z INFO    021ccce7bc396996c8f3b7bfeb1e30c6600269517026a74adfe2217b7187879797-chan#1: Unsaved peer failed. Deleting channel.
2023-10-31T15:15:57.464Z DEBUG   lightningd: io_break: destroy_plugin
2023-10-31T15:15:57.464Z DEBUG   connectd: Shutting down
2023-10-31T15:15:57.464Z DEBUG   gossipd: Shutting down
2023-10-31T15:15:57.464Z DEBUG   hsmd: Shutting down

Reported-By: @t-bast
2023-11-02 19:32:05 +10:30
..
data db: migrate old runes table to fix up id fields. 2023-08-31 05:33:15 +09:30
fuzz fuzz: new bolt11 seeds 2023-10-24 12:17:18 +10:30
plugins pytest: test for accepting even unknown messages. 2023-10-24 11:50:57 +10:30
vectors pytest: Remove onion test vectors containing legacy onions. 2022-03-18 09:20:11 +10:30
benchmark.py pytest: always provide payment_secret when making payments. 2021-07-14 14:38:00 -05:00
conftest.py pytest: use --developer instead of environment variable. 2023-09-21 20:08:24 +09:30
db.py test-db-provider: if postgres in tests, startup a bookkeeper db 2022-07-28 12:08:18 +09:30
fixtures.py pytest: use --developer instead of environment variable. 2023-09-21 20:08:24 +09:30
rkls_github_canned_server.py pytest: add blackbox tests for reckless 2023-04-09 12:41:11 +09:30
test_bookkeeper.py pytest: wean many tests off the assumption that listchannels shows private channels. 2023-10-04 08:02:33 +10:30
test_cln_rs.py cln-plugin: Add test for cln-plugin send_custom_notification 2023-10-30 18:24:23 +01:00
test_closing.py lightningd: add a feerate offset when updating feerates as opener 2023-11-02 09:49:59 +10:30
test_connection.py dualfund, tests: break out "peer forgets" test 2023-11-02 19:32:05 +10:30
test_db.py pytest: use --developer instead of environment variable. 2023-09-21 20:08:24 +09:30
test_gossip.py pytest: Fix a falke in test_gossip_pruning 2023-10-26 15:51:07 +02:00
test_invoices.py add test, update schemas, fix warning_custom_fallbacks 2023-10-26 19:11:17 +10:30
test_misc.py lightningd: wumbo is now the default, setting has no effect. 2023-11-02 08:16:51 +01:00
test_mkfunding.py pytest: add tests for devtools/mkfunding 2023-01-09 14:50:30 -06:00
test_onion.py lightningd: remove support for legacy onion format. 2022-03-18 09:20:11 +10:30
test_opening.py dualfund: error on out of order sigs 2023-11-02 19:32:05 +10:30
test_pay.py lightningd: wumbo is now the default, setting has no effect. 2023-11-02 08:16:51 +01:00
test_plugin.py dualfund: split 'commit-received' into two parts 2023-11-02 19:32:05 +10:30
test_reckless.py pytest: add reckless local install test 2023-07-27 06:53:49 +09:30
test_renepay.py pytest: use --developer instead of environment variable. 2023-09-21 20:08:24 +09:30
test_runes.py pytest: correctly test missing method for runes. 2023-10-17 14:58:40 +10:30
test_splicing.py splice: Update test for new logs 2023-10-27 13:20:33 +10:30
test_wallet.py addpsbtoutput: allow command to specify output address. 2023-11-01 14:11:28 +10:30
utils.py lightningd: wumbo is now the default, setting has no effect. 2023-11-02 08:16:51 +01:00
valgrind-suppressions.txt pytest: Use valgrind target suppressions instead of skipping tests 2022-03-10 10:21:41 +10:30