mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-02-22 06:41:44 +01:00
Code Issues Projects Releases Wiki Activity

pytest: correctly test missing method for runes.

Browse source 
This makes it clear exactly what the expectation is/

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2023-10-16 10:45:44 +10:30
parent 8ac9c73ea8
commit cdd58e2fe3
1 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
tests/test_runes.py
View file

@ -594,8 +594,8 @@ def test_missing_method_or_nodeid(node_factory):
l1.rpc.checkrune(rune=rune4, nodeid=l1.info['id'])
def test_rune_method_not_equal_and_method_empty(node_factory):
"""Test `checkrune` when `method` parameter is the empty string and a `method` is negated in the rune."""
def test_rune_method_missing(node_factory):
"""Test `checkrune` when `method` parameter not set `method` is negated in the rune."""
l1 = node_factory.get_node()
rune = l1.rpc.createrune(restrictions=[["method/getinfo"]])['rune']
@ -603,7 +603,18 @@ def test_rune_method_not_equal_and_method_empty(node_factory):
l1.rpc.checkrune(rune=rune, method='getinfo')
assert l1.rpc.checkrune(rune=rune, method='invoice')['valid'] is True
with pytest.raises(RpcError, match='Not permitted: method not present'):
l1.rpc.checkrune(rune=rune, method='')
l1.rpc.checkrune(rune=rune, method=None)
rune2 = l1.rpc.createrune(restrictions=[["method!"]])['rune']
with pytest.raises(RpcError, match='Not permitted: method is present'):
l1.rpc.checkrune(rune=rune2, method='getinfo')
with pytest.raises(RpcError, match='Not permitted: method is present'):
l1.rpc.checkrune(rune=rune2, method='')
# These two are equivalent (our Python wrapper removes None params)
l1.rpc.checkrune(rune=rune2)
l1.rpc.checkrune(rune=rune2, method=None)
def test_invalid_restrictions(node_factory):