luca vaccaro
d36fa33c9b
Explain table vars ( #792 )
...
* Database Table vars
Explain Database Table vars and bip32_max_index variable.
2018-01-28 01:41:31 +01:00
ZmnSCPxj
d03ca59f80
jsonrpc: Report standard JSON-RPC 2.0 error codes.
2018-01-27 14:32:06 +01:00
ZmnSCPxj
e1d17e92e0
jsonrpc: Implement command_fail_detailed.
2018-01-27 14:32:06 +01:00
ZmnSCPxj
551dfedc4a
jsonrpc: Internal: Support changing the error code internally.
2018-01-27 14:32:06 +01:00
ZmnSCPxj
b2133e969f
jsonrpc: Trivial compliance with JSON-RPC Error Object.
2018-01-27 14:32:06 +01:00
ZmnSCPxj
8c527f3931
common/json: Implement json_add_snum for signed numbers.
2018-01-27 14:32:06 +01:00
Christian Decker
1da27c51c2
gossip: Remove annoying nonlocal_gossip_broadcast_done status
...
Reported-by: @RvMP
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-01-27 02:27:35 +00:00
Christian Decker
a7a6b4646a
json-rpc: Remove alarming debug statement
...
People keep on stumbling over this, since it's rather alarming.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-01-27 02:27:35 +00:00
Christian Decker
3d2ef44064
gossipd: Do not report bind failures for IPv4
2018-01-27 02:27:35 +00:00
Christian Decker
8bf9f28a79
doc: Specify that pruned nodes do not work currently
2018-01-27 02:27:35 +00:00
Christian Decker
45c935ddba
pytest: Have the db_query helper work on a copy of the DB
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-01-27 02:27:35 +00:00
Rusty Russell
24ba5d6250
channeld: don't spam with all our attempts to commit.
...
Reported-by: @jb55
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-01-26 17:53:50 +01:00
Ronald van der Meer
8e087c1d71
clarified lightning-cli help dev-setfees description
2018-01-26 03:00:29 +00:00
Ronald van der Meer
fa992ecaab
clarified --lightning-dir syntax on help
2018-01-26 03:00:29 +00:00
William Casarin
5b4a62d822
doc: some sqlite db info for HACKING
...
Signed-off-by: William Casarin <jb55@jb55.com>
2018-01-26 01:20:07 +00:00
Christian Decker
6cfc0a6275
fixup! masterd: Disable a channel when channeld fails
2018-01-26 01:09:44 +00:00
Christian Decker
2e5047f74b
pytest: Fix test_pay_disconnect
...
We are now too quick in disabling the channel for us to attempt a
payment. We need to separate into getroute and sendpay to trigger this
now.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-01-26 01:09:44 +00:00
Christian Decker
dafd000c2a
pytest: Check that we disable on closing and permfail.
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-01-26 01:09:44 +00:00
Christian Decker
e463386d75
masterd: Disable a channel when channeld fails
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-01-26 01:09:44 +00:00
Christian Decker
007c349dec
gossip: Implement handler for enabling and disabling channels
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-01-26 01:09:44 +00:00
Christian Decker
c6ae4b521f
gossip: Add message to enable and disable a channel
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-01-26 01:09:44 +00:00
Christian Decker
d14969ce77
masterd: Peer has to know which direction an eventual channel is
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-01-26 01:09:44 +00:00
Christian Decker
4f4b0e9bba
channeld: Tell gossipd when we get a shutdown message from a peer
...
Disabling the channel and enqueing the update for broadcast so we
don't get forwarding requests from remote peers, and we don't try to
ourselves.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-01-26 01:09:44 +00:00
Christian Decker
6320142c34
channeld: Send disabling channel_update on shutdown
...
Sends a disable channel_update before issuing the shutdown message,
gossipd will also take care to update others and not use for future
routes.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-01-26 01:09:44 +00:00
William Casarin
8aee38162c
doc: Nix{,OS} build instructions
...
Signed-off-by: William Casarin <jb55@jb55.com>
2018-01-26 01:02:51 +00:00
practicalswift
17aaa1d235
Fix lightning typos
2018-01-26 01:02:15 +00:00
practicalswift
3e40a48332
Add lightning spell check
2018-01-26 01:02:15 +00:00
practicalswift
2c17546cbd
Onboarding: Make "lightning-cli" (without arguments) output the equivalent of "lightning-cli --help; lightning-cli help"
...
New users invoking lightning-cli are likely interested in what RPC
commands they can invoke via the command.
2018-01-26 00:35:13 +00:00
Rusty Russell
bab3b1a16b
wallet: get first blocknum from any channels.
...
The previous tests didn't make sense anyway, but I think they were trying
to exclude onchain channels.
We delete completely forgotten channels anyway now, so we don't need
such testing.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-01-25 12:52:06 +01:00
Rusty Russell
661950e402
wallet: fix logic for finding first block.
...
Over 20 years a professional C programmer, still can't count from zero!
Fixes : #709
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-01-25 12:52:06 +01:00
Rusty Russell
e66bd25b5c
test_lightningd.py: test lockin while we're not running.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-01-25 12:52:06 +01:00
Rusty Russell
9f9c34002e
chain_topology: log block height, not just hash.
...
Saves me a lookup.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-01-25 12:52:06 +01:00
Rusty Russell
e9328217ff
peer_control: better logging when we don't tell peer about locked funding.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-01-25 12:52:06 +01:00
Rusty Russell
c42fa4404a
connect: succeed if we connect to peer and it *doesn't* go back to gossipd.
...
The JSON connect command wouldn't terminate if peer reconnected
in a state CHANNELD_AWAITING_LOCKIN or above.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-01-25 12:52:06 +01:00
practicalswift
b91556283b
Onboarding: Adjust log level for common non-fatal peer state condition from info to debug
2018-01-25 00:28:47 +00:00
practicalswift
3a8220d630
Warn instead of crash when extract_feerate(...) fails
...
Fixes : #722
2018-01-25 00:16:14 +00:00
practicalswift
0557467dfa
Adjust log level for feerate warnings
...
This condition seems to be triggered quite common on testnet, so no
need for warning floods unless we're running in debug mode :-)
2018-01-25 00:15:47 +00:00
Christian Decker
7b0d806d71
pytest: Check that we forget irrevocably settled channels
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-01-25 00:14:23 +00:00
Christian Decker
9588c961bb
wallet: Forget channels that are irrevocably settled on-chain
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-01-25 00:14:23 +00:00
Rusty Russell
f03dbde354
test_lightningd.py: Test 0-msatoshi pay
...
Based-on-patch-by: ZmnSCPxj <ZmnSCPxj@protonmail.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-01-24 19:34:46 +01:00
Rusty Russell
45665a994b
htlc_end: allow htlc_out to have 0 msatoshi.
...
Such an htlc is invalid, and will be failed cleanly by our channeld
(which also checks that it meets the minimum amount), but it's
not the master's job to check it, and in fact, it asserts if we were
to try to pay or forward such a thing.
Fixes : #686
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-01-24 19:34:46 +01:00
Rusty Russell
3ccf88d6c4
lightningd: check channeld isn't trying to add 0-satoshi incoming HTLCs.
...
The peer shouldn't try, and channeld won't try to add it if it does,
but we shouldn't trust it. And it would make our htlc_in_check() code
assert.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-01-24 19:34:46 +01:00
William Casarin
3cb03ab784
bitcoin: add test programs to ALL_TEST_PROGRAMS
...
* Add BITCOIN_TEST_PROGRAMS to ALL_TEST_PROGRAMS
* Refactor bitcoin test make directives into its own Makefile under bitcoin/test
Signed-off-by: William Casarin <jb55@jb55.com>
2018-01-24 17:42:32 +01:00
alaniz
5421e9f6f2
pylightning: Add and move example to README
2018-01-24 17:30:32 +01:00
practicalswift
96d093fb30
Fix typos
2018-01-24 17:29:40 +01:00
Carl Dong
feb734086b
build: Update INSTALL.md to include FreeBSD.
2018-01-23 16:10:19 +01:00
Carl Dong
f55adbdc9c
build: Add necessary build/link flags for FreeBSD.
2018-01-23 16:10:19 +01:00
Carl Dong
8da65854f0
build: Add needed UNIX standard includes.
2018-01-23 16:10:19 +01:00
Carl Dong
75f4b56766
build: Correctly build and link ptr_valid.
2018-01-23 16:10:19 +01:00
Björge Dijkstra
2f4ba73c77
Allocate hex buffer on heap since it can be very large.
2018-01-23 13:33:29 +01:00