mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2024-11-20 02:27:51 +01:00
Code Issues Projects Releases Wiki Activity
9,860 Commits 30 Branches 190 Tags 193 MiB
61d146a2e7
Commit Graph

9860 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rusty Russell
61d146a2e7 pytest: fix gossip flake in test_restart_many_payments 
```
2021-05-23T09:18:56.9768962Z lightningd-4: 2021-05-23T08:33:31.918Z DEBUG   0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-gossipd: Ignoring future channel_announcment for 103x4x0 (current block 102)
2021-05-23T09:18:56.9771608Z lightningd-4: 2021-05-23T08:33:31.918Z DEBUG   0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-gossipd: Bad gossip order: WIRE_CHANNEL_UPDATE before announcement 103x4x0/0
2021-05-23T09:18:56.9774035Z lightningd-4: 2021-05-23T08:33:31.919Z DEBUG   0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-gossipd: Bad gossip order: WIRE_CHANNEL_UPDATE before announcement 103x4x0/1
```

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-05-25 16:25:17 +02:00
Rusty Russell
a4cb99361d CI: give nicer names to Ci runners. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-05-25 16:25:17 +02:00
Antoine Poinsot
9a363c6f9e doc/TOR: remove references to deprecated v2 hidden services 
The doc is really confusing and would probably need a refactor, i did my
best to remove references to v2 services without losing any meaning...

Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
 2021-05-24 20:22:45 +09:30
Antoine Poinsot
e6527ccece options: deprecate v2 mode for autotor 
Changelog-Deprecated: Changelog-Deprecated: lightningd: `enable-autotor-v2-mode` option.  Use v3.  See https://blog.torproject.org/v2-deprecation-timeline.

Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
 2021-05-24 20:22:45 +09:30
Antoine Poinsot
fe8074c8c3 Refuse to parse v2 onion addresses without deprecated_apis 
Tor v2 hidden services have been deprecated for a while:
https://blog.torproject.org/v2-deprecation-timeline .

This prevents user from being able to set them in the configuration
and to connect to them while still letting us be able to parse them
for gossip.

Changelog-Deprecated: lightningd: v2 Tor addresses.  Use v3.  See https://blog.torproject.org/v2-deprecation-timeline.

Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
 2021-05-24 20:22:45 +09:30
Antoine Poinsot
7bf17572b5 wireaddr: fix indentation / line breaks for autotor parsing 
It really affected readability.

Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
 2021-05-24 20:22:45 +09:30
Rusty Russell
d70661d32e pytest: check nonstandard onion generation. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-05-24 12:52:19 +02:00
Rusty Russell
2c9cb8c9e0 devtools/onion: handle onions which are not 1300 bytes long. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-05-24 12:52:19 +02:00
fiatjaf
64199d99fd "createonion" to accept an optional custom onion_size. 
Changelog-Added: `createonion` RPC command now accepts an optional `onion_size`.
 2021-05-24 12:52:19 +02:00
urza
7bd6b5a108 readme: fix ubuntu installation instructions 
I have verified that this results in working bitcoin core and c-lightning on fresh Ubuntu 20.04 server installation.

This is also consistent with instructions in doc/INSTALL.md

Fixes:  #4538
Reported-By: @urza
Changelog-None: readme change only
 2021-05-24 13:45:47 +09:30
Dave Scotese
f798fb1dd6 Clearer RETURN VALUE 
When I read the RETURN VALUE the first time, I didn't realize this command produces (or recreates) the psbt that I need.  The change I made makes that more obvious when it's presented as a hit by GH for a search for psbt.

[ Generated man page --RR ]
 2021-05-24 13:45:10 +09:30
Dave Scotese
cb7e7b293f added FAQ on getting a PSBT 
It may also be appropriate to update the description of utxopsbt so that the search hits for "psbt" here on github make it clearer that utxopsbt returns what you're seeking.  I'll make that part of this pull request too.
 2021-05-24 13:45:10 +09:30
niftynei
8c949be207 dual-open: save our now updated info about broadcast state 2021-05-24 12:17:48 +09:30
niftynei
9d9fdfdfa6 rbf-test: confirm that rbf'd inflight is opened and closed as expected 
We weren't testing that a non-tip inflight would get opened correctly.
Until now, that is.
 2021-05-24 12:17:48 +09:30
niftynei
b3565fe2ed nit: add another debug log 
log when we're telling the peer our depth's been reached
 2021-05-24 12:17:48 +09:30
niftynei
85ec604238 rbf: when a peer is activated, also keep track of all of its inflights 
We weren't watching for all inflights after the node is restarted.
Yikes.
 2021-05-24 12:17:48 +09:30
niftynei
d04c373283 rbf: when a channel is open, remove all the inflights 
The channel's open has been mined, we don't need to keep all of these around
now.
 2021-05-24 12:17:48 +09:30
niftynei
062bc12813 rbf: update the channel's funding_txid to match what's mined 
If the peer is offline when we see the funding txid, we don't actually
update the channel's info. Here, we move it up to where the scid is set,
so that we always update the channel's funding_txid to the correct
(mined) information.
 2021-05-24 12:17:48 +09:30
niftynei
e45b09358a inflights: relax assertion channel funding_txid is last inflight txid 
This assertion is not valid if a non-last funding tx is mined
 2021-05-24 12:17:48 +09:30
niftynei
d6bd6cc5cf open-rbf: we broadcast all the commitments for a channel when closed 
If you drop an rbf'd channel to chain (before any updates have been
made) we should drop *all* of the inflights to chain
 2021-05-24 12:17:48 +09:30
niftynei
dff9516cad rbf-tests: check every inflight has signed commitment produced 
Little check to make sure that we can produce a signed commitment tx for
every inflight we've got saved.
 2021-05-24 12:17:48 +09:30
niftynei
4247ec3a05 inflights: save the whole psbt to the database 
Otherwise we're missing info when we go to broadcast these and can't
properly sign the transaction to close it.

Found-by: @jasan
 2021-05-24 12:17:48 +09:30
niftynei
1d922bff1c dev-sign-last-tx: include inflight signed txs 
For convenience sake, include the inflight's signed txs as well
 2021-05-24 12:17:48 +09:30
niftynei
f468c204eb listpeers: always show all the inflights 
If you close a channel, the state won't be DUALOPEND_AWAITING_LOCKIN
 2021-05-24 12:17:48 +09:30
niftynei
e6c7928e76 listpeers: show the inflight's 'commitment tx' txid 
Changelog-Added: EXPERIMENTAL JSON-RPC: `listpeers` now includes the `scratch_txid` for every inflight (if is a dual-funded channel)
 2021-05-24 12:17:48 +09:30
niftynei
5f1ba02ece rbf: on close, drop every inflight transaction's commitment 
If it's a unilateral close, we need to drop all the inflights also,
as we don't know which of them ended up being mined.
 2021-05-24 12:17:48 +09:30
niftynei
727d7e9493 df-rbf: test that, with enough bumps, we can eventually add to mempool 
We don't pass the minimum fee requirement the first few times we attempt
an RBF, so it fails. Keep going until actually replaces
 2021-05-24 12:17:48 +09:30
niftynei
024bc83fca listpeers: add inflights info 
Changelog-Added: for v2 channels, we now list the inflights information for a channel
 2021-05-24 12:17:48 +09:30
niftynei
8925fc8b01 inflights: add checks that there's actually an inflight 2021-05-24 12:17:48 +09:30
niftynei
82fa3fa2ef df-rbf: order inflights by funding_feerate 
When we re-populate from disk, we need to know what order to recreate the
inflights list in.

Fixes #4511
 2021-05-24 12:17:48 +09:30
niftynei
8ae9f6ac9e df-tests: add better explainer for test logic 2021-05-24 12:17:48 +09:30
niftynei
bab5ef4aff df-test: test for a failed rbf attempt, currently crashes 
An attempted + failed RBF results in a crashed/dead node
 2021-05-24 12:17:48 +09:30
niftynei
e2867be609 df-tests: re-write test_funding_cancel_race for v2 commands 
test_funding_cancel_race uses fundchannel_open etc; this new test does a
similar (but not exact thing, as 'aborts' dont work after an update
is confirmed) thing, using openchannel_update and openchannel_abort.
 2021-05-23 17:42:09 +09:30
niftynei
2d4939fa6d df-tests: re-write the funding wallet corners test for v2 2021-05-23 17:42:09 +09:30
niftynei
8908dd08ec df-bugs: only include the funding if we're the opener 
`funding` field belongs to the INITIATOR!
 2021-05-23 17:42:09 +09:30
niftynei
260adb824e df: differentiate error message between 
There's a difference between "no channel" and "channel in progress
but no open available to cancel"
 2021-05-23 17:42:09 +09:30
Rusty Russell
4ae9e0c73f CI: Re-enable experimental build. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-05-23 08:20:59 +09:30
niftynei
477832057d funder: print reason that we don't contribute funds 
If we don't put funds into a channel, say why in the logs. Should make
it a bit easier to figure out what's going on.
 2021-05-23 08:19:50 +09:30
niftynei
c93bd5bd51 funder: test for adding utxos, calculating total available 
Make sure that 100% available actually puts in 100% of what we can add
(note that this isn't 'all' -- we don't include uneconomic utxos)
 2021-05-23 08:19:50 +09:30
niftynei
f6186d5860 funder: subtract the fee of the utxo from the available amount 
Adjust our total available funds downward, to account for the fees we'll
be charged to spend them.
 2021-05-23 08:19:50 +09:30
niftynei
9a1041ee97 fundpsbt: dont add utxos that are a net-loss 
if the utxo can't pay for its own fees, dont put it in the tx

Changelog-Changed: JSONRPC: fundpsbt will not include UTXOs that aren't economic (can't pay for their own fees), unless 'all'
 2021-05-23 08:19:50 +09:30
niftynei
5e7695f6a0 funder: add count of utxos we're signing to the logs 
Useful for asserting how many inputs we're contributing
 2021-05-23 08:19:50 +09:30
Rusty Russell
14febd4ecc pytest: disable mpp test which is blocking merges. 
I'm still diagnosing exactly why this fails, but it will need Christian's
help at this stage.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-05-23 08:13:27 +09:30
Rusty Russell
46b735c023 dijkstra: add chan pointer argument to path scoring. 
For fuzz, we will need some fixed per-channel data (so we always fuzz
a channel the same way).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-05-22 17:53:04 +09:30
Rusty Russell
3832542d27 common/dijkstra: remove dijkstra_amount(). 
Unless you're using amount as the sole cost function (we don't!), the
"cost" is not the "amount".

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-05-22 17:53:04 +09:30
Rusty Russell
2bb365a931 common/route: route_from_dijkstra returns route_hop array. 
This is what (most) callers actually want, so unify it into one place.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-05-22 17:53:04 +09:30
Rusty Russell
e531a38963 gossipd / plugin: clean up names in struct route_hop. 
We're going to unify them, but the names are not the normal ones.

Fix that first.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-05-22 17:53:04 +09:30
Rusty Russell
9dadcc858b common/gossip_store: avoid fd pass for new store, use end marker. 
This is also simpler.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-05-22 17:53:04 +09:30
Rusty Russell
c2a88912e1 common/gossmap: reload once we hit end marker. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-05-22 17:53:04 +09:30
Rusty Russell
0d4f014021 gossip_store: create end marker for EOF. 
This is better than using the previous "keep statting the file" approach,
since we can also tell you how long the replacement is, to avoid a
gratitous load.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-05-22 17:53:04 +09:30