Bas van Schaik
759156c71b
BuildCheckpoints: Fix possible resource leak.
2017-07-29 21:23:04 +02:00
Bas van Schaik
40c26b58bd
HttpDiscovery: Fix resource leak as a result of unclosed GZIPInputStream.
2017-07-29 21:21:16 +02:00
Andreas Schildbach
1381e86ff1
ECKey: Gender-neutralize a comment.
2017-07-27 14:18:48 +02:00
Nicola Atzei
5f95e510ef
Fix several javadoc warnings.
2017-07-27 10:35:21 +02:00
zkejid
ab24a70753
Avoid NullPointerException on preallocated exception (which has no message) in productive code.
...
For more information, see http://jawspeak.com/2010/05/26/hotspot-caused-exceptions-to-lose-their-stack-traces-in-production-and-the-fix/
2017-07-24 17:33:16 +02:00
Nicola Atzei
6b42e477f7
Script: Fix exception handling within isSentToMultiSig() method.
2017-07-24 15:24:11 +02:00
Andreas Schildbach
d982e5fe9d
Add mainnet and testnet seeds from Bloq.
2017-07-24 14:21:09 +02:00
Bo-Ye
3e62906971
FetchBlock example: Enhance this example to be able to connect DNS discovered peers so that you don't need to install bitcoind locally.
2017-07-24 14:17:48 +02:00
Andreas Schildbach
a2bb46bcd1
Unit tests: Disable a nasty HotSpot optimization that causes exception messages and traces to go missing.
...
For more information, see http://jawspeak.com/2010/05/26/hotspot-caused-exceptions-to-lose-their-stack-traces-in-production-and-the-fix/
2017-07-23 14:59:23 +02:00
Andreas Schildbach
640dda79f3
ECKey: Fix exception nessage of recently introduced check that constructed private key doesn't exceed 32 bytes.
2017-07-23 00:45:19 +02:00
Andreas Schildbach
89fb8c3bfa
script_tests.json: Two fixes synched from Bitcoin Core.
2017-07-18 19:21:57 +02:00
Nicola Atzei
c87da45321
Context: the overloaded constructor calls the most completed one
2017-07-17 11:38:39 +02:00
Andreas Schildbach
ce32f2a5ba
WalletTest: Extract empty sig constant.
2017-07-17 10:15:51 +02:00
Nicola Atzei
3cb1f6c6c5
Utils: Add some checks to bigIntegerToBytes().
2017-07-16 10:32:46 +02:00
Andreas Schildbach
3890219540
ECKey: Check that constructed private key doesn't exceed 32 bytes.
2017-07-12 10:10:21 +02:00
Nicola Atzei
c308d6ef1c
Script: Refactor executeScript() to follow Bitcoin Core implementation.
2017-07-12 10:05:32 +02:00
Nicola Atzei
e1760ec001
Scipt: Remove redundant cases of opcodes.
2017-07-12 10:01:02 +02:00
Gitju
106e9363a6
RegTestParams: MAX_TARGET to be created out of 64 hex digits
2017-07-11 18:09:25 +02:00
Nicola Atzei
d8af6b4be7
ScriptError: New error code for use in ScriptException. Script tests use this to assert for specific errors.
...
This also adds MINIMALDATA tests from Bitcoin Core into script_tests.json.
2017-07-11 18:01:28 +02:00
Nicola Atzei
bb176dab4d
Implement the CHECKSEQUENCEVERIFY script operator.
...
This also adds CSV-related tests from Bitcoin Core into script_tests.json, tx_valid.json and tx_invalid.json.
2017-07-05 18:45:33 +02:00
Andreas Schildbach
e3409e5d6d
Merge script_valid.json and script_invalid.json into one script_tests.json.
...
This also synchs script_tests.json to Bitcoin Core's version as of dde46d3ae1de18700e089bc1861cf1e18649dc5d, minus some of the newer 'invalid' tests which we can't handle yet.
We also need to check 'invalid' tests more specificly for the expected error; the current behaviour mimics how dataDrivenInvalidScripts() used to work.
The buildCreditingTransaction() and buildSpendingTransaction() methods were written by Nicola Atzei.
2017-07-05 14:33:03 +02:00
Jean-Pierre Rupp
083136e9e8
TransactionTest: Reformat some lengthy method invocations.
2017-07-01 16:42:23 +02:00
Andreas Schildbach
3ec862cf99
Transaction.SORT_TX_BY_HEIGHT: Use the Block.BLOCK_HEIGHT_UNKNOWN constant rather than -1.
2017-06-26 17:29:22 +02:00
Andreas Schildbach
e5f14e789a
ECDSASignature.decodeFromDER(): Now throws IllegalArgumentException if something with the input bytes is wrong. RuntimeException is bad!
2017-06-26 13:29:21 +02:00
Andreas Schildbach
0eabd240a6
Transaction.SORT_TX_BY_HEIGHT: For transactions not 'building', use -1 height for sorting purposes.
2017-06-25 20:18:37 +02:00
Andreas Schildbach
e3ca8f2d50
Wallet: Make calculateFee() private.
...
It was likely never meant for public consumption, because it's return type has always been private.
2017-06-25 20:02:22 +02:00
Andreas Schildbach
1692cd973e
Update wallet-template to Guava 22.0-android too.
2017-06-23 11:49:55 +02:00
Nicola
eceee6b6dd
Script: Fix two exception messages.
2017-06-14 16:38:43 +02:00
Andreas Schildbach
c24ef97ac0
Transaction.toString(): Clearly state if script is missing.
2017-06-02 16:55:40 +02:00
Andreas Schildbach
afc198600a
Utils: Inline join().
2017-06-02 16:55:40 +02:00
Andreas Schildbach
82fb22a884
Transaction: Fix two null pointer access warnings.
2017-06-02 16:22:53 +02:00
Andreas Schildbach
3fb4d6a1a3
Transaction.toString(): Print incomplete transactions, too.
2017-06-02 16:15:08 +02:00
Andreas Schildbach
6841fceabc
Transaction.getFee(): Do not determine fee on incomplete transactions.
2017-06-02 15:32:42 +02:00
Andreas Schildbach
e62275d41b
Update to Guava 22.0-android. This raises the Java API requirement to 1.7.
2017-05-31 16:37:04 +02:00
Saulius Beinorius
943a139d08
Fix for irrelevant double spend causing protobuf serialization issues
...
Fixes #1374 . Previously, transactions could have spentBy set but the spending transaction
dropped as being irrelevant. This would then be serialized to protobuf but could not be
deserialized.
2017-05-28 10:54:08 +02:00
Andreas Schildbach
9bde092143
Utils: Don't allow passing null into bigIntegerToBytes().
2017-05-16 19:35:54 +02:00
Andreas Schildbach
35b1028656
ScriptBuilder: Replace redundant code.
2017-04-06 16:41:19 +02:00
Thomas König
b890c9a9a1
ScriptBuilder: Fix number encoding for 16. It must be encoded with smallNum().
2017-04-06 16:39:54 +02:00
Oscar Guindzberg
e51428dcf6
Add "Recipients pay fees" feature to Wallet.completeTx(). There is a new SendRequest.recipientsPayFees field you can use.
...
Part of this code was written by @m-sossich.
2017-03-23 21:07:10 +01:00
Andreas Schildbach
ce07ceabc4
BIP32Test: New test vector, see https://github.com/bitcoin/bips/pull/497
2017-03-06 10:14:18 +01:00
Andreas Schildbach
7eb6854627
PeerAddress: Fix a constructor was hardcoded to the mainnet port.
2017-03-01 12:29:57 +01:00
Andreas Schildbach
53a71d7379
Transaction: Update DEFAULT_TX_FEE. Fees have risen considerably.
2017-03-01 00:09:01 +01:00
Oscar Guindzberg
4922036ae2
Wallet: Adjust lastCalculatedSize comment. The 1000 byte boundary is no longer used.
2017-02-28 23:52:07 +01:00
Giuseppe Raveduto
1fd8b90f42
Fix SendRequest package in forwarding.js.
2017-02-16 01:39:26 +01:00
Andreas Schildbach
9e72e72ef4
Update to OkHttp 3.6.0.
2017-02-12 17:28:55 +01:00
Andreas Schildbach
b7233f1245
Transaction: Print transaction version to toString().
2017-02-05 18:42:38 +01:00
Andreas Schildbach
be09b62062
WalletProtobufSerializer: Fix protobuf deserialization of transaction version.
2017-02-05 18:15:27 +01:00
Andreas Schildbach
380abd0d52
PeerAddress: Remove mostly unused setters to make the class more immutable.
2017-01-10 11:51:37 +01:00
Andreas Schildbach
88fec4e937
VersionMessage: Use Guava InetAddresses for localhost address.
2017-01-10 11:28:59 +01:00
Andreas Schildbach
9cbc45aeea
PeerAddress: Require NetworkParameters in constructors.
2017-01-10 11:23:25 +01:00