mirrors/bitcoinj
1
0
Fork 0
mirror of https://github.com/bitcoinj/bitcoinj.git synced 2025-03-13 11:36:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

BloomFilter: make hashFuncs, nTweak, and nFlags final

Browse source
This commit is contained in:
Sean Gilligan 2023-08-12 19:20:56 -07:00 • committed by Andreas Schildbach
parent 9bc0140910
commit 0a4592f189
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
core/src/main/java/org/bitcoinj/core/BloomFilter.java
View file

@ -66,9 +66,9 @@ public class BloomFilter extends BaseMessage {
}
private byte[] data;
private long hashFuncs;
private int nTweak;
private byte nFlags;
private final long hashFuncs;
private final int nTweak;
private final byte nFlags;
// Same value as Bitcoin Core
// A filter of 20,000 items and a false positive rate of 0.1% or one of 10,000 items and 0.0001% is just under 36,000 bytes
@ -138,8 +138,8 @@ public class BloomFilter extends BaseMessage {
size = max(1, min(size, (int) MAX_FILTER_SIZE * 8) / 8);
data = new byte[size];
// Optimal number of hash functions for a given filter size and element count.
hashFuncs = (int)(data.length * 8 / (double)elements * log(2));
hashFuncs = max(1, min(hashFuncs, MAX_HASH_FUNCS));
long numHashFuncs = (int)(data.length * 8 / (double)elements * log(2));
this.hashFuncs = max(1, min(numHashFuncs, MAX_HASH_FUNCS));
this.nTweak = randomNonce;
this.nFlags = (byte)(0xff & updateFlag.ordinal());
}