From 0a4592f189c4427f36fc3f528a2f9bb22fc06332 Mon Sep 17 00:00:00 2001 From: Sean Gilligan Date: Sat, 12 Aug 2023 19:20:56 -0700 Subject: [PATCH] BloomFilter: make `hashFuncs`, `nTweak`, and `nFlags` final --- core/src/main/java/org/bitcoinj/core/BloomFilter.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/core/src/main/java/org/bitcoinj/core/BloomFilter.java b/core/src/main/java/org/bitcoinj/core/BloomFilter.java index 2508133e6..e156b9953 100644 --- a/core/src/main/java/org/bitcoinj/core/BloomFilter.java +++ b/core/src/main/java/org/bitcoinj/core/BloomFilter.java @@ -66,9 +66,9 @@ public class BloomFilter extends BaseMessage { } private byte[] data; - private long hashFuncs; - private int nTweak; - private byte nFlags; + private final long hashFuncs; + private final int nTweak; + private final byte nFlags; // Same value as Bitcoin Core // A filter of 20,000 items and a false positive rate of 0.1% or one of 10,000 items and 0.0001% is just under 36,000 bytes @@ -138,8 +138,8 @@ public class BloomFilter extends BaseMessage { size = max(1, min(size, (int) MAX_FILTER_SIZE * 8) / 8); data = new byte[size]; // Optimal number of hash functions for a given filter size and element count. - hashFuncs = (int)(data.length * 8 / (double)elements * log(2)); - hashFuncs = max(1, min(hashFuncs, MAX_HASH_FUNCS)); + long numHashFuncs = (int)(data.length * 8 / (double)elements * log(2)); + this.hashFuncs = max(1, min(numHashFuncs, MAX_HASH_FUNCS)); this.nTweak = randomNonce; this.nFlags = (byte)(0xff & updateFlag.ordinal()); }