mirror of
https://github.com/bitcoin/bitcoin.git
synced 2024-11-20 10:38:42 +01:00
f32564f0a7
1abcecc40cTests: Use self.chain instead of 'regtest' in almost all current tests (Jorge Timón) Pull request description: Simply avoiding the hardcoded string in more places for consistency. It can also allow for more easily reusing tests for other chains other than regtest. Separated from #8994 . Continues #16509 . It is still not complete (ie to be complete, we need the -chain parameter in #16680 and make whether acceptnonstdtxs is allowed for that chain or not customizable for regtest [or for custom chains like in #8994 ] ). But while being incomplete like #16509 , it's quite simple to review and another step forward IMO. ACKs for top commit: Sjors: re-ACK1abcecc. I think it's an improvement even if incomplete and if some PR's might accidentally bring "regtest" back. Subsequent improvements hopefully don't have to touch 16 files. elichai: Code review ACK1abcecc40cryanofsky: Code review ACK1abcecc40c. ryanofsky: Code review ACK1abcecc40cTree-SHA512: 5620de6dab235ca8bd8670d6366c7b9f04f0e3ca9c5e7f87765b38e16ed80c17d7d1630c0d5fd7c5526f070830d94dc74cc2096d8ede87dc7180ed20569509ee
76 lines
2.9 KiB
Python
Executable File
76 lines
2.9 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2017-2019 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test debug logging."""
|
|
|
|
import os
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.test_node import ErrorMatch
|
|
|
|
|
|
class LoggingTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 1
|
|
self.setup_clean_chain = True
|
|
|
|
def relative_log_path(self, name):
|
|
return os.path.join(self.nodes[0].datadir, self.chain, name)
|
|
|
|
def run_test(self):
|
|
# test default log file name
|
|
default_log_path = self.relative_log_path("debug.log")
|
|
assert os.path.isfile(default_log_path)
|
|
|
|
# test alternative log file name in datadir
|
|
self.restart_node(0, ["-debuglogfile=foo.log"])
|
|
assert os.path.isfile(self.relative_log_path("foo.log"))
|
|
|
|
# test alternative log file name outside datadir
|
|
tempname = os.path.join(self.options.tmpdir, "foo.log")
|
|
self.restart_node(0, ["-debuglogfile=%s" % tempname])
|
|
assert os.path.isfile(tempname)
|
|
|
|
# check that invalid log (relative) will cause error
|
|
invdir = self.relative_log_path("foo")
|
|
invalidname = os.path.join("foo", "foo.log")
|
|
self.stop_node(0)
|
|
exp_stderr = r"Error: Could not open debug log file \S+$"
|
|
self.nodes[0].assert_start_raises_init_error(["-debuglogfile=%s" % (invalidname)], exp_stderr, match=ErrorMatch.FULL_REGEX)
|
|
assert not os.path.isfile(os.path.join(invdir, "foo.log"))
|
|
|
|
# check that invalid log (relative) works after path exists
|
|
self.stop_node(0)
|
|
os.mkdir(invdir)
|
|
self.start_node(0, ["-debuglogfile=%s" % (invalidname)])
|
|
assert os.path.isfile(os.path.join(invdir, "foo.log"))
|
|
|
|
# check that invalid log (absolute) will cause error
|
|
self.stop_node(0)
|
|
invdir = os.path.join(self.options.tmpdir, "foo")
|
|
invalidname = os.path.join(invdir, "foo.log")
|
|
self.nodes[0].assert_start_raises_init_error(["-debuglogfile=%s" % invalidname], exp_stderr, match=ErrorMatch.FULL_REGEX)
|
|
assert not os.path.isfile(os.path.join(invdir, "foo.log"))
|
|
|
|
# check that invalid log (absolute) works after path exists
|
|
self.stop_node(0)
|
|
os.mkdir(invdir)
|
|
self.start_node(0, ["-debuglogfile=%s" % (invalidname)])
|
|
assert os.path.isfile(os.path.join(invdir, "foo.log"))
|
|
|
|
# check that -nodebuglogfile disables logging
|
|
self.stop_node(0)
|
|
os.unlink(default_log_path)
|
|
assert not os.path.isfile(default_log_path)
|
|
self.start_node(0, ["-nodebuglogfile"])
|
|
assert not os.path.isfile(default_log_path)
|
|
|
|
# just sanity check no crash here
|
|
self.stop_node(0)
|
|
self.start_node(0, ["-debuglogfile=%s" % os.devnull])
|
|
|
|
|
|
if __name__ == '__main__':
|
|
LoggingTest().main()
|