mirror of
https://github.com/bitcoin/bitcoin.git
synced 2024-11-20 10:38:42 +01:00
f32564f0a7
1abcecc40cTests: Use self.chain instead of 'regtest' in almost all current tests (Jorge Timón) Pull request description: Simply avoiding the hardcoded string in more places for consistency. It can also allow for more easily reusing tests for other chains other than regtest. Separated from #8994 . Continues #16509 . It is still not complete (ie to be complete, we need the -chain parameter in #16680 and make whether acceptnonstdtxs is allowed for that chain or not customizable for regtest [or for custom chains like in #8994 ] ). But while being incomplete like #16509 , it's quite simple to review and another step forward IMO. ACKs for top commit: Sjors: re-ACK1abcecc. I think it's an improvement even if incomplete and if some PR's might accidentally bring "regtest" back. Subsequent improvements hopefully don't have to touch 16 files. elichai: Code review ACK1abcecc40cryanofsky: Code review ACK1abcecc40c. ryanofsky: Code review ACK1abcecc40cTree-SHA512: 5620de6dab235ca8bd8670d6366c7b9f04f0e3ca9c5e7f87765b38e16ed80c17d7d1630c0d5fd7c5526f070830d94dc74cc2096d8ede87dc7180ed20569509ee
49 lines
1.7 KiB
Python
Executable File
49 lines
1.7 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2019 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test bitcoind aborts if can't disconnect a block.
|
|
|
|
- Start a single node and generate 3 blocks.
|
|
- Delete the undo data.
|
|
- Mine a fork that requires disconnecting the tip.
|
|
- Verify that bitcoind AbortNode's.
|
|
"""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import wait_until, get_datadir_path, connect_nodes
|
|
import os
|
|
|
|
class AbortNodeTest(BitcoinTestFramework):
|
|
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 2
|
|
|
|
def setup_network(self):
|
|
self.setup_nodes()
|
|
# We'll connect the nodes later
|
|
|
|
def run_test(self):
|
|
self.nodes[0].generate(3)
|
|
datadir = get_datadir_path(self.options.tmpdir, 0)
|
|
|
|
# Deleting the undo file will result in reorg failure
|
|
os.unlink(os.path.join(datadir, self.chain, 'blocks', 'rev00000.dat'))
|
|
|
|
# Connecting to a node with a more work chain will trigger a reorg
|
|
# attempt.
|
|
self.nodes[1].generate(3)
|
|
with self.nodes[0].assert_debug_log(["Failed to disconnect block"]):
|
|
connect_nodes(self.nodes[0], 1)
|
|
self.nodes[1].generate(1)
|
|
|
|
# Check that node0 aborted
|
|
self.log.info("Waiting for crash")
|
|
wait_until(lambda: self.nodes[0].is_node_stopped(), timeout=200)
|
|
self.log.info("Node crashed - now verifying restart fails")
|
|
self.nodes[0].assert_start_raises_init_error()
|
|
|
|
if __name__ == '__main__':
|
|
AbortNodeTest().main()
|