bitcoin/src/rpc
MarcoFalke e542728cde
Merge #11303: Fix estimatesmartfee rounding display issue
1789e4675 Force explicit double -> int conversion for CFeeRate constructor (Matt Corallo)
53a6590f4 Make float <-> int casts explicit outside of test, qt, CFeeRate (Matt Corallo)
0b1b9148c Remove countMaskInv caching in bench framework (Matt Corallo)

Pull request description:

  This fixes an issue where estimatesmartfee which matches at the min relay fee will return 999 sat/byte instead of 1000 sat/byte due to a float rounding issue. I went ahead and made all float <-> int conversion outside of test/qt explicit (test only had one or two more, Qt had quite a few, including many in the Qt headers themselves) and added overloads to CFeeRate to force callers to do an explicit round themselves. Easy to test with -Wfloat-conversion.

Tree-SHA512: 66087b08e5dfca67506da54ae057c2f9d86184415e8fa4fa0199e38839e06a3ce96c836fcb7593b7d960065f5240c594ff3a0cfa14333ac528421f5aeac835c9
2017-09-30 18:07:55 +02:00
..
blockchain.cpp Unify help text for GetWarnings output in get*info RPCs 2017-09-27 11:27:26 -04:00
blockchain.h Remove unnecessary forward class declarations in header files 2017-06-12 20:37:43 +02:00
client.cpp Support BIP173 in addwitnessaddress 2017-09-28 16:24:33 -07:00
client.h rpc: Named argument support for bitcoin-cli 2017-01-10 12:04:54 +01:00
mining.cpp Change getmininginfo errors field to warnings 2017-09-27 11:27:26 -04:00
mining.h Properly bound check conf_target in wallet RPC calls 2017-07-14 23:41:40 -04:00
misc.cpp Implement BIP173 addresses and tests 2017-09-28 16:24:30 -07:00
net.cpp Merge #11303: Fix estimatesmartfee rounding display issue 2017-09-30 18:07:55 +02:00
protocol.cpp rpc: Handle getinfo locally in bitcoin-cli w/ -getinfo 2017-09-27 21:53:07 -04:00
protocol.h Merge #10871: Handle getinfo in bitcoin-cli w/ -getinfo (revival of #8843) 2017-09-28 08:33:36 +02:00
rawtransaction.cpp Merge #11309: Minor cleanups for AcceptToMemoryPool 2017-09-29 15:07:57 +02:00
register.h Do not shadow global RPC table variable (tableRPC) 2016-08-25 15:02:26 +02:00
safemode.cpp rpc: Push down safe mode checks 2017-08-29 10:09:41 +02:00
safemode.h rpc: Push down safe mode checks 2017-08-29 10:09:41 +02:00
server.cpp [rpc] Deprecate estimatefee RPC 2017-09-26 12:17:19 -04:00
server.h [rpc] Deprecate estimatefee RPC 2017-09-26 12:17:19 -04:00