bitcoin/test/functional
Jonas Schnelli d889c036cd
Merge #11403: SegWit wallet support
b224a47a1 Add address_types test (Pieter Wuille)
7ee54fd7c Support downgrading after recovered keypool witness keys (Pieter Wuille)
940a21932 SegWit wallet support (Pieter Wuille)
f37c64e47 Implicitly know about P2WPKH redeemscripts (Pieter Wuille)
57273f2b3 [test] Serialize CTransaction with witness by default (Pieter Wuille)
cf2c0b6f5 Support P2WPKH and P2SH-P2WPKH in dumpprivkey (Pieter Wuille)
37c03d3e0 Support P2WPKH addresses in create/addmultisig (Pieter Wuille)
3eaa003c8 Extend validateaddress information for P2SH-embedded witness (Pieter Wuille)
30a27dc5b Expose method to find key for a single-key destination (Pieter Wuille)
985c79552 Improve witness destination types and use them more (Pieter Wuille)
cbe197470 [refactor] GetAccount{PubKey,Address} -> GetAccountDestination (Pieter Wuille)
0c8ea6380 Abstract out IsSolvable from Witnessifier (Pieter Wuille)

Pull request description:

  This implements a minimum viable implementation of SegWit wallet support, based on top of #11389, and includes part of the functionality from #11089.

  Two new configuration options are added:
  * `-addresstype`, with options `legacy`, `p2sh`, and `bech32`. It controls what kind of addresses are produced by `getnewaddress`, `getaccountaddress`, and `createmultisigaddress`.
  * `-changetype`, with the same options, and by default equal to `-addresstype`, that controls what kind of change is used.

  All wallet private and public keys can be used for any type of address. Support for address types dependent on different derivation paths will need a major overhaul of how our internal detection of outputs work. I expect that that will happen for a next major version.

  The above also applies to imported keys, as having a distinction there but not for normal operations is a disaster for testing, and probably for comprehension of users. This has some ugly effects, like needing to associate the provided label to `importprivkey` with each style address for the corresponding key.

  To deal with witness outputs requiring a corresponding redeemscript in wallet, three approaches are used:
  * All SegWit addresses created through `getnewaddress` or multisig RPCs explicitly get their redeemscripts added to the wallet file. This means that downgrading after creating a witness address will work, as long as the wallet file is up to date.
  * All SegWit keys in the wallet get an _implicit_ redeemscript added, without it being written to the file. This means recovery of an old backup will work, as long as you use new software.
  * All keypool keys that are seen used in transactions explicitly get their redeemscripts added to the wallet files. This means that downgrading after recovering from a backup that includes a witness address will work.

  These approaches correspond to solutions 3a, 1a, and 5a respectively from https://gist.github.com/sipa/125cfa1615946d0c3f3eec2ad7f250a2. As argued there, there is no full solution for dealing with the case where you both downgrade and restore a backup, so that's also not implemented.

  `dumpwallet`, `importwallet`, `importmulti`, `signmessage` and `verifymessage` don't work with SegWit addresses yet. They're remaining TODOs, for this PR or a follow-up. Because of that, several tests unexpectedly run with `-addresstype=legacy` for now.

Tree-SHA512: d425dbe517c0422061ab8dacdc3a6ae47da071450932ed992c79559d922dff7b2574a31a8c94feccd3761c1dffb6422c50055e6dca8e3cf94a169bc95e39e959
2018-01-10 20:55:41 -10:00
..
test_framework Merge #11403: SegWit wallet support 2018-01-10 20:55:41 -10:00
.gitignore
abandonconflict.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
address_types.py Add address_types test 2018-01-09 15:35:31 -08:00
assumevalid.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
bip9-softforks.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
bip65-cltv-p2p.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
bip68-112-113-p2p.py Merge #11403: SegWit wallet support 2018-01-10 20:55:41 -10:00
bip68-sequence.py Merge #11403: SegWit wallet support 2018-01-10 20:55:41 -10:00
bipdersig-p2p.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
bitcoin_cli.py cli: Reject arguments to -getinfo 2017-11-17 15:11:50 +01:00
blockchain.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
bumpfee.py Merge #11403: SegWit wallet support 2018-01-10 20:55:41 -10:00
combine_logs.py
combined_log_template.html
conf_args.py Add configuration/argument testing 2017-12-20 12:23:12 +13:00
create_cache.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
dbcrash.py
decodescript.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
deprecated_rpc.py scripted-diff: rename assert_raises_jsonrpc to assert_raises_rpc error 2017-10-05 09:57:19 -04:00
disablewallet.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
disconnect_ban.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
example_test.py [tests] Fix network threading in functional tests 2017-12-11 09:17:21 -05:00
feature_logging.py test: Add tests for -debuglogfile with subdirs 2017-12-01 11:28:23 +01:00
fundrawtransaction.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
getblocktemplate_longpoll.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
getchaintips.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
httpbasics.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
import-rescan.py Merge #11403: SegWit wallet support 2018-01-10 20:55:41 -10:00
importmulti.py Merge #11403: SegWit wallet support 2018-01-10 20:55:41 -10:00
importprunedfunds.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
invalidateblock.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
invalidblockrequest.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
invalidtxrequest.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
keypool-topup.py Create walletdir if datadir doesn't exist and fix tests 2017-11-18 00:50:59 +13:00
keypool.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
listsinceblock.py Make listsinceblock refuse unknown block hash 2017-10-26 07:10:59 -04:00
listtransactions.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
maxuploadtarget.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
mempool_limit.py Merge #12001: [RPC] Adding ::minRelayTxFee amount to getmempoolinfo and updating help 2018-01-04 09:22:53 +01:00
mempool_packages.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
mempool_persist.py add test for unconfirmed balance between restarts 2017-12-11 09:14:50 -05:00
mempool_reorg.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
mempool_resurrect_test.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
mempool_spendcoinbase.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
merkle_blocks.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
minchainwork.py Remove unused imports 2017-11-17 15:34:28 +01:00
mining.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
multi_rpc.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
multiwallet.py Merge #11726: Cleanups + nit fixes for walletdir PR 2017-12-20 17:37:57 -05:00
net.py scripted-diff: rename assert_raises_jsonrpc to assert_raises_rpc error 2017-10-05 09:57:19 -04:00
node_network_limited.py [tests] refactor node_network_limited 2017-12-19 11:20:12 -05:00
notifications.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
nulldummy.py Merge #11403: SegWit wallet support 2018-01-10 20:55:41 -10:00
p2p-acceptblock.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
p2p-compactblocks.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
p2p-feefilter.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
p2p-fingerprint.py [tests] Use network_thread_start() in tests. 2017-12-11 09:17:21 -05:00
p2p-fullblocktest.py Merge #11403: SegWit wallet support 2018-01-10 20:55:41 -10:00
p2p-leaktests.py [tests] Fix network threading in functional tests 2017-12-11 09:17:21 -05:00
p2p-mempool.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
p2p-segwit.py Merge #11403: SegWit wallet support 2018-01-10 20:55:41 -10:00
p2p-timeouts.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
p2p-versionbits-warning.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
preciousblock.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
prioritise_transaction.py Merge #12079: Improve prioritisetransaction test coverage 2018-01-06 03:28:23 -09:00
proxy_test.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
pruning.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
rawtransactions.py Merge #11403: SegWit wallet support 2018-01-10 20:55:41 -10:00
README.md Fix incorrect Markdown link 2018-01-04 23:55:13 +01:00
receivedby.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
reindex.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
replace-by-fee.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
resendwallettransactions.py scripted-diff: rename assert_raises_jsonrpc to assert_raises_rpc error 2017-10-05 09:57:19 -04:00
rest.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
rpcbind_test.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
rpcnamedargs.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
segwit.py Merge #11403: SegWit wallet support 2018-01-10 20:55:41 -10:00
sendheaders.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
signmessages.py Merge #11403: SegWit wallet support 2018-01-10 20:55:41 -10:00
signrawtransactions.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
smartfees.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
test_runner.py Merge #11403: SegWit wallet support 2018-01-10 20:55:41 -10:00
txn_clone.py Merge #11403: SegWit wallet support 2018-01-10 20:55:41 -10:00
txn_doublespend.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
uacomment.py [tests] Add uacomment tests 2017-10-11 23:19:16 +03:00
uptime.py
wallet-accounts.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
wallet-dump.py Merge #11403: SegWit wallet support 2018-01-10 20:55:41 -10:00
wallet-encryption.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
wallet-hd.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
wallet.py Merge #11403: SegWit wallet support 2018-01-10 20:55:41 -10:00
walletbackup.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
zapwallettxes.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
zmq_test.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00

Functional tests

Writing Functional Tests

Example test

The example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • Avoid wildcard imports where possible
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramwork, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.

General test-writing advice

  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel or on Travis).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to control whether or not to use the cached data directories. The cached data directories contain a 200-block pre-mined blockchain and wallets for four nodes. Each node has 25 mature blocks (25x50=1250 BTC) in its wallet.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • mininode.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested (using python's asyncore package); the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

  • Call network_thread_start() after all P2PInterface objects are created to start the networking thread. (Continue with the test logic in your existing thread.)

  • Can be used to write tests where specific P2P protocol behavior is tested. Examples tests are p2p-accept-block.py, p2p-compactblocks.py.

Comptool

  • Comptool is a Testing framework for writing tests that compare the block/tx acceptance behavior of a bitcoind against 1 or more other bitcoind instances. It should not be used to write static tests with known outcomes, since that type of test is easier to write and maintain using the standard BitcoinTestFramework.

  • Set the num_nodes variable (defined in ComparisonTestFramework) to start up 1 or more nodes. If using 1 node, then --testbinary can be used as a command line option to change the bitcoind binary used by the test. If using 2 or more nodes, then --refbinary can be optionally used to change the bitcoind that will be used on nodes 2 and up.

  • Implement a (generator) function called get_tests() which yields TestInstances. Each TestInstance consists of:

    • A list of [object, outcome, hash] entries
      • object is a CBlock, CTransaction, or CBlockHeader. CBlock's and CTransaction's are tested for acceptance. CBlockHeaders can be used so that the test runner can deliver complete headers-chains when requested from the bitcoind, to allow writing tests where blocks can be delivered out of order but still processed by headers-first bitcoind's.
      • outcome is True, False, or None. If True or False, the tip is compared with the expected tip -- either the block passed in, or the hash specified as the optional 3rd entry. If None is specified, then the test will compare all the bitcoind's being tested to see if they all agree on what the best tip is.
      • hash is the block hash of the tip to compare against. Optional to specify; if left out then the hash of the block passed in will be used as the expected tip. This allows for specifying an expected tip while testing the handling of either invalid blocks or blocks delivered out of order, which complete a longer chain.
    • sync_every_block: True/False. If False, then all blocks are inv'ed together, and the test runner waits until the node receives the last one, and tests only the last block for tip acceptance using the outcome and specified tip. If True, then each block is tested in sequence and synced (this is slower when processing many blocks).
    • sync_every_transaction: True/False. Analogous to sync_every_block, except if the outcome on the last tx is "None", then the contents of the entire mempool are compared across all bitcoind connections. If True or False, then only the last tx's acceptance is tested against the given outcome.
  • For examples of tests written in this framework, see invalidblockrequest.py and p2p-fullblocktest.py.

test-framework modules

test_framework/authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework/test_framework.py

Base class for functional tests.

test_framework/util.py

Generally useful functions.

test_framework/mininode.py

Basic code to support P2P connectivity to a bitcoind.

test_framework/comptool.py

Framework for comparison-tool style, P2P tests.

test_framework/script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

test_framework/blockstore.py

Implements disk-backed block and tx storage.

test_framework/key.py

Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)

test_framework/bignum.py

Helpers for script.py

test_framework/blocktools.py

Helper functions for creating blocks and transactions.