mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-03-15 12:19:46 +01:00
cebaa3b2cf
Removes all legacy wallet specific functional tests. Also removes the --descriptor and --legacy-wallet options as these are no longer necessary with the legacy wallet removed.
364 lines
18 KiB
Python
Executable file
364 lines
18 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# Copyright (c) 2016-2022 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test the SegWit changeover logic."""
|
|
|
|
from decimal import Decimal
|
|
|
|
from test_framework.address import (
|
|
script_to_p2sh_p2wsh,
|
|
script_to_p2wsh,
|
|
)
|
|
from test_framework.blocktools import (
|
|
send_to_witness,
|
|
witness_script,
|
|
)
|
|
from test_framework.descriptors import descsum_create
|
|
from test_framework.messages import (
|
|
COIN,
|
|
COutPoint,
|
|
CTransaction,
|
|
CTxIn,
|
|
CTxOut,
|
|
tx_from_hex,
|
|
)
|
|
from test_framework.script import (
|
|
CScript,
|
|
OP_DROP,
|
|
OP_TRUE,
|
|
)
|
|
from test_framework.script_util import (
|
|
key_to_p2pk_script,
|
|
key_to_p2wpkh_script,
|
|
keys_to_multisig_script,
|
|
script_to_p2sh_script,
|
|
script_to_p2wsh_script,
|
|
)
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
assert_greater_than_or_equal,
|
|
assert_is_hex_string,
|
|
assert_raises_rpc_error,
|
|
)
|
|
from test_framework.wallet_util import (
|
|
get_generate_key,
|
|
)
|
|
|
|
NODE_0 = 0
|
|
NODE_2 = 2
|
|
P2WPKH = 0
|
|
P2WSH = 1
|
|
|
|
|
|
def getutxo(txid):
|
|
utxo = {}
|
|
utxo["vout"] = 0
|
|
utxo["txid"] = txid
|
|
return utxo
|
|
|
|
|
|
def find_spendable_utxo(node, min_value):
|
|
for utxo in node.listunspent(query_options={'minimumAmount': min_value}):
|
|
if utxo['spendable']:
|
|
return utxo
|
|
|
|
raise AssertionError(f"Unspent output equal or higher than {min_value} not found")
|
|
|
|
|
|
txs_mined = {} # txindex from txid to blockhash
|
|
|
|
|
|
class SegWitTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 3
|
|
# This test tests SegWit both pre and post-activation, so use the normal BIP9 activation.
|
|
self.extra_args = [
|
|
[
|
|
"-acceptnonstdtxn=1",
|
|
"-testactivationheight=segwit@165",
|
|
"-addresstype=legacy",
|
|
],
|
|
[
|
|
"-acceptnonstdtxn=1",
|
|
"-testactivationheight=segwit@165",
|
|
"-addresstype=legacy",
|
|
],
|
|
[
|
|
"-acceptnonstdtxn=1",
|
|
"-testactivationheight=segwit@165",
|
|
"-addresstype=legacy",
|
|
],
|
|
]
|
|
self.rpc_timeout = 120
|
|
|
|
def skip_test_if_missing_module(self):
|
|
self.skip_if_no_wallet()
|
|
|
|
def setup_network(self):
|
|
super().setup_network()
|
|
self.connect_nodes(0, 2)
|
|
self.sync_all()
|
|
|
|
def success_mine(self, node, txid, sign, redeem_script=""):
|
|
send_to_witness(1, node, getutxo(txid), self.pubkey[0], False, Decimal("49.998"), sign, redeem_script)
|
|
block = self.generate(node, 1)
|
|
assert_equal(len(node.getblock(block[0])["tx"]), 2)
|
|
self.sync_blocks()
|
|
|
|
def fail_accept(self, node, error_msg, txid, sign, redeem_script=""):
|
|
assert_raises_rpc_error(-26, error_msg, send_to_witness, use_p2wsh=1, node=node, utxo=getutxo(txid), pubkey=self.pubkey[0], encode_p2sh=False, amount=Decimal("49.998"), sign=sign, insert_redeem_script=redeem_script)
|
|
|
|
def run_test(self):
|
|
self.generate(self.nodes[0], 161) # block 161
|
|
|
|
self.log.info("Verify sigops are counted in GBT with pre-BIP141 rules before the fork")
|
|
txid = self.nodes[0].sendtoaddress(self.nodes[0].getnewaddress(), 1)
|
|
tmpl = self.nodes[0].getblocktemplate({'rules': ['segwit']})
|
|
assert_equal(tmpl['sizelimit'], 1000000)
|
|
assert 'weightlimit' not in tmpl
|
|
assert_equal(tmpl['sigoplimit'], 20000)
|
|
assert_equal(tmpl['transactions'][0]['hash'], txid)
|
|
assert_equal(tmpl['transactions'][0]['sigops'], 2)
|
|
assert '!segwit' not in tmpl['rules']
|
|
self.generate(self.nodes[0], 1) # block 162
|
|
|
|
balance_presetup = self.nodes[0].getbalance()
|
|
self.pubkey = []
|
|
p2sh_ids = [] # p2sh_ids[NODE][TYPE] is an array of txids that spend to P2WPKH (TYPE=0) or P2WSH (TYPE=1) scripts to an address for NODE embedded in p2sh
|
|
wit_ids = [] # wit_ids[NODE][TYPE] is an array of txids that spend to P2WPKH (TYPE=0) or P2WSH (TYPE=1) scripts to an address for NODE via bare witness
|
|
for i in range(3):
|
|
key = get_generate_key()
|
|
self.pubkey.append(key.pubkey)
|
|
|
|
multiscript = keys_to_multisig_script([self.pubkey[-1]])
|
|
p2sh_ms_addr = self.nodes[i].createmultisig(1, [self.pubkey[-1]], 'p2sh-segwit')['address']
|
|
bip173_ms_addr = self.nodes[i].createmultisig(1, [self.pubkey[-1]], 'bech32')['address']
|
|
assert_equal(p2sh_ms_addr, script_to_p2sh_p2wsh(multiscript))
|
|
assert_equal(bip173_ms_addr, script_to_p2wsh(multiscript))
|
|
|
|
p2sh_ms_desc = descsum_create(f"sh(wsh(multi(1,{key.privkey})))")
|
|
bip173_ms_desc = descsum_create(f"wsh(multi(1,{key.privkey}))")
|
|
assert_equal(self.nodes[i].deriveaddresses(p2sh_ms_desc)[0], p2sh_ms_addr)
|
|
assert_equal(self.nodes[i].deriveaddresses(bip173_ms_desc)[0], bip173_ms_addr)
|
|
|
|
sh_wpkh_desc = descsum_create(f"sh(wpkh({key.privkey}))")
|
|
wpkh_desc = descsum_create(f"wpkh({key.privkey})")
|
|
assert_equal(self.nodes[i].deriveaddresses(sh_wpkh_desc)[0], key.p2sh_p2wpkh_addr)
|
|
assert_equal(self.nodes[i].deriveaddresses(wpkh_desc)[0], key.p2wpkh_addr)
|
|
|
|
res = self.nodes[i].importdescriptors([
|
|
{"desc": p2sh_ms_desc, "timestamp": "now"},
|
|
{"desc": bip173_ms_desc, "timestamp": "now"},
|
|
{"desc": sh_wpkh_desc, "timestamp": "now"},
|
|
{"desc": wpkh_desc, "timestamp": "now"},
|
|
])
|
|
assert all([r["success"] for r in res])
|
|
|
|
p2sh_ids.append([])
|
|
wit_ids.append([])
|
|
for _ in range(2):
|
|
p2sh_ids[i].append([])
|
|
wit_ids[i].append([])
|
|
|
|
for _ in range(5):
|
|
for n in range(3):
|
|
for v in range(2):
|
|
wit_ids[n][v].append(send_to_witness(v, self.nodes[0], find_spendable_utxo(self.nodes[0], 50), self.pubkey[n], False, Decimal("49.999")))
|
|
p2sh_ids[n][v].append(send_to_witness(v, self.nodes[0], find_spendable_utxo(self.nodes[0], 50), self.pubkey[n], True, Decimal("49.999")))
|
|
|
|
self.generate(self.nodes[0], 1) # block 163
|
|
|
|
# Make sure all nodes recognize the transactions as theirs
|
|
assert_equal(self.nodes[0].getbalance(), balance_presetup - 60 * 50 + 20 * Decimal("49.999") + 50)
|
|
assert_equal(self.nodes[1].getbalance(), 20 * Decimal("49.999"))
|
|
assert_equal(self.nodes[2].getbalance(), 20 * Decimal("49.999"))
|
|
|
|
self.log.info("Verify unsigned p2sh witness txs without a redeem script are invalid")
|
|
self.fail_accept(self.nodes[2], "mandatory-script-verify-flag-failed (Operation not valid with the current stack size)", p2sh_ids[NODE_2][P2WPKH][1], sign=False)
|
|
self.fail_accept(self.nodes[2], "mandatory-script-verify-flag-failed (Operation not valid with the current stack size)", p2sh_ids[NODE_2][P2WSH][1], sign=False)
|
|
|
|
self.generate(self.nodes[0], 1) # block 164
|
|
|
|
self.log.info("Verify witness txs are mined as soon as segwit activates")
|
|
|
|
send_to_witness(1, self.nodes[2], getutxo(wit_ids[NODE_2][P2WPKH][0]), self.pubkey[0], encode_p2sh=False, amount=Decimal("49.998"), sign=True)
|
|
send_to_witness(1, self.nodes[2], getutxo(wit_ids[NODE_2][P2WSH][0]), self.pubkey[0], encode_p2sh=False, amount=Decimal("49.998"), sign=True)
|
|
send_to_witness(1, self.nodes[2], getutxo(p2sh_ids[NODE_2][P2WPKH][0]), self.pubkey[0], encode_p2sh=False, amount=Decimal("49.998"), sign=True)
|
|
send_to_witness(1, self.nodes[2], getutxo(p2sh_ids[NODE_2][P2WSH][0]), self.pubkey[0], encode_p2sh=False, amount=Decimal("49.998"), sign=True)
|
|
|
|
assert_equal(len(self.nodes[2].getrawmempool()), 4)
|
|
blockhash = self.generate(self.nodes[2], 1)[0] # block 165 (first block with new rules)
|
|
assert_equal(len(self.nodes[2].getrawmempool()), 0)
|
|
segwit_tx_list = self.nodes[2].getblock(blockhash)["tx"]
|
|
assert_equal(len(segwit_tx_list), 5)
|
|
|
|
self.log.info("Verify default node can't accept txs with missing witness")
|
|
# unsigned, no scriptsig
|
|
self.fail_accept(self.nodes[0], "mandatory-script-verify-flag-failed (Witness program hash mismatch)", wit_ids[NODE_0][P2WPKH][0], sign=False)
|
|
self.fail_accept(self.nodes[0], "mandatory-script-verify-flag-failed (Witness program was passed an empty witness)", wit_ids[NODE_0][P2WSH][0], sign=False)
|
|
self.fail_accept(self.nodes[0], "mandatory-script-verify-flag-failed (Operation not valid with the current stack size)", p2sh_ids[NODE_0][P2WPKH][0], sign=False)
|
|
self.fail_accept(self.nodes[0], "mandatory-script-verify-flag-failed (Operation not valid with the current stack size)", p2sh_ids[NODE_0][P2WSH][0], sign=False)
|
|
# unsigned with redeem script
|
|
self.fail_accept(self.nodes[0], "mandatory-script-verify-flag-failed (Witness program hash mismatch)", p2sh_ids[NODE_0][P2WPKH][0], sign=False, redeem_script=witness_script(False, self.pubkey[0]))
|
|
self.fail_accept(self.nodes[0], "mandatory-script-verify-flag-failed (Witness program was passed an empty witness)", p2sh_ids[NODE_0][P2WSH][0], sign=False, redeem_script=witness_script(True, self.pubkey[0]))
|
|
|
|
# Coinbase contains the witness commitment nonce, check that RPC shows us
|
|
coinbase_txid = self.nodes[2].getblock(blockhash)['tx'][0]
|
|
coinbase_tx = self.nodes[2].gettransaction(txid=coinbase_txid, verbose=True)
|
|
witnesses = coinbase_tx["decoded"]["vin"][0]["txinwitness"]
|
|
assert_equal(len(witnesses), 1)
|
|
assert_is_hex_string(witnesses[0])
|
|
assert_equal(witnesses[0], '00' * 32)
|
|
|
|
self.log.info("Verify witness txs without witness data are invalid after the fork")
|
|
self.fail_accept(self.nodes[2], 'mandatory-script-verify-flag-failed (Witness program hash mismatch)', wit_ids[NODE_2][P2WPKH][2], sign=False)
|
|
self.fail_accept(self.nodes[2], 'mandatory-script-verify-flag-failed (Witness program was passed an empty witness)', wit_ids[NODE_2][P2WSH][2], sign=False)
|
|
self.fail_accept(self.nodes[2], 'mandatory-script-verify-flag-failed (Witness program hash mismatch)', p2sh_ids[NODE_2][P2WPKH][2], sign=False, redeem_script=witness_script(False, self.pubkey[2]))
|
|
self.fail_accept(self.nodes[2], 'mandatory-script-verify-flag-failed (Witness program was passed an empty witness)', p2sh_ids[NODE_2][P2WSH][2], sign=False, redeem_script=witness_script(True, self.pubkey[2]))
|
|
|
|
self.log.info("Verify default node can now use witness txs")
|
|
self.success_mine(self.nodes[0], wit_ids[NODE_0][P2WPKH][0], True)
|
|
self.success_mine(self.nodes[0], wit_ids[NODE_0][P2WSH][0], True)
|
|
self.success_mine(self.nodes[0], p2sh_ids[NODE_0][P2WPKH][0], True)
|
|
self.success_mine(self.nodes[0], p2sh_ids[NODE_0][P2WSH][0], True)
|
|
|
|
self.log.info("Verify sigops are counted in GBT with BIP141 rules after the fork")
|
|
txid = self.nodes[0].sendtoaddress(self.nodes[0].getnewaddress(), 1)
|
|
raw_tx = self.nodes[0].getrawtransaction(txid, True)
|
|
tmpl = self.nodes[0].getblocktemplate({'rules': ['segwit']})
|
|
assert_greater_than_or_equal(tmpl['sizelimit'], 3999577) # actual maximum size is lower due to minimum mandatory non-witness data
|
|
assert_equal(tmpl['weightlimit'], 4000000)
|
|
assert_equal(tmpl['sigoplimit'], 80000)
|
|
assert_equal(tmpl['transactions'][0]['txid'], txid)
|
|
expected_sigops = 9 if 'txinwitness' in raw_tx["vin"][0] else 8
|
|
assert_equal(tmpl['transactions'][0]['sigops'], expected_sigops)
|
|
assert '!segwit' in tmpl['rules']
|
|
|
|
self.generate(self.nodes[0], 1) # Mine a block to clear the gbt cache
|
|
|
|
self.log.info("Non-segwit miners are able to use GBT response after activation.")
|
|
# Create a 3-tx chain: tx1 (non-segwit input, paying to a segwit output) ->
|
|
# tx2 (segwit input, paying to a non-segwit output) ->
|
|
# tx3 (non-segwit input, paying to a non-segwit output).
|
|
# tx1 is allowed to appear in the block, but no others.
|
|
txid1 = send_to_witness(1, self.nodes[0], find_spendable_utxo(self.nodes[0], 50), self.pubkey[0], False, Decimal("49.996"))
|
|
assert txid1 in self.nodes[0].getrawmempool()
|
|
|
|
tx1_hex = self.nodes[0].gettransaction(txid1)['hex']
|
|
tx1 = tx_from_hex(tx1_hex)
|
|
|
|
# Check that wtxid is properly reported in mempool entry (txid1)
|
|
assert_equal(int(self.nodes[0].getmempoolentry(txid1)["wtxid"], 16), tx1.calc_sha256(True))
|
|
|
|
# Check that weight and vsize are properly reported in mempool entry (txid1)
|
|
assert_equal(self.nodes[0].getmempoolentry(txid1)["vsize"], tx1.get_vsize())
|
|
assert_equal(self.nodes[0].getmempoolentry(txid1)["weight"], tx1.get_weight())
|
|
|
|
# Now create tx2, which will spend from txid1.
|
|
tx = CTransaction()
|
|
tx.vin.append(CTxIn(COutPoint(int(txid1, 16), 0), b''))
|
|
tx.vout.append(CTxOut(int(49.99 * COIN), CScript([OP_TRUE, OP_DROP] * 15 + [OP_TRUE])))
|
|
tx2_hex = self.nodes[0].signrawtransactionwithwallet(tx.serialize().hex())['hex']
|
|
txid2 = self.nodes[0].sendrawtransaction(tx2_hex)
|
|
tx = tx_from_hex(tx2_hex)
|
|
assert not tx.wit.is_null()
|
|
|
|
# Check that wtxid is properly reported in mempool entry (txid2)
|
|
assert_equal(int(self.nodes[0].getmempoolentry(txid2)["wtxid"], 16), tx.calc_sha256(True))
|
|
|
|
# Check that weight and vsize are properly reported in mempool entry (txid2)
|
|
assert_equal(self.nodes[0].getmempoolentry(txid2)["vsize"], tx.get_vsize())
|
|
assert_equal(self.nodes[0].getmempoolentry(txid2)["weight"], tx.get_weight())
|
|
|
|
# Now create tx3, which will spend from txid2
|
|
tx = CTransaction()
|
|
tx.vin.append(CTxIn(COutPoint(int(txid2, 16), 0), b""))
|
|
tx.vout.append(CTxOut(int(49.95 * COIN), CScript([OP_TRUE, OP_DROP] * 15 + [OP_TRUE]))) # Huge fee
|
|
tx.calc_sha256()
|
|
txid3 = self.nodes[0].sendrawtransaction(hexstring=tx.serialize().hex(), maxfeerate=0)
|
|
assert tx.wit.is_null()
|
|
assert txid3 in self.nodes[0].getrawmempool()
|
|
|
|
# Check that getblocktemplate includes all transactions.
|
|
template = self.nodes[0].getblocktemplate({"rules": ["segwit"]})
|
|
template_txids = [t['txid'] for t in template['transactions']]
|
|
assert txid1 in template_txids
|
|
assert txid2 in template_txids
|
|
assert txid3 in template_txids
|
|
|
|
# Check that wtxid is properly reported in mempool entry (txid3)
|
|
assert_equal(int(self.nodes[0].getmempoolentry(txid3)["wtxid"], 16), tx.calc_sha256(True))
|
|
|
|
# Check that weight and vsize are properly reported in mempool entry (txid3)
|
|
assert_equal(self.nodes[0].getmempoolentry(txid3)["vsize"], tx.get_vsize())
|
|
assert_equal(self.nodes[0].getmempoolentry(txid3)["weight"], tx.get_weight())
|
|
|
|
# Mine a block to clear the gbt cache again.
|
|
self.generate(self.nodes[0], 1)
|
|
|
|
def mine_and_test_listunspent(self, script_list, ismine):
|
|
utxo = find_spendable_utxo(self.nodes[0], 50)
|
|
tx = CTransaction()
|
|
tx.vin.append(CTxIn(COutPoint(int('0x' + utxo['txid'], 0), utxo['vout'])))
|
|
for i in script_list:
|
|
tx.vout.append(CTxOut(10000000, i))
|
|
tx.rehash()
|
|
signresults = self.nodes[0].signrawtransactionwithwallet(tx.serialize_without_witness().hex())['hex']
|
|
txid = self.nodes[0].sendrawtransaction(hexstring=signresults, maxfeerate=0)
|
|
txs_mined[txid] = self.generate(self.nodes[0], 1)[0]
|
|
watchcount = 0
|
|
spendcount = 0
|
|
for i in self.nodes[0].listunspent():
|
|
if i['txid'] == txid:
|
|
watchcount += 1
|
|
if i['spendable']:
|
|
spendcount += 1
|
|
if ismine == 2:
|
|
assert_equal(spendcount, len(script_list))
|
|
elif ismine == 1:
|
|
assert_equal(watchcount, len(script_list))
|
|
assert_equal(spendcount, 0)
|
|
else:
|
|
assert_equal(watchcount, 0)
|
|
return txid
|
|
|
|
def p2sh_address_to_script(self, v):
|
|
bare = CScript(bytes.fromhex(v['hex']))
|
|
p2sh = CScript(bytes.fromhex(v['scriptPubKey']))
|
|
p2wsh = script_to_p2wsh_script(bare)
|
|
p2sh_p2wsh = script_to_p2sh_script(p2wsh)
|
|
return [bare, p2sh, p2wsh, p2sh_p2wsh]
|
|
|
|
def p2pkh_address_to_script(self, v):
|
|
pubkey = bytes.fromhex(v['pubkey'])
|
|
p2wpkh = key_to_p2wpkh_script(pubkey)
|
|
p2sh_p2wpkh = script_to_p2sh_script(p2wpkh)
|
|
p2pk = key_to_p2pk_script(pubkey)
|
|
p2pkh = CScript(bytes.fromhex(v['scriptPubKey']))
|
|
p2sh_p2pk = script_to_p2sh_script(p2pk)
|
|
p2sh_p2pkh = script_to_p2sh_script(p2pkh)
|
|
p2wsh_p2pk = script_to_p2wsh_script(p2pk)
|
|
p2wsh_p2pkh = script_to_p2wsh_script(p2pkh)
|
|
p2sh_p2wsh_p2pk = script_to_p2sh_script(p2wsh_p2pk)
|
|
p2sh_p2wsh_p2pkh = script_to_p2sh_script(p2wsh_p2pkh)
|
|
return [p2wpkh, p2sh_p2wpkh, p2pk, p2pkh, p2sh_p2pk, p2sh_p2pkh, p2wsh_p2pk, p2wsh_p2pkh, p2sh_p2wsh_p2pk, p2sh_p2wsh_p2pkh]
|
|
|
|
def create_and_mine_tx_from_txids(self, txids, success=True):
|
|
tx = CTransaction()
|
|
for i in txids:
|
|
txraw = self.nodes[0].getrawtransaction(i, 0, txs_mined[i])
|
|
txtmp = tx_from_hex(txraw)
|
|
for j in range(len(txtmp.vout)):
|
|
tx.vin.append(CTxIn(COutPoint(int('0x' + i, 0), j)))
|
|
tx.vout.append(CTxOut(0, CScript()))
|
|
tx.rehash()
|
|
signresults = self.nodes[0].signrawtransactionwithwallet(tx.serialize_without_witness().hex())['hex']
|
|
self.nodes[0].sendrawtransaction(hexstring=signresults, maxfeerate=0)
|
|
self.generate(self.nodes[0], 1)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
SegWitTest(__file__).main()
|