mirror of
https://github.com/bitcoin/bitcoin.git
synced 2024-11-20 02:25:40 +01:00
fa53611cf1
fe49f06c0e
doc: clarify PR 26076 release note (Sjors Provoost)bd13dc2f46
Switch hardened derivation marker to h in descriptors (Sjors Provoost) Pull request description: This makes it easier to handle descriptor strings manually, especially when importing from another Bitcoin Core wallet. For example the `importdescriptors` RPC call is easiest to use `h` as the marker: `'["desc": ".../0h/..."]'`, avoiding the need for escape characters. With this change `listdescriptors` will use `h`, so you can copy-paste the result, without having to add escape characters or switch `'` to 'h' manually. Both markers can still be parsed. The `hdkeypath` field in `getaddressinfo` is also impacted by this change, except for legacy wallets. The latter is to prevent accidentally breaking ancient software that uses our legacy wallet. See discussion in #15740 ACKs for top commit: achow101: ACKfe49f06c0e
darosior: re-ACKfe49f06c0e
Tree-SHA512: f78bc873b24a6f7a2bf38f5dd58f2b723e35e6b10e4d65c36ec300e2d362d475eeca6e5afa04b3037ab4bee0bf8ebc93ea5fc18102a2111d3d88fc873c08dc89
140 lines
5.9 KiB
Python
Executable File
140 lines
5.9 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2022 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test the listdescriptors RPC."""
|
|
|
|
from test_framework.blocktools import (
|
|
TIME_GENESIS_BLOCK,
|
|
)
|
|
from test_framework.descriptors import (
|
|
descsum_create,
|
|
)
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
assert_raises_rpc_error,
|
|
)
|
|
|
|
|
|
class ListDescriptorsTest(BitcoinTestFramework):
|
|
def add_options(self, parser):
|
|
self.add_wallet_options(parser, legacy=False)
|
|
|
|
def set_test_params(self):
|
|
self.num_nodes = 1
|
|
|
|
def skip_test_if_missing_module(self):
|
|
self.skip_if_no_wallet()
|
|
self.skip_if_no_sqlite()
|
|
|
|
# do not create any wallet by default
|
|
def init_wallet(self, *, node):
|
|
return
|
|
|
|
def run_test(self):
|
|
node = self.nodes[0]
|
|
assert_raises_rpc_error(-18, 'No wallet is loaded.', node.listdescriptors)
|
|
|
|
if self.is_bdb_compiled():
|
|
self.log.info('Test that the command is not available for legacy wallets.')
|
|
node.createwallet(wallet_name='w1', descriptors=False)
|
|
assert_raises_rpc_error(-4, 'listdescriptors is not available for non-descriptor wallets', node.listdescriptors)
|
|
|
|
self.log.info('Test the command for empty descriptors wallet.')
|
|
node.createwallet(wallet_name='w2', blank=True, descriptors=True)
|
|
assert_equal(0, len(node.get_wallet_rpc('w2').listdescriptors()['descriptors']))
|
|
|
|
self.log.info('Test the command for a default descriptors wallet.')
|
|
node.createwallet(wallet_name='w3', descriptors=True)
|
|
result = node.get_wallet_rpc('w3').listdescriptors()
|
|
assert_equal("w3", result['wallet_name'])
|
|
assert_equal(8, len(result['descriptors']))
|
|
assert_equal(8, len([d for d in result['descriptors'] if d['active']]))
|
|
assert_equal(4, len([d for d in result['descriptors'] if d['internal']]))
|
|
for item in result['descriptors']:
|
|
assert item['desc'] != ''
|
|
assert item['next_index'] == 0
|
|
assert item['range'] == [0, 0]
|
|
assert item['timestamp'] is not None
|
|
|
|
self.log.info('Test that descriptor strings are returned in lexicographically sorted order.')
|
|
descriptor_strings = [descriptor['desc'] for descriptor in result['descriptors']]
|
|
assert_equal(descriptor_strings, sorted(descriptor_strings))
|
|
|
|
self.log.info('Test descriptors with hardened derivations are listed in importable form.')
|
|
xprv = 'tprv8ZgxMBicQKsPeuVhWwi6wuMQGfPKi9Li5GtX35jVNknACgqe3CY4g5xgkfDDJcmtF7o1QnxWDRYw4H5P26PXq7sbcUkEqeR4fg3Kxp2tigg'
|
|
xpub_acc = 'tpubDCMVLhErorrAGfApiJSJzEKwqeaf2z3NrkVMxgYQjZLzMjXMBeRw2muGNYbvaekAE8rUFLftyEar4LdrG2wXyyTJQZ26zptmeTEjPTaATts'
|
|
hardened_path = '/84h/1h/0h'
|
|
wallet = node.get_wallet_rpc('w2')
|
|
wallet.importdescriptors([{
|
|
'desc': descsum_create('wpkh(' + xprv + hardened_path + '/0/*)'),
|
|
'timestamp': TIME_GENESIS_BLOCK,
|
|
}])
|
|
expected = {
|
|
'wallet_name': 'w2',
|
|
'descriptors': [
|
|
{'desc': descsum_create('wpkh([80002067' + hardened_path + ']' + xpub_acc + '/0/*)'),
|
|
'timestamp': TIME_GENESIS_BLOCK,
|
|
'active': False,
|
|
'range': [0, 0],
|
|
'next': 0,
|
|
'next_index': 0},
|
|
],
|
|
}
|
|
assert_equal(expected, wallet.listdescriptors())
|
|
assert_equal(expected, wallet.listdescriptors(False))
|
|
|
|
self.log.info('Test list private descriptors')
|
|
expected_private = {
|
|
'wallet_name': 'w2',
|
|
'descriptors': [
|
|
{'desc': descsum_create('wpkh(' + xprv + hardened_path + '/0/*)'),
|
|
'timestamp': TIME_GENESIS_BLOCK,
|
|
'active': False,
|
|
'range': [0, 0],
|
|
'next': 0,
|
|
'next_index': 0},
|
|
],
|
|
}
|
|
assert_equal(expected_private, wallet.listdescriptors(True))
|
|
|
|
self.log.info("Test listdescriptors with encrypted wallet")
|
|
wallet.encryptwallet("pass")
|
|
assert_equal(expected, wallet.listdescriptors())
|
|
|
|
self.log.info('Test list private descriptors with encrypted wallet')
|
|
assert_raises_rpc_error(-13, 'Please enter the wallet passphrase with walletpassphrase first.', wallet.listdescriptors, True)
|
|
wallet.walletpassphrase(passphrase="pass", timeout=1000000)
|
|
assert_equal(expected_private, wallet.listdescriptors(True))
|
|
|
|
self.log.info('Test list private descriptors with watch-only wallet')
|
|
node.createwallet(wallet_name='watch-only', descriptors=True, disable_private_keys=True)
|
|
watch_only_wallet = node.get_wallet_rpc('watch-only')
|
|
watch_only_wallet.importdescriptors([{
|
|
'desc': descsum_create('wpkh(' + xpub_acc + ')'),
|
|
'timestamp': TIME_GENESIS_BLOCK,
|
|
}])
|
|
assert_raises_rpc_error(-4, 'Can\'t get descriptor string', watch_only_wallet.listdescriptors, True)
|
|
|
|
self.log.info('Test non-active non-range combo descriptor')
|
|
node.createwallet(wallet_name='w4', blank=True, descriptors=True)
|
|
wallet = node.get_wallet_rpc('w4')
|
|
wallet.importdescriptors([{
|
|
'desc': descsum_create('combo(' + node.get_deterministic_priv_key().key + ')'),
|
|
'timestamp': TIME_GENESIS_BLOCK,
|
|
}])
|
|
expected = {
|
|
'wallet_name': 'w4',
|
|
'descriptors': [
|
|
{'active': False,
|
|
'desc': 'combo(0227d85ba011276cf25b51df6a188b75e604b38770a462b2d0e9fb2fc839ef5d3f)#np574htj',
|
|
'timestamp': TIME_GENESIS_BLOCK},
|
|
]
|
|
}
|
|
assert_equal(expected, wallet.listdescriptors())
|
|
|
|
|
|
if __name__ == '__main__':
|
|
ListDescriptorsTest().main()
|