mirror of
https://github.com/bitcoin/bitcoin.git
synced 2024-11-20 02:25:40 +01:00
8f6ab31863
Previously, starting a second bitcoind using the same datadir would correctly fail to init and shutdown. However during shutdown the PID file belonging to the first instance would be erroneously removed by the second process shutting down. Fix this to only delete the PID file if we created it.
58 lines
2.9 KiB
Python
Executable File
58 lines
2.9 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2018-2022 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Check that it's not possible to start a second bitcoind instance using the same datadir or wallet."""
|
|
import random
|
|
import string
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.test_node import ErrorMatch
|
|
|
|
class FilelockTest(BitcoinTestFramework):
|
|
def add_options(self, parser):
|
|
self.add_wallet_options(parser)
|
|
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 2
|
|
|
|
def setup_network(self):
|
|
self.add_nodes(self.num_nodes, extra_args=None)
|
|
self.nodes[0].start()
|
|
self.nodes[0].wait_for_rpc_connection()
|
|
|
|
def run_test(self):
|
|
datadir = self.nodes[0].chain_path
|
|
self.log.info(f"Using datadir {datadir}")
|
|
|
|
self.log.info("Check that we can't start a second bitcoind instance using the same datadir")
|
|
expected_msg = f"Error: Cannot obtain a lock on data directory {datadir}. {self.config['environment']['PACKAGE_NAME']} is probably already running."
|
|
self.nodes[1].assert_start_raises_init_error(extra_args=[f'-datadir={self.nodes[0].datadir_path}', '-noserver'], expected_msg=expected_msg)
|
|
|
|
self.log.info("Check that cookie and PID file are not deleted when attempting to start a second bitcoind using the same datadir")
|
|
cookie_file = datadir / ".cookie"
|
|
assert cookie_file.exists() # should not be deleted during the second bitcoind instance shutdown
|
|
pid_file = datadir / "bitcoind.pid"
|
|
assert pid_file.exists()
|
|
|
|
if self.is_wallet_compiled():
|
|
def check_wallet_filelock(descriptors):
|
|
wallet_name = ''.join([random.choice(string.ascii_lowercase) for _ in range(6)])
|
|
self.nodes[0].createwallet(wallet_name=wallet_name, descriptors=descriptors)
|
|
wallet_dir = self.nodes[0].wallets_path
|
|
self.log.info("Check that we can't start a second bitcoind instance using the same wallet")
|
|
if descriptors:
|
|
expected_msg = f"Error: SQLiteDatabase: Unable to obtain an exclusive lock on the database, is it being used by another instance of {self.config['environment']['PACKAGE_NAME']}?"
|
|
else:
|
|
expected_msg = "Error: Error initializing wallet database environment"
|
|
self.nodes[1].assert_start_raises_init_error(extra_args=[f'-walletdir={wallet_dir}', f'-wallet={wallet_name}', '-noserver'], expected_msg=expected_msg, match=ErrorMatch.PARTIAL_REGEX)
|
|
|
|
if self.is_bdb_compiled():
|
|
check_wallet_filelock(False)
|
|
if self.is_sqlite_compiled():
|
|
check_wallet_filelock(True)
|
|
|
|
if __name__ == '__main__':
|
|
FilelockTest().main()
|